Path Based Signalling!!! (pbs v080)

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

Post Reply
User avatar
acidd_uk
Traffic Manager
Traffic Manager
Posts: 194
Joined: 08 Sep 2004 14:38

Post by acidd_uk »

Weird thing with PBS - my trains will not advance through green PBS signals. Take a look at the attached savegame - two trains are both waiting on green signals.... Is this a bug or is this me being dumb with my network layout? All in all, PBS rocks!

Edit: This is using the latest windows build 178.
Attachments
Behemouth Transport, 6th Jun 1989.sav
Savegame
(409.63 KiB) Downloaded 177 times
Asterix
Engineer
Engineer
Posts: 121
Joined: 04 Apr 2005 18:17
Location: Germany

Post by Asterix »

well, basically PBS checks, if the next signal it has to pass is green before entering a PBS-block.
currently everything between two PBS-signals is considered a PBS-block, so your trains check if the next signal after their current one is red or green. These are red in your savegame. in the one-way-parts you could solve it by putting a normal (non-PBS) signal between the two PBS-signals.
User avatar
acidd_uk
Traffic Manager
Traffic Manager
Posts: 194
Joined: 08 Sep 2004 14:38

Post by acidd_uk »

Hmm, I can see the logic to that for regular signals. But if the look-ahead signal is a red PBS signal, then would it be possible to do a preliminary look-ahead for that signal, and so on... Because looking ahead and finding a red PBS signal means that you may be able to proceed, whereas looking ahead to a regular red signal means you cannot proceed. Hmm, need to think about that...

Edit: Ok, thought about it. If the look ahead signal is the entrance to the pbs block, then if it's red, check to see if there's an available route though the pbs block. If there is, then proceed as normal. Would that work in the general case?
Last edited by acidd_uk on 14 Apr 2005 17:29, edited 1 time in total.
User avatar
Hackykid
Traffic Manager
Traffic Manager
Posts: 157
Joined: 22 Nov 2004 16:04
Location: Eindhoven de Gekste!!! (ongeveer ;P)
Contact:

Post by Hackykid »

@Hazelrah

Hmm... a wiki page, interesting idea...
On one hand it would be nice to put up some info about pbs on the wiki, on the other hand, pbs is still changing a lot, and its not so cool if i have to update this thread AND the wiki page each time...
Maybe a very simple page, and a link to this thread could work...
Best place to discuss such stuff, would be irc imo, when i'm online i'm usually there (#openttd at freenode).

@Goldwyn

Hmmm, i see, building a road on a rail tile resets the reserved status...
Well its known now, anyway :-)

@acid_uk

Well, basicly what Asterix said, it wait for the EXIT signal to be green, and your straight tracks are considered pbs junctions cause they have pbs signals on both sides.
Also, the 2-way tracks can cause crashes/other bad stuff, cause they can be entered from both sides, and currently a train cant know if another train has planned to enter it from the other side.
BUT, i've also thought of track layouts like this, and i think it would be really neat :-),
I'm gonna add some new pbs signal types to make stuff like this possible, but this may still may be some time into the future,,,,

@acid_uk->edit() :-p

Well. i already have some ideas on this, like making a train reserve 2 blocks a head in some cases (looking ahead), or 'locking' a 2-way signal into a 1-way one, temporarily.
But, before i implement this, regular pbs needs to work near perfectly, i think. One step at a time, you know :-)
So, just be patient :-p
DopeFish Lives!!!
Hazelrah
Traffic Manager
Traffic Manager
Posts: 196
Joined: 13 Apr 2005 05:41

Post by Hazelrah »

Actually, I think that it would be nice to have a series of wiki pages (basically a new category) for any patch under development that has yet to make it into the nightly builds. For instance, your Signal Copy feature could use a wiki page. I agree with you very much that the main discussion should be in the forums or even IRC. Basically I was thinking the same as you. A simple description, maybe a couple of pictures, name of the developer, and a link to the post in the forums.

While I'm not new to the concept of wiki's, I haven't done too much editing besides adding a bit of information to an already existing page, or some small grammar editing. Basically I wouldn't have the guts to create a whole new category on my own . :oops:

Hmm, looking at the wiki, maybe this kind of thing would go under Development:Main_page Subprojects Or create a new subheading called "Experimental Patches" or something like that. Anyways, I'd be willing to set it all up myself as long as somebody with a little bit more authority than me says "go for it!"

-Hazelrah
therax
Engineer
Engineer
Posts: 12
Joined: 16 Apr 2005 21:17

Post by therax »

First, let me say that I love PBS. It's completely rekindled my interest in OTTD. Now I can actually have the illusion of intelligent dispatchers controlling the signals on my network!

Now, here's a saved game where PBS appears to be acting strangely. (This saved game uses dbsetw.grf and no other newgrfs.)

Look at the segment between the entrance to München Woods and the depot near the junction to the west. A train is entering the depot via a PBS block, and another train is approaching soon from the northeast, passing through the PBS-controlled entrance to München Woods.

As the second train reaches the exit to its PBS block, it stops at that semaphore. I would expect to continue on out to the next block, through the standard signal, and wait at the entrance to the PBS junction block. The semaphore at the exit is up, and the following signal is green (Pic 2). This is the first oddity.

After the western train finishes entering the depot, the eastern train starts moving. But now it has reserved a long stretch of track from its current position all the way to the depot, even though the two signal blocks separating the two junctions are not PBS blocks (Pic 1)!

Finally, despite having reserved track all the way into the depot, the eastern train now halts at the entrance to the western PBS block, apparently waiting for the reserved tracks to clear (that it reserved itself just previously). This locks up the westbound track here forever.
Attachments
Pic1.png
Pic1.png (152.72 KiB) Viewed 4389 times
Pic2.png
Pic2.png (175.5 KiB) Viewed 4391 times
Freidorf Transport, 1st Sep 1994.sav
(142.85 KiB) Downloaded 165 times
Goldwyn
Engineer
Engineer
Posts: 29
Joined: 21 Mar 2005 20:25

Post by Goldwyn »

hey therax, I tried your saved game, when I placed another signal before the problem track, it did not reserve any tracks. I also removed and replaced the signal in your original spot and it also did not show that problem.

But loading it the first time and waiting, I ran into your problem. I guess you could try the temporary solution for now.

(Oh, was wondering which version of pbs are you using?)
Hazelrah
Traffic Manager
Traffic Manager
Posts: 196
Joined: 13 Apr 2005 05:41

Post by Hazelrah »

therax,

You have a depot inside of a PBS block, which I believe is still a big no no. This was happening to me a couple of days ago and that was exactly my problem. For me, it didn't mater how many normal signals or other PBS blocks I put between one PBS block and another, if the trains were aiming for the depot, it would try to reserve all the track to the depot. Then it would stop at the intermediate PBS block. I think I was using an older version because I just upgraded this morning, but I had to be very careful when removing that depot. The game became very unstable. I believe that depots need to be seperated from PBS blocks by at least one signal.

-Hazelrah
User avatar
Hackykid
Traffic Manager
Traffic Manager
Posts: 157
Joined: 22 Nov 2004 16:04
Location: Eindhoven de Gekste!!! (ongeveer ;P)
Contact:

Post by Hackykid »

@hazelrah
Actually, since v063, depots inside pbs blocks should work....

@Goldwyn
Hmm, removing and placing the signal again did not help for me, neither did placing extra signals...

@therax
Thanks for the savegame/screenshots, was very helpfull.


So........, in any case:
New pbs version (v066) solves this bug :-)
DopeFish Lives!!!
User avatar
Hackykid
Traffic Manager
Traffic Manager
Posts: 157
Joined: 22 Nov 2004 16:04
Location: Eindhoven de Gekste!!! (ongeveer ;P)
Contact:

Post by Hackykid »

Yay! New pbs version :-) (v067)

In this version, reversing inside pbs blocks should work a bit better. (cause less crashes)
Lemme know how this works out.

Also, the bug where building a road on a track would reset the reserved status. has been solved. (also, no more gfx glitches on level crossings :-p)
DopeFish Lives!!!
Abraxa
Engineer
Engineer
Posts: 58
Joined: 18 Apr 2005 13:35

Post by Abraxa »

Just wanted to drop by and say thanks to Hacky cause I love the effort he puts into this patch and also because I'm sure it makes the oTTD developers very happy to see that people contribute such major patches, too.
Good job!

-Abraxa
ConductorBob
Director
Director
Posts: 560
Joined: 21 Jun 2004 16:17
Location: Train station 1

Post by ConductorBob »

Yeah, I love your stuff man. But you made the latest release for r2222, but I only see r2221...
DaleStan
TTDPatch Developer
TTDPatch Developer
Posts: 10285
Joined: 18 Feb 2004 03:06
Contact:

Post by DaleStan »

TortiseSVN tells me that r2222 is available on the SVN server.
Tonight's Windows nightly will probably be r2222, assuming it appears. (MacOS and Linux nightlies have already appeared.)
To get a good answer, ask a Smart Question. Similarly, if you want a bug fixed, write a Useful Bug Report. No TTDPatch crashlog? Then follow directions.
Projects: NFORenum (download) | PlaneSet (Website) | grfcodec (download) | grfdebug.log parser
User avatar
fire87
Tycoon
Tycoon
Posts: 1381
Joined: 28 Jul 2004 14:58
Location: Skedsmokorset, Norway

Post by fire87 »

How do I use PBS here?
As in: How can I get it to work? I downloaded the win-thing, and just copy-pasted it in the OTTD folder, but still it doesn't work..
Currently working on:

Norwegian (NSB) Trainset
Topic | Website
User avatar
0beron
Engineer
Engineer
Posts: 38
Joined: 26 Mar 2005 14:46

Post by 0beron »

You need the source from the SVN repository, apply the patch file for PBS, and then compile the game to run it.
User avatar
fire87
Tycoon
Tycoon
Posts: 1381
Joined: 28 Jul 2004 14:58
Location: Skedsmokorset, Norway

Post by fire87 »

Hmm.. Then I'll rather wait 'till it get implemented..
Currently working on:

Norwegian (NSB) Trainset
Topic | Website
Goldwyn
Engineer
Engineer
Posts: 29
Joined: 21 Mar 2005 20:25

Post by Goldwyn »

If you got the build file, you just need to unzip both, and copy it over your existing files. Then you need to turn on npf. For now, to distinquish a PBS block you must use semiphores (ctrl + click when placing signals). Then you just have fun with trains playing chicken.
Attachments
lookout.png
lookout.png (78.45 KiB) Viewed 3902 times
ConductorBob
Director
Director
Posts: 560
Joined: 21 Jun 2004 16:17
Location: Train station 1

Post by ConductorBob »

I dunno if this has been stated but I'm having a problem around my stations on double tracks when a line begins to form.

Here's a pic... Second pic sorta explains.
Attachments
Problem Station.JPG
This si the second picture. Assume the green lines are trains. They are waiting to etner station. Red and pink are trains in teh station. if pink leaves then both green trains will attempt to enter the open station area. Problem occurs now as only one goe
(425.19 KiB) Downloaded 206 times
Station.JPG
Heres the general station area.
(425.17 KiB) Downloaded 202 times
User avatar
GoneWacko
Tycoon
Tycoon
Posts: 8680
Joined: 10 Jul 2002 15:08
Location: Enschede, The Netherlands
Contact:

Post by GoneWacko »

ConductorBob wrote:I dunno if this has been stated but I'm having a problem around my stations on double tracks when a line begins to form.

Here's a pic... Second pic sorta explains.
Comments weren't made to contain entire stories. :)

Please tell the problem in the post itself.
GoneWacko. Making [url=irc://irc.oftc.net/tycoon]#tycoon[/url] sexy and exciting since 1784.
hYpe_
Engineer
Engineer
Posts: 59
Joined: 24 Dec 2003 14:46

Post by hYpe_ »

oops, solved :D

nevermind
Attachments
Desert Cargo, 20. Feb 1958.jpg
Desert Cargo, 20. Feb 1958.jpg (216.11 KiB) Viewed 861 times
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 22 guests