[patch] Realistic Train Shunting

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

martin1180
Engineer
Engineer
Posts: 1
Joined: 27 Oct 2020 15:26

Re: [patch] Realistic Train Shunting

Post by martin1180 »

Hi everyone,

do you know if there is a chance that this patch could be incorporated into some patch pack (for example JGR)? I've seen similar comment from 2018, so I wonder if there was some development in that area?
User avatar
SciFurz
Engineer
Engineer
Posts: 118
Joined: 13 Oct 2018 16:33
Contact:

Re: [patch] Realistic Train Shunting

Post by SciFurz »

martin1180 wrote: 27 Oct 2020 15:29 Hi everyone,

do you know if there is a chance that this patch could be incorporated into some patch pack (for example JGR)? I've seen similar comment from 2018, so I wonder if there was some development in that area?
I actually incorporated the code into a copy of my realtime patch to see if it worked, but it seems there's a variable size conflict or something somewhere in the extra order stack the code creates and the OpenTTD target version being relatively old by now. I couldn't spot a quick solution and had little time to do more work on it.
This thing is still something I'd like to add though, so I can build a real sorting yard eventually. It will likely mean a partially different implementation of the code.
Tinkering in the code in between writing mostly naughty stuff.
See http://scifurz.wordpress.com/
Union Pacific
Engineer
Engineer
Posts: 2
Joined: 19 Apr 2014 13:25

Re: [patch] Realistic Train Shunting

Post by Union Pacific »

Is there any newer updates from the last 2018 post?
User avatar
kamnet
Moderator
Moderator
Posts: 7490
Joined: 28 Sep 2009 17:15
Location: Eastern KY
Contact:

Re: [patch] Realistic Train Shunting

Post by kamnet »

Union Pacific wrote: 04 Jan 2021 06:19 Is there any newer updates from the last 2018 post?
martin1180 wrote: 27 Oct 2020 15:29 do you know if there is a chance that this patch could be incorporated into some patch pack (for example JGR)? I've seen similar comment from 2018, so I wonder if there was some development in that area?
There has been no further development of this patch posted.
User avatar
wallyweb
Tycoon
Tycoon
Posts: 5836
Joined: 27 Nov 2004 15:05
Location: Canada

Re: [patch] Realistic Train Shunting

Post by wallyweb »

Karn wrote: 25 Mar 2019 17:20
Valle wrote: Seeing that you're also active with Realistic Train Shunting, Karn, I'd like to ask you: has any more work on this acceleration model happened since the last update?
Currently I'm too busy with personal life. Both yaam and rts are on hold until I find free time for it.
When it comes to priorities, I would like to finish shunting patch first and after it's done, then work on yaam again. Shunting patch is more rewarding to develop.
Karn
Traffic Manager
Traffic Manager
Posts: 128
Joined: 02 Oct 2011 18:56

Re: [patch] Realistic Train Shunting

Post by Karn »

SciFurz wrote: 29 Oct 2020 05:12
martin1180 wrote: 27 Oct 2020 15:29 Hi everyone,

do you know if there is a chance that this patch could be incorporated into some patch pack (for example JGR)? I've seen similar comment from 2018, so I wonder if there was some development in that area?
I actually incorporated the code into a copy of my realtime patch to see if it worked, but it seems there's a variable size conflict or something somewhere in the extra order stack the code creates and the OpenTTD target version being relatively old by now. I couldn't spot a quick solution and had little time to do more work on it.
This thing is still something I'd like to add though, so I can build a real sorting yard eventually. It will likely mean a partially different implementation of the code.
The bug you noticed is simply about mixing order stack and station stack, long ago they were equal, but lately one of them got bigger, solution is quite easy to not mix them up, this commit should fix it. https://github.com/Palo123/OpenTTD-YPS/ ... 33f25aedca

I've got some time to work on this in recent weeks, hopefully I can finish global order list soon. Then my time disappears again..
User avatar
wallyweb
Tycoon
Tycoon
Posts: 5836
Joined: 27 Nov 2004 15:05
Location: Canada

Re: [patch] Realistic Train Shunting

Post by wallyweb »

:D :bow:
patrik.kolibal
Engineer
Engineer
Posts: 2
Joined: 22 Feb 2021 12:58

Re: [patch] Realistic Train Shunting

Post by patrik.kolibal »

Hi
Please, will you help me? I took all the CZTR GRFs and then I normally turned on the game, but as I learned, I got an error
Eddi
Tycoon
Tycoon
Posts: 7582
Joined: 17 Jan 2007 00:14

Re: [patch] Realistic Train Shunting

Post by Eddi »

please give the exact error message, and if possible a savegame.

and if it was a crash, also the crash log
You might not exactly be interested in Ferion, but if you are, have fun :)
Flaška73
Engineer
Engineer
Posts: 1
Joined: 01 Mar 2021 11:48

Re: [patch] Realistic Train Shunting

Post by Flaška73 »

Hi.
I have the same problem as the man before me.

Error message:

Assrrtion failed at line 134 of
c:/github/OpenTTD-YPS/src/newgrf.cpp: feature < GSF_END

Log:

*** OpenTTD Crash Report ***

Crash at: Mon Mar 01 11:58:16 2021
In game date: 2001-01-01 (0)

Crash reason:
Exception: E1212012
Location: 75CDA8B2
Message: Assertion failed at line 134 of c:/github/OpenTTD-YPS/src/newgrf.cpp: feature < GSF_END

OpenTTD version:
Version: 20180814-Decouple-g251e5384 (0)
NewGRF ver: 19000000
Bits: 32
Endian: little
Dedicated: no
Build date: Aug 14 2018 10:05:36

Registers:
EAX: 01B5D2E0 EBX: 00000000 ECX: 00000000 EDX: 0024A000
ESI: 00000016 EDI: 005474E0 EBP: 01B5D338 ESP: 01B5D2E0
EIP: 75CDA8B2 EFLAGS: 00200246

Bytes at instruction pointer:
8B 4C 24 54 33 CC E8 23 4E 00 00 8B E5 5D C2 10 00 83 64 24 10 00 EB DE

Stack trace:
E1212012 00000000 00000000 75CDA8B2 00000000 0000000B 75997FEA 01BC0340
00000001 AB2EC350 00000000 00000000 00000000 01BEF488 00000000 00000000
01B5003B 00000000 3B00003B 00000000 00000016 A6FBFA67 01B5D3A8 00547507
E1212012 00000000 00000000 00000000 764441CC 01B5D3A8 763E71E6 763E71F1
00000016 F9EC7E5B 0000AC89 00000013 01B5D6F0 01BC0000 01BFDAD8 00000000
00000000 00000001 005474E0 76445C48 01B5D364 01B5CC74 01B5FFCC 763ECCC0
8E1A3DDB FFFFFFFE 01B5D6D8 763EB69B 00000016 01BC0000 00000000 01B5D3DC
779C8786 00000000 00000000 00000000 00000000 00010003 01B5D4A4 01B5D4A4
759DFB64 01BC0000 00000000 01BFDAD8 01B5D618 00000001 00000000 00000064
000002F6 00000010 00000095 00000000 00000000 01BFDAD8 01BFDB3C 50022080
00000194 0000001A 0000037B 00000000 00000020 00000032 00000000 016F1982
00000000 00007F01 00000016 00000132 00000000 00000000 00000000 00000000
00000780 00000410 0000000D 000005EC 00000000 000D04F4 0000001C 0000000F
00000000 00000000 00000780 00000410 01B5D550 01B5FFCC 759A0F00 068A85B2
76E0201C 01B5D600 759DE8C1 01B5D618 016F1980 00000000 759DE90D 00000000
00000000 00000000 00000001 00000000 00000001 759652A4 00000001 76417227
023220FC 00A6441F 025313E4 023223F8 01B5D528 000001FF 023223F8 023216C8
00000000 02321600 01B5D538 7641733C 023220FC 00A6441F 00000016 01B5D528
023216C8 7FFFFFFF 023223F8 023216C8 0000000A 00000000 00000001 00000001
023220FC 00A6441F 00000016 00000001 00000000 01B5D572 01B5D570 006F371D
00000001 00000000 0000000A 00000000 00000000 01B5D6F0 00000058 01B5D748
01B5D5A0 00000000 016F1D80 01B5D6A8 75CBB24E 016F1980 00000400 01B5D5BC
01B5D6F0 00000058 0000AC89 00000013 75CBB089 00000000 01B5D640 000000B0
01B5D5A0 A202721D 00000200 FFFFFFFF 016F1980 00000000 01B5D688 00000000

Operating system:
Name: Windows
Release: 6.2.9200 ()
Compiler: GCC 5.3.0 "5.3.0"

Configuration:
Blitter: 32bpp-anim
Graphics set: OpenGFX (7393)
Language: C:\Users\KACORA\Desktop\openttd_decouple_0.10.4_win32\lang\czech.lng
Music driver: win32
Music set: NoMusic (0)
Network: no
Sound driver: win32
Sound set: NoSound (2)
Video driver: win32

Fonts:
Small: sprite
Medium: sprite
Large: sprite
Mono: sprite

AI Configuration (local: 255):

Libraries:
FreeType: 2.4.10
LZMA: 5.0.4
LZO: 2.06
PNG: 1.5.16
Zlib: 1.2.11

Module information:
C:\Users\KACORA\Desktop\openttd_decouple_0.10.4_win32\openttd.exe handle: 00400000 size: 13251912 crc: EA1BCCA4 date: 2018-08-14 08:05:51
C:\WINDOWS\SYSTEM32\ntdll.dll handle: 77980000 size: 1696248 crc: A9690115 date: 2021-02-13 17:24:08
C:\WINDOWS\System32\KERNEL32.DLL handle: 76960000 size: 632544 crc: B158A13D date: 2021-02-13 17:24:08
C:\WINDOWS\System32\KERNELBASE.dll handle: 75bb0000 size: 2182176 crc: 057E7A4B date: 2021-02-13 17:24:05
C:\WINDOWS\System32\ADVAPI32.DLL handle: 76ea0000 size: 489128 crc: B5D0B433 date: 2020-11-14 10:25:52
C:\WINDOWS\System32\msvcrt.dll handle: 76390000 size: 775256 crc: A69BF47F date: 2020-10-18 17:05:38
C:\WINDOWS\System32\sechost.dll handle: 76ab0000 size: 477784 crc: 4A2744E2 date: 2021-02-13 17:24:08
C:\WINDOWS\System32\RPCRT4.dll handle: 77050000 size: 786608 crc: 4FA8FB57 date: 2021-01-22 15:09:28
C:\WINDOWS\System32\GDI32.dll handle: 76b40000 size: 136328 crc: 2EA7F95A date: 2021-01-22 15:09:32
C:\WINDOWS\System32\win32u.dll handle: 76e00000 size: 92952 crc: 0CBD257E date: 2021-02-13 17:24:10
C:\WINDOWS\System32\gdi32full.dll handle: 76d20000 size: 895040 crc: 2ACF8B83 date: 2021-01-22 15:09:36
C:\WINDOWS\System32\msvcp_win.dll handle: 76e20000 size: 495840 crc: 899F0F49 date: 2021-02-13 17:24:10
C:\WINDOWS\System32\ucrtbase.dll handle: 76840000 size: 1181208 crc: C1DCED69 date: 2021-02-13 17:24:10
C:\WINDOWS\System32\USER32.dll handle: 75960000 size: 1663656 crc: 67E6E55D date: 2021-01-22 15:09:35
C:\WINDOWS\System32\IMM32.DLL handle: 77940000 size: 143056 crc: 25A83BD7 date: 2020-10-18 17:05:44
C:\WINDOWS\System32\SHELL32.DLL handle: 77380000 size: 6004840 crc: EEC36459 date: 2021-02-13 17:24:11
C:\WINDOWS\System32\WS2_32.dll handle: 75dd0000 size: 397728 crc: 91C8CAB4 date: 2020-10-18 17:05:38
C:\WINDOWS\SYSTEM32\WINMM.DLL handle: 74140000 size: 149272 crc: 75868CA9 date: 2020-10-18 17:05:38
C:\WINDOWS\SYSTEM32\windows.storage.dll handle: 74be0000 size: 6362216 crc: CC233C06 date: 2021-02-13 17:24:09
C:\WINDOWS\System32\combase.dll handle: 765b0000 size: 2637728 crc: 2F998357 date: 2021-02-13 17:24:10
C:\WINDOWS\SYSTEM32\Wldp.dll handle: 74b70000 size: 139960 crc: 0FBA6C41 date: 2020-12-09 06:16:12
C:\WINDOWS\System32\SHCORE.dll handle: 758d0000 size: 548528 crc: CFE199CB date: 2021-01-22 15:09:35
C:\WINDOWS\System32\shlwapi.dll handle: 75840000 size: 275808 crc: 1C3085F3 date: 2021-01-22 15:09:38
C:\WINDOWS\system32\uxtheme.dll handle: 73ed0000 size: 453632 crc: 1D875F12 date: 2021-01-22 15:09:29
C:\WINDOWS\System32\MSCTF.dll handle: 772a0000 size: 860464 crc: 6CACEDEE date: 2021-02-13 17:24:08
C:\WINDOWS\System32\OLEAUT32.dll handle: 77110000 size: 606872 crc: 9AB818C4 date: 2021-02-13 17:24:10
C:\WINDOWS\SYSTEM32\kernel.appcore.dll handle: 74b60000 size: 52672 crc: C8B72A1B date: 2020-10-18 17:05:42
C:\WINDOWS\System32\bcryptPrimitives.dll handle: 76450000 size: 375000 crc: 9E12B901 date: 2020-12-09 06:16:08
C:\WINDOWS\SYSTEM32\textinputframework.dll handle: 74aa0000 size: 754088 crc: 3D45D880 date: 2021-02-13 17:24:09
C:\WINDOWS\SYSTEM32\CoreUIComponents.dll handle: 71e50000 size: 2621720 crc: EEEED56D date: 2020-10-18 17:05:40
C:\WINDOWS\SYSTEM32\CoreMessaging.dll handle: 720d0000 size: 630624 crc: 7F724E16 date: 2021-01-22 15:09:36
C:\WINDOWS\SYSTEM32\wintypes.dll handle: 72170000 size: 896096 crc: BF6382D9 date: 2021-01-22 15:09:36
C:\WINDOWS\SYSTEM32\ntmarta.dll handle: 745a0000 size: 152904 crc: 4942B8F6 date: 2020-10-18 17:05:44
C:\WINDOWS\system32\mswsock.dll handle: 73e70000 size: 324416 crc: 98BF2586 date: 2020-10-18 17:05:43
C:\WINDOWS\SYSTEM32\winmmbase.dll handle: 70c20000 size: 110720 crc: AC0C6B02 date: 2019-12-07 09:09:11
C:\WINDOWS\SYSTEM32\MMDevAPI.DLL handle: 70bb0000 size: 421480 crc: EEB56CC4 date: 2021-02-13 17:24:08
C:\WINDOWS\SYSTEM32\DEVOBJ.dll handle: 74860000 size: 138936 crc: F091B12E date: 2020-10-18 17:05:44
C:\WINDOWS\System32\cfgmgr32.dll handle: 76ce0000 size: 236520 crc: 5169D1DC date: 2020-10-18 17:05:44
C:\WINDOWS\SYSTEM32\wdmaud.drv handle: 6d160000 size: 215040 crc: E0477AD9 date: 2019-12-07 09:09:11
C:\WINDOWS\SYSTEM32\ksuser.dll handle: 70b80000 size: 20328 crc: 53B0C3C3 date: 2019-12-07 09:09:11
C:\WINDOWS\SYSTEM32\AVRT.dll handle: 70b90000 size: 27336 crc: EF602A94 date: 2020-10-18 17:05:37
C:\WINDOWS\SYSTEM32\AUDIOSES.DLL handle: 6cf00000 size: 1268576 crc: 60FE5717 date: 2021-02-13 17:24:08
C:\WINDOWS\SYSTEM32\powrprof.dll handle: 73f60000 size: 268080 crc: 8D43BCF1 date: 2020-10-18 17:05:44
C:\WINDOWS\SYSTEM32\UMPDC.dll handle: 73f50000 size: 47472 crc: F94F163A date: 2020-10-18 17:05:42
C:\WINDOWS\SYSTEM32\msacm32.drv handle: 6cef0000 size: 23552 crc: E04404B8 date: 2020-10-15 06:13:19
C:\WINDOWS\SYSTEM32\MSACM32.dll handle: 6ced0000 size: 93472 crc: 6A32087D date: 2019-12-07 09:09:11
C:\WINDOWS\SYSTEM32\midimap.dll handle: 6cec0000 size: 18944 crc: 6B3EEBB2 date: 2020-10-15 06:13:19
C:\WINDOWS\System32\clbcatq.dll handle: 76f20000 size: 504552 crc: 4C6A67D5 date: 2020-10-18 17:05:43
C:\Windows\System32\Windows.UI.dll handle: 749a0000 size: 998352 crc: 903F311A date: 2021-01-22 15:09:30
C:\Windows\System32\InputHost.dll handle: 72250000 size: 968424 crc: 15F5F267 date: 2021-01-22 15:09:33
C:\Windows\System32\WindowManagementAPI.dll handle: 74920000 size: 455680 crc: C2387CD0 date: 2021-01-22 15:09:33
C:\WINDOWS\SYSTEM32\twinapi.appcore.dll handle: 70d10000 size: 1634208 crc: FFC17043 date: 2021-01-22 15:09:34
C:\Windows\System32\PROPSYS.dll handle: 75330000 size: 797472 crc: 99BC00D1 date: 2021-01-22 15:09:33
C:\WINDOWS\System32\ole32.dll handle: 771b0000 size: 924528 crc: 36317573 date: 2021-01-22 15:09:36
C:\WINDOWS\SYSTEM32\TextShaping.dll handle: 6bd30000 size: 611952 crc: 5AACCB69 date: 2020-10-18 17:05:40
C:\WINDOWS\System32\psapi.dll handle: 76b30000 size: 17016 crc: 575218A3 date: 2020-10-18 17:05:43

---- gamelog start ----
Tick 0: new game started
Revision text changed to 20180814-Decou, savegame version 200, not modified, _openttd_newgrf_version = 0x19000000
New game mode: 1 landscape: 0
Added NewGRF: GRF ID 4D490104, checksum 81F0F3929F0C1356F8AE81016C337F77, filename: cztr_rails-2.1.2\cztr_rails.grf (md5sum matches)
Added NewGRF: GRF ID 4D490307, checksum 87502FC3C789199B270E4E2882261F69, filename: cztr_rail_addons-1.0.2\cztr_rail_addons.grf (md5sum matches)
Added NewGRF: GRF ID 4D490208, checksum 0546BB7475AC6822FD1A62AC341F5700, filename: cztr_engines__electric-0.9.2\cztr_engines-electric.grf (md5sum matches)
Added NewGRF: GRF ID 4D490213, checksum 9AE03F3FF3FE1A6A8663F2FF9DF25DA5, filename: cztr_wagons__cargo-1.0.0\cztr_wagons_cargo.grf (md5sum matches)
Added NewGRF: GRF ID 4D490212, checksum CCA36A06C2A78229A970DD219C3454E3, filename: cztr_wagons__passengers-0.9.0\cztr_wagoons-pass.grf (md5sum matches)
Added NewGRF: GRF ID 4D490203, checksum 2607A7620A7D12DA457763D798D5D790, filename: cztr_truck_set-1.0.1\cztr_truck_set.grf (md5sum matches)
Added NewGRF: GRF ID 4D490302, checksum 938BC78CAAC2E69DBBC919FC869C0767, filename: cztr_tree_set-2.0.1\cztr_tree_set.grf (md5sum matches)
Added NewGRF: GRF ID 4D490202, checksum A2E703C1F59899FD15881DB60145482C, filename: cztr_t-2.0.0\cztr_tram_set.grf (md5sum matches)
Added NewGRF: GRF ID 56480002, checksum A073ECD0799F9E4E1B974F2DAE3665BD, filename: cztr_stations-1.0.0\cztr_stations.grf (md5sum matches)
Added NewGRF: GRF ID 4D490101, checksum F5336411DD0495FC44E36876D6104A9B, filename: cztr_road_set-2.0.0\cztr_road_set.grf (md5sum matches)
Added NewGRF: GRF ID 4D490320, checksum 76E6377C947C5563E739352968715887, filename: cztr_bridges-0.8.8\cztr_infrastructure.grf (md5sum matches)
Added NewGRF: GRF ID 4D490207, checksum 785DF78025B97921C488E0699C27729B, filename: cztr_engines__steam-1.0.0\cztr_engines-steam.grf (md5sum matches)
Added NewGRF: GRF ID 4D490210, checksum B1B46E420AE3C9BE736F0E02A03EB43E, filename: cztr_engines__emu-0.9.0\cztr_engines-emu.grf (md5sum matches)
Added NewGRF: GRF ID 4D490209, checksum 29E8857B333AAC5156184070046286CB, filename: cztr_engines__diesel-0.9.0\cztr_engines-diesel.grf (md5sum matches)
Added NewGRF: GRF ID 4D490401, checksum 22B2D1D195FC972E3C3439DE72E6D80A, filename: cztr_effects-1.0.0\cztr_efects.grf (md5sum matches)
Added NewGRF: GRF ID 4D490201, checksum A5C7B7BD3945F4B9FC823189012FB534, filename: cztr_bus_set-1.0.1\cztr_bus_set.grf (md5sum matches)
Added NewGRF: GRF ID 4D490303, checksum 2D0B7BEF9CF4D1A45D3EA0B616ADDA4B, filename: cztr_bridges-0.9.0\cztr_bridges.grf (md5sum matches)
Added NewGRF: GRF ID 4D490102, checksum E474F3ECB6E44B7F13C4FD9E87E3AD61, filename: cztr_ground_set-2.0.0\cztr_ground.grf (md5sum matches)
---- gamelog end ----

Recent news messages:

*** End of OpenTTD Crash Report ***
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 14 guests