Transport Tycoon Forums

The place to talk about Transport Tycoon
It is currently Mon Aug 21, 2017 9:36 pm

All times are UTC




Post new topic  Reply to topic  [ 939 posts ]  Go to page Previous 143 44 45 46 47
Author Message
 Post subject: Re: JGR's Patch Pack
PostPosted: Fri Aug 11, 2017 12:48 pm 
Offline
Traffic Manager
Traffic Manager
User avatar

Joined: Mon Apr 17, 2017 4:52 pm
Posts: 215
Location: S.W. London
No it doesn't: it still crashed when I did the same thing with the same NewGRF.

_________________
Image

https://www.tt-forums.net/viewtopic.php?f=47&t=76619&p=1188249#p1188249


Top
   
 Post subject: Re: JGR's Patch Pack
PostPosted: Fri Aug 11, 2017 2:49 pm 
Offline
Tycoon
Tycoon
User avatar

Joined: Mon Aug 08, 2005 1:46 pm
Posts: 1680
Location: Ipswich
This looks to be a fault with the GRF in question. It's probably worth forwarding a bug report to whoever maintains it.
I will look into replacing the assertion with something less user-unfriendly at some point soonish.

_________________
Ex TTDPatch Coder, Grumpy Greymuzzle
Avatar by MoonsongWolf.
Patch Pack, Github


Top
   
 Post subject: Re: JGR's Patch Pack
PostPosted: Fri Aug 11, 2017 3:04 pm 
Offline
Traffic Manager
Traffic Manager
User avatar

Joined: Mon Apr 17, 2017 4:52 pm
Posts: 215
Location: S.W. London
I shall let myself know. I'll check teh sounds, but I don't get why it doesn't work on your patch pack.

_________________
Image

https://www.tt-forums.net/viewtopic.php?f=47&t=76619&p=1188249#p1188249


Top
   
 Post subject: Re: JGR's Patch Pack
PostPosted: Fri Aug 11, 2017 3:21 pm 
Offline
OpenTTD Developer
OpenTTD Developer

Joined: Sun Sep 09, 2007 5:03 am
Posts: 4447
Location: home
Gwyd wrote:
No it doesn't: it still crashed when I did the same thing with the same NewGRF.
Yes, so it's not because the internals of the savegame were messed up in some way. If a fresh game worked, the former would be the cause. That is, messed up savegame got eliminated as cause, because it crashes consistently rather than just in that one savegame.

_________________
Being a OpenTTD developer does not mean I know what I am doing.
Also, other OpenTTD developers may have different opinions.


Top
   
 Post subject: Re: JGR's Patch Pack
PostPosted: Fri Aug 11, 2017 6:54 pm 
Offline
Engineer
Engineer

Joined: Tue Jun 27, 2017 9:43 pm
Posts: 10
I think I made something of a mistake. I changed the daylength in one save, and when I opened another save it had messed with all of the timetabling and dispatch scheduling in that save, despite the daylength being the same. Is there any way to fix this without deleting all of the schedules and starting over?


Top
   
 Post subject: Re: JGR's Patch Pack
PostPosted: Fri Aug 11, 2017 7:09 pm 
Offline
Tycoon
Tycoon
User avatar

Joined: Mon Aug 08, 2005 1:46 pm
Posts: 1680
Location: Ipswich
Gwyd wrote:
I shall let myself know. I'll check teh sounds, but I don't get why it doesn't work on your patch pack.

Sorry, didn't know that it was your GRF.
The sound in question appears to have 2 channels.
I've added some checks which log a suitable error message instead of aborting.
It'll be in the next release.

p4nzer wrote:
I think I made something of a mistake. I changed the daylength in one save, and when I opened another save it had messed with all of the timetabling and dispatch scheduling in that save, despite the daylength being the same. Is there any way to fix this without deleting all of the schedules and starting over?

I'll look into it, if you could post the savegame that would be helpful.

Edit:
I'm not sure that I understand what you have done.
If you changed the day length and then overwrote your good savegame with it, then yes, you will most likely need to adjust scheduled dispatch start dates (i.e. by using the start date button).
If changing the daylength in one game and loading an unrelated game somehow adjusted your scheduled dispatches in the unrelated game, relative to just loading it directly, that would be a bug.

_________________
Ex TTDPatch Coder, Grumpy Greymuzzle
Avatar by MoonsongWolf.
Patch Pack, Github


Top
   
 Post subject: Re: JGR's Patch Pack
PostPosted: Wed Aug 16, 2017 6:08 pm 
Offline
Engineer
Engineer

Joined: Tue Jun 27, 2017 9:43 pm
Posts: 10
It would appear that daylength is a global variable, which I didn't know. Changing it back made everything go back to normal.

edit: but yes, changing daylength in one save overwrote schedules in every save.


Top
   
 Post subject: Re: JGR's Patch Pack
PostPosted: Wed Aug 16, 2017 7:31 pm 
Offline
Tycoon
Tycoon
User avatar

Joined: Mon Aug 08, 2005 1:46 pm
Posts: 1680
Location: Ipswich
p4nzer wrote:
It would appear that daylength is a global variable, which I didn't know. Changing it back made everything go back to normal.

edit: but yes, changing daylength in one save overwrote schedules in every save.

The day length variable is saved to and loaded from the savegame. I cannot reproduce any problem of this type.
Are you sure that you are not changing the client time display settings instead? (Ticks per minute, etc.)

The only potential problem that I can find with scheduled dispatch is multiplayer-related.

_________________
Ex TTDPatch Coder, Grumpy Greymuzzle
Avatar by MoonsongWolf.
Patch Pack, Github


Top
   
 Post subject: Re: JGR's Patch Pack
PostPosted: Wed Aug 16, 2017 8:44 pm 
Offline
Engineer
Engineer

Joined: Sun Apr 09, 2017 2:58 pm
Posts: 30
While I have not tested in multiplayer, I have written the schedule dispatch with multi-player in mind (that is also why date/time stuff in the patch is stored in complicated way) and unless I miss, I believe it would work as-is in multiplayer. Working with tick system under the day-length patch is confusing :P

Minute-per-day and minute offset are global setting, though if you revert everything back it should make everything looks normal again. Note that those two settings are purely for UI, so if those are changed, and while the dispatch schedule and timetable will look very weird, it is actually functioning the same (i.e. dispatching train on the same interval as before the change).


Top
   
 Post subject: Re: JGR's Patch Pack
PostPosted: Wed Aug 16, 2017 9:58 pm 
Offline
Tycoon
Tycoon
User avatar

Joined: Mon Aug 08, 2005 1:46 pm
Posts: 1680
Location: Ipswich
ino wrote:
While I have not tested in multiplayer, I have written the schedule dispatch with multi-player in mind (that is also why date/time stuff in the patch is stored in complicated way) and unless I miss, I believe it would work as-is in multiplayer. Working with tick system under the day-length patch is confusing :P

Minute-per-day and minute offset are global setting, though if you revert everything back it should make everything looks normal again. Note that those two settings are purely for UI, so if those are changed, and while the dispatch schedule and timetable will look very weird, it is actually functioning the same (i.e. dispatching train on the same interval as before the change).

It mostly looks fine to me. OrderList::ResetScheduledDispatch() looks problematic though as it is called in command context and depends on the local setting for whether time is displayed in minutes, and the ticks per minute.
In an MP game, a CMD_SCHEDULED_DISPATCH enable command on a vehicle which hadn't previously been used with scheduled dispatch looks like it would initialise the vehicle with different values on the different machines.
In the past similar constructs around these two settings have caused desync bug reports.

_________________
Ex TTDPatch Coder, Grumpy Greymuzzle
Avatar by MoonsongWolf.
Patch Pack, Github


Top
   
 Post subject: Re: JGR's Patch Pack
PostPosted: Thu Aug 17, 2017 4:11 am 
Offline
Engineer
Engineer

Joined: Sun Apr 09, 2017 2:58 pm
Posts: 30
JGR wrote:
It mostly looks fine to me. OrderList::ResetScheduledDispatch() looks problematic though as it is called in command context and depends on the local setting for whether time is displayed in minutes, and the ticks per minute.
In an MP game, a CMD_SCHEDULED_DISPATCH enable command on a vehicle which hadn't previously been used with scheduled dispatch looks like it would initialise the vehicle with different values on the different machines.
In the past similar constructs around these two settings have caused desync bug reports.


Ouch. Totally forgotten about that. Will fix.


Top
   
 Post subject: Re: JGR's Patch Pack
PostPosted: Sat Aug 19, 2017 9:11 pm 
Offline
Engineer
Engineer

Joined: Sat Feb 18, 2017 5:47 pm
Posts: 21
Hi JGR,

due to the recent additions of patches, I have been greeted at every start of OpenTTD by an ever-growing number of missing translated strings (in my case German). And since it grew to a number at which I could say it bugged my ingame experience a little bit, I decided to do some translations on my own and (possibly) submit them upstream.

However I'm not so sure as to whereto submit my translations of the strings of the various patches and additions, so maybe I asked myself it would be okay to submit it to the patch pack instead :?:

Anyway, here is the language file:
Attachment:
File comment: German language file
german.txt [520.11 KiB]
Downloaded 6 times


PS: Or should I create a .diff? You can however easily see my additions by comparing it with the language file for v. 20.1.


Top
   
 Post subject: Re: JGR's Patch Pack
PostPosted: Sun Aug 20, 2017 8:21 am 
Offline
Tycoon
Tycoon

Joined: Wed Apr 27, 2005 7:09 am
Posts: 5071
Kruemelchen wrote:
Anyway, here is the language file:

Are these all missing translations? I don´t think so.

Nevertheless, some remarks (mostly trunk translations):

Code:
STR_TOOLTIP_RESIZE                                              :{BLACK}Klicken und Ziehen zum Ändern der Größe des Fensters
STR_TOOLTIP_TOGGLE_LARGE_SMALL_WINDOW                           :{BLACK}Zwischen Fenstergrößen umschalten

I´d like to see "Fenstergröße" and "Größe des Fensters" unified to "Fenstergröße".

Code:
STR_TOOLBAR_TOOLTIP_FUND_CONSTRUCTION_OF_NEW                    :{BLACK}Liste aller Industrien oder Errichtung und Finanzierung einer neuen Industrie

-> Liste aller Industrien anzeigen, sowie Errichtung oder Finanzierung einer neuen Industrie
But since "prospection" means "Erkundung", I´d like to propose
-> Liste aller Industrien anzeigen, sowie Erkundung von Rohstoffen oder Finanzierung einer neuen Industrie

STR_SMALLMAP_TOOLTIP_SHOW_LINK_STATS_ON_MAP :{BLACK}Zeige Frachtverbindungen auf Karte
-> Zeige Frachtverbindungen auf der Karte
or better, since every other string uses "Weltkarte"
-> Zeige Frachtverbindungen auf der Weltkarte

Code:
STR_SMALLMAP_TOOLTIP_COMPANY_SELECTION                          :{BLACK}Anzeigeeigenschaften mit Klick auf Firma ändern. Strg+Klick deaktiviert alle Firmen außer die ausgewählte. Wiederholtes Strg+Klick aktiviert alle Firmen

-> Anzeigeeigenschaften mit Klick auf Firma ändern. Strg+Klick deaktiviert alle Firmen außer der ausgewählten. Wiederholtes Strg+Klick aktiviert alle Firmen

regards
Michael

_________________
Image


Top
   
 Post subject: Re: JGR's Patch Pack
PostPosted: Sun Aug 20, 2017 9:51 am 
Offline
Engineer
Engineer

Joined: Sat Feb 18, 2017 5:47 pm
Posts: 21
michael blunck wrote:
Kruemelchen wrote:
Anyway, here is the language file:

Are these all missing translations? I don´t think so.

There are still a few strings (let's say around 4) missing, which I didn't think I could correctly translate without 'diving further into the matter'.

However, I translated merely the patches (or some minor spelling corrections to 3 or so trunk translations). Your additions are very welcome :D

(and if you spot some mistranslations in my strings, you're free to correct them or just contact me and I'll look into it :) )


Top
   
 Post subject: Re: JGR's Patch Pack
PostPosted: Sun Aug 20, 2017 10:29 am 
Offline
Transport Coordinator
Transport Coordinator

Joined: Mon Oct 23, 2006 2:07 am
Posts: 287
Location: Berlin
Hello

Kruemelchen wrote:
… I decided to do some translations on my own …

"Some translations" is a euphemism at all. As far I can see and as you stated yourself it's a more or less complete translation. Congratulations.

Kruemelchen wrote:
You can however easily see my additions by comparing it with the language file for v. 20.1.

You took the 20.1 language file as the base for your translations? Please check the list of closed pull requests of JGRPP, because I translated a few patch settings and ingame strings during the last weeks (german translation parts 4 and 5). Maybe you can improve my translations or vice versa. For preventing double work it seems to be to late. :-)

Tschö, Auge

_________________
further development of My Little Forum 1


Top
   
 Post subject: Re: JGR's Patch Pack
PostPosted: Sun Aug 20, 2017 12:59 pm 
Offline
Traffic Manager
Traffic Manager

Joined: Sun Apr 03, 2016 8:19 pm
Posts: 160
JGR wrote:
p4nzer wrote:
It would appear that daylength is a global variable, which I didn't know. Changing it back made everything go back to normal.

edit: but yes, changing daylength in one save overwrote schedules in every save.

The day length variable is saved to and loaded from the savegame. I cannot reproduce any problem of this type.
Are you sure that you are not changing the client time display settings instead? (Ticks per minute, etc.)

The only potential problem that I can find with scheduled dispatch is multiplayer-related.


ino wrote:
JGR wrote:
ino wrote:
While I have not tested in multiplayer, I have written the schedule dispatch with multi-player in mind (that is also why date/time stuff in the patch is stored in complicated way) and unless I miss, I believe it would work as-is in multiplayer. Working with tick system under the day-length patch is confusing :P

Minute-per-day and minute offset are global setting, though if you revert everything back it should make everything looks normal again. Note that those two settings are purely for UI, so if those are changed, and while the dispatch schedule and timetable will look very weird, it is actually functioning the same (i.e. dispatching train on the same interval as before the change).

It mostly looks fine to me. OrderList::ResetScheduledDispatch() looks problematic though as it is called in command context and depends on the local setting for whether time is displayed in minutes, and the ticks per minute.
In an MP game, a CMD_SCHEDULED_DISPATCH enable command on a vehicle which hadn't previously been used with scheduled dispatch looks like it would initialise the vehicle with different values on the different machines.
In the past similar constructs around these two settings have caused desync bug reports.


Ouch. Totally forgotten about that. Will fix.


Would that have anything to do with my inability to use the clock with certain settings?

The settings I'm trying to combine are...

  • Show time in minutes rather than days: On
  • Enter timetable start times in text (requires time to be in minutes): On (but doesn't fix it by being off)
  • Ticks per minute: 255 (longer minutes)
  • Clock offset in minutes: 0 (should be changed? It didn't help when I tried, just changed the negative numbers)
  • Round up auto-filled timetables times to multiples of this many ticks: 85 (20 seconds under the 255 tick setting?)
  • Day length factor: 125 (very long days)

...but it gives me weird times like "-H:-M" (with numbers at least). I'll include my config as well...

Attachment:
openttd.cfg [47.15 KiB]
Downloaded 2 times


Attachments:
Unnamed, 2100-01-01.png [352.06 KiB]
Not downloaded yet

_________________
Licenses for my work...
All my sets will be one of two licenses and have one extra provision.

Public Domain Mark
Used with FicTownNames v0.0.7a and later. Note the PDM was chosen for unrestriction and Fair Use. If you alter FicTownNames, please include the source code but it isn't required.

GPL v2
Used with everything else I make for OpenTTD (a prototype of blueFish, as of this writing). The graphics and base code of blueFish are not by me so keep that in mind.

You automatically have my permission to re-license graphics or code by me if needed for use in any project that is not GPL v2, on the condition that if you release any derivatives of my graphics they're automatically considered as ALSO GPL v2 (code may remain unreleased, but please do provide it) and carry this provision in GPL v2 uses.

(Note to admins: If this can't count as legal permission to re-license, let me know immediately. I really do not want my work blocked-off.)
Top
   
 Post subject: Re: JGR's Patch Pack
PostPosted: Sun Aug 20, 2017 7:03 pm 
Offline
Engineer
Engineer

Joined: Sat Feb 18, 2017 5:47 pm
Posts: 21
Thank you, Auge :)
Auge wrote:
You took the 20.1 language file as the base for your translations? Please check the list of closed pull requests of JGRPP, because I translated a few patch settings and ingame strings during the last weeks (german translation parts 4 and 5). Maybe you can improve my translations or vice versa. For preventing double work it seems to be to late. :-)

Thank you for your contribution, I'll have a look at your commits :D
Well it didn't take me long, and I'm glad I can now compare them!

I guess I should take the chance to finally get myself a github account then :mrgreen:
I'll then rework the translations and do a pull request anytime soon!
Maybe we'll then have a full translation when everything is combined :wink:

cheers


Top
   
 Post subject: Re: JGR's Patch Pack
PostPosted: Sun Aug 20, 2017 7:49 pm 
Offline
Tycoon
Tycoon
User avatar

Joined: Mon Aug 08, 2005 1:46 pm
Posts: 1680
Location: Ipswich
SimYouLater wrote:
Would that have anything to do with my inability to use the clock with certain settings?

The settings I'm trying to combine are...

  • Show time in minutes rather than days: On
  • Enter timetable start times in text (requires time to be in minutes): On (but doesn't fix it by being off)
  • Ticks per minute: 255 (longer minutes)
  • Clock offset in minutes: 0 (should be changed? It didn't help when I tried, just changed the negative numbers)
  • Round up auto-filled timetables times to multiples of this many ticks: 85 (20 seconds under the 255 tick setting?)
  • Day length factor: 125 (very long days)

...but it gives me weird times like "-H:-M" (with numbers at least). I'll include my config as well...

openttd.cfg

This is due to numeric overflow in the function(s) which convert tick counts to HH:MM strings. It's fixed now.
At day-lengths that high, the tick count no longer fits into a 32-bit signed integer. Somehow those functions got missed when changing types and field sizes.
Thanks for the bug report. It'll be in the next release.

Kruemelchen wrote:
Thank you, Auge :)
Auge wrote:
You took the 20.1 language file as the base for your translations? Please check the list of closed pull requests of JGRPP, because I translated a few patch settings and ingame strings during the last weeks (german translation parts 4 and 5). Maybe you can improve my translations or vice versa. For preventing double work it seems to be to late. :-)

Thank you for your contribution, I'll have a look at your commits :D
Well it didn't take me long, and I'm glad I can now compare them!

I guess I should take the chance to finally get myself a github account then :mrgreen:
I'll then rework the translations and do a pull request anytime soon!
Maybe we'll then have a full translation when everything is combined :wink:

cheers

I'd be happy to merge your translations when you feel that they are ready.
Many thanks for your contributions.

_________________
Ex TTDPatch Coder, Grumpy Greymuzzle
Avatar by MoonsongWolf.
Patch Pack, Github


Top
   
 Post subject: Re: JGR's Patch Pack
PostPosted: Sun Aug 20, 2017 11:23 pm 
Offline
Traffic Manager
Traffic Manager

Joined: Sun Apr 03, 2016 8:19 pm
Posts: 160
JGR wrote:
SimYouLater wrote:
Would that have anything to do with my inability to use the clock with certain settings?

The settings I'm trying to combine are...

  • Show time in minutes rather than days: On
  • Enter timetable start times in text (requires time to be in minutes): On (but doesn't fix it by being off)
  • Ticks per minute: 255 (longer minutes)
  • Clock offset in minutes: 0 (should be changed? It didn't help when I tried, just changed the negative numbers)
  • Round up auto-filled timetables times to multiples of this many ticks: 85 (20 seconds under the 255 tick setting?)
  • Day length factor: 125 (very long days)

...but it gives me weird times like "-H:-M" (with numbers at least). I'll include my config as well...

openttd.cfg

This is due to numeric overflow in the function(s) which convert tick counts to HH:MM strings. It's fixed now.
At day-lengths that high, the tick count no longer fits into a 32-bit signed integer. Somehow those functions got missed when changing types and field sizes.
Thanks for the bug report. It'll be in the next release.


Thank you! When I started reading "numerical overflow" (the thing that caused old high score games to roll over, or similar, right?) I thought "Oh. I'll have to hold back on the numbers then because i went too far." Glad that it can be (relatively) easily fixed. No problem for the bug report. I've had it for months and for some stupid reason never thought to let you know. >_<

_________________
Licenses for my work...
All my sets will be one of two licenses and have one extra provision.

Public Domain Mark
Used with FicTownNames v0.0.7a and later. Note the PDM was chosen for unrestriction and Fair Use. If you alter FicTownNames, please include the source code but it isn't required.

GPL v2
Used with everything else I make for OpenTTD (a prototype of blueFish, as of this writing). The graphics and base code of blueFish are not by me so keep that in mind.

You automatically have my permission to re-license graphics or code by me if needed for use in any project that is not GPL v2, on the condition that if you release any derivatives of my graphics they're automatically considered as ALSO GPL v2 (code may remain unreleased, but please do provide it) and carry this provision in GPL v2 uses.

(Note to admins: If this can't count as legal permission to re-license, let me know immediately. I really do not want my work blocked-off.)


Top
   
Display posts from previous:  Sort by  
Post new topic  Reply to topic  [ 939 posts ]  Go to page Previous 143 44 45 46 47

All times are UTC


Who is online

Users browsing this forum: No registered users and 7 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB © 2000-2017 phpBB Limited

Copyright © Owen Rudge/The Transport Tycoon Forums 2001-2017.
Hosted by Zernebok Hosting.