1.9.1 crashes in multiplayer

[alluke]

Crashes when I click "Find server", previous versions worked without problems. Log below:

Code: Select all

*** OpenTTD Crash Report ***

Crash at: Wed Apr 17 16:47:34 2019
In game date: 2039-06-15 (40)

Crash reason:
 Signal:  Segmentation fault: 11 (11)
 Message: <none>

OpenTTD version:
 Version:    1.9.1 (0)
 NewGRF ver: 19186d64
 Bits:       64
 Endian:     little
 Dedicated:  no
 Build date: Apr  8 2019 19:46:19


Stacktrace:
 [00] openttd              0x0000000102a14728 (SelectCompanyLiveryWindow::GroupNameSorter(Group const* const*, Group const* const*) + 56808)
 [01] CoreFoundation       0x00007fff880625a2 (_CFRuntimeCreateInstance + 610)
 [02] openttd              0x0000000102b58c10 (Pool<OrderList, unsigned short, 128ul, 64000ul, (PoolType)1, false, true>::CleanPool() + 50112)
 [03] libsystem_c.dylib    0x00007fff89d08065 (_qsort + 2021)
 [04] openttd              0x0000000102ae1b4b (NetworkGameWindow::NGameSearchFilter(NetworkGameList* const*, StringFilter&) + 9883)

Operating system:
 Name:     Mac OS X
 Release:  10.11.6
 Machine:  Intel 80486
 Min Ver:  1090
 Compiler: GCC 4.2.1 "4.2.1 Compatible Apple LLVM 9.1.0 (clang-902.0.39.2)"

Configuration:
 Blitter:      32bpp-sse2-anim
 Graphics set: OpenGFX (5580)
 Language:     /Applications/OpenTTD/OpenTTD 1.9.1.app/Contents/Resources/lang/finnish.lng
 Music driver: cocoa
 Music set:    NoMusic (0)
 Network:      no
 Sound driver: cocoa
 Sound set:    OpenSFX (87)
 Video driver: cocoa

Fonts:
 Small:  sprite
 Medium: sprite
 Large:  sprite
 Mono:   sprite

AI Configuration (local: 0) (current: 0):
  0: Human

Libraries:
 FreeType:   2.9.1
 LZMA:       5.2.4
 LZO:        2.10
 PNG:        1.6.36
 Zlib:       1.2.5

---- gamelog start ----
Tick 0: new game started
Revision text changed to g919d7accd7a05, savegame version 207, not modified, _openttd_newgrf_version = 0x19006d64
New game mode: 1 landscape: 0
Tick 10429: settings changed
Setting changed: vehicle.plane_speed : 1 -> 2
Tick 10429: settings changed
Setting changed: vehicle.plane_speed : 2 -> 3
Tick 10429: settings changed
Setting changed: vehicle.plane_speed : 3 -> 4
Tick 10429: settings changed
Setting changed: vehicle.plane_speed : 4 -> 3
Tick 10429: settings changed
Setting changed: vehicle.plane_speed : 3 -> 2
Tick 48718: game loaded
Revision text changed to 1.9.1, savegame version 207, not modified, _openttd_newgrf_version = 0x19186d64
New game mode: 0 landscape: 0
---- gamelog end ----

Recent news messages:

*** End of OpenTTD Crash Report ***

[JGR]

I was able to reproduce this once on a Mac, on my first attempt, multiple further attempts did not crash.
lldb seems to produce much better stack traces than the built in crash logger.
(The method names in the original posted crashlog are misleading as the offsets are improbably large).

[+] Spoiler

Code: Select all

    (crash dialog box frames snipped)
    frame #16: 0x0000000107ecbf88 openttd`HandleCrash(int) + 232
    frame #17: 0x00007fff94f64b3a libsystem_platform.dylib`_sigtramp + 26
    frame #18: 0x00007fff7f4e9aad CoreFoundation`CFStringCompareWithOptionsAndLocale + 77
    frame #19: 0x0000000107ecd4c6 openttd`MacOSStringCompare(char const*, char const*) + 230
    frame #20: 0x000000010804b796 openttd`strnatcmp(char const*, char const*, bool) + 198
    frame #21: 0x0000000107e3201f openttd`NetworkGameWindow::NGameAllowedSorter(NetworkGameList* const&, NetworkGameList* const&) + 143
    frame #22: 0x0000000107e34e28 openttd`void std::__1::__sort<GUIList<NetworkGameList*, StringFilter&>::Sort(bool (*)(NetworkGameList* const&, NetworkGameList* const&))::'lambda'(NetworkGameList* const&, NetworkGameList* const&)&, NetworkGameList**>(NetworkGameList**, NetworkGameList**, GUIList<NetworkGameList*, StringFilter&>::Sort(bool (*)(NetworkGameList* const&, NetworkGameList* const&))::'lambda'(NetworkGameList* const&, NetworkGameList* const&)&) + 808
    frame #23: 0x0000000107e34b5e openttd`void std::__1::__sort<GUIList<NetworkGameList*, StringFilter&>::Sort(bool (*)(NetworkGameList* const&, NetworkGameList* const&))::'lambda'(NetworkGameList* const&, NetworkGameList* const&)&, NetworkGameList**>(NetworkGameList**, NetworkGameList**, GUIList<NetworkGameList*, StringFilter&>::Sort(bool (*)(NetworkGameList* const&, NetworkGameList* const&))::'lambda'(NetworkGameList* const&, NetworkGameList* const&)&) + 94
    frame #24: 0x0000000107e34af3 openttd`GUIList<NetworkGameList*, StringFilter&>::Sort(bool (*)(NetworkGameList* const&, NetworkGameList* const&)) + 147
    frame #25: 0x0000000107e3475d openttd`NetworkGameWindow::BuildGUINetworkGameList() + 557
    frame #26: 0x0000000107e33087 openttd`NetworkGameWindow::OnPaint() + 39
    frame #27: 0x0000000108121e64 openttd`DrawOverlappedWindowForAll(int, int, int, int) + 212
    frame #28: 0x0000000107d943b5 openttd`RedrawScreenRect(int, int, int, int) + 261
    frame #29: 0x0000000107d946f0 openttd`DrawDirtyBlocks() + 736
    frame #30: 0x00000001081277cc openttd`UpdateWindows() + 2076
    frame #31: 0x00000001081302e8 openttd`QZ_GameLoop() + 3608
    frame #32: 0x000000010812c3cb openttd`-[OTTDMain launchGameEngine:] + 43
    frame #33: 0x00007fff7f56837c CoreFoundation`__CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER__ + 12
    frame #34: 0x00007fff7f56827b CoreFoundation`_CFXRegistrationPost + 427
    frame #35: 0x00007fff7f567fe2 CoreFoundation`___CFXNotificationPost_block_invoke + 50
    frame #36: 0x00007fff7f525413 CoreFoundation`-[_CFXNotificationRegistrar find:object:observer:enumerator:] + 1827
    frame #37: 0x00007fff7f52444c CoreFoundation`_CFXNotificationPost + 604
    frame #38: 0x00007fff80f495a7 Foundation`-[NSNotificationCenter postNotificationName:object:userInfo:] + 66
    frame #39: 0x000000010812d13d openttd`VideoDriver_Cocoa::MainLoop() + 45
    frame #40: 0x0000000107eb4775 openttd`openttd_main(int, char**) + 5397
    frame #41: 0x0000000107eceeb8 openttd`main + 152
    frame #42: 0x00007fff94d55235 libdyld.dylib`start + 1
    frame #43: 0x00007fff94d55235 libdyld.dylib`start + 1