chillcore patch pack

[whtemple1959]

Hello,

I am teaching myself about git, github and versioning control and patching
Let me tell you it is not for the faint of heart
getting patches which apparently where made with the old svn system to sync with the git system has been problematic for me
I wanted to compare a few versions one of them being Chill's patch pack against JGR's
I have been here ...
http://bundles.openttdcoop.org/chillpp/releases/
I have tried every version and yet during the make process the sources always have an error which stops the make process
one thing I have found that since I am new might be limited to me is that if I clone a repo it will compile but if I down load the zip file the zip file version will not compile
these little idiosyncrasies I am experiencing are to say the least mind-boggling

So ...
Why will a clone compile but it's zip file not?
Is there a place I can clone a working version of Chill's patch pack?

I suppose I should mention I am using
Mint 18
git 2.7.4
archive manager 3.16.5

Pastebin posts ....
chillpp ..... https://pastebin.com/u5qzNQyp
openttd clone v1.1 ..... https://pastebin.com/y3kFnWjQ
openttd zip file v1.1 ...https://pastebin.com/EYSTmPq6


Thank you
Bill

[kamnet]

Here's the link to the development thread for Chill's Patch Pack. First post includes source code and the last Windows 32-bit binary available.
viewtopic.php?f=33&t=47622

[whtemple1959]

Kamnet,

Thanks for the input
I should have mentioned that I have been to https://hg.openttdcoop.org/chillpp also
Below is the pastebin of the errors which that particular source version gives me

The same as the others if it is not folio.cpp then it is fontcache.cpp which throws a wrench into the make process

https://pastebin.com/fZHXkRL3

The search continues

Thanks
Bill

[Eddi]

these kinds of errors (and warnings) usually come from newer library versions and compiler versions than were available when the code was still actively maintained

you can try some --without-<whatever> configure options to disable some game features and bypass some of the problematic libraries

or you could skim through core game changes how they handled these kinds of transitions (may be tricky to backport)

but a quick attempt here:

Code: Select all

/home/william/Downloads/chillpp-8b08ca4a8490/src/core/math_func.hpp:38:22: note:   template argument deduction/substitution failed:
/home/william/Downloads/chillpp-8b08ca4a8490/src/fontcache.cpp:1034:58: note:   deduced conflicting types for parameter ‘T’ (‘int’ and ‘unsigned int’)
  width  = max(1, slot->bitmap.width + (size == FS_NORMAL));

try replacing the "1" with "1U" (and similar changes in other locations)

[whtemple1959]

Chill Pack update

First I want to thank Kamnet, Eddi, and Row Dog for all of their guidance and advice

Through my research I found that Chill's repository was actually a Mercurial revision control repository and that is why Git would not clone it so I installed Mercurial and TortoiseHg and obtained the repository

After testing three or four from each year of "commits" I was still having trouble with fileio.cpp and fontcache.cpp(I still do not understand how so many revisions could be giving me the exact same errors)

Using Meld and online searches I was finally able to hobble together functioning fileio.cpp and fontcache.cpp files.
Although there were far too many warnings during the "make" process for this accountant(I will work on cleaning those up later) I was able to compile and install the game.

Unfortunately the game crashes at start up.

libpthread and libc.so.6 are mentioned frequently in the crash report so I think maybe this is the source of the problem.

I am attaching the crash data if any one wants to take a look and maybe assist me with fixing the problem

The system will not allow me to upload the "crash.log" so here it is .....

*** OpenTTD Crash Report ***

Crash at: Thu Oct 11 15:32:49 2018
In game date: 0-01-01 (0)

Crash reason:
Signal: Aborted (6)
Message: <none>

OpenTTD version:
Version: norev000 (1)
NewGRF ver: 13000000
Bits: 64
Endian: little
Dedicated: no
Build date: Oct 11 2018 11:29:08

Stacktrace:
[00] openttd(_ZNK12CrashLogUnix13LogStacktraceEPcPKc+0x4a) [0x6d545a]
[01] openttd(_ZNK8CrashLog12FillCrashLogEPcPKc+0xfc) [0x5d8eec]
[02] openttd(_ZNK8CrashLog12MakeCrashLogEv+0x7f) [0x5d919f]
[03] openttd() [0x6d53a2]
[04] /lib/x86_64-linux-gnu/libc.so.6(+0x354b0) [0x7fb64038e4b0]
[05] /lib/x86_64-linux-gnu/libc.so.6(gsignal+0x38) [0x7fb64038e428]
[06] /lib/x86_64-linux-gnu/libc.so.6(abort+0x16a) [0x7fb64039002a]
[07] /lib/x86_64-linux-gnu/libc.so.6(+0x777ea) [0x7fb6403d07ea]
[08] /lib/x86_64-linux-gnu/libc.so.6(+0x8037a) [0x7fb6403d937a]
[09] /lib/x86_64-linux-gnu/libc.so.6(cfree+0x4c) [0x7fb6403dd53c]
[10] openttd(_ZN6WindowD1Ev+0x7b) [0x7fde5b]
[11] openttd(_Z19DeleteWindowByClass11WindowClass+0x40) [0x7fe050]
[12] openttd() [0x618ac5]
[13] openttd() [0x618e34]
[14] openttd(_ZN20ThreadObject_pthread10ThreadProcEv+0xb) [0x7a28ab]
[15] openttd(_ZN20ThreadObject_pthread12stThreadProcEPv+0x9) [0x7a2929]
[16] /lib/x86_64-linux-gnu/libpthread.so.0(+0x76ba) [0x7fb6422326ba]
[17] /lib/x86_64-linux-gnu/libc.so.6(clone+0x6d) [0x7fb64046041d]

Operating system:
Name: Linux
Release: 4.4.0-21-generic
Version: #37-Ubuntu SMP Mon Apr 18 18:33:37 UTC 2016
Machine: x86_64
Compiler: GCC 5.4.0 "5.4.0 20160609"

Configuration:
Blitter: 8bpp-optimized
Graphics set: OpenGFX (5580)
Language: /usr/local/share/games/openttd/lang/english_US.lng
Music driver: extmidi
Music set: Radio Monochrome Volume 1. (0)
Network: no
Sound driver: sdl
Sound set: OpenSFX (87)
Video driver: sdl

AI Configuration (local: 0):

Libraries:
FontConfig: 2.11.94
FreeType: 2.6.1
ICU: 55.1
LZMA: 5.1.0alpha
LZO: 2.08
PNG: 1.2.54
SDL: 1.2.15
Zlib: 1.2.8

---- gamelog start ----
Tick 0: new game started
Revision text changed to norev000, savegame version 179, maybe modified, _openttd_newgrf_version = 0x13000000
New game mode: 0 landscape: 0
---- gamelog end ----

*** End of OpenTTD Crash Report ***

Respectfully
Bill

[Eddi]

my first guess would be that your messy fontcache changes cause those...

[whtemple1959]

Eddi,

You are right from my research it appears I have a dangling participle some where in my hacks.

Since the only thing I want is the Save Company Profile patch ... viewtopic.php?f=33&t=40457&start=0 I think my time will be better spent trying to upgrade the patch rather than down grading the came to fit the patch.

But I will state again your suggestions and guidance have been a god send.

Thank you

Bill