Page 7 of 8

Re: American Bridge Replacement Set [0.4.0 Released 4-30-19]

Posted: 10 Nov 2019 23:33
by SimYouLater
Never mind about the trestle. It's a minor glitch and can't be solved wityhout adjusting the sprites. I'll post the bridge glitches in the other direction so you don't have to check anything manually.

Here's the cable-stayed rail bridge...

Re: American Bridge Replacement Set [0.4.0 Released 4-30-19]

Posted: 10 Nov 2019 23:39
by wallyweb
Just a note ... You can't check alignments against custom bridge heads mainly because they are not part of the bridges. Set your alignments against the bridge's own ramps. I recommend using the flat ramp which can in turn be aligned to a flat ground tile. You may find my Tile Grids very useful here.

Re: American Bridge Replacement Set [0.4.0 Released 4-30-19]

Posted: 10 Nov 2019 23:41
by SimYouLater
Plate girder bridge, checked against both bridge head types...

EDIT: Not fixable via sprite alignment, adding this for your convenience.

Re: American Bridge Replacement Set [0.4.0 Released 4-30-19]

Posted: 10 Nov 2019 23:55
by SimYouLater
Issue with the covered road bridge, that should be everything. Hopefully this isn't too much work for you!

Re: American Bridge Replacement Set [0.4.0 Released 4-30-19]

Posted: 11 Nov 2019 00:07
by wallyweb
SimYouLater wrote:
10 Nov 2019 23:55
Issue with the covered road bridge, that should be everything. Hopefully this isn't too much work for you!
Looks to me like a girder for the N>S bridge was used.

Re: American Bridge Replacement Set [0.4.0 Released 4-30-19]

Posted: 11 Nov 2019 00:07
by Andrew350
Trouble is you're only checking one type of bridge head with your fixes ;)
gap.png
gap.png (14.16 KiB) Viewed 2548 times
Like I said, some of the issues you're pointing out can't be easily solved by just re-aligning the sprites; they are put where they are for a reason ;) In order to "fix" them would require a tricky dance of balancing how it looks between different versions of the game to support a minor niche feature. It's hard enough to get all the pieces to line up properly as it is, so I'm not sure the amount of time it would take to make it "perfect" is worth it (if its even possible for that matter). In the case where one is going to look "off" I would lean towards JGRPP taking the hit, plus many of these issues are also very minor ;)

The covered bridge thing is definitely weird though, especially since it only happens in one direction :? There's probably an errant byte somewhere, so I'll look into that :)

EDIT:
wallyweb wrote:Looks to me like a girder for the N>S bridge was used
Yeah, except there shouldn't even be a support there at all Ah nevermind, yeah it's just the wrong sprite there. Easy fix :)

Re: American Bridge Replacement Set [0.4.0 Released 4-30-19]

Posted: 15 Nov 2019 02:04
by SimYouLater
Andrew350 wrote:
11 Nov 2019 00:07
Trouble is you're only checking one type of bridge head with your fixes ;)

Like I said, some of the issues you're pointing out can't be easily solved by just re-aligning the sprites; they are put where they are for a reason ;) In order to "fix" them would require a tricky dance of balancing how it looks between different versions of the game to support a minor niche feature. It's hard enough to get all the pieces to line up properly as it is, so I'm not sure the amount of time it would take to make it "perfect" is worth it (if its even possible for that matter). In the case where one is going to look "off" I would lean towards JGRPP taking the hit, plus many of these issues are also very minor ;)
Fair enough! Can you at least fix the alignment of the cable-stayed bridge? It looks like an easy fix to me.
Andrew350 wrote:
11 Nov 2019 00:07
The covered bridge thing is definitely weird though, especially since it only happens in one direction :? There's probably an errant byte somewhere, so I'll look into that :)

EDIT:
wallyweb wrote:Looks to me like a girder for the N>S bridge was used
Yeah, except there shouldn't even be a support there at all Ah nevermind, yeah it's just the wrong sprite there. Easy fix :)
Yeah, that was definitely unintentional. I'm looking forward to version 4.1! :D

EDIT: Fixed the cable-stayed bridge for you!

Re: American Bridge Replacement Set [0.4.0 Released 4-30-19]

Posted: 26 Jan 2020 01:41
by Gadg8eer
Hi. I spotted an issue with the cable-stayed bridge's supports. I know I'm new, but can you fix this in the next release?

EDIT: I just checked it in the sprite aligner, this can't be fixed the way I thought it could. Sorry to bother you.

Re: American Bridge Replacement Set [0.4.0 Released 4-30-19]

Posted: 06 Feb 2020 04:43
by Gadg8eer
So, I've been looking into bridges in an attempt to make a JGR-compatible bridge set. Is there any chance you can help me code a single road-only bridge mod out of your wooden bridge in m4nfo?

Re: American Bridge Replacement Set [0.4.0 Released 4-30-19]

Posted: 06 Feb 2020 22:25
by Andrew350
Hi Gadg8eer

Unfortunately I've never used m4nfo so I don't think I will be of much help there. I may be able to give some pointers for regular nfo, but I'm not sure how that will translate to m4nfo.

Honestly once you copy one bridge, it's mostly a matter of changing certain bytes and strings and sprites to add another one. Understanding what each part does will help with debugging if you miss something (I always miss something :P), and that info can be found in the newgrf documentation. I strongly recommend reading the docs while reading the code side-by-side to understand what is going on in each piece of code :)

Re: American Bridge Replacement Set [0.4.0 Released 4-30-19]

Posted: 09 Feb 2020 01:28
by Gadg8eer
Andrew350 wrote:
06 Feb 2020 22:25
Hi Gadg8eer

Unfortunately I've never used m4nfo so I don't think I will be of much help there. I may be able to give some pointers for regular nfo, but I'm not sure how that will translate to m4nfo.

Honestly once you copy one bridge, it's mostly a matter of changing certain bytes and strings and sprites to add another one. Understanding what each part does will help with debugging if you miss something (I always miss something :P), and that info can be found in the newgrf documentation. I strongly recommend reading the docs while reading the code side-by-side to understand what is going on in each piece of code :)
Thanks. Can I contact you via PM if wallyweb doesn't know anything about m4nfo? I don't learn well from reading or doing, only from having someone to ask questions when I run into an issue.

Re: American Bridge Replacement Set [0.4.0 Released 4-30-19]

Posted: 09 Feb 2020 01:56
by wallyweb
Gadg8eer wrote:
09 Feb 2020 01:28
if wallyweb doesn't know anything about m4nfo? I don't learn well from reading or doing, only from having someone to ask questions when I run into an issue.
Michael Blunck (aka MB) is the best person to consult about m4nfo. He developed it. Also, Michael is very good about helping people. You'll get good guidance. 8)

Re: American Bridge Replacement Set [0.4.0 Released 4-30-19]

Posted: 09 Feb 2020 02:14
by Gadg8eer
wallyweb wrote:
09 Feb 2020 01:56
Gadg8eer wrote:
09 Feb 2020 01:28
if wallyweb doesn't know anything about m4nfo? I don't learn well from reading or doing, only from having someone to ask questions when I run into an issue.
Michael Blunck (aka MB) is the best person to consult about m4nfo. He developed it. Also, Michael is very good about helping people. You'll get good guidance. 8)
Is that the guy who's a perfectionist with his NewGRFs? I've heard good things about him, but also bad things. I'll contact him regardless if I can't figure out how to make his m4nfo bridge template work.

Re: American Bridge Replacement Set [0.4.0 Released 4-30-19]

Posted: 09 Feb 2020 02:33
by wallyweb
Gadg8eer wrote:
09 Feb 2020 02:14
wallyweb wrote:
09 Feb 2020 01:56
Gadg8eer wrote:
09 Feb 2020 01:28
if wallyweb doesn't know anything about m4nfo? I don't learn well from reading or doing, only from having someone to ask questions when I run into an issue.
Michael Blunck (aka MB) is the best person to consult about m4nfo. He developed it. Also, Michael is very good about helping people. You'll get good guidance. 8)
Is that the guy who's a perfectionist with his NewGRFs?
Yep. :D He was one of the first to release a NewGRF way back when there was only TTDPatch.
I'll contact him regardless if I can't figure out how to make his m4nfo bridge template work.
You'll not regret it. :D

Re: American Bridge Replacement Set [0.4.0 Released 4-30-19]

Posted: 28 May 2020 23:53
by Gadg8eer
wallyweb wrote:
09 Feb 2020 02:33
Gadg8eer wrote:
09 Feb 2020 02:14
wallyweb wrote:
09 Feb 2020 01:56
Michael Blunck (aka MB) is the best person to consult about m4nfo. He developed it. Also, Michael is very good about helping people. You'll get good guidance. 8)
Is that the guy who's a perfectionist with his NewGRFs?
Yep. :D He was one of the first to release a NewGRF way back when there was only TTDPatch.
I'll contact him regardless if I can't figure out how to make his m4nfo bridge template work.
You'll not regret it. :D
I regret it. MB hasn't so much as looked at my PM.

Any chance you can help me code bridges? I'm planning a modular approach to them, each GRF has only one bridge and a parameter for the bridge ID so that they can be mixed and matched.

Re: American Bridge Replacement Set [0.4.0 Released 4-30-19]

Posted: 29 May 2020 03:20
by wallyweb
Gadg8eer wrote:
28 May 2020 23:53
Any chance you can help me code bridges? I'm planning a modular approach to them, each GRF has only one bridge and a parameter for the bridge ID so that they can be mixed and matched.
I was thinking about something like that a few months ago. It could be a bit of a nightmare though. The ID is used in several places in the code. I've got a bit of a workload for the next couple of weeks. Remind me the second Friday in June and we'll take a look at it. Do you have the sprites for a very simple bridge to start with?

Re: American Bridge Replacement Set [0.4.0 Released 4-30-19]

Posted: 29 May 2020 03:29
by Gadg8eer
wallyweb wrote:
29 May 2020 03:20
Gadg8eer wrote:
28 May 2020 23:53
Any chance you can help me code bridges? I'm planning a modular approach to them, each GRF has only one bridge and a parameter for the bridge ID so that they can be mixed and matched.
I was thinking about something like that a few months ago. It could be a bit of a nightmare though. The ID is used in several places in the code. I've got a bit of a workload for the next couple of weeks. Remind me the second Friday in June and we'll take a look at it. Do you have the sprites for a very simple bridge to start with?
I know it's kind of annoying that I use other people's sprites, but I figure it's better to give full credits and only use GPL stuff than to create GRFs with terrible graphics. So yes, I do have the sprites needed, borrowed from other bridge sets. The problem is that I have no idea how m4nfo works, which has led to a dead end in my bridge coding.

Keep in mind these bridges have been hand-picked for graphical compatibility with JGRPP, which has custom bridge heads. Not a single bridge has so much as a pixel of a hole; holes in the sprites currently plague every bridge set ever made.

Re: American Bridge Replacement Set [0.4.0 Released 4-30-19]

Posted: 29 May 2020 04:08
by wallyweb
Ok .. All my coding is in NFO.
The Suspended Monorail Bridge in your spreadsheet was done by me. We'll save that one for last.
JGR is a good choice for bridges. He's added some features that are quite interesting. More on that later.
If you haven't seen my tutorial, now is a good time to study it here. It's a work in progress with much still to be done.
What do you mean by "holes"?

Re: American Bridge Replacement Set [0.4.0 Released 4-30-19]

Posted: 10 Jun 2020 21:41
by Gadg8eer
wallyweb wrote:
29 May 2020 04:08
Ok .. All my coding is in NFO.
The Suspended Monorail Bridge in your spreadsheet was done by me. We'll save that one for last.
JGR is a good choice for bridges. He's added some features that are quite interesting. More on that later.
If you haven't seen my tutorial, now is a good time to study it here. It's a work in progress with much still to be done.
What do you mean by "holes"?
When using custom bridge heads, holes appear in at least one bridge in every bridge set made to date. You can see the hole in this rail bridge where the demolition explosion (the orange pixels) shines through the hole.

Re: American Bridge Replacement Set [0.4.0 Released 4-30-19]

Posted: 10 Jun 2020 22:44
by Andrew350
Seeing as the discussion is leading away from the main topic, perhaps it is best moved to PMs or split off to a new development thread :)