American Bridge Replacement Set [0.4.0 Released 4-30-19]

Discuss, get help with, or post new graphics for TTDPatch and OpenTTD, using the NewGRF system, here. Graphics for plain TTD also acceptable here.

Moderator: Graphics Moderators

User avatar
Andrew350
Route Supervisor
Route Supervisor
Posts: 484
Joined: 19 Dec 2011 07:54
Location: Washington State, USA
Contact:

Re: American Bridge Replacement Set [0.4.0 Released 4-30-19]

Post by Andrew350 » 15 May 2019 05:55

So I've made the fix to the default bridge recode and (re)attached the .txt file below. All credit goes to FooBar for the work, and as stated in the original posting is available under Creative Commons Attribution-Noncommercial 3.0 Netherlands license, GNU GPL v2 licence, and GNU GPL v3 licence; just make sure to credit FooBar if you use (part of) this in your project. :)

The only thing I modified is the sprite table for part 0 of the tubular bridges to fix the incorrect sprites, all else is the same. I'll also redirect the link on the GRFSpecs wiki to point here for future brave souls who might need it for a bridge NewGRF :)

And of course I'll make the fix in ABRS itself, although probably not until 0.5 unless more bugs show up before then.
Attachments
default_bridges_revised.txt
Released under Creative Commons Attribution-Noncommercial 3.0 Netherlands license, GNU GPL v2 licence, and GNU GPL v3 licence. Credit: FooBar
(72.74 KiB) Downloaded 37 times

SimYouLater
Director
Director
Posts: 599
Joined: 03 Apr 2016 20:19

Re: American Bridge Replacement Set [0.4.0 Released 4-30-19]

Post by SimYouLater » 29 May 2019 00:14

Andrew350 wrote:So I've made the fix to the default bridge recode and (re)attached the .txt file below. All credit goes to FooBar for the work, and as stated in the original posting is available under Creative Commons Attribution-Noncommercial 3.0 Netherlands license, GNU GPL v2 licence, and GNU GPL v3 licence; just make sure to credit FooBar if you use (part of) this in your project. :)

The only thing I modified is the sprite table for part 0 of the tubular bridges to fix the incorrect sprites, all else is the same. I'll also redirect the link on the GRFSpecs wiki to point here for future brave souls who might need it for a bridge NewGRF :)

And of course I'll make the fix in ABRS itself, although probably not until 0.5 unless more bugs show up before then.
Can I make the fix myself and call it 4.1? Aside from NRT in JGRPP, I'm waiting on this before I can start my dream game in 1700 and go past 2100.
Licenses for my work...
You automatically have my permission to re-license graphics or code by me if needed for use in any project that is not GPL v2, on the condition that if you release any derivatives of my graphics they're automatically considered as ALSO GPL v2 (code may remain unreleased, but please do provide it) and carry this provision in GPL v2 uses.
Please ask someone in-the-know to be sure that the graphics are done by me. Especially TTD-Scale, long story.

User avatar
Andrew350
Route Supervisor
Route Supervisor
Posts: 484
Joined: 19 Dec 2011 07:54
Location: Washington State, USA
Contact:

Re: American Bridge Replacement Set [0.4.0 Released 4-30-19]

Post by Andrew350 » 29 May 2019 04:49

No need to make a new version really, just modify the few hex bytes necessary locally and compile. It should remain compatible once the next version comes out (if you choose to upgrade the savegame). :)

SimYouLater
Director
Director
Posts: 599
Joined: 03 Apr 2016 20:19

Re: American Bridge Replacement Set [0.4.0 Released 4-30-19]

Post by SimYouLater » 29 May 2019 04:54

Andrew350 wrote:No need to make a new version really, just modify the few hex bytes necessary locally and compile. It should remain compatible once the next version comes out (if you choose to upgrade the savegame). :)
Tbh, I need someone to show me the edits I need to make. I am clueless with NFO.
Licenses for my work...
You automatically have my permission to re-license graphics or code by me if needed for use in any project that is not GPL v2, on the condition that if you release any derivatives of my graphics they're automatically considered as ALSO GPL v2 (code may remain unreleased, but please do provide it) and carry this provision in GPL v2 uses.
Please ask someone in-the-know to be sure that the graphics are done by me. Especially TTD-Scale, long story.

User avatar
Andrew350
Route Supervisor
Route Supervisor
Posts: 484
Joined: 19 Dec 2011 07:54
Location: Washington State, USA
Contact:

Re: American Bridge Replacement Set [0.4.0 Released 4-30-19]

Post by Andrew350 » 29 May 2019 05:08

SimYouLater wrote:Tbh, I need someone to show me the edits I need to make. I am clueless with NFO
Well in that case, the 'simple' way would be to copy all of the code for the tubular bridges in the default_bridges_revised.txt file posted above, then paste that over the same bridges in the american_bridges.nfo file found in the source zip. (The tubular bridge code is all the way at the bottom, make sure to copy and paste over all 3 of them!). Then just compile with grfcodec.

SimYouLater
Director
Director
Posts: 599
Joined: 03 Apr 2016 20:19

Re: American Bridge Replacement Set [0.4.0 Released 4-30-19]

Post by SimYouLater » 29 May 2019 18:30

Andrew350 wrote:
SimYouLater wrote:Tbh, I need someone to show me the edits I need to make. I am clueless with NFO
Well in that case, the 'simple' way would be to copy all of the code for the tubular bridges in the default_bridges_revised.txt file posted above, then paste that over the same bridges in the american_bridges.nfo file found in the source zip. (The tubular bridge code is all the way at the bottom, make sure to copy and paste over all 3 of them!). Then just compile with grfcodec.
I just did exactly that but, for some reason, it didn't fix the issue.

EDIT: On further inspection, the default_bridges_revised.txt is identical to the nfo's contents. You posted the wrong thing.
Licenses for my work...
You automatically have my permission to re-license graphics or code by me if needed for use in any project that is not GPL v2, on the condition that if you release any derivatives of my graphics they're automatically considered as ALSO GPL v2 (code may remain unreleased, but please do provide it) and carry this provision in GPL v2 uses.
Please ask someone in-the-know to be sure that the graphics are done by me. Especially TTD-Scale, long story.

Eddi
Tycoon
Tycoon
Posts: 7395
Joined: 17 Jan 2007 00:14

Re: American Bridge Replacement Set [0.4.0 Released 4-30-19]

Post by Eddi » 29 May 2019 23:05

SimYouLater wrote:EDIT: On further inspection, the default_bridges_revised.txt is identical to the nfo's contents. You posted the wrong thing.
you must be blind, i clearly see the difference

in the lines after

Code: Select all

//bronze tubular steel bridge (0A)
in the .txt they start with 0B, 0C, 11, ...
and in the .nfo with 0A, 0D, 10, ...
(just the first entry in each line)
You might not exactly be interested in Ferion, but if you are, have fun :)

SimYouLater
Director
Director
Posts: 599
Joined: 03 Apr 2016 20:19

Re: American Bridge Replacement Set [0.4.0 Released 4-30-19]

Post by SimYouLater » 29 May 2019 23:33

Eddi wrote:
SimYouLater wrote:EDIT: On further inspection, the default_bridges_revised.txt is identical to the nfo's contents. You posted the wrong thing.
you must be blind, i clearly see the difference

in the lines after

Code: Select all

//bronze tubular steel bridge (0A)
in the .txt they start with 0B, 0C, 11, ...
and in the .nfo with 0A, 0D, 10, ...
(just the first entry in each line)
You're right, somehow I got confused.

I managed to put the thing back together. Here...
Attachments
american_bridges.grf
0.4.0, with corrected tubular bridges
(168.76 KiB) Downloaded 27 times
Licenses for my work...
You automatically have my permission to re-license graphics or code by me if needed for use in any project that is not GPL v2, on the condition that if you release any derivatives of my graphics they're automatically considered as ALSO GPL v2 (code may remain unreleased, but please do provide it) and carry this provision in GPL v2 uses.
Please ask someone in-the-know to be sure that the graphics are done by me. Especially TTD-Scale, long story.

User avatar
NekoMaster
Tycoon
Tycoon
Posts: 3940
Joined: 16 Aug 2008 22:26
Skype: neko-master
Location: Oshawa, Ontario, CANADA

Re: American Bridge Replacement Set [0.4.0 Released 4-30-19]

Post by NekoMaster » 13 Jun 2019 23:39

Checking out version 0.4.0 for once and it looks good, though It would be nice if I could customize it a bit like say, having Parameters to allow users to tweak the introduction dates and max speeds (The default speeds are "OK" but I'd prefer maybe a bit faster on some of the non-wood type bridges considering I see VIA trains zipping across plate girder bridges at around 160 km/h quite often when I travel)
Image Proud Canadian Image
Nekomasters Projects! (Downloads available on BaNaNaS!) \(>^w^<)/
# NARS ADD-ON SET 2CC | 2cc Rapid Transit For Me! (2ccRTFM) | 2cc Wagons In NML (2ccWIN)
# NML Category System (Organize your GRFS!) <- TT-Forums Exclusive Download!

User avatar
Andrew350
Route Supervisor
Route Supervisor
Posts: 484
Joined: 19 Dec 2011 07:54
Location: Washington State, USA
Contact:

Re: American Bridge Replacement Set [0.4.0 Released 4-30-19]

Post by Andrew350 » 14 Jun 2019 03:36

NekoMaster wrote:
13 Jun 2019 23:39
Checking out version 0.4.0 for once and it looks good, though It would be nice if I could customize it a bit like say, having Parameters to allow users to tweak the introduction dates and max speeds (The default speeds are "OK" but I'd prefer maybe a bit faster on some of the non-wood type bridges considering I see VIA trains zipping across plate girder bridges at around 160 km/h quite often when I travel)
I fully agree, and it's on my to-do list to include user-defined speeds, intro dates, etc. I just have to figure out how to do it in NFO; it's probably not hard but I haven't really had the urge to dive in and try it yet :P

User avatar
NekoMaster
Tycoon
Tycoon
Posts: 3940
Joined: 16 Aug 2008 22:26
Skype: neko-master
Location: Oshawa, Ontario, CANADA

Re: American Bridge Replacement Set [0.4.0 Released 4-30-19]

Post by NekoMaster » 14 Jun 2019 17:20

Andrew350 wrote:
14 Jun 2019 03:36
NekoMaster wrote:
13 Jun 2019 23:39
Checking out version 0.4.0 for once and it looks good, though It would be nice if I could customize it a bit like say, having Parameters to allow users to tweak the introduction dates and max speeds (The default speeds are "OK" but I'd prefer maybe a bit faster on some of the non-wood type bridges considering I see VIA trains zipping across plate girder bridges at around 160 km/h quite often when I travel)
I fully agree, and it's on my to-do list to include user-defined speeds, intro dates, etc. I just have to figure out how to do it in NFO; it's probably not hard but I haven't really had the urge to dive in and try it yet :P
Well for now I just setup a little GRF codec setup on my C drive to modify the set to my needs though I wont be releasing the modified GRF so no incompatible versions and problems arise. Plus the modifications I'm doing may not be for everyone :D
Image Proud Canadian Image
Nekomasters Projects! (Downloads available on BaNaNaS!) \(>^w^<)/
# NARS ADD-ON SET 2CC | 2cc Rapid Transit For Me! (2ccRTFM) | 2cc Wagons In NML (2ccWIN)
# NML Category System (Organize your GRFS!) <- TT-Forums Exclusive Download!

Post Reply

Return to “Graphics Development”

Who is online

Users browsing this forum: No registered users and 6 guests