[OTTD] PolTrams: newgrf with Polish trams

Discuss, get help with, or post new graphics for TTDPatch and OpenTTD, using the NewGRF system, here. Graphics for plain TTD also acceptable here.

Moderator: Graphics Moderators

Wahazar
Tycoon
Tycoon
Posts: 1451
Joined: 18 Jan 2014 18:10

Re: [OTTD] PolTrams: newgrf with Polish trams

Post by Wahazar »

PikkaBird wrote:
McZapkie wrote: You still haven't really explained what you mean by "SFX setting".
I corrected my question later:
However instead of checking SFX settings itself, better idea is just to check [sound] section vehicle = true/false
Of course, you are right, that SFX set name is not a good idea to checking for newgrf (I'm using it to switch sound off because of my laziness).
Eddi
Tycoon
Tycoon
Posts: 8257
Joined: 17 Jan 2007 00:14

Re: [OTTD] PolTrams: newgrf with Polish trams

Post by Eddi »

So, basically, you're asking "if i close the water pipe, does that prevent rain from falling?"
Wahazar
Tycoon
Tycoon
Posts: 1451
Joined: 18 Jan 2014 18:10

Re: [OTTD] PolTrams: newgrf with Polish trams

Post by Wahazar »

I'm trying to define sounds for trams, but something goes wrong.
I have two sets, polroad and poltrams, each one have sounds defined via sound_effect property, for example
sound_effect: sound("src/sfx/horse_kls8.wav");

It works fine, if only one newgrf is loaded.
If both are, newgrf loaded below, steal sounds from the newgrf above.
Any idea, what can be wrong? Sprite Id is defined as SPRITE_ID_NEW_ROADVEH, I did not see any other conflicts.

EDIT: I found similar problem with other newgrfs, for example polroad or poltrams have changed sounds with eGRVTS trams.
Formerly known as: McZapkie
Projects: Reproducible Map Generation patch, NewGRFs: Manpower industries, PolTrams, Polroad, 600mm narrow gauge, wired, ECS industry extension, V4 CEE train set, HotHut.
Another favorite games: freeciv longturn, OHOL/2HOL.
User avatar
einsteinyh
Engineer
Engineer
Posts: 46
Joined: 15 Feb 2016 01:22
Location: Bogotá

Re: [OTTD] PolTrams: newgrf with Polish trams

Post by einsteinyh »

Where can I find the GRF? I don't find it in Bananas... :cry:
Wahazar
Tycoon
Tycoon
Posts: 1451
Joined: 18 Jan 2014 18:10

Re: [OTTD] PolTrams: newgrf with Polish trams

Post by Wahazar »

einsteinyh wrote:Where can I find the GRF? I don't find it in Bananas... :cry:
Sorry for late reply, I was on vacations.
GRF is on Bananas, it is called 'Polish Tram Set by Sojita'. Write tag 'tram' for searching.
Formerly known as: McZapkie
Projects: Reproducible Map Generation patch, NewGRFs: Manpower industries, PolTrams, Polroad, 600mm narrow gauge, wired, ECS industry extension, V4 CEE train set, HotHut.
Another favorite games: freeciv longturn, OHOL/2HOL.
User avatar
sevenfm
Engineer
Engineer
Posts: 117
Joined: 25 Jul 2016 23:44
Location: Soviet Russia

Re: [OTTD] PolTrams: newgrf with Polish trams

Post by sevenfm »

It would be great to have option for some early horse trams in this set. I understand it's meant to be realistic but I really miss horse trams when starting in 1800 and the only other option - EGRVTS, is completely unbalanced when used with this set.
I like trains. They are soothing.
Wahazar
Tycoon
Tycoon
Posts: 1451
Joined: 18 Jan 2014 18:10

Re: [OTTD] PolTrams: newgrf with Polish trams

Post by Wahazar »

sevenfm wrote:It would be great to have option for some early horse trams in this set. I understand it's meant to be realistic but I really miss horse trams when starting in 1800 and the only other option - EGRVTS, is completely unbalanced when used with this set.
I have plan to add first horse tram, which was in use in Warsaw from 1866. But I prefer to keep real prototypes dates. You can use Polroad set which have some horse carriages (it is possible to switch off/on other vehicles), I also recommend "Early houses" - this grf decrease pass/mail production before XX century, so horse carriages can copy with urban transport.
Formerly known as: McZapkie
Projects: Reproducible Map Generation patch, NewGRFs: Manpower industries, PolTrams, Polroad, 600mm narrow gauge, wired, ECS industry extension, V4 CEE train set, HotHut.
Another favorite games: freeciv longturn, OHOL/2HOL.
User avatar
sevenfm
Engineer
Engineer
Posts: 117
Joined: 25 Jul 2016 23:44
Location: Soviet Russia

Re: [OTTD] PolTrams: newgrf with Polish trams

Post by sevenfm »

Russian translation for PolTrams set:
https://drive.google.com/open?id=1Kz56l ... Zz0zv68ZJp
User avatar
sevenfm
Engineer
Engineer
Posts: 117
Joined: 25 Jul 2016 23:44
Location: Soviet Russia

Re: [OTTD] PolTrams: newgrf with Polish trams

Post by sevenfm »

It seems that running cost modifier parameter has no effect. Purchase cost modifier works well.
How to fix that? The same problems seems to be with PolRoad set, but in HEQS set running cost modifier works as it should.
Tested with OpenTTD 1.8, no other grfs, downloaded PolTrams from ingame content.

Edit:
If I add Basecosts after this set, I can change running cost of vehicles by changing running cost for electric engines, but changing running cost for road vehicles in Basecosts still has no effect. Very strange.
Wahazar
Tycoon
Tycoon
Posts: 1451
Joined: 18 Jan 2014 18:10

Re: [OTTD] PolTrams: newgrf with Polish trams

Post by Wahazar »

Base costs for trams are as for electric locomotives - seems that it was not a good idea.
I fixed running cost modifier (low/normal/high), it works fine now:
https://jenkins.openttdcoop.org/job/poltrams/lastBuild/
but it still rely on electric traction base costs.
User avatar
sevenfm
Engineer
Engineer
Posts: 117
Joined: 25 Jul 2016 23:44
Location: Soviet Russia

Re: [OTTD] PolTrams: newgrf with Polish trams

Post by sevenfm »

Maybe it's better to set running_cost_base to RUNNING_COST_ROADVEH for all trams? I looked at 2cc trams code and they use only RUNNING_COST_ROADVEH for trams.
I also found that PolRoad set also uses RUNNING_COST_ELECTRIC for horse vehicles - stage coach, omnibus and others, it doesn't seem right.
As far as I understand from NML documentation, RUNNING_COST_STEAM, RUNNING_COST_DIESEL and RUNNING_COST_ELECTRIC are for train engines, not for road vehicles/trams.
Wahazar
Tycoon
Tycoon
Posts: 1451
Joined: 18 Jan 2014 18:10

Re: [OTTD] PolTrams: newgrf with Polish trams

Post by Wahazar »

Christmas present: new version uploaded to new banana service, while source migrated to github (link in O.P.).
Some bugs fixed - running cost now base on roadveh.
All cargo trams can carry mail (it is not realistic, but more playable).
Horse trams can use non-electrified track.
New tram added - universal horse tram from 1860, inspired by first Warsaw tram used to carry both passengers and freight.
Formerly known as: McZapkie
Projects: Reproducible Map Generation patch, NewGRFs: Manpower industries, PolTrams, Polroad, 600mm narrow gauge, wired, ECS industry extension, V4 CEE train set, HotHut.
Another favorite games: freeciv longturn, OHOL/2HOL.
Post Reply

Return to “Graphics Development”

Who is online

Users browsing this forum: Google [Bot], Google Adsense [Bot] and 13 guests