Page 98 of 98

Re: Multiple unit Wagon (invisible)

Posted: 13 Jan 2020 18:40
by Transportman
ignasigh wrote: 02 Jan 2020 08:22 Hi

I am using latest 2CC NML sets and I noticed that the MUW are invisible when the train exits the depot. I am trying with the most simple set to check if that is because of any conflict with any GRF but nothing changes.

Anyone faces/faced same issue?

So far noticed with the BR251, but not with others..maybe my bad luck :)
Can you try the latest nightly build from here? There was an error with that vehicle that indeed broke MUW, but has been fixed in that version.

Re: [OTTD] 2cc TrainsInNML

Posted: 13 Jan 2020 22:20
by kamnet
Since it's been several months since the last nightly, could you promote it up to the current alpha and put it on Bananas?

Re: [OTTD] 2cc TrainsInNML

Posted: 18 Jan 2020 16:34
by Transportman
kamnet wrote: 13 Jan 2020 22:20 Since it's been several months since the last nightly, could you promote it up to the current alpha and put it on Bananas?
I agree, will try to do that this weekend.

It is done.

Tractive Effort formula

Posted: 20 Feb 2020 08:33
by Echon
https://wiki.openttd.org/Tractive_Effort
Has this formula changed, or is it different in some newGRFs?

I am playing with 2cc Trains, and made a spreadsheet to easily see the maximum weight of the various engines, but the trains are not as powerful as the calculations indicate. Wagon capacity varies a lot in this set, and some of the trains are also quite long, so it would be very helpful to have a quick way to estimate the upper limit. Realistic acceleration is enabled.

Re: [OTTD] 2cc TrainsInNML

Posted: 23 Feb 2020 18:21
by Transportman
Cross-post from the release topic:
Transportman wrote: 23 Feb 2020 18:20
Transportman wrote: 18 Jan 2020 19:38 I just released a new version (3.0-RC1) with two small fixes compared to the previous release. It is on BaNaNaS.

Somewhere next month I intend to make it a full release.
3.0 has been released, no changes compared to 3.0-RC1. With that I will stop development of this set, I just don't have the motivation to continue on it.

Bugs in vehicle properties

Posted: 24 Apr 2020 20:16
by werbfred
Hello,

Tried to raise an issue at https://dev.openttdcoop.org/projects/2ccts/issues, but registering fails...

I believe that the files listed below all have issues in their defines.

They use defines DUALHEADED instead of DUAL_HEADED for following files

.\2ccts-7358-source\src\Coaches\Maglev_Wagon_Powered_property.pnml
.\2ccts-7358-source\src\Coaches\Maglev_Wagon_Unpowered_property.pnml
.\2ccts-7358-source\src\Coaches\Metro_Wagon_Powered_property.pnml
.\2ccts-7358-source\src\Coaches\Metro_Wagon_Unpowered_property.pnml
.\2ccts-7358-source\src\Coaches\MU_Wagon_Powered_property.pnml
.\2ccts-7358-source\src\Coaches\MU_Wagon_Unpowered_property.pnml
.\2ccts-7358-source\src\Diesel\Germany_DB_220_V200_property.pnml
.\2ccts-7358-source\src\Diesel\Germany_DB_260_Gravita_10BB_property.pnml
.\2ccts-7358-source\src\Diesel\Germany_DB_310_Kof_II_property.pnml
.\2ccts-7358-source\src\Diesel\Italy_ACT_D200_property.pnml
.\2ccts-7358-source\src\Diesel\USA_GNR_EMD_F3_property.pnml
.\2ccts-7358-source\src\DMU\Germany_DB_601_VT11_TEE_property.pnml
.\2ccts-7358-source\src\DMU\Germany_DB_VT04_Flying_Hamburger_property.pnml
.\2ccts-7358-source\src\DMU\Germany_DB_VT08_property.pnml
.\2ccts-7358-source\src\Electric\Brasil_RFFSA_He_4_4_property.pnml
.\2ccts-7358-source\src\Electric\Germany_DB_103_property.pnml
.\2ccts-7358-source\src\Electric\Germany_DB_Class_E91_property.pnml
.\2ccts-7358-source\src\Electric\Switzerland_SBB_Ce_4_4_property.pnml
.\2ccts-7358-source\src\Metro\Germany_DB_ET171_property.pnml
.\2ccts-7358-source\src\Railbus-diesel\Austria_OBB_VT42_property.pnml
.\2ccts-7358-source\src\Railbus-diesel\Germany_DB_VT133_property.pnml
.\2ccts-7358-source\src\Railbus-diesel\Germany_DB_VT98_property.pnml
.\2ccts-7358-source\src\Railbus-electric\Germany_DB_ET85_property.pnml
.\2ccts-7358-source\src\Railbus-electric\Switzerland_SBB_Cfe_3_3_property.pnml
.\2ccts-7358-source\src\Steam\Germany_DB_9977_property.pnml
.\2ccts-7358-source\src\Steam\Germany_DB_BR18_property.pnml

, and TE_COEFFICENT instead of TE_COEFFICIENT for files below

.\2ccts-7358-source\src\Coaches\Maglev_Wagon_Powered_property.pnml
.\2ccts-7358-source\src\Coaches\Maglev_Wagon_Unpowered_property.pnml
.\2ccts-7358-source\src\Coaches\Metro_Wagon_Powered_property.pnml
.\2ccts-7358-source\src\Coaches\Metro_Wagon_Unpowered_property.pnml
.\2ccts-7358-source\src\Coaches\MU_Wagon_Powered_property.pnml
.\2ccts-7358-source\src\Coaches\MU_Wagon_Unpowered_property.pnml
.\2ccts-7358-source\src\Diesel\Germany_DB_220_V200_property.pnml
.\2ccts-7358-source\src\Diesel\Germany_DB_260_Gravita_10BB_property.pnml
.\2ccts-7358-source\src\Diesel\Germany_DB_310_Kof_II_property.pnml
.\2ccts-7358-source\src\Diesel\Italy_ACT_D200_property.pnml
.\2ccts-7358-source\src\Diesel\USA_GNR_EMD_F3_property.pnml
.\2ccts-7358-source\src\DMU\Germany_DB_601_VT11_TEE_property.pnml
.\2ccts-7358-source\src\DMU\Germany_DB_VT04_Flying_Hamburger_property.pnml
.\2ccts-7358-source\src\DMU\Germany_DB_VT08_property.pnml
.\2ccts-7358-source\src\Electric\Brasil_RFFSA_He_4_4_property.pnml
.\2ccts-7358-source\src\Electric\Germany_DB_103_property.pnml
.\2ccts-7358-source\src\Electric\Germany_DB_Class_E91_property.pnml
.\2ccts-7358-source\src\Electric\Switzerland_SBB_Ce_4_4_property.pnml
.\2ccts-7358-source\src\Metro\Germany_DB_ET171_property.pnml
.\2ccts-7358-source\src\Railbus-diesel\Austria_OBB_VT42_property.pnml
.\2ccts-7358-source\src\Railbus-diesel\Germany_DB_VT133_property.pnml
.\2ccts-7358-source\src\Railbus-diesel\Germany_DB_VT98_property.pnml
.\2ccts-7358-source\src\Railbus-electric\Germany_DB_ET85_property.pnml
.\2ccts-7358-source\src\Railbus-electric\Switzerland_SBB_Cfe_3_3_property.pnml
.\2ccts-7358-source\src\Steam\Germany_DB_9977_property.pnml
.\2ccts-7358-source\src\Steam\Germany_DB_BR18_property.pnml

Files are :

Re: [OTTD] 2cc TrainsInNML

Posted: 30 Apr 2020 20:49
by werbfred
My bad, looks that most of these files are not included in the 2ccts.pnml file

However found a *real* error :

Code: Select all

Coaches/Gen2/Steel_3_axle_Compartment_Coach_property.pnml
Has not the same introduction date and model life than the 2 other Steel_3_axle cochaes.

I believe it should be :

Code: Select all

#define INTRODUCTION_YEAR 1920
#define MODEL_LIFE 60

Re: [OTTD] 2cc TrainsInNML

Posted: 04 May 2020 19:14
by Transportman
werbfred wrote: 30 Apr 2020 20:49 My bad, looks that most of these files are not included in the 2ccts.pnml file
Correct, I should maybe remove those old files. I renamed a bunch of vehicles and deleted the files, but somewhere I accidentally added them back.
However found a *real* error :

Code: Select all

Coaches/Gen2/Steel_3_axle_Compartment_Coach_property.pnml
Has not the same introduction date and model life than the 2 other Steel_3_axle cochaes.

I believe it should be :

Code: Select all

#define INTRODUCTION_YEAR 1920
#define MODEL_LIFE 60
Should indeed be the same, will fix unless I forget.

Re: [OTTD] 2cc TrainsInNML

Posted: 23 Dec 2020 13:05
by Wahazar
I noticed small glitch: second and fourth sprite in template_2cc_L12 should have 30, 26, not 29, 25 - currently it may cut pixels.

Re: [OTTD] 2cc TrainsInNML

Posted: 25 Dec 2020 09:58
by Transportman
McZapkie wrote: 23 Dec 2020 13:05 I noticed small glitch: second and fourth sprite in template_2cc_L12 should have 30, 26, not 29, 25 - currently it may cut pixels.
Thanks for spotting, is it only the 2nd and 4th, or also 6th and 8th?

Re: [OTTD] 2cc TrainsInNML

Posted: 25 Dec 2020 10:47
by Wahazar
Only these two :)

Re: [OTTD] 2cc TrainsInNML

Posted: 25 Dec 2020 12:37
by Transportman
McZapkie wrote: 25 Dec 2020 10:47 Only these two :)
Fixed the code, and requested the account migration so I can upload the fix to BaNaNaS, so I expect that somewhere after Christmas it will be available.

Re: [OTTD] 2cc TrainsInNML

Posted: 25 Dec 2020 18:28
by Wahazar
If about of fixtures, here are CFR-60 diesel sprites which better resembles prototype: https://dev.openttdcoop.org/projects/v4 ... 060_DA.png

Re: [OTTD] 2cc TrainsInNML

Posted: 26 Dec 2020 03:38
by GarryG
Hi, having a minor problem with my train set. Some trains with "retire_early: 5;" don't retire .. any suggestions?

Re: [OTTD] 2cc TrainsInNML

Posted: 26 Dec 2020 23:08
by fridaemon
Hello ;) First, thank you very much for your pefect set. I use it the most of all train graphics.
But now I have problem with few metro trains in your set ...
Last part of train is few pixels above.
Image

Re: [OTTD] 2cc TrainsInNML

Posted: 26 May 2021 11:22
by Wahazar
MU wagons with ECS Tourist are displayed as mail vans.
It is because TOUR cargo is assigned both to the CC_PASSENGERS and CC_EXPRESS class,
so cargo_classes checked for bitmask(CC_PASSENGERS) is not working properly.
I fixed it in V4 CEE by checking if hasbit(cargo_classes,CC_PASSENGERS)) is 1,
and it is working but only because there are two possibilities (passenger or mail van).

Therefore some general question arises (in case of more possible choices):
how to properly construct switch for checking multiple cargo classes (without ugly nested switches)?

Re: [OTTD] 2cc TrainsInNML

Posted: 05 Apr 2023 06:46
by MagicBuzz
Hello,

I'm working on a French Train set that currently lacks of wagons.

I may use the Iron Horse set with the parameter "wagons only" but I don't like much its graphics (too much "cartoon" or something like that for me).
I like the "2CC Trains in NML" wagons, but the existing wagon set based on this one is not up to date.

Right now the GRF checks for at least one region is checked or it disable itself.
Could you please change this behavior, so we can use the set without any engine, to keep only the wagons.

Re: [OTTD] 2cc TrainsInNML

Posted: 09 Apr 2023 21:51
by Transportman
MagicBuzz wrote: 05 Apr 2023 06:46 Hello,

I'm working on a French Train set that currently lacks of wagons.

I may use the Iron Horse set with the parameter "wagons only" but I don't like much its graphics (too much "cartoon" or something like that for me).
I like the "2CC Trains in NML" wagons, but the existing wagon set based on this one is not up to date.

Right now the GRF checks for at least one region is checked or it disable itself.
Could you please change this behavior, so we can use the set without any engine, to keep only the wagons.
Hi, while I can understand your request, I'm not currently developing any NewGRFs due to various reasons*, so I'm sorry but it is not going to be changed in the near future although I do see it as a valid suggestion. You could workaround it by enabling at least one region and then hiding the vehicles you don't want.

It is also not a simple change of just disabling the check, as disabling all regions will also disable the wagons (vehicles that should be available in all regions are coded to require at least one region to be enabled, I should have coded that as just always true...), and there are some wagons that are only available with certain regions enabled (in most cases, all regions have a type of that wagon available, but not all types).

*There are 2 reasons that are linked to each other. I just haven't been playing OpenTTD in quite some time and I'm busy with other hobbies so I'm currently not really motivated to do NewGRF development, and since the DevZone where the builds were done previously is no longer available I would also need to figure out how to create new releases from my own computer (it shouldn't be difficult, but because of reason 1 I'm not really motivated to look into it, and because I don't look into it, I don't know how to release changes which feed back into not getting motivated to make the changes).

Re: [OTTD] 2cc TrainsInNML

Posted: 10 Apr 2023 08:08
by Emperor Jake
Move the code over to GitHub, that's where most NewGRF development happens these days :wink:

Re: [OTTD] 2cc TrainsInNML

Posted: 18 Apr 2023 19:54
by Transportman
Emperor Jake wrote: 10 Apr 2023 08:08 Move the code over to GitHub, that's where most NewGRF development happens these days :wink:
That's the part I already did, it is really the part of getting the code to become a release that I haven't put time in (although I could always hardcode a version number so that I can create a release locally).