[OTTD] 2cc TrainSet - The Trains of the world in 2cc

[MasterMeNL]

The code used in 2ccTS is like (might be different for other engines, but I don't believe it is):

Code: Select all

//Low cost when standing still, for use in the '10' at the RUN cost spot HEAD
-1 * 0  02 00 EC 82 B4 00 FF 01			// 1 case
                          MU_nnn_RCOST_IDLE 80 00 00	        // Standing still cost
                          MU_nnn_RCOST 80	// RUN cost

//Low cost when standing still, for use in the '10' at the RUN cost spot WAGON
-1 * 0  02 00 ED 82 B4 00 FF 01			// 1 case
                          MU_nnn_RCOST_IDLE 80 00 00	        // Standing still cost
                          MU_nnn_RCOST_WAG 80	// RUN cost

Thus it checks variable B4 (current speed) when determining running costs. It's set to MU_nnn_RCOST_IDLE when speed is 0. And MU_nn_RCOST otherwise.

I'm not too familiar with the exact movement code...
might actually be true. It smells a bit like something one might want to investigate in detail in both the code of this set (which vehicle exactly? Every one?) and OpenTTD's movement code... but not before sleep for me

Maybe check for speed < 1km/h (or <= 1km/h) instead of 0.
Sure this will make the train €10 cheaper each year, but if the speed is 0,0001 (or something) because it's waiting at a signal it'll probably work.
Or is this not possible at all?

Regards,

Melvin.

[Eddi]

what i suspect happens is: in front of a red block signal, the train is set back to ~10 of 256 "progress" steps (i knew the exact number once, but i forgot) and speed set to 0, from there, it tries to accelerate again until it hits the end of the tile, at which it encounters the red signal again, and the cycle repeats. during this cycle, the speed might rise a bit, depending on train power.

[planetmaker]

Maybe check for speed < 1km/h (or <= 1km/h) instead of 0.
Sure this will make the train €10 cheaper each year, but if the speed is 0,0001 (or something) because it's waiting at a signal it'll probably work.
Or is this not possible at all?

Yes, something like that is feasible - and probably is the solution which is recommended.

[MasterMeNL]

Maybe check for speed < 1km/h (or <= 1km/h) instead of 0.
Sure this will make the train €10 cheaper each year, but if the speed is 0,0001 (or something) because it's waiting at a signal it'll probably work.
Or is this not possible at all?

Yes, something like that is feasible - and probably is the solution which is recommended.

Can't wait for 2cc 2.0.0 Beta 6 and/or 2cctrainset-nightly-r758! Or is this something so easy that I could fix it myself?
Because the parts you posted containing 2cc code don't look like anything I'm used to and I don't know what it means really.

[Akip Nax Dhagadoe]

What about Indonesian trains?

Like this:



Name: CC203 (Diesel Electric)
Model: GE U20C
Designed: 1995
Max Speed: 120 km/h
Weight: 78 tons
Max Tractive Effort: 156 kN
Power: 2150 HP
ARR Wheel Arrangement: C-C



Name: CC200 (Diesel Electric)
Model: UM 106T
Designed: 1952
Max Speed: 100 km/h
Weight: 96 tons
Max Tractive Effort: 192 kN
Power: 1750 HP
ARR Wheel Arrangement: C-2-C

Maybe just that. Actually there is still many more...

Regards, Akip

[NekoMaster]

I like the looks of the CC203, though if you want either engine in the game you'll probably have to draw them your self, as there seems to be no-one working on 2cc-Set right now. Kinda sucks since there hasn't been any updates or bug fixes in ages now.

[Voyager One]

I am still the "artist of the set", I haven't gone anywhere but Jake seems to have too much work IRL to do a significant update... Just remember that there are hundreds of wagons still waiting to be coded...

[Purno]

Well, all is released under GPL license so anyone could pick it up and continue drawing or coding

[Akip Nax Dhagadoe]

I like the looks of the CC203, though if you want either engine in the game you'll probably have to draw them your self, as there seems to be no-one working on 2cc-Set right now. Kinda sucks since there hasn't been any updates or bug fixes in ages now.

Yeah. But, I don't have any experience in drawing sprites.

Regards, Akip

[Voyager One]

So... we need a coder with more time than Jake (no offense Jake, we all know that college must come first)...

[TinyMusic]

So... we need a coder with more time than Jake (no offense Jake, we all know that college must come first)...

Has there been a rewrite of this NewGRF in NML?

[Transportman]

So... we need a coder with more time than Jake (no offense Jake, we all know that college must come first)...

Has there been a rewrite of this NewGRF in NML?

The repository indicates it still is NFO.

[Voyager One]

Don't ask me, I know nothing of coding...

[kamnet]

Nobody has messed with the coding because DJ left it a complicated mess that nobody else understands. I'd say somebody trying their hand at re-coding it in NML is going to have a rough time duplicating the success, but it's probably the best option for moving this set forward.

[andythenorth]

Doesn't this set just get compiled by feeding it a spreadsheet? As I understood it, that was done by DJ so _anybody_ could update the set, without having to be an nfo coder. What's the problem or problems?

[kamnet]

I'm assuming it was too much to handle, based on Emperor Jake's post a little over a year ago.

Last year, Voyager One and I (mainly Voyager One) drew a lot of wagons intended for the 2CC trainset. However, before they were finished, the 2CC trainset's coder, DJ Nekkid, disappeared without a trace. I attempted to take over the 2CC trainset's code, but I couldn't wrap my head around the convoluted mess of NFO and compile scripts. So instead, I decided to undertake a new project which will be separate from the 2CC set. This is a set which will contain only wagons, mainly in 2CC, and intended for combination with the 2CC trainset or any other trainset with which it happens to match.

[Transportman]

Nobody has messed with the coding because DJ left it a complicated mess that nobody else understands. I'd say somebody trying their hand at re-coding it in NML is going to have a rough time duplicating the success, but it's probably the best option for moving this set forward.

I indeed think recoding would be very rough, but is the best way forward. Based on the code I have seen so far:

The properties of vehicles look easy to recode, most properties can (easily) be copied from the spreadsheet, but I have the feeling that not all trains are in there, so some properties should be grabbed from the source (which is slightly less easy). Most other properties are either trivial to fill in (like track types), and for other properties there is some more liberty to set them differently (like running and purchase costs). This will take quite some time (and some balancing afterwards), but will be relatively easy.

The graphics (and callbacks) are a completely different story however. Graphics are all templated (at least, for what I have seen), so that helps a bit, but recoding them properly will be the largest and most difficult task.

Short version: Recoding will be the best way forward, but very time consuming and hard work.

[andythenorth]

http://www.joelonsoftware.com/articles/ ... 00069.html

[Transportman]

http://www.joelonsoftware.com/articles/ ... 00069.html

But does that really apply to this case? Now we have a code that works but nobody knows why. And because nobody knows why, improving it becomes very difficult. In the article you mention it seems to be that there is a good basis that can be understood and improved on.

Also, on the recoding matter: The Dutch Trainset was recoded to NML by Yexo using a script, and from there improved. I don't know if Yexo still has that script (or that it can be downloaded somewhere), so that might also be an option instead of a complete manual rewrite.

[Voyager One]

So... anyone willing to take over the coding process? Pretty please, I miss this set immensely...