Page 1 of 26

UKRS v3.04 and UKRS industries v2.01 (20th of Jan)

Posted: 02 Oct 2006 20:43
by PikkaBird
Thanks to the articulated wagon bug being fixed in the latest nightly, the UK Renewal Set v3 is now officially released.

For those that don't know, this is a complete, 1920-2040 train replacement set, based on UK prototypes and in company colours. v3 features significant graphic updates to v2, a number of new locomotives and freight cars, and full newcargos support.

You can download it from here.

Also, I've released v2 of the UKRS Industries. There are four new industries and two new cargos. Information is here.

Posted: 02 Oct 2006 20:45
by Lakie
Finally out of the Beta stages then, Pikka.
Thankyou so much for this update to these excellent grfs. :D

[edit] I fixed a spelling error.

~ Lakie

Posted: 02 Oct 2006 21:04
by Dave
Brilliant!

Posted: 02 Oct 2006 22:26
by Redirect Left
Hi Pikka!
Your update to the trains is great, however, when i pushed the red button to turn on your industries, i got a crash, here is the crash log, plus config.

Posted: 02 Oct 2006 22:29
by Patchman
Don't try to turn it on in existing savegames.

Posted: 02 Oct 2006 22:32
by Redirect Left
Patchman wrote:Don't try to turn it on in existing savegames.
Oh, right, i wasnt expecting a problem as the trains worked fine.
Oh well, time to start a fresh game!

Cheers Patchman.

Posted: 02 Oct 2006 22:47
by PikkaBird
For what it's worth, I get a crash too if I turn the industry grf on mid-game, so it is reproducable, patchman. It might be something for Csaba to have a look at?

Posted: 02 Oct 2006 22:51
by Redirect Left
PikkaBird wrote:For what it's worth, I get a crash too if I turn the industry grf on mid-game, so it is reproducable, patchman. It might be something for Csaba to have a look at?
Nice to know its not just me :)

Posted: 03 Oct 2006 00:19
by Patchman
The crash is because of sprite 435, but I don't know enough about industries to understand if the grf is wrong or the patch is doing something bad. It does set prop 22 of industry ID 1, enabling callbacks for an industry that doesn't have an action 3.

Code: Select all

435 * 18       00 0A 05 01 0F 08 01 09 01 17 03 18 02 1A 20 00 00 00

Posted: 03 Oct 2006 06:38
by jonty-comp
Wow! Those industries look GREAT! :D:D
I presume that the engineer yard uses that new feature so you can drive through it? :o
And the quarry on the hillside, awesome. :shock:

Posted: 03 Oct 2006 07:18
by PikkaBird
Patchman wrote:The crash is because of sprite 435, but I don't know enough about industries to understand if the grf is wrong or the patch is doing something bad. It does set prop 22 of industry ID 1, enabling callbacks for an industry that doesn't have an action 3.

Code: Select all

435 * 18       00 0A 05 01 0F 08 01 09 01 17 03 18 02 1A 20 00 00 00
... but that sprite doesn't set properties for industry ID 1, and it doesn't even mention prop 22.

It's also not the first industry in the grf that's being copied, replaced, and activating the callbacks for; practically identical psuedosprites for several other industries appear earlier in the grf..

Posted: 03 Oct 2006 08:32
by Raichase
Yay for Pikka! Been enjoying this for a while, good to see it's a "proper" release now :D.

Fantastic work, as always.

Posted: 03 Oct 2006 16:27
by Patchman
PikkaBird wrote:... but that sprite doesn't set properties for industry ID 1, and it doesn't even mention prop 22.
It copies the data from ID 1, maybe there's a bug that also copies some (random?) data to ID 1. So I guess it'll be up to Csaba to look into this.

Posted: 03 Oct 2006 16:30
by Csaboka
PikkaBird wrote:It might be something for Csaba to have a look at?
I'm sorry, but until I find some way to get the latest sources of the Patch, I can't debug anything. I'm busy with some homework anyway, so I couldn't look at it for some days even if I could download the sources.

Pikka: The new industries look very cool BTW. :)

[Edit] Oh, I forgot that we have nightly builds, and each has the source code snapshot included... I'll try to debug this when I'm finished with the more important work.

Posted: 03 Oct 2006 16:54
by Patchman
Csaboka wrote:Oh, I forgot that we have nightly builds, and each has the source code snapshot included... I'll try to debug this when I'm finished with the more important work.
I'm not sure if this bug isn't also in the 2.5 sources though.

Feel free to just email me a diff if you can't commit directly. I guess looking at the fix I can see if it should go in 2.5 or 2.6 then.

Posted: 03 Oct 2006 22:07
by jebartle
can not dl v3!

I get "page not found"


JEB

Posted: 03 Oct 2006 22:34
by PikkaBird
jebartle wrote:can not dl v3!

I get "page not found"
If you're seeing download links for both v2 and v3, refresh the page.

Posted: 05 Oct 2006 07:32
by Wile E. Coyote
Pikka, please tell labels for new cargos.

Posted: 05 Oct 2006 07:35
by michael blunck

Posted: 05 Oct 2006 07:47
by Wile E. Coyote
Thanx, Michael! :D I somehow couldn't find that page in Wiki. :?