Transport Tycoon Forums

The place to talk about Transport Tycoon
It is currently Fri Nov 24, 2017 2:44 pm

All times are UTC




Post new topic  Reply to topic  [ 16 posts ] 
Author Message
PostPosted: Tue Jul 30, 2013 2:15 pm 
Offline
Moderator
Moderator
User avatar

Joined: Sat Apr 02, 2005 7:01 am
Posts: 3671
Location: Sydney NSW Antipodea
The tool tip for the NewObjects button on the main tool bar says "Save music settings to disk".

_________________
Formerly known as r0b0t_b0y2003, robotboy, roboboy and beclawat. The best place to get the most recent nightly builds of TTDPatch is: http://roboboy.users.tt-forums.net/TTDPatch/nightlies/


Top
   
PostPosted: Tue Jul 30, 2013 3:26 pm 
Offline
TTDPatch Developer
TTDPatch Developer
User avatar

Joined: Wed May 26, 2004 4:37 pm
Posts: 1802
Location: Britain
That would appear to be the textid (0x1F9) stored for the tool-tip for that button, yes.
I imagine it'd require adding a new string (e.g. "\98Build NewGRF Object") which is then stored as the tool-tip.
It shouldn't be too hard to change, but I don't have any capacity to compile or test TTDPatch currently to check for quirks (or bugs).

~ Lakie

_________________
TTDpatch Developer 2005 - 2010 ~ It all started because of shortened vehicle not loading correctly, now look where I've gone with it!
Grfs coded ~ Finnish Train Set (Teaser) | Bm73 (Release 3) | Emu 680 (Release 3)| Glass Station (Release 1) | UK Roadset (Version 1.1a) | New Water Coasts (Version 7)
Pikka: "Lakie's a good coder, but before he'll add any feature to TTDP you have to convince him that you're not going to use it to destroy the world as we know it."


Top
   
PostPosted: Tue Jul 30, 2013 4:44 pm 
Offline
Administrator
Administrator
User avatar

Joined: Fri Jan 26, 2001 8:18 pm
Posts: 23810
Skype: orudge
Location: Banchory, UK
These sorts of things should probably go into the bug tracker, if not there already. Whether there are any developers who could fix them is another matter!

_________________
Owen Rudge
owenrudge.net | Owen's Transport Tycoon Station | Owen's Locomotion Depot | The Transport Tycoon Wiki


Top
   
PostPosted: Tue Jul 30, 2013 5:43 pm 
Offline
TTDPatch Developer
TTDPatch Developer
User avatar

Joined: Wed May 26, 2004 4:37 pm
Posts: 1802
Location: Britain
Most likely, however I imagine not may people look at the bug tracker these days, (me included).
I'm unable to compile TTDPatch at present (due to changes with Cygwin), but I believe these changes should work.
(Hopefully someone can test these changes).

~ Lakie


Attachments:
Tool-tip.patch [1.48 KiB]
Downloaded 146 times

_________________
TTDpatch Developer 2005 - 2010 ~ It all started because of shortened vehicle not loading correctly, now look where I've gone with it!
Grfs coded ~ Finnish Train Set (Teaser) | Bm73 (Release 3) | Emu 680 (Release 3)| Glass Station (Release 1) | UK Roadset (Version 1.1a) | New Water Coasts (Version 7)
Pikka: "Lakie's a good coder, but before he'll add any feature to TTDP you have to convince him that you're not going to use it to destroy the world as we know it."
Top
   
PostPosted: Wed Jul 31, 2013 2:41 am 
Offline
Moderator
Moderator
User avatar

Joined: Sat Apr 02, 2005 7:01 am
Posts: 3671
Location: Sydney NSW Antipodea
I submitted it to the bug tracker as well.
http://projects.tt-forums.net/issues/199

_________________
Formerly known as r0b0t_b0y2003, robotboy, roboboy and beclawat. The best place to get the most recent nightly builds of TTDPatch is: http://roboboy.users.tt-forums.net/TTDPatch/nightlies/


Top
   
PostPosted: Wed Jul 31, 2013 10:58 pm 
Offline
TTDPatch Developer
TTDPatch Developer
User avatar

Joined: Wed May 26, 2004 4:37 pm
Posts: 1802
Location: Britain
Finally managed to get it compiled under a Ubuntu VM, seems to work as expected although "\98Build objects" may be a better caption. Any thoughts?

~ Lakie

_________________
TTDpatch Developer 2005 - 2010 ~ It all started because of shortened vehicle not loading correctly, now look where I've gone with it!
Grfs coded ~ Finnish Train Set (Teaser) | Bm73 (Release 3) | Emu 680 (Release 3)| Glass Station (Release 1) | UK Roadset (Version 1.1a) | New Water Coasts (Version 7)
Pikka: "Lakie's a good coder, but before he'll add any feature to TTDP you have to convince him that you're not going to use it to destroy the world as we know it."


Top
   
PostPosted: Thu Aug 01, 2013 6:26 am 
Offline
Moderator
Moderator
User avatar

Joined: Sat Apr 02, 2005 7:01 am
Posts: 3671
Location: Sydney NSW Antipodea
OpenTTD uses "Place Object. ..." it also includes text about shift displaying the estimate but none of TTD's do that, so I would go for either "Build object" or "Place object".

_________________
Formerly known as r0b0t_b0y2003, robotboy, roboboy and beclawat. The best place to get the most recent nightly builds of TTDPatch is: http://roboboy.users.tt-forums.net/TTDPatch/nightlies/


Top
   
PostPosted: Thu Aug 01, 2013 12:12 pm 
Offline
TTDPatch Developer
TTDPatch Developer
User avatar

Joined: Wed May 26, 2004 4:37 pm
Posts: 1802
Location: Britain
"Place object" sounds better, bit misleading in there's a cost attached...
I believe the majority of the object gui lacks tool-tips, so it might be worth me looking into including those also.
(Mainly the title, class and object selections and the object variant selection*).

* - Only for objects with 2-4 views, no point when just single view.

~ Lakie

_________________
TTDpatch Developer 2005 - 2010 ~ It all started because of shortened vehicle not loading correctly, now look where I've gone with it!
Grfs coded ~ Finnish Train Set (Teaser) | Bm73 (Release 3) | Emu 680 (Release 3)| Glass Station (Release 1) | UK Roadset (Version 1.1a) | New Water Coasts (Version 7)
Pikka: "Lakie's a good coder, but before he'll add any feature to TTDP you have to convince him that you're not going to use it to destroy the world as we know it."


Top
   
PostPosted: Thu Aug 01, 2013 1:23 pm 
Offline
Moderator
Moderator
User avatar

Joined: Sat Apr 02, 2005 7:01 am
Posts: 3671
Location: Sydney NSW Antipodea
The rest of the TTD tooltips use build though.

_________________
Formerly known as r0b0t_b0y2003, robotboy, roboboy and beclawat. The best place to get the most recent nightly builds of TTDPatch is: http://roboboy.users.tt-forums.net/TTDPatch/nightlies/


Top
   
PostPosted: Fri Aug 02, 2013 9:08 am 
Offline
Moderator
Moderator
User avatar

Joined: Sat Apr 02, 2005 7:01 am
Posts: 3671
Location: Sydney NSW Antipodea
Some suggestions for the view selection, "Select object direction" or "Select object view. I would say for consistency with the train station window, the class drop down shouldn't have a tooltip same with the object drop down.

Edit: Can I have a couple of days to see if I can work out how to set the tooltip for the views?
Edit again: I can not find any new or modified windows except the Dock/water toolbar that have had their tooltips fixed or added. Eg the Tram toolbar still says road, truck or bus where they are correct for Roads. So I think, scratch my previous comment about giving me a few days to see if I can work out how to add the tooltips to the Objects Window. I will try and learn from what you change in objects.asm and try to fix the Tram toolbar myself.

_________________
Formerly known as r0b0t_b0y2003, robotboy, roboboy and beclawat. The best place to get the most recent nightly builds of TTDPatch is: http://roboboy.users.tt-forums.net/TTDPatch/nightlies/


Top
   
PostPosted: Fri Aug 02, 2013 3:50 pm 
Offline
TTDPatch Developer
TTDPatch Developer
User avatar

Joined: Wed May 26, 2004 4:37 pm
Posts: 1802
Location: Britain
The Object gui is in objects.asm, I imagine it'll be in the window definition most likely.
I was thinking of making the view 'buttons' similarly tool-tipped to the other directional selction windows, likely using 'variant' instead of view or direction.

~ Lakie

_________________
TTDpatch Developer 2005 - 2010 ~ It all started because of shortened vehicle not loading correctly, now look where I've gone with it!
Grfs coded ~ Finnish Train Set (Teaser) | Bm73 (Release 3) | Emu 680 (Release 3)| Glass Station (Release 1) | UK Roadset (Version 1.1a) | New Water Coasts (Version 7)
Pikka: "Lakie's a good coder, but before he'll add any feature to TTDP you have to convince him that you're not going to use it to destroy the world as we know it."


Top
   
PostPosted: Fri Aug 02, 2013 4:03 pm 
Offline
Moderator
Moderator
User avatar

Joined: Sat Apr 02, 2005 7:01 am
Posts: 3671
Location: Sydney NSW Antipodea
I also noticed that right clicking the view buttons activates them as though they had been right clicked. I suspect that issue might go away once we have tool tips for them.

_________________
Formerly known as r0b0t_b0y2003, robotboy, roboboy and beclawat. The best place to get the most recent nightly builds of TTDPatch is: http://roboboy.users.tt-forums.net/TTDPatch/nightlies/


Top
   
PostPosted: Fri Aug 02, 2013 5:19 pm 
Offline
TTDPatch Developer
TTDPatch Developer
User avatar

Joined: Wed May 26, 2004 4:37 pm
Posts: 1802
Location: Britain
That's quite possible, ideally the tool-tips are handled with-in the click handler. Sounds like it needs coded added for handling right click events for generating the tool-tips.
I'll look into it some-time, shouldn't be overly difficult to add (hopefully).

~ Lakie

_________________
TTDpatch Developer 2005 - 2010 ~ It all started because of shortened vehicle not loading correctly, now look where I've gone with it!
Grfs coded ~ Finnish Train Set (Teaser) | Bm73 (Release 3) | Emu 680 (Release 3)| Glass Station (Release 1) | UK Roadset (Version 1.1a) | New Water Coasts (Version 7)
Pikka: "Lakie's a good coder, but before he'll add any feature to TTDP you have to convince him that you're not going to use it to destroy the world as we know it."


Top
   
PostPosted: Sat Aug 03, 2013 3:20 am 
Offline
Moderator
Moderator
User avatar

Joined: Sat Apr 02, 2005 7:01 am
Posts: 3671
Location: Sydney NSW Antipodea
I presume I need to set up a guiwindow block of type cWinTypeToolTip as there is now cWinElemToolTip? Or am I completely seeing how the GUI system works wrong?

An example of what I was thinking:
Code:
guiwindow cWinTypeToolTip,230,195
   guicaption cColorSchemeCream, ourtext(objectgui_title)
endguiwindow


I was trying to work it out using the code that sets up the objects window and reading inc/window.inc. I couldn't find definitions for guiwindow, guicaption and guiele to determine exactly what the parameters do. I was then going to attempt to display the window in the click handler.

_________________
Formerly known as r0b0t_b0y2003, robotboy, roboboy and beclawat. The best place to get the most recent nightly builds of TTDPatch is: http://roboboy.users.tt-forums.net/TTDPatch/nightlies/


Top
   
PostPosted: Sat Aug 03, 2013 3:19 pm 
Offline
TTDPatch Developer
TTDPatch Developer
User avatar

Joined: Wed May 26, 2004 4:37 pm
Posts: 1802
Location: Britain
I don't think that's quite how it should be done, whilst TTDPatch lacks solid examples of how to do tool-tips, TTD checked for a right mouse click in the click event handler, branching to code which generates the tool-tip.
Given the majority of the TTDPatch GUI's do not currently use tool-tips, I may have to look at how TTD actually generates them...

~ Lakie

_________________
TTDpatch Developer 2005 - 2010 ~ It all started because of shortened vehicle not loading correctly, now look where I've gone with it!
Grfs coded ~ Finnish Train Set (Teaser) | Bm73 (Release 3) | Emu 680 (Release 3)| Glass Station (Release 1) | UK Roadset (Version 1.1a) | New Water Coasts (Version 7)
Pikka: "Lakie's a good coder, but before he'll add any feature to TTDP you have to convince him that you're not going to use it to destroy the world as we know it."


Top
   
PostPosted: Sat Aug 03, 2013 3:23 pm 
Offline
Moderator
Moderator
User avatar

Joined: Sat Apr 02, 2005 7:01 am
Posts: 3671
Location: Sydney NSW Antipodea
ok. I think we can put these tooltips (excluding the main toolbar one) as features that can wait till you have time.

_________________
Formerly known as r0b0t_b0y2003, robotboy, roboboy and beclawat. The best place to get the most recent nightly builds of TTDPatch is: http://roboboy.users.tt-forums.net/TTDPatch/nightlies/


Top
   
Display posts from previous:  Sort by  
Post new topic  Reply to topic  [ 16 posts ] 

All times are UTC


Who is online

Users browsing this forum: No registered users and 4 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB © 2000-2017 phpBB Limited

Copyright © Owen Rudge/The Transport Tycoon Forums 2001-2017.
Hosted by Zernebok Hosting.