My ships do not carry or refit properly

[copperpen]

I had not used shipping for a long time so did not realise there is a problem. Using the nightly 1926, 1928 or 1929 I am not able to carry pasengers, mail or tourists, nor can I refit to carry them. This applies whether using standard ship graphics or newshipsw.grf. If I put in 2.5-beta-9 I have the passenger and mail capacity back and in the correct vessels.

I tested using the up-to-date base grf and only newships active in the nightly. I used an old base grf for the beta 9 check.

Mervyn

[michael blunck]

Ah yes. Interesting.

However, I don´t have time to test newships.grf, instead I tested the NewShipsXL set and r1926 gives me a sprite error in sprite #497 (code 6/30) (which is the Harland reefer, BTW).

@developers:

Code: Select all

  497 * 34	 00 02 0C 01 05
                        00 7B 44
                        06 06
                        08 FF
                        09 01
                        0A B4
                        0B 55
                        0C 0C
                        0D 18 01
                        0F BE
                        10 04
                        11 00 70 00 00  // FOOD,FRUT,FISH
                        15 68

There´s no error flagged in older versions, namely not in r1815.

regards
Michael

[copperpen]

I do not have the newshipsXL set, but have continued testing with newships. The change in coding that has caused this problem happened with build 1897. The previous one, 1895, allows the correct refit and correct original traffic type for each vessel. I suspect that this is also the cause of some rail and road units to display incorrect traffic types. For example, road tanker will carry tourists as a refit option.

Mervyn

[michael blunck]

The change in coding that has caused this problem happened with build 1897.

Thanks for the investigation. Indeed, in r1896 Oskar did start some action0 modifications, which seems to be the reason for the bugs. I´ve already alerted him about that.

[edit]
Just seen that Oskar did fix that in r1931.
[/edit]

regards
Michael

[copperpen]

Working properly with 1931 installed.

Mervyn

[Nagyzee]

Ah, it's great that I've found this topic. Had the exact same problem. The first available ferry type was transporting coal by default and was refitable only to other freight cargo but not passengers or mail.