Articulated Road Vehicles

[DaleStan]

If you don't get the correct capacity, try adding a CB 15 check in the depot-sprite chain; something like

Code: Select all

*0 02 01 7F 81 0C 00 FF 01 <cbresult> 15 15 <gfxID>
*0 03 01 01 <ID> 01 FF 7F 00 <gfxID>

I don't know if that will work, but it seems like 15 must be called in the purchase window too.

And which sprite is not supported? Cargo type FF has been supported for all vehicles for as long as I've been coding.

[Uwe]

Thank you both for the information, I'll try CB 15. I use cargo type FF and that works, I get a special sprite in the purchase window, I just do not get the correct capacity shown for my aRV. Sorry for the confusion.

[Lakie]

And which sprite is not supported? Cargo type FF has been supported for all vehicles for as long as I've been coding.

I know the special cargo FF sprite has been around for a long time, I was referring to the fact it is possible to use a callback to expand the area for it, as MB showed with some of his development work, basically the text was 'offset' from where it would normally be, but I could be wrong...

~ Lakie

[DaleStan]

That's a simple case of using string codes \20 and\or \01 appropriately. Possibly \1F too, but that's less likely.

[Uwe]

OK, I tried CB 15, but it did not work. I only get the cargo capacity for the first vehicle part shown in the purchase window. Thanks for the help anyway, it was worth a try.

Concerning the crash I get whenever selling an articulated vehicle, I made a ollydbg screenshot of the crash, hopefully some patch dev can use the information. The crash happens directly when I move the vehicle onto the trash bin in the depot. I currently use nightly r1793.

[JGR]

I'm going to assume that you meant r1693 and not a revision from the future...

I will have a look at the crash info.

JGR

[Uwe]

Err, yes, typo, it should have been 1719, but the crash also occured in earlier versions.

[JGR]

Are you using the German version of TTD?
If so you could try again with the American version, and if it still crashes repost the same info as before.

(This also makes it much easier to find the code from the IDA listings).

Thanks

JGR

[Uwe]

I use the German version, yes. Just tried the American one and it crashes as well, ollydbg screenshot is attached.

[JGR]

The function in which the code dies is DeleteVehicleSchedule (_CS:00138460,5614A7).
The schedule pointer field of the vehicle in question is obviously invalid/undefined at -1.

I would imagine that the trailer vehicles would not have a schedule pointer...
Hence the delete vehicle schedule pointer function should not be called for those...

As more info arises I will edit this post...

JGR

[Carlo Ghega]

Hello!

Still got the same problem as Uwe, dare to ask if you think that there might be a chance to get this fixed some day soon?

No offence meant,
best regards,

Carlo

[wallyweb]

This question has popped up elsewhere without a response that I could find with the forum search function, so I thought as this seems to be the general articulated RV thread, I'd repeat the question here on behalf of myself and the others who have asked it. Perhaps this way it will be addressed.

The issue is with refitting articulated RV's ... the trailer does not get the refit.
For buses and trams where the refit would be merely passenger/tourist this is probably not so critical as two sets of IDs could be used ... one for passengers and one for tourists ... and the whole refit issue bypassed.
Where this becomes a real issue is with articulated trucks. To begin, there are several configurations for trucks: box, hopper, flatbed, etc. .Next, each configuration can have several cargoes available as refits. This makes multiple ID's highly impractical. A refit function would seem to be the only practical approach.

This all begs several questions:

How important is it to players to have refitable articulated RVs?
Is anybody aware that refitting the trailers of articulated RVs is an issue?
If yes, is anybody addressing this issue?

Articulated RVs work. Articulated trucks work. It would be a shame to have to pass on using them because they don't support trailer refits.

[athanasios]

And I am dreaming of the day George's LVs get articulated. Hope it will not remain a dream.

[Redirect Left]

And I am dreaming of the day George's LVs get articulated. Hope it will not remain a dream.

Same here

[wallyweb]

With reference to a discussion in the Generic Road Vehicle Set thread, the trailer refit problem also existed in OTTD and apparently was resolved. Perhaps their solution could work in the patch too. Is this possible?

[Lakie]

Quite possibly, however upon asking the devs responsible for that patch for 'guidance' on implement it, I got no reply as of yet.
Also my understanding of C / C++ is very limited, so I won't be able to look at the code and follow the method...

~ Lakie

[wallyweb]

Thanks Lakie.
Perhaps a Patch dev who is familiar with C/C++ could lend you a hand. Unfortunately the last time I did any work with C, C++ hadn't been developed yet.

[DaleStan]

I think most of Open is still C compiled with a C++ compiler. I know there's some C++ (YAPF in particular), but I suspect the majority is still C. BICBW.

That aside, it seems like, once you find the hooks to patch the refit button, it should be a relatively simple matter to just cycle through the entire consist, possibly simply calling [esp] for each vehicle.

[wallyweb]

I thought I'd post a png to better describe the issue. (see below)
Then I saw DaleStan's comment mentioning cycling.
Then I had an inspiration ... Maybe this could be developed into a feature. If there was someway to optionally* cycle through the consist, refitting each part independently so as to achieve a mixed consist.

optionally* - For the quick and dirty crowd, the "refit all at once" method should be retained as default.

[DaleStan]

That aside, it seems like, once you find the hooks to patch the refit button, it should be a relatively simple matter to just cycle through the entire consist, possibly simply calling [esp] for each vehicle.

Looking at the diff, that's almost exactly what Open does, except for the call [esp] part. Starting with the engine, it tests:
Can the vehicle be refitted to this cargo?
Does the vehicle have capacity?
If yes twice, determine the capacity, from the callback if available or from the old capacity.
If yes twice, and DC_EXEC [ebx bit 0 set, IIRC.] change the vehicle slot appropriately.
Proceed to the next vehicle. (cvivpjv esi, [esi+veh.nextunitid], <Can the vehicle be refitted to this cargo?>)