Newcargos profit problem with the nightlies redux

[PikkaBird]

I haven't had one of these in a while.

Edit: Actually, I can reproduce it. Build a train that carries a new cargo. Let it make a trip or two. Save and reload the game. This bug is currently making any game using newcargos unplayable.

[PikkaBird]

Bump.

Also, I don't get this if I have noinflation turned on.

[PikkaBird]

Config attached. I've been using my grf posted here.

[Csaboka]

Another 2.5 bug, entirely my fault again. Should be fixed in the next nightly.

(Note to self: don't try to write clever code, it can backfire too easily. Just play it safe.)

[PikkaBird]

And there was much rejoicing.

[Greno Zee]

(Note to self: don't try to write clever code, it can backfire too easily. Just play it safe.)

Being a developer myself, I've gotta tell you: this is good for a boss. If you are master of your time (meaning you decide what to dare for and what not), go for the clever code, it's so much more fun.

Great work overall, devs!

[Csaboka]

You're right, clever code is usually funnier to write, but in this particular case, it cost me a lot of time. The original price factor code was clever, that is, it calculated in some obscure way to save some instructions. It turned out to be incorrect (see link in the first post), and I thought I had fixed it by tweaking my clever code a bit. Now it turned out that the tweak didn't fix the problem either, and I decided to rewrite the thing in a non-obscure way. So clever code made me debug my code twice, I could have avoided that by writing it the safe way.

Clever code is OK if you're 100% sure of what you're doing (which I wasn't), and you don't expect others to modify your code. Otherwise, it's better to be boring and correct