Buses and trucks are going to tram depot

Wile E. Coyote · Post by **Wile E. Coyote** » 09 Aug 2006 10:16

With Patch 2.5.7 (and previous) when I want to replace bus or truck and send them to depot, they also go to tram depot and stop there. Of course, I can't purchase new bus or truck there.
I'll add configs if they are needed.

stevenh · Post by **stevenh** » 30 Aug 2006 00:30

Wile, I promise I'm still alive.... though a little off-the-radar.
This bug has been repaired in the next nightly (version >= 881) . [ie. the vehicles will no longer attempt to search for the wrong depot type, they'll only aim for the proper depots!]
Unfortunately, I haven't stopped the vehicles from driving into the wrong depots, they'll still drive into them if they have no orders and the tracks/roads are connected.
Actually, they wouldn't have been able to get into the wrong depots if there was no 'wrong' track/road built up against them. See the picture....

Redirect Left · Post by **Redirect Left** » 30 Aug 2006 00:45

Hmm, will make sure to do what you do in the diagram

Post by **PikkaBird** » 30 Aug 2006 02:18

Are you actually using the tram depot graphics supplied in the tramtrack grf, steven? If so, I should probably make the tram depot look different if it can't be used for road vehicles, to minimise confusion.

stevenh · Post by **stevenh** » 30 Aug 2006 03:18

PikkaBird wrote:Are you actually using the tram depot graphics supplied in the tramtrack grf, steven? If so, I should probably make the tram depot look different if it can't be used for road vehicles, to minimise confusion.

Yes, I am using the depot in the GRF.
I was going to get back to you on this... I had plans... oh I had plans... of double-decker depots and the like... back in the day... but a change in ground tile was sufficient.
An update to the tram depot would be sweet.

Wile E. Coyote · Post by **Wile E. Coyote** » 30 Aug 2006 07:33

Thanx Steven, obviously with all of you devs nothing is impossible!

And Pikka, that would be great

Do you allready have some depot in plan to draw? If not, may I suggest you building?

michael blunck · Post by **michael blunck** » 30 Aug 2006 08:44

>> I should probably make the tram depot look different [...]

> Do you allready have some depot in plan to draw? If not, may I suggest you building?

Because that tram depot would be in the "official" version of ttdpbase.grf, it should be nothing "special", i.e. different building style, alien colours, etc. pp., but stay in the well-known TTD-style (which is still the baseline of the game) as close as possible (probably change a small number of pxs only).

Completely new-styled tram depots should go in the diverse tram sets, IMO.

regards
Michael

Post by **WWTBAM** » 30 Aug 2006 09:48

i think weve switched the rv depot gfx to the tto ones so maybe its just make the tram ones the old TTD ones.

Wile E. Coyote · Post by **Wile E. Coyote** » 30 Aug 2006 09:56

michael blunck wrote:Completely new-styled tram depots should go in the diverse tram sets, IMO.

Yes, now I see you are absolutely right.

Post by **PikkaBird** » 31 Aug 2006 09:44

I'll get on it, I'll make something basic and TTD style.

It might be a few days as I don't have internet access at home right now.

Post by **PikkaBird** » 01 Sep 2006 07:22

Okay, try this one, if it will upload on this dialup. I added an electric substation to the roof of the tram depot.

(attachments removed as they may be out of date and I don't want people finding them - download ttdpbase(w).grf from the patch site)

Rob · Post by **Rob** » 01 Sep 2006 17:56

It gives me the following error :

[TTDPatch 2.6 alpha O r892]

Website · Post by **Lakie** » 01 Sep 2006 18:38

Yes, because I altered ttdpbase[w].grf to have the clonetrain cursor.
Please download the new version of ttdpbase[w].grf (from the patch website), and sorry for the inconviance.

[edit] Or atleast thats the last commit which actually alter the ttdpbase[w].grf version data.

~ Lakie

JGR · Post by **JGR** » 04 Sep 2006 17:52

Both trams and road vehicles only use tram depots in the latest nightly (and one or two earlier).

I couldn't understand why my buses refused to go to depots and hadn't been serviced for up to ten years

, causing 0% reliability, etc...

This was temporarily solved by building tram depots, which they were quite happy to go to.
Trams behaved correctly.

The reason is that the variable tramVehPtr, is never -1 as tested by line 2060 of the procedure checkIfDepotIsTramDepot as it is unconditionally set in procedures newSendVehicleToDepot and newSendVehicleToDepotAuto prior to indirectly calling the depot checking code, to the current vehicle pointer.
I would suggest that some code to check whether the vehicle which is supposed to be a tram really is, be inserted after the first check.
Such that the procedure becomes something like:

Code: Select all

checkIfDepotIsTramDepot:
	cmp	dword [tramVehPtr], 0FFFFFFFFh
	je	.isRoadVehicle
	[u]push	esi
	mov	esi, [tramVehPtr]
	movzx	esi, byte [esi+veh.vehtype]
	test	byte [vehmiscflags+esi], VEHMISCFLAG_RVISTRAM
	pop	esi
	jz	.isRoadVehicle[/u]
	push	ebx
	add	ebx, edi
	cmp	byte [landscape3 + ebx * 2], 1
	pop	ebx
	je	.normalDepotCheck
	mov	al, 0
	retn
.isRoadVehicle:
...

which works as expected.

Inserted tram checking code copied from somewhere else in the trams.asm file.

Keep up the good work Steven and the other patch devs, your work is certainly appreciated.[/u]

DaleStan · Post by **DaleStan** » 04 Sep 2006 23:17

Looks good to me too.

I think this is "only" your second bugfix, but then again, two bugfixes in twenty-two posts is somewhat above average.

stevenh · Post by **stevenh** » 05 Sep 2006 00:55

Ass.. I trusted my old variables... how bad on my behalf.
Forgive me and thankyou for the fix JGR.

note: code inserted into nightly as of r903

Wile E. Coyote · Post by **Wile E. Coyote** » 06 Sep 2006 07:25

I use grf with Patch 2.5.8 and all is working OK.

Transport Tycoon Forums

Buses and trucks are going to tram depot

Buses and trucks are going to tram depot

Both trams and road vehicles only use tram depots

Who is online