MiniIN patches and TODO list

Got an idea for OpenTTD? Post it here!

Moderator: OpenTTD Developers

richk67
Tycoon
Tycoon
Posts: 2363
Joined: 05 Jun 2003 16:21
Location: Up North
Contact:

MiniIN patches and TODO list

Post by richk67 »

Hi All.

I thought it would be a good idea to separate out the patches and "things to be done" in MiniIN from the main discussion thread. I have already lost track of some patches earlier, just because by the time I did the next update, the patch was 5 pages back.

This thread is the home for all new versions of existing patches, copies or links to patches (by authors please) for new features you would like to see, and other assorted items that *need* to be done.

PLEASE DO NOT HAVE IDLE CHAT IN THIS THREAD. IT IS PRINCIPALLY FOR THE PATCH DEVELOPERS

To keep it sane, I need to have a neater clear list. At the moment (mid July), MiniIN has about 30 patches, and it is already getting to the point it is beyond simple organisation.

So please help and use this thread for patches, and new features.

For bugfixes: Please provide a one/two line summary of what the bug and fix do for the commit log.

When I have committed your patch to MiniIN, can you update your post to say "Edit DONE: committed at r????" so I can see at a glance that I have done the work.

IF YOU HAVE A BUG TO REPORT.... PLEASE USE THE MiniIN Problem Thread (sticky) in the OTTD Problems Forum.
Last edited by richk67 on 22 Jul 2006 12:44, edited 5 times in total.
OTTD NewGRF_ports. Add an airport design via newgrf.Superceded by Yexo's NewGrf Airports 2
Want to organise your trains? Try Routemarkers.
--- ==== --- === --- === ---
Firework Photography
User avatar
mart3p
Tycoon
Tycoon
Posts: 1030
Joined: 31 Oct 2005 21:00
Location: UK

Post by mart3p »

Well, let me be the first to contribute to your new thread. :D

Here is the Drive-Through Road Stops patch for the MiniIN and roadstops.grf for the new graphics. The file roadstops.grf needs to be in the data folder, it does not require a config. file entry.

Note to those who download roadstops.grf: This is NOT a NewGRF file. If you use it without the drive-through road stops patch IT WILL NOT WORK.

Edit: DONE - committed at r5560 + r5567
Attachments
roadstops.grf
please read note above
(2.35 KiB) Downloaded 512 times
Drive_Thru_MiniIN_r5543.patch
(29.4 KiB) Downloaded 402 times
Last edited by mart3p on 22 Jul 2006 12:24, edited 1 time in total.
Image
User avatar
mart3p
Tycoon
Tycoon
Posts: 1030
Joined: 31 Oct 2005 21:00
Location: UK

Post by mart3p »

Richk, are you aware that you didn't commit roadstops.grf at r 5562 (just in case you forgot ;) )

Here's a bugfix for a problem reported a while ago, refittable road vehicles not being refitted to the correct cargo when cloned. Essential for Long Vehicles GRFs. :)

Edit: Just seen your PM, I will look into it straight away.


Edit: DONE - committed at r5574
Attachments
RV_Clone_Bugfix_MiniIN_r5562.patch
(1.42 KiB) Downloaded 356 times
Last edited by mart3p on 22 Jul 2006 12:25, edited 1 time in total.
Image
User avatar
mart3p
Tycoon
Tycoon
Posts: 1030
Joined: 31 Oct 2005 21:00
Location: UK

Post by mart3p »

Sorry about the compile warnings. :oops: MSVC2005 didn’t complain, but I suppose that’s not a surprise. Anyway, this patch should fix it.

Edit: DONE - committed at r5573
Attachments
Drive_Thru_Fix_MiniIN_r5562.patch
(808 Bytes) Downloaded 367 times
Last edited by mart3p on 22 Jul 2006 12:26, edited 1 time in total.
Image
gigajum
Route Supervisor
Route Supervisor
Posts: 511
Joined: 08 Mar 2006 08:33
Location: Germany

Post by gigajum »

Cause Richk overread it in the miniIN thread (imo) :)

Edit: DONE - committed at r5576
Attachments
additional_orders_unload_fix.diff
(808 Bytes) Downloaded 324 times
Last edited by gigajum on 26 Jul 2006 04:35, edited 2 times in total.
Frostregen
Transport Coordinator
Transport Coordinator
Posts: 340
Joined: 06 Feb 2006 23:58

Post by Frostregen »

Here's the update for the Copy&Paste Patch again.
Also a small update to patch cleanly again.
-> Now applies to MiniIN rev 5579.

Changes:
DONE-> Bugfix: Convert Depots/Tunnels/Bridges too
DONE-> Fix: Bridge end out of selection at "copy time"
DONE-> Fix: Tunnel end out of selection at "copy time"
DONE-> Feature: estimate Costs more exact(at all ;))
DONE-> Feature: Choose to _copy_: Own stuff
DONE-> Feature: Choose to _copy_: Road
DONE-> Feature: Choose to _copy_: Rail

The new copypaste.grf is linked, as it won't be included within the .patch file.
copypaste.grf v5

Edit: DONE - committed at r5587
Attachments
copy_paste_rev5579_MiniIN_update.patch
copy&paste patch for MiniIN rev5579
(25.51 KiB) Downloaded 372 times
Last edited by Frostregen on 24 Jul 2006 08:11, edited 1 time in total.
gigajum
Route Supervisor
Route Supervisor
Posts: 511
Joined: 08 Mar 2006 08:33
Location: Germany

Post by gigajum »

i fixed the fix for the advanced autoreplace, which failed with an assert failure, if you replace only the engine and not the waggons and change the rail type.

Haukinger has not fixed it :(

note: this is the fixed update version, not a fix for his update, against MiniIN.

Edit: DONE - committed at r5717
Attachments
auto_replace_bugfix.diff
(4.27 KiB) Downloaded 388 times
Last edited by gigajum on 03 Aug 2006 09:07, edited 2 times in total.
User avatar
mart3p
Tycoon
Tycoon
Posts: 1030
Joined: 31 Oct 2005 21:00
Location: UK

Post by mart3p »

Here’s the fix for the assert I’ve been getting with subsidiaries on, when selecting a road vehicle of a subsidiary company, from a station vehicle list.

Edit: DONE - committed at r5588
Attachments
Subs_Assert_Bugfix_MiniIN_r5584.patch
(401 Bytes) Downloaded 361 times
Image
gigajum
Route Supervisor
Route Supervisor
Posts: 511
Joined: 08 Mar 2006 08:33
Location: Germany

Post by gigajum »

Ok here's the fix for percentile unloading at a station that not accepts this cargo.


Edit: DONE - committed at r5661
Attachments
addional_orders_unload_fix2.diff
(2.61 KiB) Downloaded 368 times
Last edited by gigajum on 31 Jul 2006 06:52, edited 1 time in total.
gigajum
Route Supervisor
Route Supervisor
Posts: 511
Joined: 08 Mar 2006 08:33
Location: Germany

Post by gigajum »

I don't know if that what i fixed caused that bug

If it not caused it, that fix changes the code to start/stop not ALL single waggons of EACH train. Only the engines of each train are enough. Saves some cpu time (imo).

Edit: DONE - committed at r5587
Attachments
sendalltodepot_fix.diff
(1.17 KiB) Downloaded 366 times
Last edited by gigajum on 31 Jul 2006 06:51, edited 1 time in total.
User avatar
Wolf01
Tycoon
Tycoon
Posts: 2016
Joined: 24 Apr 2004 10:43
Location: Venezia - Italia
Contact:

Post by Wolf01 »

Adjoin stations patch:
- you can place different stations adjacent (with CTRL)
- you can join stations if they fit in the station_spread
- you can do both these things at the same time (without CTRL)
- you can disable this in configure patches -> stations (join distance is set to 1 tile)

Credits:
Wolf01 (Idea,testing)
Frostregen (Coding)
#OpenTTD (Support)
Attachments
adjacent_stations_rev5632_v5_872.diff
(33.06 KiB) Downloaded 410 times
User avatar
mart3p
Tycoon
Tycoon
Posts: 1030
Joined: 31 Oct 2005 21:00
Location: UK

Post by mart3p »

This patch fixes a bug reported (by ddream) in the MiniIN problems thread. When building a drive-through road stop, a road connecting the stop to a road on the adjacent tile, was built on one side only. This patch disables the building of connecting roads for drive-through stops (same behaviour as TTDPatch).

Edit: DONE - committed at r5658
Attachments
Drive_Thru_Connect_Bugfix_MiniIN_r5656.patch
(1.34 KiB) Downloaded 283 times
Image
gigajum
Route Supervisor
Route Supervisor
Posts: 511
Joined: 08 Mar 2006 08:33
Location: Germany

Post by gigajum »

Ok here's a nice one :)

It prevents towns from builing bridges within two tiles to another bridge.
It should be an addition to the Town growth patch. So i did not make it optional.

@ richk: could you please say what's speaking against this to get included.

Edit: DONE - committed at r5826
Attachments
No_town_bridges_within_2_tiles.diff
(1.62 KiB) Downloaded 383 times
Last edited by gigajum on 09 Aug 2006 22:07, edited 2 times in total.
gigajum
Route Supervisor
Route Supervisor
Posts: 511
Joined: 08 Mar 2006 08:33
Location: Germany

Post by gigajum »

A small update to the waypoint stats. It now counts trains over a year, too. On huge train networks one month is sometimes a bit low.

Edit: DONE - committed at r5720
Attachments
waypoint_stats_update_miniIN.diff
(9.59 KiB) Downloaded 325 times
Last edited by gigajum on 03 Aug 2006 09:08, edited 1 time in total.
richk67
Tycoon
Tycoon
Posts: 2363
Joined: 05 Jun 2003 16:21
Location: Up North
Contact:

Post by richk67 »

gigajum wrote:@ richk: could you please say what's speaking against this to get included.
Nothing... I just ran out of time last night... I think my last commit was at 1.30am or something. I'll add it tonight. (Normal service is nearly resumed ;) )
OTTD NewGRF_ports. Add an airport design via newgrf.Superceded by Yexo's NewGrf Airports 2
Want to organise your trains? Try Routemarkers.
--- ==== --- === --- === ---
Firework Photography
User avatar
SirkoZ
Tycoon
Tycoon
Posts: 1518
Joined: 06 Mar 2004 23:51
Location: The sunny side of Alps

Post by SirkoZ »

Rich - please - tell me - why don't you include my improved_vehicle names + speeds patch already - I think with the new physics patch, the real horse power of TGV (13600) and EuroStar (16000) will help rather nicely with hill trains (I PMed you, but I guess there's too much of everything...). :)

BTW - I have some new mini-in-size-maxi-in-functionality patches in the works. :)
richk67
Tycoon
Tycoon
Posts: 2363
Joined: 05 Jun 2003 16:21
Location: Up North
Contact:

Post by richk67 »

Much nicer variety than it was; good work. Last I looked it seemed all was TAM - a manufacturer I had never heard of. Perhaps we ought to consider having some Opels, and later trucks should be mainly Volvo and Mercedes who totally dominate the real world truck market.

OK. Good news and bad news. Good news - origveh looks good. Bad news is the changes to tables\engines.h dont compile cleanly as these have been recently added to by the physics patch. If you create a MiniIN version of this to integrate with the physics patch, I *will* add it.
OTTD NewGRF_ports. Add an airport design via newgrf.Superceded by Yexo's NewGrf Airports 2
Want to organise your trains? Try Routemarkers.
--- ==== --- === --- === ---
Firework Photography
User avatar
SirkoZ
Tycoon
Tycoon
Posts: 1518
Joined: 06 Mar 2004 23:51
Location: The sunny side of Alps

Post by SirkoZ »

richk67 wrote:Much nicer variety than it was; good work. Last I looked it seemed all was TAM - a manufacturer I had never heard of. Perhaps we ought to consider having some Opels, and later trucks should be mainly Volvo and Mercedes who totally dominate the real world truck market.

OK. Good news and bad news. Good news - origveh looks good. Bad news is the changes to tables\engines.h dont compile cleanly as these have been recently added to by the physics patch. If you create a MiniIN version of this to integrate with the physics patch, I *will* add it.
Indeed - perhaps I forgot to tell you that I have revised all the names. :)

I will update it immediatelly.

Thanks many times. ;)
User avatar
SirkoZ
Tycoon
Tycoon
Posts: 1518
Joined: 06 Mar 2004 23:51
Location: The sunny side of Alps

Post by SirkoZ »

There - I have posted it in its respective topic. Just follow the link in my signature.

Thanks. 8)
richk67
Tycoon
Tycoon
Posts: 2363
Joined: 05 Jun 2003 16:21
Location: Up North
Contact:

Post by richk67 »

Done at r5722 :)
OTTD NewGRF_ports. Add an airport design via newgrf.Superceded by Yexo's NewGrf Airports 2
Want to organise your trains? Try Routemarkers.
--- ==== --- === --- === ---
Firework Photography
Post Reply

Return to “OpenTTD Suggestions”

Who is online

Users browsing this forum: No registered users and 10 guests