Build Templates (Copy&Paste) (r13911 + 0.6.3 + 0.6.2)

bobingabout · Post by **bobingabout** » 23 May 2006 09:26

there was once a patch to do things diagonally if you held CTRL when dragging, but it's been left to rot somewhere...

Frostregen · Post by **Frostregen** » 23 May 2006 15:27

Comments about the GUI?

The little arrows are for rotation and will be replaced by "circle arrows".

Red.xiii · Post by **Red.xiii** » 23 May 2006 16:04

Very nicely done! A bit big comparing it to the buttons currently in use though....

Any chance of getting this code commited? I know you've worked on several patches and i have no idea if your work is paying off, cos i think it's excellent!

Frostregen · Post by **Frostregen** » 23 May 2006 17:57

When I've figured out how to add new images, the text-buttons will be replaced by smaller image buttons.

The Layout would change to this:

Code: Select all

[img: Copy] [img: rotate CCW] [img: rotate CW] [img: Paste]
[      text: include vacant terrain                       ]

EDIT: See image

Hm, I just worked on 1 tiny bugfix before, which was commited (1 line of code moved 3 lines down

)
But thx =)

I don't think it will be committed at this state.
Mainly because I don't like the code myself

Also some points are really dissatisfying:
-Rotation won't work on everything (Airports, stations etc.)

-non-conform stations, newstations
This would even require pathfinding, to connect every station piece.
+additional terraforming to create possible path's.
At the moment i think this is to complex(newstations, track length limits), with too little gain, so I will leave it out. Maybe this can be added later.

-For multiplayer it may be to traffic intensive (i still did not test it)
There are 2 ideas how to do it, but none really satisfying.
(1. Make it a single Command - 2. Delay the building process)

News:
-Rail/Road Depots added
-"do not paste vacant terrain" added.

LKRaider · Post by **LKRaider** » 24 May 2006 02:57

This patch is amazing! Congratulations!

gkirilov · Post by **gkirilov** » 24 May 2006 07:45

If there is something that can not be rotated - just disable the rotate buttons.
It will increase the chanse of being added to the trunk

.
Great patch. I am already using it in my build.

ebi · Post by **ebi** » 24 May 2006 15:40

It becomes so wunderfull....

Greetings EBI

gkirilov · Post by **gkirilov** » 25 May 2006 23:35

I just found out that you can "copy" from one game then load another game and paste the layout. That's great

So now .. we can have a "template" save game with ALL the layout of stations, junctions and so on and just copy/paste from one savegame to another.

p.s. don't know if this is intentionally build feature, but please keep it that way.

Frostregen · Post by **Frostregen** » 28 May 2006 02:30

New Version:

-rotation added
-fixed a bug when copying a 2-track-tile with 2 signals.

Bugs:
-tunnel exit is not checked, neither if terrain is properly restored.
(Just make sure both tunnel ends are within the selection, or it may be very expensive

)

Status:
-implementing load & save of selection.

@gkirilov: No, this was not intentionally. I just forgot to clear the copy-buffer after map load

When load & save is implemented, this won't be a point anyway.

Frostregen · Post by **Frostregen** » 28 May 2006 08:43

-Load & Save implemented.
-main code moved to copy_paste_gui.c
-Waypoints added
-disable rotate/Paste/Save buttons, if nothing is copied.

Do not use this to create a large template database, as the file format will definitely change in future, which would ruin your effort.
But try it to report bugs

Things left to do:
-"tunnel ends not in selection" glitch.
-replace some strings (load / save dialogs)
-create + add new sprites for GUI

Wolf01 · Post by **Wolf01** » 28 May 2006 09:16

great, we will exchange junctions as now we exchange scenarios

gkirilov · Post by **gkirilov** » 28 May 2006 12:36

erase.

Haukinger · Post by **Haukinger** » 28 May 2006 15:01

I can't compile this on linux - it says 'fd' undeclared in unix.c at line 161... Windows works fine.

EDIT: done. should be

Code: Select all

fios->mtime = sb.st_mtime;
ttd_strlcpy(fios->name, dirent->d_name, lengthof(fios->name));

instead of

Code: Select all

fios->mtime = *(uint64*)&fd.ftLastWriteTime;
ttd_strlcpy(fios->name, fd.cFileName, lengthof(fios->name));

and

Code: Select all

ttd_strlcpy(fios->title, dirent->d_name, lengthof(fios->title));

instead of

Code: Select all

ttd_strlcpy(fios->title, FS2OTTD(fd.cFileName), lengthof(fios->title));

BTW: Great work, man ! I'm adding this patch to my server...

Frostregen · Post by **Frostregen** » 28 May 2006 18:03

@Haukinger:
thx. Stupid copy&paste error :-/

Btw, this patch is completely clientside at the moment, so there is no need to add it to a server. Would be interesting how well it works on multiplayer though.

Fixed patch attached.

Brianetta · Post by **Brianetta** » 29 May 2006 00:05

Be interesting to see if , after applying this patch, a client gains this advantage over other players. Feel free to test it on my nightly server. (:

Haukinger · Post by **Haukinger** » 29 May 2006 08:22

One more feature-request(-suggestion) from me: let the paste-tool clear the to-be-modified tiles. As it is no, it leaves rails there (even your own) and then fails to terraform or place different rails/signals.

Frostregen · Post by **Frostregen** » 29 May 2006 11:44

@Brianetta: I'll try it tonight.

@Haukinger: Good point, will be done. Maybe tonight.

Haukinger · Post by **Haukinger** » 29 May 2006 14:52

Bug alert

You can't load templates in multiplayer. The game continues, but you are dropped from the server the moment you click on 'load' - totally quiet. No notification, no error message, no nothing.

In debug-mode, it says 'missing frame for sync test' once the load-template dialog opens. If you are quick enough and cancel now, the you stay connected. If you click on a filename, the connection is closed.

Sacro · Post by **Sacro** » 29 May 2006 16:03

Yeah, you can only do 1 thing per frame AFAIK, so you need it to buffer the things to do, and output 1 per frame

Frostregen · Post by **Frostregen** » 30 May 2006 03:55

@Haukinger: thx for the bugreport. fixed.
The "demolish before build" is hard to solve, because terraforming may affect tiles far away from the terraformed tile. (if you raise the top of a hill, you would need to clear all tiles around the hill-base)

@Sacro: That was not the problem.
It reset the networking state after a template load. Which caused the game to pause, if you open the load/save dialog again. This caused the drop.
But the Buffer thing is needed too. I could not paste a track with a signal in multiplayer.

Transport Tycoon Forums

Build Templates (Copy&Paste) (r13911 + 0.6.3 + 0.6.2)

Who is online