Municipal(Town Owned) Airports

JimboTG · Post by **JimboTG** » 20 Oct 2005 02:10

Fox,

Im using MSVC6 so I dont get as many error warnings as others, and it compiles without a hitch for me, Ive even combined subsidiarys and municipal airports successfully(without a single error!) heres my combined patch file, ive disabled tax on my patch if station sharing is on because i dont think its fair to be taxed by two different patches.

pls be specific with your warnings and compiler errors, so as i may be of some help

PS. LordOfThePigs - I hope you dont mind

LordOfThePigs · Post by **LordOfThePigs** » 20 Oct 2005 05:00

Why should I? It open source isn't it?

JimboTG · Post by **JimboTG** » 20 Oct 2005 05:03

nonetheless, Its only polite to ask

Smoky555 · Post by **Smoky555** » 20 Oct 2005 05:51

JimboTG wrote:Fox,

Im using MSVC6 so I dont get as many error warnings as others, and it compiles without a hitch for me, Ive even combined subsidiarys and municipal airports successfully(without a single error!) heres my combined patch file, ive disabled tax on my patch if station sharing is on because i dont think its fair to be taxed by two different patches.

pls be specific with your warnings and compiler errors, so as i may be of some help

PS. LordOfThePigs - I hope you dont mind

Sorry, but where is subsidiaries.h file ???

JimboTG · Post by **JimboTG** » 20 Oct 2005 06:01

oops, my bad. I have a memory like a goldfish and i forgot to add the relevant files. Ive corrected that now so just redownload the patch

MeusH · Post by **MeusH** » 20 Oct 2005 06:21

Born Acorn wrote:It would be good if you could "Propose airfield building" in smaller towns, and the town builds an airfield minimum 6 tiles away from the town centre?

In "town actions" just like "build statue" or "fund local road reconstruction"? I've proposed that, too, but I've been told that wouldn't be good, now I think the same

Smoky555 · Post by **Smoky555** » 20 Oct 2005 06:42

JimboTG wrote:oops, my bad. I have a memory like a goldfish and i forgot to add the relevant files. Ive corrected that now so just redownload the patch

m_airport.c , m_airport.h ...
bad memory

but, in new version of your patch you forget again to add this string in Makefile:

Code: Select all

C_SOURCES += m_airport.c

and i get an error
"No rules to compile 'subsidiaries.o' needed for 'openttd'. Stopping..."
i compiling openttd in linux ...

JimboTG · Post by **JimboTG** » 20 Oct 2005 07:34

Just for you smokey, ive added the line in the makefile

as for your other error, I really cant help as im not a linux user(windows is convenient for me) so maybe if anyone else has any suggestions?

Smoky555 · Post by **Smoky555** » 20 Oct 2005 07:46

JimboTG wrote:Just for you smokey, ive added the line in the makefile

as for your other error, I really cant help as im not a linux user(windows is convenient for me) so maybe if anyone else has any suggestions?

Just for you, Jimbo
you didn't add this line ("C_SOURCES += m_airport.c ") to Makefile

look at your diff-file carefully

Smoky555 · Post by **Smoky555** » 20 Oct 2005 07:49

the part of your diff-file look like this:

Code: Select all

Index: Makefile
===================================================================
--- Makefile	(revision 3070)
+++ Makefile	(working copy)
@@ -685,6 +685,9 @@
 C_SOURCES += sound/null_s.c
 C_SOURCES += video/dedicated_v.c
 C_SOURCES += video/null_v.c
+C_SOURCES += subsidiaries.c
+C_SOURCES += subsidiaries_cmd.c
+C_SOURCES += subsidiaries_gui.c
 
 # AI related files
 C_SOURCES += ai/ai.c

do you see this string?

JimboTG · Post by **JimboTG** » 20 Oct 2005 07:56

I have just checked BOTH posted diffs and they both contain the added string, this I can guarantee because ive done a clean SVN checkout twice, and applied the diffs from this forum then manually checked the makefiles.

Smoky555 · Post by **Smoky555** » 20 Oct 2005 09:15

JimboTG wrote:I have just checked BOTH posted diffs and they both contain the added string, this I can guarantee because ive done a clean SVN checkout twice, and applied the diffs from this forum then manually checked the makefiles.

wait a minute
you add this string in openttd.dsp file, for compiling in MSVC, but i tell you about Makefile (for compiling in cygwin or in Linux)

JimboTG · Post by **JimboTG** » 20 Oct 2005 11:47

NO I am talking about the makefile, please check again, could someone else verify this aswell please?

Smoky555 · Post by **Smoky555** » 20 Oct 2005 11:59

now - yes
but early (at 9:00 am) - no

Smoky555 · Post by **Smoky555** » 21 Oct 2005 03:42

To: JimboTG
Sorry, yesterday was a bad day for me

JimboTG · Post by **JimboTG** » 21 Oct 2005 09:22

No problem, we all have bad days.

Has anyone got any suggestions/feedback about the patch, Ive run out of things to do

bobingabout · Post by **bobingabout** » 21 Oct 2005 10:41

it seems like a great patch. thats about all i can say without playing it. and i can't play it ATM.

oVRoM · Post by **oVRoM** » 22 Oct 2005 23:25

Code: Select all

2005-10-23 01:18:40.292 openttd[11962] An assertion has failed and OpenTTD must quit.
GetPlayer in player.h (line 213)
"i < lengthof(_players)"

I get this as soon as I click the button to show all aircrafts servicing an airport on any Municipal Airport:

I'm using the Municipal Airports & subsidiaries combo patch on rev 3077 by the way.

JimboTG · Post by **JimboTG** » 22 Oct 2005 23:40

thats a new one;

Im in the process of upgrading to visual studio 2003 right now, I should be up and running by tomorrow night, could you do me a favour and see if you can repeat the bug with just the municipal airports patch alone, then I will have a good idea of where to start.

thanks

oVRoM · Post by **oVRoM** » 23 Oct 2005 00:32

Yep, same problem with trunk 3077 and only MA.

relevant part of player.h:

Code: Select all

static inline Player* GetPlayer(PlayerID i)
{ 
        assert(i < lengthof(_players);
        return &_players[i];
}

I guess it's sort of logical that this fails... I suppose since the town doesn't count as a player, this assert failes. The PlayerID i is 15 here when it halts by the way.

So a quick & very dirty patch would be simple :-)

Code: Select all

assert(i < lengthof(_players) || 15);

;-)

Transport Tycoon Forums

Municipal(Town Owned) Airports

Who is online