Problem compiling GRFCodec

[DaleStan]

How does one compile the GRFCodec source?
$ make
and
$ make grfcodec
both produce this output:

Code: Select all

info.h:67: error: `struct infowriter::box::<anonymous union>::boxsprite' invalid; an anonymous union can only have non-static data members
info.h:72: error: `struct infowriter::box::<anonymous union>::boxdata' invalid; an anonymous union can only have non-static data members

If I remove the union, GRFCodec compiles, but the linker fails with reams of text, mostly undefined operator new, operator delete, and ___gxx_personality_sj0.

The compiler errors are the same, and the linker errors superficially the same, for both Cygwin and (after patching) Linux.

My gcc versions are
$ gcc --version
gcc (GCC) 3.3.3 (cygwin special)
and
$ gcc --version
gcc (GCC) 3.2.3

[Mek]

This is a problem with gcc 3.x i believe, you have to give the union a name (and use that name everywhere)... i had that same problem when i tried to compile it, but i fixed it, i will see if i can find enough spare time to make a diff

[Darkvater]

No, grfcodec itself is faulty.

It gives exactly the same error on VS.NET. What I did is just move the struct decleration from the class outside of the class; and it all worked.

Don't forget though that you need ttdpal.h which is missing from the grfcodec source zip. It's only there in one of the earlies source files.

When running grfcodec there is also a delete() error with invalid heap. Best is to just comment that out.

[Mek]

No, grfcodec itself is faulty.

This might be the case, but with gcc < 3.x it compiles perfectly....

[DaleStan]

Don't forget though that you need ttdpal.h which is missing from the grfcodec source zip. It's only there in one of the earlies source files.

That's because make builds it for you now. make clean doesn't delete it though.

When running grfcodec there is also a delete() error with invalid heap. Best is to just comment that out.

On this I beg to differ. Best is to find the offending delete, and fix it.

It's now compiling and linking (use g++ to link, not gcc), so once I get things running, I'll post a patch.

[Darkvater]

Aaaah. MSVC doesn't use the makefile so the files doesn't get created

And that delete was just weird. It seemed correct but every time resulted in invalid heap. So I asked patchman and he said that is possible because grfcodec is the biggest mess he has ever coded.