Patch: Upgrade airports

[Sarvesh50]

Can i reqeust the last openttd with this patch and some other nice one?
I cant compile

[Eddi]

no, you can't request that. this forum is only for people who actually develop something.

[Sarvesh50]

No problem
Good there is karma you will burn.
Have a nice day.

[sickie]

Wishing for other people to burn does no good to your karma too, Sarvesh50.

[planetmaker]

Can i reqeust the last openttd with this patch and some other nice one?
I cant compile

Of course you may ask.

Providing binaries with one patch: 100€
Additional work required depending on available patch and how well it applies: 100€ / hour
Additional patches: 150€ each plus required extra work.

A four hour minimum charge applies.

So, contact me, if you're interested and we can work out the details. Delivery of a binary upon reception of money.

[nighthawk_c_m]

Damn capitalism starts hitting openttd

[PikkaBird]

no, you can't request that. this forum is only for people who actually develop something.

Actually, this forum is only for people who are willing to be constructive and helpful. Consider this a moderator warning!

Sarvesh50, compiling isn't too hard, perhaps if you want regular updates you should consider learning how to do it? http://wiki.openttd.org/Category:Compiling_OpenTTD is a good place to start.

[Eddi]

Consider this a moderator warning!

... I challenge the validity of this warning, as you are not actually a moderator of this forum

[PikkaBird]

Consider this a moderator warning!

... I challenge the validity of this warning, as you are not actually a moderator of this forum

I know I'm not, I sought the opinion of a global moderator first!

[Sarvesh50]

Thank you Pikkabird.
Why are so many people not nice anymore?
The reccesion ?

[cirdan]

Update against trunk.

[andythenorth]

Why are so many people not nice anymore?

They're about as nice as they ever were. The past was not a better place

[xmirakulix]

I found a bug in this patch that crashes the game because of a failed assertion.
It can be reproduced with the latest version of the patch against trunk r20794.

Crash reason:
Signal: Abort trap (6)
Message: Assertion failed at line 497 of /Users/flo/Desktop/openttd/git-openttd/src/station.cpp: this->PtInExtendedRect(TileX(ta.tile), TileY(ta.tile))

It happens when you upgrade an airport two times and don't place it at the exact same location every time.
I think the screenshot shows what I try to describe...

Crash screenshot

crash.jpg (86.24 KiB) Viewed 6449 times

[cirdan]

Wow, a bug two years and a half after the last one. I almost thought there weren't any left.

The attached patch fixes it. Thanks for the report!

[xmirakulix]

Confimed as fixed. Thank you for the quick response!

[Sarvesh50]

Will this one update for openttd 1.1 beta3?

[cirdan]

The last patch I posted (against r21541) should apply cleanly against 1.1.0-beta3.

[Sarvesh50]

I tried it it doesnt work
I apply tortoisesvn opens but doesnt change or patch anything...

[ChillCore]

Tortoisesvn only like svn patches. It can not apply git or hg patches.

Just change the header from:

Code: Select all

diff --git a/src/station_cmd.cpp b/src/station_cmd.cpp
index fc6faff..357a83f 100644
--- a/src/station_cmd.cpp
+++ b/src/station_cmd.cpp

to:

Code: Select all

Index: src/station_cmd.cpp
===================================================================
--- src/station_cmd.cpp	(revision 21541)
+++ src/station_cmd.cpp	(working copy)

and it should apply just fine.

I think you should also be able to apply the git patch with "-p1" from the console but I have never tested that when I was still on Windows. I could be wrong ...

ps: I could post an svn patch but as the change to make is minor ...

[dihedral]

Why are so many people not nice anymore?

They're about as nice as they ever were. The past was not a better place

but the future was better in the past