Terkhen's Personal Patch Pack

[ashb]

So I also wanted this, I've taken took v04 of the TPP and applied it to the cargo dist from last week sometime. It seems to behave largely, though I have noticed a few crashes (i think to do with deleting a depot when trains still have orderes to it) which could be due to the timetable separation patch, and some desyncs, which could be that, or might be the tunnels on bridges.

Either way, it mostly all works, thought its not up to date with either the cargodist or the latest version of the TPPP.

Terkehn: good work on compiling the patches.

[Terkhen]

As I already noted in this thread: having the right to use TPPP diff file in any way you want does not mean that you should post your work here: it is not TPPP and posting it here is going offtopic. Also, I cannot understand why you decided to post your diff here just after the post where I explain why I am against making a build with Cargo distribution, more so when you describe all the defects that I mentioned in that post.

[Wasila]

Well, I'll risk it and see what happens. Thanks.

[2007Alain2007]

will there be More conditonal orders i have asked to patch packs to added this and see who come back to me with it added

[Terkhen]

will there be More conditonal orders i have asked to patch packs to added this and see who come back to me with it added

• r16755-v05: Conditional order "skip with certain probability" removed to allow almost complete savegame compatibility with trunk.

You can also check all the discussion that we had before I adopted this decision. Or you can keep asking everywhere without informing yourself first.

[2007Alain2007]

I asked becuse i could not see oit on your rejected list of patchs thats all any ways i got the patch pack in mine working right with not bugs i can see

[Terkhen]

It is included in a more important place, but now I realize that it means nothing for people that don't know the source.

If you convince me that the patch is useful and / or easy to include and mantain, I will add it to TPPP. Patches that bump the save game version will never be included, as TPPP tries to maintain savegame compatibility with trunk. Big patches that add a lot of features (like cargodist, more height levels, etc) will never be included in TPPP. These patches are *very* complex, and their creators are always in the need for more testing.

Anyways, I guess I was too naive to assume that everyone would check the page-long discussion about conditional orders and other patches that bump savegame version in TPPP. The patch has been added to the rejected list.

[thetzar]

Can someone provide a Mac binary for this patchpack? When I try to compile, I get kicked languagefile errors.

[Terkhen]

If such binary is provided, I will gladly add it to the list of downloads (or just give permissions to the contributor to post binaries directly). These errors are probably produced by the Rating in town label patch, as it is the only one that changes fields of existing OpenTTD strings (it is possible that the NewGRF GUI Window patch gives problems too, but less probable). Compiling with the Rating in town label with Visual Express already gives a lot of warnings, but I didn't knew that it broke compatibility in other platforms. I'll try to solve that problem in the next version of the Rating in town label patch, when I finish my current project.

To check if this is really the cause of your problem, download the Rating in town label patch (the link is in my signature) and try to compile only with it. If I am not mistaken, you will get the same errors as you did when compiling TPPP. Then you should be able to compile a version of TPPP without that patch.

[thetzar]

Actually, on further testing my compile errors are happening on plain trunk, as well. Which means I have other issues entirely to worry about.

[Sapakara]

Terkhen thx a lot for this nice patch pack. I have only one problem with it. When I play The Netherlands scenario that is in the download content and I try to build a tunnel under water your version crashed. What do you need to see what goes wrong?

And final I have a patch request. Is it possible to include the aiport-upgrade patch (http://www.tt-forums.net/viewtopic.php?t=35867) in your patch pack?

grtz and keep up that good work

[Terkhen]

Version r17097-v06 of TPPP released. See this post for changes and download.

Sapakara: I wasn't able to reproduce that strange crash except with version compiled with the v05 diff file. My only guess is that I messed the code in some way while patching everything together, as v06 (and any other binary including the chunnels patch that I created while trying to find the source of this bug) allows creating chunnels without problems. The Close airports patch already allows to upgrade existing airports without stopping all airplanes: I don't want to make the easiest method of transport easier.

[Sapakara]

Terkhen,

With your new version same crash happened. I add the crash.log to this messege. It is sad to see that the station gui and newgrf gui are removed from your PP. These are very useful.

*** OpenTTD Crash Report ***
Date: 2009-08-07 10:31:13
Build: r17097M (2) built on Aug 7 2009 08:51:14
Reason: Assertion failed at c:\users\terkhen\desktop\compilar\tppp\src\tile_map.h:71: tile < MapSize()
Language: dutch.lng
Exception C0000005 at 0047D907
Registers:
EAX: 020A8768 EBX: 0012FA40 ECX: 0012F764 EDX: 020A87C7
ESI: FFFFFC37 EDI: 00000437 EBP: 0012FA08 ESP: 0012F97C
EIP: 0047D907 EFLAGS: 00010202

Bytes at CS:EIP:
C6 05 00 00 00 00 00 A1 AC 91 6F 00 0F B6 04 F0 C1 E8 04 C3 53 56 8B F0

Stack trace:
004C34BD 001C2C37 0012FA74 004C3246 00000000 0100029E 00000003 00000437
001C2C37 00000000 00000000 00000009 00000000 00000384 00000009 00000000
00000640 FFFFF800 00000001 00000000 00000000 00000000 0001FFFF 00000000
09231DFF 00000000 7E01FFFF 00000000 091E8EB8 00000000 7E01FFFF 00000000
09231DFF 00000000 0001FFFF 0012FA54 00405406 00000002 00000201 00000000
00000000 0067DE1C 001C2C37 00000001 004C3246 001C2C37 0000437C 0000384D
004C16D2 00004379 001C2C37 00000000 0012FA78 0041EAD1 0012FA84 004746D8
001C2C37 00000201 00000000 00000002 00000000 00DE0710 00000000 0012FAB4
00443623 0000384D 0012FAB4 0044F598 0000437C 00003850 001C2C37 00000144
00000096 00000000 00000096 0000015C 001C05B4 00000001 00000000 0044F8CA
00000000 00000000 00000144 00000096 0012FB54 00000000 0054A4D7 0012FBBC
0054A091 00000000 00992C60 00000000 00000000 00000102 0012FB38 746B13D4
00010155 00000000 00000001 746B13D9 00000000 7FFDF000 00000102 00D00000
00010155 0012FB0C 00000000 0012FB80 746DF1A6 746B13E0 FFFFFFFF 746B13D9
7E3AB372 00000000 00000001 0012FBD4 00000000 0012FC88 0012FB80 7E398734
001C05B4 00000200 00000000 01440096 0054A091 DCBAABCD 00000000 0012FBBC
0054A091 0012FBE8 7E398816 0054A091 001C05B4 00000200 00000000 01440096
0012FC90 0012FC88 009F06A0 00000014 00000001 00000000 00000000 00000010
00000000 00000030 00000001 00000000 00000000 0012FB9C 0012F5A0 0012FC38
7E3C048F 7E398830 00000000 0012FC48 7E3989CD 00000000 0054A091 001C05B4
00000200 00000000 01440096 009F06B4 00000001 7E3AA78F 7E39929B 003DC3E3
0012FC48 7E399402 0012FC88 00000000 00000000 0012FC10 0012F5A0 0012FFB0
7E3C048F 7E3989F0 FFFFFFFF 0012FC58 7E398A10 0012FC88 00000000 00000000
0054AB36 0012FC88 006D4F64 00000001 0012FD14 00000000 0012FC60 003DC3E3

Module information:
d:\Openttd TPPP\openttd.exe handle: 00400000 size: 2898432 crc: 4CF4EE39 date: 2009-08-07 06:53:46
C:\WINDOWS\system32\ntdll.dll handle: 7C900000 size: 735744 crc: 810A5742 date: 2009-02-09 10:56:06
C:\WINDOWS\system32\kernel32.dll handle: 7C7D0000 size: 1030656 crc: E62CE906 date: 2009-03-21 14:09:59
C:\WINDOWS\system32\WINMM.dll handle: 76AF0000 size: 179200 crc: 14C886F9 date: 2008-04-14 17:02:44
C:\WINDOWS\system32\ADVAPI32.dll handle: 77F40000 size: 684544 crc: 386B374F date: 2009-02-09 10:56:07
C:\WINDOWS\system32\RPCRT4.dll handle: 77DA0000 size: 585216 crc: 857DC3DC date: 2009-04-15 14:55:06
C:\WINDOWS\system32\Secur32.dll handle: 77F10000 size: 56832 crc: 24F7E205 date: 2009-02-03 19:59:02
C:\WINDOWS\system32\GDI32.dll handle: 77E40000 size: 286720 crc: AD0D7A5A date: 2008-10-23 12:43:45
C:\WINDOWS\system32\USER32.dll handle: 7E390000 size: 580096 crc: A1DEF669 date: 2008-04-14 17:02:44
C:\WINDOWS\system32\WS2_32.dll handle: 71A30000 size: 82432 crc: 1CF0E4F7 date: 2008-04-14 17:02:45
C:\WINDOWS\system32\msvcrt.dll handle: 77BE0000 size: 343040 crc: 914594B7 date: 2008-04-14 17:02:33
C:\WINDOWS\system32\WS2HELP.dll handle: 71A20000 size: 19968 crc: 25A9B9EA date: 2008-04-14 17:02:45
C:\WINDOWS\system32\SHELL32.dll handle: 7C9C0000 size: 8508416 crc: 1CE36AED date: 2008-06-17 19:03:19
C:\WINDOWS\system32\SHLWAPI.dll handle: 77E90000 size: 498688 crc: CC283459 date: 2008-04-14 17:02:39
C:\WINDOWS\system32\IMM32.DLL handle: 76330000 size: 110080 crc: BC278F31 date: 2008-04-14 17:02:28
C:\WINDOWS\WinSxS\x86_Microsoft.Windows.Common-Controls_6595b64144ccf1df_6.0.2600.5512_x-ww_35d4ce83\comctl32.dll handle: 77390000 size: 1054208 crc: D48C9A27 date: 2008-04-14 17:00:21
C:\WINDOWS\system32\comctl32.dll handle: 5D4E0000 size: 617472 crc: 3039BA4F date: 2008-04-14 17:02:23
C:\WINDOWS\system32\SHFolder.dll handle: 76730000 size: 25088 crc: D4F9262A date: 2008-04-14 17:02:39
C:\WINDOWS\system32\WINTRUST.dll handle: 76BF0000 size: 176640 crc: 20C532EF date: 2008-04-14 17:02:44
C:\WINDOWS\system32\CRYPT32.dll handle: 77A40000 size: 602624 crc: 7EA0028A date: 2008-04-14 17:02:23
C:\WINDOWS\system32\MSASN1.dll handle: 77AE0000 size: 57344 crc: 576F740E date: 2008-04-14 17:02:29
C:\WINDOWS\system32\IMAGEHLP.dll handle: 76C50000 size: 144384 crc: 4D6F22DF date: 2008-04-14 17:02:28
C:\WINDOWS\system32\wdmaud.drv handle: 72C90000 size: 23552 crc: F3E22527 date: 2008-04-14 17:03:22
C:\WINDOWS\system32\msacm32.drv handle: 72C80000 size: 20992 crc: 59696C97 date: 2002-12-31 06:00:00
C:\WINDOWS\system32\MSACM32.dll handle: 77BB0000 size: 71680 crc: 4C6A08FD date: 2008-04-14 17:02:29
C:\WINDOWS\system32\midimap.dll handle: 77BA0000 size: 18944 crc: 4F148956 date: 2008-04-14 17:02:29
C:\WINDOWS\system32\ole32.dll handle: 774A0000 size: 1287168 crc: C44C98F7 date: 2008-04-14 17:02:37
C:\WINDOWS\system32\uxtheme.dll handle: 5B190000 size: 219136 crc: C6670262 date: 2009-01-21 06:08:43
C:\Program Files\System Tools\RocketDock\RocketDock.dll handle: 10000000 size: 69632 crc: B42DC454 date: 2007-09-02 12:57:36
C:\WINDOWS\system32\PSAPI.DLL handle: 76BB0000 size: 23040 crc: 8CDC5A38 date: 2008-04-14 17:02:38
C:\WINDOWS\system32\MSCTF.dll handle: 746A0000 size: 297984 crc: D0327D58 date: 2008-04-14 17:02:30
C:\WINDOWS\system32\CLBCATQ.DLL handle: 76F90000 size: 498688 crc: 23CAAAF9 date: 2008-04-14 17:02:23
C:\WINDOWS\system32\COMRes.dll handle: 77010000 size: 822784 crc: 01C741E4 date: 2008-04-14 17:02:23
C:\WINDOWS\system32\OLEAUT32.dll handle: 770E0000 size: 551936 crc: 56F4315C date: 2008-04-14 17:02:37
C:\WINDOWS\system32\VERSION.dll handle: 77BD0000 size: 18944 crc: FC19E92F date: 2008-04-14 17:02:44
C:\WINDOWS\system32\dmime.dll handle: 59A40000 size: 181248 crc: 42675F28 date: 2008-04-14 17:02:24
C:\WINDOWS\system32\DSOUND.dll handle: 73E80000 size: 367616 crc: 79EDF214 date: 2008-04-14 17:02:24
C:\WINDOWS\system32\dmusic.dll handle: 6CE90000 size: 104448 crc: C8018462 date: 2008-04-14 17:02:24
C:\WINDOWS\system32\KsUser.dll handle: 73E50000 size: 4096 crc: D76DE7B2 date: 2008-04-14 17:02:30
C:\WINDOWS\system32\dmsynth.dll handle: 6CEB0000 size: 103424 crc: 406D85F2 date: 2008-04-14 17:02:24
C:\WINDOWS\system32\dmloader.dll handle: 6CF20000 size: 35840 crc: A482F803 date: 2008-04-14 17:02:24
C:\WINDOWS\system32\msctfime.ime handle: 75250000 size: 177152 crc: 3096545F date: 2008-04-14 17:01:10
C:\WINDOWS\system32\mswsock.dll handle: 719D0000 size: 247296 crc: AB503995 date: 2008-06-20 17:49:21
C:\WINDOWS\system32\hnetcfg.dll handle: 61200000 size: 347648 crc: DAE28AF3 date: 2008-04-14 17:02:27
C:\WINDOWS\System32\wshtcpip.dll handle: 71A10000 size: 19456 crc: C10DDDD3 date: 2008-04-14 17:02:45

System information:
Windows version 5.1 2600 Service Pack 3

---- gamelog start ----
Tick 0: game loaded
Conversion from OTTD savegame without gamelog: version 90, 0
Revision text changed to r17097M, savegame version 124, modified, _openttd_newgrf_version = 0x080042c9
New game mode: 1 landscape: 0
---- gamelog end ----

[Terkhen]

With your new version same crash happened. I add the crash.log to this messege. It is sad to see that the station gui and newgrf gui are removed from your PP. These are very useful.

I have tested everything again. The crash cause lies only in the chunnels patch, and it has been reported to hackalittlebit. I will make a new version of TPPP as soon as it is corrected.

Big changes in trunk have made these patches too outdated. To work with current trunk they would need a complete rewrite (not the minor updates I was doing to them). We will have to wait until proper updates for these patches are done.

[Wasila]

Hey,

I added the patches 'Chunnels' and 'Signals in Bridges and Tunnels' to my running game which already had 'extra-large-maps patch' and 'cargodist'. I have been testing the new addition and have noticed something very peculiar.

Later in the game I planned on constructing a gigantic landbridge to connect two continents on the map. I did a cost estimation and I got roughly £400,000,000. I did this again after installing the new patches and this dropped to under £100,000,000. A tunnel, however, cost £600,000,000 (despite being told that underwater tunnels were cheaper than raising land).

Could someone please shed light onto this situation?
Thanks.

[Terkhen]

There are too many factors that could affect the cost. You should try with a binary including only the Chunnels patch (with no GRFs at all). Also, I can be mistaken about tunnels being cheaper than building a landbridge: but then the costs would be too strange

[Wasila]

I recompiled (with a slightly older nightly) with just maps patch and chunnels. The landbridge costed £100,000,000 or so and the tunnel costed just under £500,000,000.

[dihedral]

why people assume they can run a game for 5 mins spot bugs at a glace, i do not know!

[Wasila]

Why? Should I have run the game for longer?

[Terkhen]

Then its obvious that I was mistaken and raising land is cheaper than building chunnels, which makes the patch useless if you don't care about the looks of your network.

dihedral: I'm sorry, what bug are you referring to?