Transport Tycoon Forums

The place to talk about Transport Tycoon
It is currently Wed Jun 19, 2013 7:27 pm

All times are UTC




Post new topic Reply to topic  [ 2850 posts ]  Go to page Previous  1, 2, 3, 4, 5, 6, 7, 8 ... 143  Next
Author Message
 Post subject: Re: Cargo Distribution
PostPosted: Mon Apr 13, 2009 9:07 pm 
Offline
Chairman
Chairman
User avatar

Joined: Sat Oct 13, 2007 8:28 am
Posts: 859
ChillCore wrote:
I am going to test your patch and i will post a patch for turtoise.
If you think the patch is stable enough I will post my binaries too,
if that is okay with you that is.


Of course it is. The sources are "derived work" of OpenTTD and thus under the GPL. Everyone can change, republish, compile, distribute or do whatever with them. I'm happy to see people doing that.

I'm even more happy if people help me find the bugs mentioned here. It was only a little frustrating to spend half the day on setting up a virtual machine with windows, installing all the stuff and actually finding the problem, just to see someone else had just done the same thing. Perhaps just drop me a line when you start working on some known problem, so that I can concentrate on something else then. I'll post my IM information in my forum profile. But again: I don't want to prevent anyone from doing anything they like with the patches I post.

The good thing is: I can build Windows binaries myself now. I'll attach the fixed one I've tested with.


Attachments:
openttd.zip [1.94 MiB]
Downloaded 162 times

_________________
The guy on the picture is not me, it's Alonso.
Top
 Profile  
 
 Post subject: Re: Cargo Distribution
PostPosted: Mon Apr 13, 2009 10:18 pm 
Offline
Tycoon
Tycoon
User avatar

Joined: Sat Oct 04, 2008 11:05 pm
Posts: 2254
Location: Lost in spaces
As promised.
Svn / Turtoise patch attached.
After quick testing no more slowdowns. even with accuracy set higher (32 tested)

How to use a patch including new files using Turtoise:

- create a dummy file for each new file.
- apply the patch and compile.
- Never apply the patch twice.
First revert your source using Turtoise.
Then revert the new files to dummy files manually:
Turtoise does not revert new files for some reason.

Now you can reapply the patch to your source.


@ fonso:
Now you can easier debug windows compatibility, your afternoon was not a total waste. I hope.

ps:
The patch is the all in version.


Attachments:
cargodist_r16055_svn_Turtoise.patch [132.2 KiB]
Downloaded 86 times

_________________
Playing with my patchpack? Ask questions on usage and report bugs in the correct thread first!
All included patches have been modified and are no longer 100% original.

See the first post of my thread, please.
Thank you very much for understanding.
Top
 Profile  
 
 Post subject: Re: Cargo Distribution
PostPosted: Mon Apr 13, 2009 10:23 pm 
Offline
Engineer
Engineer

Joined: Fri Oct 05, 2007 4:56 pm
Posts: 4
fonso wrote:
Perhaps just drop me a line when you start working on some known problem, so that I can concentrate on something else then. I'll post my IM information in my forum profile. But again: I don't want to prevent anyone from doing anything they like with the patches I post.



Will keep that in mind next time :)
I have spend some time playing with your patch applied and it seems that everything is working, although during compilation (still MSVC and WinXP) there is one warning
Code:
Warning   1   warning C4804: '>' : unsafe use of type 'bool' in operation   f:\temp\openttd\src\mcf.cpp   72   openttd


Top
 Profile  
 
 Post subject: Re: Cargo Distribution
PostPosted: Tue Apr 14, 2009 12:21 pm 
Offline
Route Supervisor
Route Supervisor

Joined: Fri Sep 24, 2004 3:47 pm
Posts: 454
fonso wrote:
ChillCore wrote:
I am going to test your patch and i will post a patch for turtoise.
If you think the patch is stable enough I will post my binaries too,
if that is okay with you that is.


Of course it is. The sources are "derived work" of OpenTTD and thus under the GPL. Everyone can change, republish, compile, distribute or do whatever with them. I'm happy to see people doing that.

I'm even more happy if people help me find the bugs mentioned here. It was only a little frustrating to spend half the day on setting up a virtual machine with windows, installing all the stuff and actually finding the problem, just to see someone else had just done the same thing. Perhaps just drop me a line when you start working on some known problem, so that I can concentrate on something else then. I'll post my IM information in my forum profile. But again: I don't want to prevent anyone from doing anything they like with the patches I post.

The good thing is: I can build Windows binaries myself now. I'll attach the fixed one I've tested with.


Hi,

I downloaded the binary you posted, and copied it to an install of trunk R16055 (which works) and I get an error: " No available language packs (invalid versions?)" I'm not quite sure what the problem is there, but if trunk works, I guess there's nothing wrong with the language packs?


Top
 Profile  
 
 Post subject: Re: Cargo Distribution
PostPosted: Tue Apr 14, 2009 1:11 pm 
Offline
Chairman
Chairman
User avatar

Joined: Sat Oct 13, 2007 8:28 am
Posts: 859
el koeno wrote:
I downloaded the binary you posted, and copied it to an install of trunk R16055 (which works) and I get an error: " No available language packs (invalid versions?)" I'm not quite sure what the problem is there, but if trunk works, I guess there's nothing wrong with the language packs?


Ouch, I'm sorry ... this is because you not only need the binary but also some other files that are generated from the patch-modified sources. If you use the binary I posted with trunk versions of those other files it complains (as you have seen). I'll try to figure out which those files are.

_________________
The guy on the picture is not me, it's Alonso.


Top
 Profile  
 
 Post subject: Re: Cargo Distribution
PostPosted: Tue Apr 14, 2009 1:18 pm 
Offline
Tycoon
Tycoon
User avatar

Joined: Sat Oct 04, 2008 11:05 pm
Posts: 2254
Location: Lost in spaces
Hi fonso,
I see you only included openttd.exe
You need everything from the bin i think.
Try these to compare.
I think you can leave the svn folders out.

[EDIT]
Binaries removed. newer are available further in the thread.
[/EDIT]

_________________
Playing with my patchpack? Ask questions on usage and report bugs in the correct thread first!
All included patches have been modified and are no longer 100% original.

See the first post of my thread, please.
Thank you very much for understanding.


Last edited by ChillCore on Wed Apr 22, 2009 10:29 am, edited 1 time in total.

Top
 Profile  
 
 Post subject: Re: Cargo Distribution
PostPosted: Tue Apr 14, 2009 2:38 pm 
Offline
Route Supervisor
Route Supervisor

Joined: Fri Sep 24, 2004 3:47 pm
Posts: 454
ChillCore wrote:
Hi fonso,
I see you only included openttd.exe
You need everything from the bin i think.
Try these to compare.
I think you can leave the svn folders out.


Thanks, that one worked. It might contain some copyrighted material though.


Top
 Profile  
 
 Post subject: Re: Cargo Distribution
PostPosted: Tue Apr 14, 2009 2:40 pm 
Offline
Engineer
Engineer

Joined: Mon Oct 13, 2008 11:40 am
Posts: 14
wow this really works great fonso :bow: :bow: :bow:

I only have one question. In the map there are some new black numbers. What do they exactly mean?

Also sometimes the numbers are writen on top of the numbers of other cities rendering them unreadible


Top
 Profile  
 
 Post subject: Re: Cargo Distribution
PostPosted: Tue Apr 14, 2009 2:51 pm 
Offline
Tycoon
Tycoon
User avatar

Joined: Sat Oct 04, 2008 11:05 pm
Posts: 2254
Location: Lost in spaces
Quote:
Thanks, that one worked. It might contain some copyrighted material though.

Please tell me which files those are.
So i do not do that again.
I will remove the binaries if needed.

_________________
Playing with my patchpack? Ask questions on usage and report bugs in the correct thread first!
All included patches have been modified and are no longer 100% original.

See the first post of my thread, please.
Thank you very much for understanding.


Top
 Profile  
 
 Post subject: Re: Cargo Distribution
PostPosted: Tue Apr 14, 2009 3:15 pm 
Offline
Chairman
Chairman
User avatar

Joined: Sat Oct 13, 2007 8:28 am
Posts: 859
mullie0 wrote:
wow this really works great fonso :bow: :bow: :bow:

I only have one question. In the map there are some new black numbers. What do they exactly mean?

Also sometimes the numbers are writen on top of the numbers of other cities rendering them unreadible


The numbers are shown in the following format:

U/C:S/P

U = usage of the link (cargo having arrived at the destination coming from the source)
C = capacity of the link
S = cargo sent along the link (without necessarily arriving at the other side)
P = cargo planned for the link

Of course this doesn't matter much as no one can read it. If you click on the town names button some coloured boxes will be shown instead, but those are only marginally more readable. The coding is as follows:

white: capacity
grey: usage
red: plan
yellow: sent

The space, however, is so tight that you have to get really close to the screen in order to see if there is a box of a certain colour or not. And then you still don't know much about its size. Also, in areas with lots of stations, for example in town centers, the boxes still overlap and you can't discern anything. I'm thinking of reducing the space used for each item of information even further by drawing cubes instead of boxes, but I doubt it would help a lot.

So, I got a task for the artists among you: Draw a mockup of how the capacity/usage/planned/sent information (or at least a subset you'd like to see there) can be displayed readably in the map. I could really use an idea there as I'm not very good with GUI stuff.

_________________
The guy on the picture is not me, it's Alonso.


Top
 Profile  
 
 Post subject: Re: Cargo Distribution
PostPosted: Tue Apr 14, 2009 3:43 pm 
Offline
Engineer
Engineer

Joined: Mon Oct 13, 2008 11:40 am
Posts: 14
thank you very much for the info Fonso


Top
 Profile  
 
 Post subject: Re: Cargo Distribution
PostPosted: Tue Apr 14, 2009 3:50 pm 
Offline
Transport Coordinator
Transport Coordinator

Joined: Wed Mar 07, 2007 8:13 pm
Posts: 280
ChillCore wrote:
Quote:
Thanks, that one worked. It might contain some copyrighted material though.

Please tell me which files those are.
So i do not do that again.
I will remove the binaries if needed.

I don't think any files should be removed, but you should add GPL-licence.

_________________
Finnish Town Names || Finnish Trainset || Swedish Houses 1.1.1


Top
 Profile  
 
 Post subject: Re: Cargo Distribution
PostPosted: Tue Apr 14, 2009 4:06 pm 
Offline
Route Supervisor
Route Supervisor

Joined: Fri Sep 24, 2004 3:47 pm
Posts: 454
ChillCore wrote:
Quote:
Thanks, that one worked. It might contain some copyrighted material though.

Please tell me which files those are.
So i do not do that again.
I will remove the binaries if needed.


I'm not totally sure, but the data directory might contain some of the original artwork. I'm not entirely sure, as it might just contain the openGFX these days. I only use the openttd/data directory in "My Documents", so I wouldn't really know. ;)


Top
 Profile  
 
 Post subject: Re: Cargo Distribution
PostPosted: Tue Apr 14, 2009 4:13 pm 
Offline
Engineer
Engineer

Joined: Sat Apr 04, 2009 12:35 pm
Posts: 10
Location: The Hague, The Netherlands
ChillCore wrote:
Quote:
Thanks, that one worked. It might contain some copyrighted material though.

Please tell me which files those are.
So i do not do that again.
I will remove the binaries if needed.


You haven't included any of the original artwork grfs, so no reason to panic ;). For the record, the said files are (at least for the windows version): sample.cat, trg1r.grf, trgcr.grf, trghr.grf, trgir.grf and trgtr.grf. I think the files of the DOS version have other names, but they are similar though.


Top
 Profile  
 
 Post subject: Re: Cargo Distribution
PostPosted: Tue Apr 14, 2009 6:40 pm 
Offline
Engineer
Engineer

Joined: Thu Apr 09, 2009 7:26 pm
Posts: 7
Location: La Haye, NL
I just tried Chillcore's build: cargodist_r16055_win32.7z [2.88 ].

Again I builded two buses: A->B and A->C. So far no freezings yet, or high cpu-load. I will try further by building trains. I'll keep you posted, but so far so good.


Top
 Profile  
 
 Post subject: Re: Cargo Distribution
PostPosted: Tue Apr 14, 2009 6:58 pm 
Offline
Tycoon
Tycoon
User avatar

Joined: Sat Oct 04, 2008 11:05 pm
Posts: 2254
Location: Lost in spaces
Yes, lets get back on topic.

Here too it runs like a train even with bigger savegames.
I watched smallmap mostly i love how i can evaluate downloaded savegames.

For cargo distribution testing i should start a new game i guess ...

_________________
Playing with my patchpack? Ask questions on usage and report bugs in the correct thread first!
All included patches have been modified and are no longer 100% original.

See the first post of my thread, please.
Thank you very much for understanding.


Top
 Profile  
 
 Post subject: Re: Cargo Distribution
PostPosted: Tue Apr 14, 2009 7:00 pm 
Offline
TTDPatch Developer
TTDPatch Developer

Joined: Wed Feb 18, 2004 3:06 am
Posts: 10285
Zuu wrote:
Code:
1/accuracy < epsilon

can be changed to
Code:
1 < epsilon * accuracy

In pure math, these are equivivalent

No, they're not. They are equivalent iff "accuracy" is positive.

_________________
To get a good answer, ask a Smart Question. Similarly, if you want a bug fixed, write a Useful Bug Report. No TTDPatch crashlog? Then follow directions.
Projects: NFORenum (download) | PlaneSet (Website) | grfcodec (download) | grfdebug.log parser


Top
 Profile  
 
 Post subject: Re: Cargo Distribution
PostPosted: Tue Apr 14, 2009 8:56 pm 
Offline
Route Supervisor
Route Supervisor

Joined: Fri Sep 24, 2004 3:47 pm
Posts: 454
Jafinto wrote:
ChillCore wrote:
Quote:
Thanks, that one worked. It might contain some copyrighted material though.

Please tell me which files those are.
So i do not do that again.
I will remove the binaries if needed.


You haven't included any of the original artwork grfs, so no reason to panic ;). For the record, the said files are (at least for the windows version): sample.cat, trg1r.grf, trgcr.grf, trghr.grf, trgir.grf and trgtr.grf. I think the files of the DOS version have other names, but they are similar though.


Ah, good. I wasn't sure what was in the .grfs in the data directory.

On-topic: It seems to work fine, haven't found any problems. The GUI needs a major overhaul, but Fonso is on the case there.


Top
 Profile  
 
 Post subject: Re: Cargo Distribution
PostPosted: Wed Apr 15, 2009 7:02 am 
Offline
Director
Director

Joined: Thu Jul 28, 2005 9:31 am
Posts: 532
The Cargodest GUI worked quite well, I feel - lots of information, yet presented in an accessible format. And you could set your favourite view (for me, Destinations) as your default.


Top
 Profile  
 
 Post subject: Re: Cargo Distribution
PostPosted: Wed Apr 15, 2009 2:45 pm 
Offline
Director
Director

Joined: Thu Jul 28, 2005 9:31 am
Posts: 532
With the r16055 exe version I get 100% CPU load and then game crashes. I run the 2cc set on a 512/256 map with snowy terrain. What debugging/crash information can I send in to help?

(I've just built a network with an eye on the CPU meter all the time. Seems that my method of making a few very long-distance connections with very few stations all across the map brings CPU up quite a lot.; up to 60% for some time after I open the link, with just two trains. See attached image. The other two trains run a local line with four stops.)


Attachments:
CPU.jpg [606.66 KiB]
Downloaded 117 times
Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 2850 posts ]  Go to page Previous  1, 2, 3, 4, 5, 6, 7, 8 ... 143  Next

All times are UTC


Who is online

Users browsing this forum: 3298, FlameSing and 5 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  

Powered by phpBB © 2000-2013 phpBB Group

Copyright © Owen Rudge/The Transport Tycoon Forums 2001-2013.
Hosted by Zernebok Hosting.