Updated extra-large-maps patch, version 12 (for r23992)

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

Starbud
Traffic Manager
Traffic Manager
Posts: 211
Joined: 05 Mar 2007 00:48
Location: Sweden
Contact:

Re: Updated extra-large-maps patch, version 8 (for r13664)

Post by Starbud »

Anything that give larger maps.
Maybe enven irregular maps?
http://openttd.org - i love building stuff :)
Someones play with pics http://dimalimsliv.blogg.se
User avatar
Roest
Traffic Manager
Traffic Manager
Posts: 215
Joined: 03 Apr 2008 08:18

Re: Updated extra-large-maps patch, version 8 (for r13664)

Post by Roest »

Terkhen wrote:By popular demand... another update to current trunk.

Is there still any interest in this patch?
Terkhen
OpenTTD Developer
OpenTTD Developer
Posts: 1034
Joined: 11 Sep 2008 07:32
Location: Spain

Re: Updated extra-large-maps patch, version 8 (for r13664)

Post by Terkhen »

I meant interest from the developers, not by players.
Wasila
Tycoon
Tycoon
Posts: 1498
Joined: 15 Mar 2008 07:02

Re: Updated extra-large-maps patch, version 8 (for r13664)

Post by Wasila »

Looks like my new World Map has gone out the window :P

I'll definitely be looking to downloading this and using it once I have a look at Cindini.
Moriarty
Tycoon
Tycoon
Posts: 1395
Joined: 12 Jun 2004 00:37
Location: United Kingdom of Great Britain and Northern Ireland
Contact:

Re: Updated extra-large-maps patch, version 8 (for r13664)

Post by Moriarty »

I am currently playing with heightmap generation. I can make them pretty much any size, and many of them have to be scaled down even for 2048*2048, so should this patch come to trunk soonish (i.e. before I lose interest ;-) ), I can make maps of 8096*8096 (i.e. continental US, the world, europe etc etc).
So content for such maps can certainly be created.
Wasila
Tycoon
Tycoon
Posts: 1498
Joined: 15 Mar 2008 07:02

Re: Updated extra-large-maps patch, version 8 (for r13664)

Post by Wasila »

Well it looks like the devs are interested. Is it going into trunk?
Roujin
Tycoon
Tycoon
Posts: 1884
Joined: 08 Apr 2007 04:07

Re: Updated extra-large-maps patch, version 8 (for r13664)

Post by Roujin »

Wasila wrote:Well it looks like the devs are interested. Is it going into trunk?
Where do you take this information from?

Some time ago IIRC there were issues with vehicles crashing that were actually in totally different parts of the map (due to some calculation errors caused by raising the map limits..). Do these still exist? I'm pretty sure devs won't even consider this patch as long such bugs are not 100% eliminated. ;)
* @Belugas wonders what is worst... a mom or a wife...
<Lakie> Well, they do the same thing but the code is different.

______________
My patches
check my wiki page (sticky button) for a complete list

ImageImage
ImageImageImageImageImageImageImage
Terkhen
OpenTTD Developer
OpenTTD Developer
Posts: 1034
Joined: 11 Sep 2008 07:32
Location: Spain

Re: Updated extra-large-maps patch, version 8 (for r13664)

Post by Terkhen »

Bilbo said the crash bug was corrected (for trains at least) and I never had any problems playing with the patch. Of course this doesn't mean that it has been thoroughly tested: with maps of this size is possible that the problem still exists and I just was lucky enough to not have it.
User avatar
Bilbo
Tycoon
Tycoon
Posts: 1710
Joined: 06 Jun 2007 21:07
Location: Czech Republic

Re: Updated extra-large-maps patch, version 8 (for r13664)

Post by Bilbo »

That bug was introduced by change to trunk few thousand revisions ago when fixing exploit where your trains could collide with opponent's train if places "just right" next to their tracks. Unfortunately, the code caused overflow if the distance was over 4096 squares. When I spotted the bug, I have modified the check to use 64bit variables. The affected file was src/train_cmd.cpp, you can check that part of the patch ...

Current version of patch does not suffer with "distant train crash" bug. Also, very old versions before that "exploit fix" does not suffer with that either :)

I looked on the code, but I have not noticed any other place where the X and Y coordinates of a vehicle are squared - mostly the "manhattan distance" is used instead, I think the code I had to fix used manhattan distance too before it was modified to avoid the exploit.

I don't know of any bugs in the patch currently - I tested the patch about 200 game years, but perhaps some wider testing could be done before putting the patch to stable versions.

The only thing I can guarantee, is if there are bugs, they will manifest only if larger-than-standard sizes are selected.

Perhaps best way would be to put the patch in trunk some rather long time before the release to get things properly tested by many people.
If you need something, do it yourself or it will be never done.

My patches: Extra large maps (1048576 high, 1048576 wide) (FS#1059), Vehicle + Town + Industry console commands (FS#1060), few minor patches (FS#2820, FS#1521, FS#2837, FS#2843), AI debugging facility

Other: Very large ships NewGRF, Bilbo's multiplayer patch pack v5 (for OpenTTD 0.7.3)
User avatar
NekoMaster
Tycoon
Tycoon
Posts: 4001
Joined: 16 Aug 2008 22:26
Skype: neko-master
Location: Oshawa, Ontario, CANADA

Re: Updated extra-large-maps patch, version 8 (for r13664)

Post by NekoMaster »

Hey, is there any recent patched win32 bins available? BTW dont tell me to patch myself, my PC is so s*** it overheats watching you tube videos (WTF!)
Image Proud Canadian Image
Nekomasters Projects! (Downloads available on BaNaNaS!) \(>^w^<)/
# NARS ADD-ON SET 2CC | 2cc Rapid Transit For Me! (2ccRTFM) | 2cc Wagons In NML (2ccWIN)
# NML Category System (Organize your GRFS!) <- TT-Forums Exclusive Download!
SmatZ
OpenTTD Developer
OpenTTD Developer
Posts: 351
Joined: 03 Oct 2006 18:26
Location: Prague, Czech Republic
Contact:

Re: Updated extra-large-maps patch, version 8 (for r13664)

Post by SmatZ »

NekoMaster, "slow computer" is not an excuse:
http://www.tt-forums.net/viewtopic.php? ... 32#p761732 :-p

btw, nice to see Bilbo is still replying in this thread :)
Image
User avatar
NekoMaster
Tycoon
Tycoon
Posts: 4001
Joined: 16 Aug 2008 22:26
Skype: neko-master
Location: Oshawa, Ontario, CANADA

Re: Updated extra-large-maps patch, version 8 (for r13664)

Post by NekoMaster »

SmatZ wrote:NekoMaster, "slow computer" is not an excuse:
http://www.tt-forums.net/viewtopic.php? ... 32#p761732 :-p
Yes it IS! F*** How come no one ever beleives me! Theres nothing I can do about this peice of S**T, and its getting so bad that it over heats just watching a flash video or playing a flash game (like Pandemic II)

Why wont any one ever compile just a binary? What happened to nice people making precompiled binarys for others? Are you all such @$$ holes that you can do this one simple task?
I was asking nice before, in fact the dude (I forgot the name) on the other thread said that he would compile a Binary if anyone asked for it.
Image Proud Canadian Image
Nekomasters Projects! (Downloads available on BaNaNaS!) \(>^w^<)/
# NARS ADD-ON SET 2CC | 2cc Rapid Transit For Me! (2ccRTFM) | 2cc Wagons In NML (2ccWIN)
# NML Category System (Organize your GRFS!) <- TT-Forums Exclusive Download!
DaleStan
TTDPatch Developer
TTDPatch Developer
Posts: 10285
Joined: 18 Feb 2004 03:06
Contact:

Re: Updated extra-large-maps patch, version 8 (for r13664)

Post by DaleStan »

NekoMaster wrote:What happened to nice people making precompiled binarys for others? Are you all such @$$ holes that you can do this one simple task?

I was asking nice before,
What happened to accepting a "no" gracefully?
To get a good answer, ask a Smart Question. Similarly, if you want a bug fixed, write a Useful Bug Report. No TTDPatch crashlog? Then follow directions.
Projects: NFORenum (download) | PlaneSet (Website) | grfcodec (download) | grfdebug.log parser
User avatar
Gremnon
Tycoon
Tycoon
Posts: 1517
Joined: 16 Sep 2005 12:23
Skype: the_gremnon
Location: /home
Contact:

Re: Updated extra-large-maps patch, version 8 (for r13664)

Post by Gremnon »

It was me, and I also said because of your attitude, not to ask me again. Slow computer isn't an excuse, if you have patience.
Conditional Zenith
Chief Executive
Chief Executive
Posts: 697
Joined: 10 Jun 2003 00:19
Location: Australia

Re: Updated extra-large-maps patch, version 8 (for r13664)

Post by Conditional Zenith »

NekoMaster: I think you will find people are more sympathetic if you aren't so demanding and stop calling people a***oles, s****eads, or bitches when they say no.
Terkhen
OpenTTD Developer
OpenTTD Developer
Posts: 1034
Joined: 11 Sep 2008 07:32
Location: Spain

Re: Updated extra-large-maps patch, version 8 (for r13664)

Post by Terkhen »

NekoMaster: I suppose your computer is also too slow for checking the previous page of this thread. That's a shame because I posted a compiled binary updated to r15327 there. With "polite" requests like yours, I wonder why I took the time to update the patch to trunk and post a compiled binary.
User avatar
Bilbo
Tycoon
Tycoon
Posts: 1710
Joined: 06 Jun 2007 21:07
Location: Czech Republic

Re: Updated extra-large-maps patch, version 8 (for r13664)

Post by Bilbo »

SmatZ wrote:NekoMaster, "slow computer" is not an excuse:
http://www.tt-forums.net/viewtopic.php? ... 32#p761732 :-p

btw, nice to see Bilbo is still replying in this thread :)
Wjile I am not actively developing OpenTTD (I have lot of work elsewhere), I am still monitoring what is happening here... perhaps if current OTTD devs will be interested in the patch (or any of my other patches), I might update/improve it ...
If you need something, do it yourself or it will be never done.

My patches: Extra large maps (1048576 high, 1048576 wide) (FS#1059), Vehicle + Town + Industry console commands (FS#1060), few minor patches (FS#2820, FS#1521, FS#2837, FS#2843), AI debugging facility

Other: Very large ships NewGRF, Bilbo's multiplayer patch pack v5 (for OpenTTD 0.7.3)
Eddi
Tycoon
Tycoon
Posts: 8272
Joined: 17 Jan 2007 00:14

Re: Updated extra-large-maps patch, version 8 (for r13664)

Post by Eddi »

May i nominate a person for the *PLONK*-Awards 2009?
User avatar
planetmaker
OpenTTD Developer
OpenTTD Developer
Posts: 9432
Joined: 07 Nov 2007 22:44
Location: Sol d

Re: Updated extra-large-maps patch, version 8 (for r13664)

Post by planetmaker »

That nomination would get my vote :)
Starbud
Traffic Manager
Traffic Manager
Posts: 211
Joined: 05 Mar 2007 00:48
Location: Sweden
Contact:

Re: Updated extra-large-maps patch, version 8 (for r13664)

Post by Starbud »

What is a PLONK award?
http://openttd.org - i love building stuff :)
Someones play with pics http://dimalimsliv.blogg.se
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 40 guests