YAPP - Yet Another PBS Patch (now in trunk!)

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

Tekky
Route Supervisor
Route Supervisor
Posts: 420
Joined: 19 Dec 2006 04:24

Re: YAPP - Yet Another PBS Patch (now in trunk!)

Post by Tekky »

I like Brianetta's suggestion of "routing signals". However, this could maybe be confused with TTDPatch's programmable signals which offer conditional routing.... Therefore, I do still prefer the term "PBS signals" slightly.

It was said that OpenTTD's YAPP signals were different to TTDPatch's PBS signals. I disagree with this. They are nearly the same, especially since the introduction of TTDPatch through signals.
User avatar
AndersI
Tycoon
Tycoon
Posts: 1732
Joined: 19 Apr 2004 20:09
Location: Sweden
Contact:

Re: YAPP - Yet Another PBS Patch (now in trunk!)

Post by AndersI »

SWP of course :-)
For Safe Waiting Point.
jaybud4
Engineer
Engineer
Posts: 116
Joined: 16 Feb 2008 06:13

Re: YAPP - Yet Another PBS Patch (now in trunk!)

Post by jaybud4 »

Okay, I'm not looking thru 47 pages.
Anybody got any information on how to use these beasts successfully?
I've only managed to get gridlock after gridlock on my lines... :\
EDIT: Here's my best attempt so far.
It's kinda based off of an interstate/freeway.
The middle two lines are the fast lanes that go through the entire line. The outer two break off at each exit as shown.
Seems to work out okay so far.
Linked because the image is rather large.
http://img.photobucket.com/albums/v139/ ... 1975-1.png
Yes, I realize that station is only accessible/leaves from the one direction.
That was intended.
Image
If you're bugged by anything I say/do: Please send me a PM. I don't always watch every thread I post in after I do so.
Spingo
Engineer
Engineer
Posts: 15
Joined: 12 Jul 2007 00:43
Location: SydAU

Re: YAPP - Yet Another PBS Patch (now in trunk!)

Post by Spingo »

You don't need to look through 47 pages - just look in the wiki - http://wiki.openttd.org/index.php/YAPP

The main problem that I see in your screenshot is the lack of a signal immediately before/after each platform on the station, and the placement of a signal at the exit of the merge. You need to place PBS signals at safe waiting locations.
May your cheese be tasty!
User avatar
Brianetta
Tycoon
Tycoon
Posts: 2566
Joined: 15 Oct 2003 22:00
Location: Jarrow, UK
Contact:

Re: YAPP - Yet Another PBS Patch (now in trunk!)

Post by Brianetta »

Spingo is right. Every time you place a PBS signal, ask yourself, "Do I really want a train to wait here?" If you don't, don't place the signal. Remember, trains can go both ways through the signals, but won't ever wait at the back side of one.
PGP fingerprint: E66A 9D58 AA10 E967 41A6 474E E41D 10AE 082C F3ED
Tekky
Route Supervisor
Route Supervisor
Posts: 420
Joined: 19 Dec 2006 04:24

Re: YAPP - Yet Another PBS Patch (now in trunk!)

Post by Tekky »

Spingo wrote:The main problem that I see in your screenshot is the lack of a signal immediately before/after each platform on the station, and the placement of a signal at the exit of the merge.
Signals in front of station platforms are no longer necessary. However, the signal at the exit of the merge should clearly be removed, as it is not a safe waiting location.
Tekky
Route Supervisor
Route Supervisor
Posts: 420
Joined: 19 Dec 2006 04:24

Re: YAPP - Yet Another PBS Patch (now in trunk!)

Post by Tekky »

I have started a new thread about renaming YAPP "advanced signals". Please post all further discussion about this topic in my new thread and not in this thread.

EDIT: I have just started a poll in the thread mentioned above about whether and how "advanced signals" should be renamed. Current poll results are 9 to 1 in favor of renaming the signals. Most votes have been cast for renaming them to "PBS signals" or "path signals", however the poll has only just started. You are welcome to also take part in the poll. :-)
Last edited by Tekky on 15 Aug 2008 12:34, edited 4 times in total.
tut
Engineer
Engineer
Posts: 9
Joined: 14 Aug 2008 01:29

Re: YAPP - Yet Another PBS Patch (now in trunk!)

Post by tut »

Could someone make YAPP v9 patch for 0.6.2 openttd release if possible?
Tekky
Route Supervisor
Route Supervisor
Posts: 420
Joined: 19 Dec 2006 04:24

Re: YAPP - Yet Another PBS Patch (now in trunk!)

Post by Tekky »

YAPP 9 was made taking the current code structure of the latest nightly build into account. I guess it would be many hours of work to port it to 0.6.2. Why don't you just download the latest nightly build, in which YAPP is included?
jaybud4
Engineer
Engineer
Posts: 116
Joined: 16 Feb 2008 06:13

Re: YAPP - Yet Another PBS Patch (now in trunk!)

Post by jaybud4 »

Just download the latest nightly.
It's not like it's a noticeable stability difference.
In fact, the nightly is probably even MORE stable..
Image
If you're bugged by anything I say/do: Please send me a PM. I don't always watch every thread I post in after I do so.
tut
Engineer
Engineer
Posts: 9
Joined: 14 Aug 2008 01:29

Re: YAPP - Yet Another PBS Patch (now in trunk!)

Post by tut »

Tekky wrote:I guess it would be many hours of work to port it to 0.6.2.
As I can see there was similar patch for openttd v0.6.0 and yapp v5.
Tekky
Route Supervisor
Route Supervisor
Posts: 420
Joined: 19 Dec 2006 04:24

Re: YAPP - Yet Another PBS Patch (now in trunk!)

Post by Tekky »

I certainly don't recommend using YAPP 5, as it is very buggy compared to the version of YAPP in the latest nightly.

If you want to stay with OpenTTD 0.6.2 for stability concerns, I can assure you that the latest nightly build is much more stable than any attempt to port YAPP to OpenTTD 0.6.2.
tut
Engineer
Engineer
Posts: 9
Joined: 14 Aug 2008 01:29

Re: YAPP - Yet Another PBS Patch (now in trunk!)

Post by tut »

Tekky wrote:If you want to stay with OpenTTD 0.6.2 for stability concerns, I can assure you that the latest nightly build is much more stable than any attempt to port YAPP to OpenTTD 0.6.2.
Actually I'd like to add the yapp patch as an option to FreeBSD port of openttd. Only official releases are used there usually.
jaybud4
Engineer
Engineer
Posts: 116
Joined: 16 Feb 2008 06:13

Re: YAPP - Yet Another PBS Patch (now in trunk!)

Post by jaybud4 »

tut wrote:
Tekky wrote:If you want to stay with OpenTTD 0.6.2 for stability concerns, I can assure you that the latest nightly build is much more stable than any attempt to port YAPP to OpenTTD 0.6.2.
Actually I'd like to add the yapp patch as an option to FreeBSD port of openttd. Only official releases are used there usually.
The nightlies ARE official releases, for all intents and purposes.
They're releases by definition... And definitely official...
^Hahaa. Stupid pun.
Image
If you're bugged by anything I say/do: Please send me a PM. I don't always watch every thread I post in after I do so.
Rubidium
OpenTTD Developer
OpenTTD Developer
Posts: 3815
Joined: 09 Feb 2006 19:15

Re: YAPP - Yet Another PBS Patch (now in trunk!)

Post by Rubidium »

tut wrote:Actually I'd like to add the yapp patch as an option to FreeBSD port of openttd. Only official releases are used there usually.
I hope you are aware of the fact that IF you backport the YAPP patch that it's pointless to call the OpenTTD in FreeBSD 0.6.2 because it is so network incompatible that I can guarantee network trouble and savegames that can't be loaded.
tut
Engineer
Engineer
Posts: 9
Joined: 14 Aug 2008 01:29

Re: YAPP - Yet Another PBS Patch (now in trunk!)

Post by tut »

Rubidium wrote:
tut wrote:Actually I'd like to add the yapp patch as an option to FreeBSD port of openttd. Only official releases are used there usually.
I hope you are aware of the fact that IF you backport the YAPP patch that it's pointless to call the OpenTTD in FreeBSD 0.6.2 because it is so network incompatible that I can guarantee network trouble and savegames that can't be loaded.
As I said the yapp patch will be a build option turned off by default.
User avatar
planetmaker
OpenTTD Developer
OpenTTD Developer
Posts: 9432
Joined: 07 Nov 2007 22:44
Location: Sol d

Re: YAPP - Yet Another PBS Patch (now in trunk!)

Post by planetmaker »

tut wrote:
Rubidium wrote:
tut wrote:Actually I'd like to add the yapp patch as an option to FreeBSD port of openttd. Only official releases are used there usually.
I hope you are aware of the fact that IF you backport the YAPP patch that it's pointless to call the OpenTTD in FreeBSD 0.6.2 because it is so network incompatible that I can guarantee network trouble and savegames that can't be loaded.
As I said the yapp patch will be a build option turned off by default.
Even then. It has (new) patch options, thus making it incompatible with any binary which does not have this patch. Better go for the clean solution, grab one of the latest nightlies and use that.
tut
Engineer
Engineer
Posts: 9
Joined: 14 Aug 2008 01:29

Re: YAPP - Yet Another PBS Patch (now in trunk!)

Post by tut »

planetmaker wrote:
tut wrote:
Rubidium wrote:As I said the yapp patch will be a build option turned off by default.
Even then. It has (new) patch options, thus making it incompatible with any binary which does not have this patch. Better go for the clean solution, grab one of the latest nightlies and use that.
It is much more worse for one who plays multiplayer game to build yapp with some nightly build. But if there will be openttd v.0.6.2 FreeBSD port with optional yapp, it is easy to find people with the same version to play multiplayer.
User avatar
planetmaker
OpenTTD Developer
OpenTTD Developer
Posts: 9432
Joined: 07 Nov 2007 22:44
Location: Sol d

Re: YAPP - Yet Another PBS Patch (now in trunk!)

Post by planetmaker »

tut wrote:It is much more worse for one who plays multiplayer game to build yapp with some nightly build. But if there will be openttd v.0.6.2 FreeBSD port with optional yapp, it is easy to find people with the same version to play multiplayer.
YAPP is integrated in the nightly. Thus you just need a clean nightly and you're fine, no patching required. And a patched 0.6.2 is a different version than 0.6.2 no matter how you twist or call it.

Also, integrating YAPP into the source of 0.6.2 requires backporting yapp to that version, and either
- making available the binaries (for different platforms)
- making available the source and patch or both already integrated
- or (much worse and no fun) hacking the network code such that unmodified clients can join on the cost that they will desync within very short time as they run on a different source than the server. YAPP is not a client or server-only patch. Both server and client need it.

The FAR easier way is to supply the binaries for that nightly release you run - actually binaries are available from the OpenTTD website for download for the last few nightlies.

If you still believe it's a good idea to patch YAPP into 0.6.2 and call it (wrongly a clean) 0.6.2: go ahead - I'm sure your players are in for a lot of trouble - or you supply patched binaries in which case you could supply nightly binaries for far less work.

If, on the other hand, you play a game with YAPP switched off - fine, but why then patch in the first place?
peter1138
OpenTTD Developer
OpenTTD Developer
Posts: 1728
Joined: 30 Mar 2005 09:43

Re: YAPP - Yet Another PBS Patch (now in trunk!)

Post by peter1138 »

I just hope tut is not the FreeBSD port maintainer. :)
He's like, some kind of OpenTTD developer.
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 6 guests