Total Bridge Renewal Set: version 1.12

Discuss, get help with, or post new graphics for TTDPatch and OpenTTD, using the NewGRF system, here. Graphics for plain TTD also acceptable here.

Moderator: Graphics Moderators

User avatar
thgergo
Route Supervisor
Route Supervisor
Posts: 391
Joined: 29 Mar 2005 12:44
Location: Hungary

Re: Total Bridge Renewal Set: version 1.1 Released!

Post by thgergo »

ok, the bug has been caught, anyway it was my mistake too, I have reduced the maximum length accidently for the viaduct to 0F=(16), 18 in real with 2 ramps. And OTTD has begun failing with longer bridges than 18. If the first bridge is cant be bought due to length problems, the further bridges will fail too. Ill have to make some bug report with this :P Anyway expect a v1.11 soon for the fix.
The attached version should fix your problems.
Also, TTDpatch seems doesn't have this bug.
Attachments
total_bridges.grf
v.1.11
(450.91 KiB) Downloaded 1634 times
fds
fds
v111.PNG (267.04 KiB) Viewed 20579 times
Image
Image
User avatar
STT Transport
Chairman
Chairman
Posts: 880
Joined: 22 Feb 2008 11:26
Location: Vriezenveen, The Netherlands

Re: Total Bridge Renewal Set: version 1.11 Released!

Post by STT Transport »

Cool, thats very good work! :D
Maybey next time you most post the grf on you first post ??
Anaway go on! :D (with the set!)
"A million years into the sky is Ra, Sun God. Sealed and buried for all time, his Stargate."
User avatar
OczeQ
Engineer
Engineer
Posts: 29
Joined: 16 Nov 2005 21:41
Location: Gliwice, Poland
Contact:

Re: Total Bridge Renewal Set: version 1.11 Released!

Post by OczeQ »

Thanks thgergo, it works nice now 8)
Image
User avatar
ISA
Tycoon
Tycoon
Posts: 3384
Joined: 17 Oct 2005 20:56
Location: Estonia

Re: Total Bridge Renewal Set: version 1.11 Released!

Post by ISA »

As I can see these bug fixes don't fix my problem to use those nice bridges in earlier nightlys? But ok no rush :) just asking
User avatar
thgergo
Route Supervisor
Route Supervisor
Posts: 391
Joined: 29 Mar 2005 12:44
Location: Hungary

Re: Total Bridge Renewal Set: version 1.11 Released!

Post by thgergo »

ISA wrote:As I can see these bug fixes don't fix my problem to use those nice bridges in earlier nightlys? But ok no rush :) just asking
Can you give the error dialog again? I thought skipping the corresponding sprites fixes the issue. Can you give a shot like you have done it earlier?
Image
Image
User avatar
ISA
Tycoon
Tycoon
Posts: 3384
Joined: 17 Oct 2005 20:56
Location: Estonia

Re: Total Bridge Renewal Set: version 1.11 Released!

Post by ISA »

thgergo wrote:
ISA wrote:As I can see these bug fixes don't fix my problem to use those nice bridges in earlier nightlys? But ok no rush :) just asking
Can you give the error dialog again? I thought skipping the corresponding sprites fixes the issue. Can you give a shot like you have done it earlier?
Oky toky. When I get behind my computer I send it to You
DaleStan
TTDPatch Developer
TTDPatch Developer
Posts: 10285
Joined: 18 Feb 2004 03:06
Contact:

Re: Total Bridge Renewal Set: version 1.11 Released!

Post by DaleStan »

Invalid ID. You're likely not skipping all the relevant sprites.
To get a good answer, ask a Smart Question. Similarly, if you want a bug fixed, write a Useful Bug Report. No TTDPatch crashlog? Then follow directions.
Projects: NFORenum (download) | PlaneSet (Website) | grfcodec (download) | grfdebug.log parser
User avatar
thgergo
Route Supervisor
Route Supervisor
Posts: 391
Joined: 29 Mar 2005 12:44
Location: Hungary

Re: Total Bridge Renewal Set: version 1.11 Released!

Post by thgergo »

DaleStan wrote:Invalid ID. You're likely not skipping all the relevant sprites.
It does skip that relevant sprites, I assume TTDpatch checks skipped actions too :!: To prove myself, if I invert the skipping action, skip the invalid sprites in OTTD not in TTDpatch, it gives no replaced tubular bridgeheads, so the skipping condition is executed.
Attachments
skipping.PNG
skipping.PNG (40.55 KiB) Viewed 1994 times
Image
Image
User avatar
OzTrans
Tycoon
Tycoon
Posts: 1680
Joined: 04 Mar 2005 01:07

Re: Total Bridge Renewal Set: version 1.11 Released!

Post by OzTrans »

thgergo wrote:It does skip that relevant sprites, ...
You should use an action-9 instead of 7 ...
User avatar
thgergo
Route Supervisor
Route Supervisor
Posts: 391
Joined: 29 Mar 2005 12:44
Location: Hungary

Re: Total Bridge Renewal Set: version 1.11 Released!

Post by thgergo »

OzTransLtd wrote:
thgergo wrote:It does skip that relevant sprites, ...
You should use an action-9 instead of 7 ...
Hmm, that should be the solution
Image
Image
User avatar
thgergo
Route Supervisor
Route Supervisor
Posts: 391
Joined: 29 Mar 2005 12:44
Location: Hungary

Re: Total Bridge Renewal Set: version 1.11 Released!

Post by thgergo »

Ok, yet another bugfix comes v1.12, this just fixes the skipping problem, it does nothing with OTTD, so most of you don't need to dl this, this fixes the compatibility with older TTDpatch versions r1895 and lower. The posted version is tested with that version TTDpatch, so it should work for you ISA.
Attachments
total_bridges.grf
v.1.12
(450.91 KiB) Downloaded 12857 times
v112.PNG
v112.PNG (267.15 KiB) Viewed 31217 times
Image
Image
User avatar
STT Transport
Chairman
Chairman
Posts: 880
Joined: 22 Feb 2008 11:26
Location: Vriezenveen, The Netherlands

Re: Total Bridge Renewal Set: version 1.12 -TTDpatch r1895 works

Post by STT Transport »

[OT]Just a question, witch grf do you use for the underground ?? (i mean the grass ??)[/OT]
EDIT:
I found them after a long search :P
BTW: The bridges are still awasome :D
Last edited by Lakie on 24 Jun 2008 13:56, edited 1 time in total.
Reason: Please don't use bright red...
"A million years into the sky is Ra, Sun God. Sealed and buried for all time, his Stargate."
User avatar
Beardie
Tycoon
Tycoon
Posts: 2029
Joined: 12 Apr 2008 19:38
Skype: rbeardwell91
Location: Buckshaw Village, Lancashire, UK

Re: Total Bridge Renewal Set: version 1.12 -TTDpatch r1895 works

Post by Beardie »

Can someone tell me if the 18 tile bridge limit has been fixed, becuase on mine it hasn't just a bit confused with the posts. (This is for OpenTTD)
Previously Known As Beardie27
Check out my UPDATED! Screenshot Thread
Check out my Railway Photography and Deviant Account


Image
fjb
Engineer
Engineer
Posts: 86
Joined: 08 Oct 2007 11:20

Re: Total Bridge Renewal Set: version 1.12 -TTDpatch r1895 works

Post by fjb »

Hi,

(svn r13611) -Fix [FS#2100]: if the first bridge can't be build for a given length, then none of the other bridges can. Effectively meaning that if someone replaces the first bridge with a bridge that can be only 3 tiles longs then only other bridges that can be 3 tiles long will be buildable, but only if they are 3 tiles long.
Regards
Frank
User avatar
Beardie
Tycoon
Tycoon
Posts: 2029
Joined: 12 Apr 2008 19:38
Skype: rbeardwell91
Location: Buckshaw Village, Lancashire, UK

Re: Total Bridge Renewal Set: version 1.12 -TTDpatch r1895 works

Post by Beardie »

fjb wrote:Hi,

(svn r13611) -Fix [FS#2100]: if the first bridge can't be build for a given length, then none of the other bridges can. Effectively meaning that if someone replaces the first bridge with a bridge that can be only 3 tiles longs then only other bridges that can be 3 tiles long will be buildable, but only if they are 3 tiles long.
That sounds like a riddle or something, i am assuming this was fixed in r13611 then because i have r13519. Unless anyone can give me a understandable answer
Previously Known As Beardie27
Check out my UPDATED! Screenshot Thread
Check out my Railway Photography and Deviant Account


Image
Roujin
Tycoon
Tycoon
Posts: 1884
Joined: 08 Apr 2007 04:07

Re: Total Bridge Renewal Set: version 1.12 -TTDpatch r1895 works

Post by Roujin »

This was a direct quote from the svn logs, not a riddle. ;) It's the message of commit r13611, so you're right with your assumption.
* @Belugas wonders what is worst... a mom or a wife...
<Lakie> Well, they do the same thing but the code is different.

______________
My patches
check my wiki page (sticky button) for a complete list

ImageImage
ImageImageImageImageImageImageImage
User avatar
thgergo
Route Supervisor
Route Supervisor
Posts: 391
Joined: 29 Mar 2005 12:44
Location: Hungary

Re: Total Bridge Renewal Set: version 1.12 -TTDpatch r1895 works

Post by thgergo »

Beardie27 wrote:
fjb wrote:Hi,

(svn r13611) -Fix [FS#2100]: if the first bridge can't be build for a given length, then none of the other bridges can. Effectively meaning that if someone replaces the first bridge with a bridge that can be only 3 tiles longs then only other bridges that can be 3 tiles long will be buildable, but only if they are 3 tiles long.
That sounds like a riddle or something, i am assuming this was fixed in r13611 then because i have r13519. Unless anyone can give me a understandable answer
That problem also fixed in TBRS 1.12 also...
Image
Image
User avatar
Beardie
Tycoon
Tycoon
Posts: 2029
Joined: 12 Apr 2008 19:38
Skype: rbeardwell91
Location: Buckshaw Village, Lancashire, UK

Re: Total Bridge Renewal Set: version 1.12 -TTDpatch r1895 works

Post by Beardie »

Well i didn't download v1.12 because i thought it was just a TTDpatch update in it, and i haven't got round to updating to the latest nightly, Thanks guys :D
Previously Known As Beardie27
Check out my UPDATED! Screenshot Thread
Check out my Railway Photography and Deviant Account


Image
Post Reply

Return to “Graphics Development”

Who is online

Users browsing this forum: No registered users and 26 guests