Patch: AutoRoad Tool (in trunk since r11339)

[Digitalfox]

This last days good new features have made into trunk, congratulations to everybody involved and nice work

[Octopussy]

Fantastic

it is in trunk

Commit by rubidium :: r11339 /trunk/ (7 files in 4 dirs):
-Add: autoroad; same as autorail, but for road and trams and only on X and Y direction. Patch by Octopussy and skidd13.

[Roujin]

first off, congratulations another small thing i always thought of "why don't we actually have this? this would be so nice!"

I see that your patch made it to trunk, so congratulations and thank you to both of you and rubidium. Nevertheless I have small suggestion, would it be possible to indicate, on which part of tile is the road going to be build(like autorail tool shows)?

may i forward this suggestion?
right now it's sometimes still a little dodgy to use, especially for very small bits of road, because you don't see what you're doing until it's too late. (and here CTRL doesn't toggle remove, like it does with rail, so it's more annoying to remove mistakes )

[Octopussy]

OK now another problem..

I have find several errors in road gui code :
There is a double confusion in the file road_gui.cpp about X, Y, NE and NW direction.

In the code we have :
NE for Y direction and NW for X direction

But this is wrong. We should have, like another orientation and the rail_gui.cpp file :
NE for X direction and NW for Y direction

I have made a patch in order to correct this problem and clarify the code.

[skidd13]

It's not directly a confusion. But you are right it's a inconsisty.
If you change all the stuff, you have to change "DDSP_PLACE_ROAD_NE" and the other regarding inconsistent stuff too. Otherwise the inconsisty will move, but stay.

Aside: IIRC we are dealing with half road bits here too. So naming only one (the upper one from the look at the screen view) bit of the whole (lets say ROAD_NE from ROAD_X) it might be ok as it is. But thats a lazy nitpick comment. Ignore it!

[Roujin]

I really miss a preview function like the autorail has. So i thought maybe it's just a matter of not available sprites and if i make some, maybe a coder will implement it.

So here it is. Hope someone will make something out of it

edit: i have used the sizes from the standard ground tiles, just so you know

[Leviath.NL]

I couldn't resist to edit it:

autoroad.png (2.18 KiB) Viewed 3031 times

[Leviath.NL]

I made a grf of the sprites, It probably isn't complete because slopes with foundation need different xrel & yrel. (doesn't it?)

[Roujin]

hi, thanks for coding mine too your solution is probably better, I'd just remove one of the stripes in the middle of the "dead end"-tiles, since the original road sprites also have just one stripe there. You know what i mean?

I suppose adding your .grf does nothing yet, am i right? One would still need someone to change the source code accordingly, right?

[Leviath.NL]

I looked into the source and as far as I can see, with very limited coding capability, it is not coded yet. The grf only contains real sprites and has no functionality whatsoever. About your suggestion, I indeed planned on doing it but forget, I'll upload a new grf soon.

edit:
added updated grf:

autoroad.png (2.01 KiB) Viewed 2864 times

edit2:
nfo had a typo, updated all grf's

[Roujin]

Well i thought about looking at it myself, maybe i could even manage something because i could probably steal a lot from the autorail code. But actually i have to hold a speech about some topic @university tomorrow, i shouldn't really divert my mind from that by doing something complicated

plus my girlfriend is over and she'd probably be mad at me if i spend the night at my computer xD

[Octopussy]

It's not directly a confusion. But you are right it's a inconsisty.
If you change all the stuff, you have to change "DDSP_PLACE_ROAD_NE" and the other regarding inconsistent stuff too. Otherwise the inconsisty will move, but stay.

I don't think my patch correction is useless.
I have make some pictures in order to show you the problem :

There is a confusion in the gui and another one in the code (not only in the gui)
So it is a double confusion.

[Detal]

Autoroad tool for road and tramsroad construction, like the autorail one.

You can build road in each direction you want (x and y)

Based on SVN 11307

Hey dude,
how do you integrate this tool?

[planetmaker]

The title says "in trunk since r11339". It's already there by default.