Improved smooth_economy patch

MagicBuzz · **Posted:** Sat Jan 27, 2007 7:55 pm

As I thought, it work fine.

Just replace in "ExtChangeIndustryProduction(Industry *i)" located in industry_cmd.cpp :

Code:

            if (mag >= 10) {
               SetDParam(2, mag);
               SetDParam(0, _cargoc.names_s[i->produced_cargo[j]]);
               SetDParam(1, i->index);
               AddNewsItem(
                  percent >= 0 ? STR_INDUSTRY_PROD_GOUP : STR_INDUSTRY_PROD_GODOWN,
                  NEWS_FLAGS(NM_THIN, NF_VIEWPORT|NF_TILE, NT_ECONOMY, 0),
                  i->xy + TileDiffXY(1, 1), 0
               );
            }

by

Code:

            mag = abs(percent);
            if (mag >= 10 && (HASBIT(i->town->have_ratings, _local_player) || i->town->exclusivity == _local_player)) {
               SetDParam(2, mag);
               SetDParam(0, _cargoc.names_s[i->produced_cargo[j]]);
               SetDParam(1, i->index);
               AddNewsItem(
                  percent >= 0 ? STR_INDUSTRY_PROD_GOUP : STR_INDUSTRY_PROD_GODOWN,
                  NEWS_FLAGS(NM_THIN, NF_VIEWPORT|NF_TILE, NT_ECONOMY, 0),
                  i->xy + TileDiffXY(1, 1), 0
               );
            }

Here is a patch file :

http://magicsite.manga-torii.com/files/ ... cities.zip

SirkoZ · **Posted:** Sat Jan 27, 2007 8:21 pm

I'm glad you like the patch.

Yes, the numerous messages tend to be very annoying, to me too...
Usually I just turn the economy messages OFF (under the "Message Settings").

I thought about making the messages of only player-used industries to be visible to a certain player but I'm not really sure how I'd go about it.

I'll look some more at the source, but please be patient, as my programming knowledge is quite basic.

SirkoZ · **Posted:** Sat Jan 27, 2007 8:22 pm

Wow - thank you - looks like you have posted a new message while I was still typing the above one.

I'll try that and include it.

Thank you very much!

EDIT: I just may post it tomorrow (sunday) - it's evening here and I am sleepy - I'll rather get at it tomorrow and also update the other patches.

Thanks again.

MagicBuzz · **Posted:** Sat Jan 27, 2007 8:38 pm

SirkoZ wrote:

Wow - thank you

Thank you very much!

Thanks again.

No problem, I did it for me

SirkoZ · **Posted:** Sun Jan 28, 2007 7:40 am

Well I'm sure other players will appreciate it.

Anyways here's version 2.8 of the patch - that message filtering deserves a revision upgrade.

SirkoZ · **Posted:** Sun Jul 29, 2007 12:16 am

Mainly different approach.....here's the v3.0 (2.9 was a non-release although fully functional):

EDIT: the 0% transported behaviour was too radical in 3.0 - so it's fixed now - 3.0c
(also chances are a bit higher now):

clark17 · **Joined:** Thu Oct 18, 2007 11:46 am **Posts:** 4

It there has a chance to see it in the trunk?

George · **Posted:** Fri Oct 19, 2007 7:01 pm

Sorry for a question, but
Can industry prop 13 (var 93) have values other than 00, 04, 08, 10, 20, 40, 80?

DaleStan · **Joined:** Wed Feb 18, 2004 3:06 am **Posts:** 10285

George wrote:

Can industry prop 13 (var 93)

Industry prop 13 is cargo-specific.
Industry variable 93 is not cargo-specific.

Of which do you speak?

SirkoZ · **Posted:** Fri Oct 19, 2007 8:28 pm

clark17 wrote:

It there has a chance to see it in the trunk?

I honestly don't know.

SirkoZ · **Posted:** Fri Oct 19, 2007 8:29 pm

George wrote:

Sorry for a question, but
Can industry prop 13 (var 93) have values other than 00, 04, 08, 10, 20, 40, 80?

No clue - DaleStan is the one to tell you the grf specifics. I only deal with the behaviour, not grf compatibility.

George · **Posted:** Fri Oct 19, 2007 8:57 pm

DaleStan wrote:

George wrote:

Can industry prop 13 (var 93)

Industry prop 13 is cargo-specific.
Industry variable 93 is not cargo-specific.
Of which do you speak?

Sorry for not clean question
51766 [36][5A] Industry array (+90 entries), locations within each entry follow:
Offset Size Meaning
13 B Production multiplier, always either 00 (which means the industry has announced imminent closure) or an integer power of 2. 10 is the default, 04 is the minimum, 80 is the maximum.

belugas · **Posted:** Fri Oct 19, 2007 9:01 pm

I think it is only a powerof 2, indeed.
I'll check when i can

George · **Posted:** Sat Oct 20, 2007 6:06 am

belugas wrote:

I think it is only a powerof 2, indeed.
I'll check when i can

It may be useful to use other values to indicate for the GRF that the value is smooth.

DaleStan · **Joined:** Wed Feb 18, 2004 3:06 am **Posts:** 10285

George wrote:

51766 [36][5A] Industry array (+90 entries), locations within each entry follow:
Offset Size Meaning
13 B Production multiplier, always either 00 (which means the industry has announced imminent closure) or an integer power of 2. 10 is the default, 04 is the minimum, 80 is the maximum.

Absolutely everything GRF-accessible that listed in that document is a variable. *EVERYTHING!* Stop calling them properties. They aren't.

Properties are the things you put in an action 0.

George · **Posted:** Sun Oct 21, 2007 5:09 am

DaleStan wrote:

George wrote:

51766 [36][5A] Industry array (+90 entries), locations within each entry follow:
Offset Size Meaning
13 B Production multiplier, always either 00 (which means the industry has announced imminent closure) or an integer power of 2. 10 is the default, 04 is the minimum, 80 is the maximum.

Absolutely everything GRF-accessible that listed in that document is a variable. *EVERYTHING!* Stop calling them properties. They aren't.
Properties are the things you put in an action 0.

Sorry
Back on topic. Values in var 93 could take a more wide range of values in OTTD. GRFs could use it. What do you think?

SirkoZ · **Posted:** Mon Nov 26, 2007 1:42 am

Newsflash - since r11500 - my smooth_economy patch has been included in the trunk, although not 3.0c but 3.0w - its behavior is still the same old good one that was known for my patches but it's really simple and "clean".

Of course as always, there can be improvements, de-coupl-ings and such, but it's in and it's behaving, that's the most important.

Thank you to all that have helped me through the years with your suggestions/advices for this small but useful patch. And of course - thank you, Belugas, who reviewed and approved it.

Octopussy · **Joined:** Mon May 01, 2006 9:57 pm **Posts:** 122

SirkoZ wrote:

Newsflash - since r11500 - my smooth_economy patch has been included in the trunk, although not 3.0c but 3.0w - its behavior is still the same old good one that was known for my patches but it's really simple and "clean".

Of course as always, there can be improvements, de-coupl-ings and such, but it's in and it's behaving, that's the most important.

Thank you to all that have helped me through the years with your suggestions/advices for this small but useful patch. And of course - thank you, Belugas, who reviewed and approved it.

Well Done !!

it might be thought to add [in trunk] in the main post of this topic and update this page of the OpenTTD Manual : http://wiki.openttd.org/index.php/Economy

And what's the difference with this another project branch : http://wiki.openttd.org/index.php/New_E ... _Balancing ?

SirkoZ · **Posted:** Tue Nov 27, 2007 1:11 am

Yes, I will update that wiki page tomorrow and also the title here.

Transport Tycoon Forums

Improved smooth_economy patch

Who is online