Face customization patch - TESTING requested!

[jez]

Hi all,

This thread is to keep track of the progress of my face customization patch. The latest version and an associated screenshot will be maintained in this first post. I'm always welcoming any testing with bug reports and/or suggestions for improvement.

As you can see in the screenshot it allows extensive face customization, saving/loading of the current face to a config file variable, and a manual view/input of the current 'face code' (a 32 bit unsigned integer controlling the look of the face). It also includes significant rewriting of the face-drawing code (located in players.c) to make the structure of the player face variable more meaningful.

Kudos to BoominGranny who supplied the face customization code that got me started, in the below thread!
http://www.tt-forums.net/viewtopic.php? ... sc&start=0

The one very minor bug I know about is:
Click Load or Save, then close the face dialog, leaving the red message dialog open. Open the face dialog again, then click load or save. The button doesn't appear to press in first time, as if SetWindowDirty() hadn't been called.

I have no idea why this is, maybe someone would like to help me with it if they can figure it out!

[czerty]

Hmm, how about adding lock buton to dondt allow change - I mean - I wand caucasian male with blue eyes, but dont want manualy to create him, if lock is added to caucasian and blue eyes, then if I click on randomize, then only random generator generates me only caucasian males with blue eyes.

And yes, this in trunk will be very nice. You have my vote.

[jez]

Hmm, how about adding lock buton to dondt allow change - I mean - I wand caucasian male with blue eyes, but dont want manualy to create him, if lock is added to caucasian and blue eyes, then if I click on randomize, then only random generator generates me only caucasian males with blue eyes.

And yes, this in trunk will be very nice. You have my vote.

Hmm, difficult to see how you'd implement that in the GUI. I'd suggest you randomly generate a face and then change the eyes/eye colour back to what you want them to be. If you really like that face you only have to do it once and then you can save it

[Born Acorn]

It needs better spacing and more colours than just endless lines of black. Currently it looks crowded and complex.

You should make the window larger as a whole. It's not 1994 anymore, and people don't have 640x800 as a default resolution.

[glx]

You should make the window larger as a whole. It's not 1994 anymore, and people don't have 640x800 as a default resolution.

I agree, some languages will need more space.

[jez]

I agree that the buttons could be a little wider, but more spacing and different colours??? That wouldn't fit in well with the look of TTD at all. It looks quite similar to the style of the 'Message settings' window, which is was basically modeled on.

[Born Acorn]

I agree that the buttons could be a little wider, but more spacing and different colours??? That wouldn't fit in well with the look of TTD at all. It looks quite similar to the style of the 'Message settings' window, which is was basically modeled on.

I'm on about the colours and style used in the Company Window. After all, it is a subwindow of the company window, so it makes sense to use the same style.

[jez]

The colour used for text on buttons in the Company window is black.

[Bot_40]

Well here's a quick ms paint mockup I did in 2 seconds
Matches the style of the other window better and would be clearer too

[Born Acorn]

The colour used for text on buttons in the Company window is black.

No crap.

Currently, your GUI looks extremely cramped and complex. Use the other features to make it look less so.

All the recent GUI windows, such as the TGP generation screen, have space. You GUI has no space.

Look at these three "new" GUI screens. Each has space and different colours than just the normal grey.

The layout is spread out, and it looks very neat.

Bot_40 has the right idea.

[jez]

And as you'll notice with the 'New colour scheme' dialog, it is grey because that fits in with the theme. The player company window is grey, and so should the face selector be.

[Born Acorn]

Yes, but it isn't cramped, like your face selector GUI.

[jez]

OK. Well, attached are shots of how it looks before, and after, vertical expansion.

Personally I think it's nicer and more in keeping with the rest of the interface before the expansion. 'Too cramped' is a subjective term; I don't think it looks too cramped - just neat and tidy. I do agree that this style looks a bit better than just the buttons, though.

[Peca-on-line]

Nr 1 is better.

[Born Acorn]

Number One for sure, and boy, that is a mega cool improvement. Now this looks like a really good candidate for Trunk.

[jez]

... and here's what it looks like with the attribute numbers in some... different colours.

[Born Acorn]

Number 3 has appeal to it, with the white numbers. Definately!

[jez]

Whaddya think of silver for the attribute numbers?

[mexicoshanty]

Whaddya think of silver for the attribute numbers?

I reckon white so it fits in. There is no sliver text anywhere.

But good job on the face customizer in general, once it's pollished i think it should make it into a final release.

[Born Acorn]

Yes, White would do it for sure.