Autoreplace change

pavel1269 · **Posted:** Wed Apr 25, 2012 1:12 pm

In current system, vehicle has to fulfill interval condition to visit the depot, no matter what. My patch changes this behavior. As soon as vehicle replace is viable (money, pf penalty etc.), it will go to the depot.

Warning, I have no idea, how it could impact the performance. It can have little to no effect, but the opposite as well.

Eddi · **Joined:** Wed Jan 17, 2007 12:14 am **Posts:** 4576

so each time you have money for one replacement, you want 20 vehicles to drop whatever they were doing, to race to the depot whoever comes first?

alistairgrew · **Posted:** Wed Apr 25, 2012 2:59 pm

Eddi wrote:

so each time you have money for one replacement, you want 20 vehicles to drop whatever they were doing, to race to the depot whoever comes first?

Ditto the above, anyway surely you can just send all the vehcles to depot or do it by group?

pavel1269 · **Posted:** Wed Apr 25, 2012 3:22 pm

Sending all vehicles to the depot will result in the "race". I didn't change behavior that much. If you play with no breakdowns, you have no service when no breakdowns settings on and all your trains passed the time to service. Activating some autoreplace will work the same way with this patch as without. The difference I made is only to ignore the interval time when vehicle wants to replace in depot.

frosch · **Posted:** Wed Apr 25, 2012 7:28 pm

The time interval was intentionally added a while back.

The reason is that you cannot tell always in advance whether autoreplace will succeed. Independent of money issues it can fail because NewGRFs disallow the new train composition etc.

In older OpenTTD (1.0 or 0.7 maybe?) trains would enter depots, fail autoreplace, move out, drive a circle and enter the depot again. I.e. they would be completely locked into depots until you disable autoreplace.

pavel1269 · **Posted:** Wed Apr 25, 2012 11:10 pm

frosch wrote:

The time interval was intentionally added a while back.

Good to know. I knew that autoreplace was working for me before and then you (devs) broke it for me

.

frosch wrote:

The reason is that you cannot tell always in advance whether autoreplace will succeed. Independent of money issues it can fail because NewGRFs disallow the new train composition etc.

I believe (not really know), that the whole train is checked before it sends him to depot.

Eddi · **Joined:** Wed Jan 17, 2007 12:14 am **Posts:** 4576

pavel1269 wrote:

I believe (not really know), that the whole train is checked before it sends him to depot.

the newgrf could say "this replacement only works on wednesdays". you cannot check these things before sending to depot.

pavel1269 · **Posted:** Thu Apr 26, 2012 6:28 am

I see where are you heading. This patch will make it even "worse". The only "logical" solution here might be, for me, to stop vehicle at the depot and ... try every tick, oh god ....

Eddi · **Joined:** Wed Jan 17, 2007 12:14 am **Posts:** 4576

using the service interval currently has two effects:

when initially setting a replacement, it holds off parts of the vehicles. this reduces disruption to the network due to all vehicles heading to depot at the same time
when a replacement fails, the vehicle will back off for a while before trying again.

pavel1269 · **Posted:** Thu Apr 26, 2012 4:30 pm

I understand the solution, problems and such. Personally, for me, I see no problem with everyone wants to visit depot now. For the record, I am not playing with breakdowns as I don't like them at the current state. I don't service trains neither as I hate those one tile worm holes. Turning on auto replace will make (should make, age ...) all trains to go to depot. And more, I don't see this as a problem, its behavior I want to see whenever I activate auto replace. The "maximum_go_to_depot_penalty" is making major differences here and that's good.

And side note, I figured out that major difference is made by day length patch. Interval of 120days means 4,5 minutes in normal game. You might not notice at all. Day length makes this behavior noticeable. So personally, setting extra short intervals is viable. But once, I will start using depots, I won't wanna service like every day. And I would not want to wait for longer intervals. Then, this patch is ideal again.

Transport Tycoon Forums

Autoreplace change

Who is online