trunk 26074 crash report

[hpfx]

Hello,
Just to notify that rev 26074 does crash with this message :
Assertion failed at line 290 of ..\src\script\api\script_object.cpp: StrEmpty(text) || (GetCommandFlags(cmd) & CMD_STR_CTRL)!=0 || StrValid(text,text + strlen(text))

It crash when using GSSign.BuildSign on a GSText, it does not crash with a raw string.

Note also : it does not crash on stable 1.3.2, and it does display correct sign.


here is the begining of the report :

*** OpenTTD Crash Report ***

Crash at: Sun Nov 24 08:40:25 2013
In game date: 2010-02-05 (73)

Crash reason:
Exception: E1212012
Location: 7C812FD3
Message: Assertion failed at line 290 of ..\src\script\api\script_object.cpp: StrEmpty(text) || (GetCommandFlags(cmd) & CMD_STR_CTRL) != 0 || StrValid(text, text + strlen(text))

OpenTTD version:
Version: r26074 (0)
NewGRF ver: 140065da
Bits: 32
Endian: little
Dedicated: no
Build date: Nov 23 2013 19:11:32

Registers:
EAX: 0013F328 EBX: 00000016 ECX: 00000000 EDX: 00F83D70
ESI: 00000000 EDI: 00000000 EBP: 0013F378 ESP: 0013F324
EIP: 7C812FD3 EFLAGS: 00000246

Bytes at instruction pointer:
5E C9 C2 10 00 85 FF 0F 8E 5E 8E FF FF 8B 55 FC 89 55 0C 0F B7 16 8B 7D

Stack trace:
00F83648 E1212012 00000000 00000000 7C812FD3 00000000 00000028 000C0668
00000000 013312E0 00F38890 00000010 00000000 00000000 00000000 00000000
00000000 7C91D80A 7C9232F0 FFFFFFFF 00000024 0013F3D8 005FC29C E1212012
00000000 00000000 00000000 006CD827 00000016 01374429 01395430 01395430
00000000 0013F3C4 7E3E6579 00000000 7C91D80A 005FC28C 00000001 0013F398
0013EF40 0013F658 006D3CF0 01D1B419 FFFFFFFE 0013F5E8 006CCDE5 00000016
...

for information, the code I used :

Code: Select all

local message = GSText(GSText.STR_INDUSTRY,indus);
GSNews.Create(GSNews.NT_GENERAL,message,0); // <- works ok.
GSSign.BuildSign(tile_index, message); // <- crash

english.txt

Code: Select all

STR_INDUSTRY	:{LTBROWN}{INDUSTRY}

[WWTBAM]

Did you make a FlySpray ticket?

[hpfx]

done, https://bugs.openttd.org/task/5818
it was first ticket.