New cheat patch

[Slower]

Hello,
I have programmed feature with new cheat available in the single player game. It disables penalty for (un)loading for over sized train in station.

[Supercheese]

Seems reasonable enough -- I actually hard-remove (comment out) this loading speed penalty in my custom-compiled OTTD, so a soft-remove like this would be an improvement. Without actually patching and compiling, I offer this suggestion:

For the cheat menu text, rather than "Long trains will not get penalty in stations", I would phrase it more like "Disable loading speed penalty for trains longer than stations".

[SirkoZ]

Or rather "...loading time penalty...".

[Slower]

Thanks for advises, I never know how should I describe the funcionality in few words

[Supercheese]

You should probably submit this to Flyspray (http://bugs.openttd.org/), I'm pretty sure that's the preferred process for reviewing patches if you want to have them considered for trunk inclusion.

[Zuu]

Regarding the patch, you should omit the changes to projects/openttd_vs100vcxproj in your patch. Those appear to only be local for compilation on your system. Thus they shouldn't be included in the patch.

Eg. do

Code: Select all

svn diff src > my.patch

or in case of mercurial queues:

Code: Select all

hg qdiff src > my.patch

With mercurial patch queues, I usually put a patch at the start of the queue which contain removal of DirectMusic. This way, I make sure none of my real patches contain changes to the project files.

[Slower]

Oh, sorry, I've forgotten to omit project file. Should I create the task on FS? or is the patch post this way fine too?

[Eddi]

general rule: post here if you want more feedback from players, post on flyspray if you want more feedback from developers (but try to have this as "finished" as possible before doing so)