Patch: Change to Station Rating

[rfc2795]

Current station rating rules are here.

What means a vehicle that which max speed is below 85km/h can't receive points for the rating. Thus station with only road vehicle and ships are on the disadvantage and the station rating isn't for show. It's has a impact of how much you obtain from a industry and the chance a industry will change her production amount (higher better and with smooth economy >=80% are nice to have).

What does the patch:
It's differ the about the tempo and for different vehicle class: Train, Ship, Airplane and Road Vehicle. With this a station can reached 80% even with slow and old vehicles. However the maximal approve for speed isn't change and are max. 17%.

Train, Airplane: same as always. ( speed (km/h) - 85 ) / 4 . no gain <= 85km/h, max. gain for 253km/h speed, linear rise. (0.098% / km/h)
Road Vehicle: ( speed (km/h) - 60 ) / 2 . no gain <= 60km/h, max. gain for 144 km/h speed, linear rise. (0.196% / km/h)
Ships: same as always. ( speed (km/h) - 20 ) * 2 . no gain <= 20km/h, max. gain for 41 km/h speed, linear rise. (0.784% / km/h)

All values are my ideas. Other suggestion are welcomed.

--

Changelog:

0.9.1
Doc

0.9.2
Fix: False calculation for Ships Speed rating.

[dadymax]

Well. I my games sinse '98 in TT, TTD, OpenTTD _newer_ happen that road station over some industry have empty bays because of lack capacity of road vehicles. Of course there was solution to build 10 roadstops as one station. But in this situation speed of vehicles doesn't matter because of high count events with "Days since last cargo pickup" < 7.5*4 (for road vehs and ships). There is a some kind of tactics to give boost to station rating by adding to current station two road stops close and get 1 or 2 vehicles order to move cargo from one to another - in result we have station with rating over 90 (if you transport cargos out of there) by very cheap solution.

As result I don't see any problem with current station rules.
IMHO.

But I want to say "Thanks!" to you as to anyone who try to make this great game better.

Thanks!

[Eddi]

i tried to clean up the station rating code relating to speed, to move the logic to the relevant vehicle data types. this should make it more clear which vehicles get which penalties.

there should be no change to trunk behaviour, but it is largely untested, and i may have read the math wrong...

[rfc2795]

Some strange behavior form my patch. Ships has full speed bonus even if they are too slow for this. Ships already has a speed bonus. (I'm going to search for it or do anyone know the exact place the code piece is located?)

--

solved in Patch 0.9.2