New map features

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

User avatar
cirdan
Director
Director
Posts: 539
Joined: 07 Apr 2007 18:08

Re: New map features

Post by cirdan »

Lechuza wrote:I would love if the daylength patch ends up making it to trunk too! :D
I have pondered adding one of the daylength patches that float around the forums, but there are too many unsettled issues with them. Essentially, there is not a clear specification of how daylength should behave, with all corner cases sorted out, and that should come first, before any coding.
User avatar
cirdan
Director
Director
Posts: 539
Joined: 07 Apr 2007 18:08

Re: New map features

Post by cirdan »

I have just pushed a small update to the repo to fix a crash when loading an old savegame in which an articulated road vehicle was in the middle of turning around (reported by romazoon).
TrueSatan
Transport Coordinator
Transport Coordinator
Posts: 291
Joined: 16 Jul 2003 18:33

Re: New map features

Post by TrueSatan »

cirdan wrote:I have just pushed a small update to the repo to fix a crash when loading an old savegame in which an articulated road vehicle was in the middle of turning around (reported by romazoon).
And guess who compiled the ubuntu version right away :)
Thanks for the new version.

Cheers
Attachments
openttd-custom-g3b0e642f-UNIX.tar.xz
Version: g3b0e642f
Ubuntu Linux 14.04 64bit
(4.61 MiB) Downloaded 24 times
User avatar
wallyweb
Tycoon
Tycoon
Posts: 6102
Joined: 27 Nov 2004 15:05
Location: Canada

Re: New map features

Post by wallyweb »

cirdan wrote:I have just pushed a small update to the repo ...
... and here be the Win32 binaries with the usual guarantee of a lack of any guarantee:
OpenTTD-g3b0e642f-Win32.7z
(5.27 MiB) Downloaded 29 times
User avatar
romazoon
Tycoon
Tycoon
Posts: 1291
Joined: 20 Jun 2010 23:16

Re: New map features

Post by romazoon »

Wow that s great Cirdan happy to see that hotfix ;)

and Thanks Wally for the binary !

Now i have to say sorry Cirdan, i m gonna make again a bug report 8o

I think i found a bug (no crash), if i load an older savegame from 1.4.4 into Cirdan's version, old timetables (some of them not all ) seems to be losing an entry and appear therefor "incomplete". but if i load the same savegame in 1.4.4 and check those (sharing order) train i find that their timetable table were complete. (see screenies)

notable difference between 1.4.4 and "recent trunk" concerning timetable is the automatic "pre"filling of timetable....i have no clue, but i thought i would mention it to you, if that can help somehow...(i noticed you included that into your version, i just don t remember since when you included it too)

Cirdan, if you need a savegame showing the same behavior, the last i sent you also trigger the bug...but not on the same train !!, on that save check the IC03xx group of train, i tried it and at least this group of train show the "incomplete timetable" bug.
Attachments
World Bank, 30 Oct 2249.png
this is when loaded in Cirdan's version.
(378.21 KiB) Downloaded 7 times
World Bank, 16 Jan 2250.png
this is using 1.4.4, and loading the savegame is fine.
(370.69 KiB) Downloaded 7 times
User avatar
cirdan
Director
Director
Posts: 539
Joined: 07 Apr 2007 18:08

Re: New map features

Post by cirdan »

romazoon wrote:Now i have to say sorry Cirdan, i m gonna make again a bug report 8o
That is nothing to be sorry about—you are doing a great service reporting these bugs.
romazoon wrote:I think i found a bug (no crash), if i load an older savegame from 1.4.4 into Cirdan's version, old timetables (some of them not all ) seems to be losing an entry and appear therefor "incomplete". but if i load the same savegame in 1.4.4 and check those (sharing order) train i find that their timetable table were complete. (see screenies)
What happens here is that, under certain conditions, the current order of a vehicle can be untimetabled when loading an old savegame. This bug was introduced when importing a commit from openttd and, in fact, the bug is also present in openttd trunk. I have just pushed a fix for this to my branch.
User avatar
wallyweb
Tycoon
Tycoon
Posts: 6102
Joined: 27 Nov 2004 15:05
Location: Canada

Re: New map features

Post by wallyweb »

cirdan wrote:I have just pushed a fix for this to my branch.
... and here be the Win32 binaries with the usual guarantee of a lack of any guarantee:
OpenTTD-g19c91853-Win32.7z
(5.27 MiB) Downloaded 29 times
User avatar
romazoon
Tycoon
Tycoon
Posts: 1291
Joined: 20 Jun 2010 23:16

Re: New map features

Post by romazoon »

well i m sorry for the work it implies for you, but yes i know you need those report, and i m glad doing some testing and participating in someway to improve your version :)

Thanks for the fix Cirdan, and wally thanks again for the binary.


While i am here... i am looking for a compiled binary for Linux i686 ....anychance someone have that to share with the world ? that would be for doing some multiplayer testing ;) thanks in advance.
TrueSatan
Transport Coordinator
Transport Coordinator
Posts: 291
Joined: 16 Jul 2003 18:33

Re: New map features

Post by TrueSatan »

And here is the ubuntu 64bit version for Ubuntu 14.04

Thanks Cirdan :)
Attachments
openttd-custom-g19c91853-UNIX.tar.xz
Version:g19c91853
Ubuntu 14.04 64bit
(4.61 MiB) Downloaded 24 times
User avatar
romazoon
Tycoon
Tycoon
Posts: 1291
Joined: 20 Jun 2010 23:16

Re: New map features

Post by romazoon »

new crash report!

just load the savegame , it crash in the first minut.

Cirdan if you need somethng more i ll send it asap.

*** OpenTTD Crash Report ***

Crash at: Mon Nov 10 00:47:36 2014
In game date: 2107-06-06 (4)

Crash reason:
Exception: E1212012
Location: 7535C42D
Message: Assertion failed at line 753 of C:/MinGW/msys/1.0/home/AdminGuy/fttd/src/roadveh_cmd.cpp: abs((int)(GetSlopePixelZ(x, y) - v->z_pos)) < 3

Binary:
Version: g19c91853 (0)
NewGRF ver: 150064d0
Build date: Nov 8 2014 15:14:20
Flags: 32-bit little-endian

Registers:
EAX: 0028AF64 EBX: 00000016 ECX: 00000000 EDX: 0008E3C8
ESI: 764E3180 EDI: 00000000 EBP: 0028AFB4 ESP: 0028AF64
EIP: 7535C42D EFLAGS: 00000246

Bytes at instruction pointer:
C9 C2 10 00 CC CC CC CC CC 8B FF 55 8B EC 56 8B 75 08 83 FE F4 72 18 83
Attachments
crash.png
(294.13 KiB) Downloaded 6 times
World Bank, 18 Mai 2107.sav
the problematic savegame
(7.64 MiB) Downloaded 25 times
User avatar
cirdan
Director
Director
Posts: 539
Joined: 07 Apr 2007 18:08

Re: New map features

Post by cirdan »

Your savegames are full of surprises... The crash happens when a road ends at the lower side of a bridge head and a vehicle drives up to it. Since any such road is a dead end, vehicles normally avoid going there, but in your game the pathfinder decided that one of those dead ends was a good spot for turning around. I have just pushed a fix for this bug.
User avatar
romazoon
Tycoon
Tycoon
Posts: 1291
Joined: 20 Jun 2010 23:16

Re: New map features

Post by romazoon »

cirdan wrote:Your savegames are full of surprises..
well well we can probably declare cindini scenarios "one of the best map for testing purpose" ;)
cirdan wrote:Since any such road is a dead end
that s quite surprising as there is only humans players in that game, so i m quite surprised we putted a roadvehicule in such the position you describe !!

but well i know at least one AI using dead ends for returning its vehicles (civil AI)...so it s good the bug is taken care of.

glad you found the bug and thanks for fixing it already ;)
User avatar
wallyweb
Tycoon
Tycoon
Posts: 6102
Joined: 27 Nov 2004 15:05
Location: Canada

Re: New map features

Post by wallyweb »

cirdan wrote:I have just pushed a fix for this bug.
Oh look! A release party! :D
I just love release parties! :D
Who is bringing pizza and beer? :roll:
I brought a Windows binary. 8)
Sorry but the shop was all out of guarantee toppings. :mrgreen:
OpenTTD-g5bcea3d0-Win32.7z
(5.27 MiB) Downloaded 26 times
User avatar
romazoon
Tycoon
Tycoon
Posts: 1291
Joined: 20 Jun 2010 23:16

Re: New map features

Post by romazoon »

a release party ? well i bring a new crash...but a train crash this time, two trains collided for no reason(a newspaper told me)...so i reloaded last save and waited for the exact date to see if it happens again and why. it was a train reserving a path and going, then in a a blink of an eye the reservation is canceled , at this moment where path is not reserved, it allow another train to start and crash!

crash happens on the 29th of november, I ll give you two savegame : one from 2 month before that date (the one i reloaded to check what happened,and the crash happened again)...and one at the exact moment before they crash (but the canceled path is allready done...sorry).

btw i pushed the savegame on 1.4.4 further than that date and nothing happens.

edit : letting run the game after the train crash, i saw the same behavior happening at the same place around the 10th of february 2140 (i have changed nothing in between). luckily this time no crash happened, but i saw the path reserved simply disapear and train kept going like normal.
Attachments
Cindini Nacional, 11 Sep 2139.sav
load this one, wait the 29th november and see crash and the reservation being made then disapear (with show path on)
(7.8 MiB) Downloaded 30 times
Cindini Nacional, 29 Nov 2139.sav
load this one and you ll see the crash happening in a matter of a second after hitting play.
(7.63 MiB) Downloaded 24 times
Cindini Nacional, 29 Nov 2139#1.png
the save from 11sept, is not at the right location, so you can use that screenie to find the right spot (if you don t want to bother loading the second savegame that should open at the right place...but that is taken maybe a bit too late)
(543.84 KiB) Downloaded 5 times
TrueSatan
Transport Coordinator
Transport Coordinator
Posts: 291
Joined: 16 Jul 2003 18:33

Re: New map features

Post by TrueSatan »

Even if you found a new crash here is g5bcea3d0 meanwhile.

Thanks for finding the bugs roma and Cridan for fixing them :)

Lets try the new version.

Cheers
Attachments
openttd-custom-g5bcea3d0-UNIX.tar.xz
Version: g5bcea3d0
Ubuntu 14.04 64bit
(4.61 MiB) Downloaded 27 times
Hafting
Engineer
Engineer
Posts: 106
Joined: 13 Feb 2014 11:22

Crash trying to show the settings dialog

Post by Hafting »

Wanting to test this patchset, I downloaded using git and compiled it on arch linux.

Code: Select all

./configure --CFLAGS=-O2 -march=native --CXXFLAGS=-O2 -march=native --enable-unicode=1
make -j 5
make install
/usr/local/games/openttd
I use the config file and newgrfs from my ordinary openttd-1.4.4

When I start the game, I get: "The currently used base set is missing a number of sprites. Please update the base graphichs set". I have zbase, and cannot see anything missing when I start a game. Openttd 1.4.4 does not give this message.

I can start games. I use FIRS, and get "There were no suitable places for 'Builders yard' industries". Strange, but the game will work without those. I don't get that from openttd-1.4,4 either.

Trying to bring up the "Game Options" dialog always crash. There is no need to even start a game, just click "Game Options" and it dies. "Game options" from within the game also crashes. Other dialogs seems to work.

The crash log, when starting openttd and immediately clicking "Game Options":

Code: Select all

*** OpenTTD Crash Report ***

Crash at: Wed Nov 12 11:11:37 2014
In game date: 2051-05-09 (27)

Crash reason:
 Signal:  Aborted (6)
 Message: <none>

Binary:
 Version:    g5bcea3d0 (0)
 NewGRF ver: 150064d0
 Build date: Nov 12 2014 11:40:34
 Flags:      64-bit little-endian

Stacktrace:
 [00] /usr/local/games/openttd(_ZNK12CrashLogUnix13LogStacktraceEP7stringb+0x68) [0x73b888]
 [01] /usr/local/games/openttd(_ZNK8CrashLog12FillCrashLogEP7stringb+0x11e) [0x62264e]
 [02] /usr/local/games/openttd(_ZNK8CrashLog12MakeCrashLogEv+0xa4) [0x622e84]
 [03] /usr/local/games/openttd() [0x73b705]
 [04] /usr/lib/libc.so.6(+0x339f0) [0x7f263cc6a9f0]
 [05] /usr/lib/libc.so.6(gsignal+0x37) [0x7f263cc6a967]
 [06] /usr/lib/libc.so.6(abort+0x16a) [0x7f263cc6bd3a]
 [07] /usr/lib/libc.so.6(+0x73413) [0x7f263ccaa413]
 [08] /usr/lib/libc.so.6(+0x7884e) [0x7f263ccaf84e]
 [09] /usr/lib/libc.so.6(+0x7900b) [0x7f263ccb000b]
 [10] /usr/local/games/openttd(_Z15ShowGameOptionsv+0x408) [0x7d4cb8]
 [11] /usr/local/games/openttd(_Z17HandleMouseEventsv+0x1309) [0x87edc9]
 [12] /usr/local/games/openttd(_ZN15VideoDriver_SDL9PollEventEv+0x6d) [0x86477d]
 [13] /usr/local/games/openttd(_ZN15VideoDriver_SDL8MainLoopEv+0x70) [0x864ac0]
 [14] /usr/local/games/openttd(_Z12openttd_mainiPPc+0x1581) [0x72afd1]
 [15] /usr/lib/libc.so.6(__libc_start_main+0xf0) [0x7f263cc57040]
 [16] /usr/local/games/openttd() [0x576fce]

Operating system:
 Name:     Linux
 Release:  3.15.0-rc8-ARCH
 Version:  #1 SMP PREEMPT Thu Aug 14 16:15:10 CEST 2014
 Machine:  x86_64
 Compiler: GCC 4.9.2 "4.9.2"

Configuration:
 Blitter:      32bpp-sse4-anim
 Graphics set: zBase (251)
 Language:     /usr/local/share/games/openttd/lang/english.lng
 Music driver: extmidi
 Music set:    NoMusic (0)
 Network:      no
 Sound driver: sdl
 Sound set:    NoSound (2)
 Video driver: sdl

Fonts:
 Small:  DejaVu Sans
 Medium: DejaVu Sans
 Large:  DejaVu Sans
 Mono:   sprite

AI Configuration (local: 0):
  0: Human

Libraries:
 FontConfig: 2.11.1
 FreeType:   2.5.3
 ICU:        54.1
 LZMA:       5.0.7
 LZO:        2.08
 PNG:        1.6.13
 SDL:        1.2.15
 Zlib:       1.2.8

---- gamelog start ----
Tick 62675: Load game
    Conversion from OTTD savegame without gamelog, version 0, 1
    Revision text changed to g5bcea3d0, savegame version 22, not modified, newgrf version 0x150064d0
    New game mode 0, landscape 1
    Game loaded
---- gamelog end ----

*** End of OpenTTD Crash Report ***

User avatar
planetmaker
OpenTTD Developer
OpenTTD Developer
Posts: 9432
Joined: 07 Nov 2007 22:44
Location: Sol d

Re: Crash trying to show the settings dialog

Post by planetmaker »

which patch(set)?

When you test patches or patch sets please reply to the appropriate thread.
Hafting
Engineer
Engineer
Posts: 106
Joined: 13 Feb 2014 11:22

Re: Crash trying to show the settings dialog

Post by Hafting »

[quote="planetmaker"]which patch(set)?

Cirdan's "New map features". Sorry for posting in the wrong place. Should I re-post, or is it possible to move the message over?
User avatar
planetmaker
OpenTTD Developer
OpenTTD Developer
Posts: 9432
Joined: 07 Nov 2007 22:44
Location: Sol d

Re: New map features

Post by planetmaker »

Moved.
Hafting
Engineer
Engineer
Posts: 106
Joined: 13 Feb 2014 11:22

Re: New map features

Post by Hafting »

Crash while making terrain, and other terrain generation oddities

The terrain generator seems to operate differently, generating much more sea than usual. I use 512x512 maps. If I set custom sea level to 20%, I still gets lots of sea, perhaps similiar to 60% sea in 1.4.4. Not a problem for me, I like games with lots of shipping. But it seems like I cannot get the terrain generator to make land-only games, which used to be easy enough. Using standard sea levels instead of percentages shows the same - a lot more sea than usual.

Another oddity is with the lighthouses. Normally, they are spread all over the map (but always close to the sea). With "new map features", the lighthouses seems to cluster along the lower left and right edges of the map. Islands there get perhaps 8 lighthouses in a row, with no lighthouses on any central or upper islands. Problems with placement code?

Now the crash. When making a map, I can choose if the edges should be sea-only or not. This works fine if at least some edges are set to sea-only. If none of the map edges are sea-only, the terrain generator (Terra Genesis) crashes. Problem with slopes on the map edges?

Crash log. Start the program, start new game, set no edges to sea-only, generate the map, get this:

Code: Select all

ALSA lib pcm_dmix.c:1022:(snd_pcm_dmix_open) unable to open slave
dbg: [grf] Palette sprites are missing
dbg: [sprite] Tried to load normal sprite #723 as a recolour sprite. Probable cause: NewGRF interference
Error: Assertion failed at line 1038 of /usr/src/openttd/src/landscape.cpp: IsInclinedSlope(slopeBegin)
Crash encountered, generating crash log...
*** OpenTTD Crash Report ***

Crash at: Wed Nov 12 13:01:54 2014
In game date: 1945-01-01 (0)

Crash reason:
 Signal:  Aborted (6)
 Message: Assertion failed at line 1038 of /usr/src/openttd/src/landscape.cpp: IsInclinedSlope(slopeBegin)

Binary:
 Version:    g5bcea3d0 (0)
 NewGRF ver: 150064d0
 Build date: Nov 12 2014 11:40:34
 Flags:      64-bit little-endian

Stacktrace:
 [00] /usr/local/games/openttd(_ZNK12CrashLogUnix13LogStacktraceEP7stringb+0x68) [0x73b888]
 [01] /usr/local/games/openttd(_ZNK8CrashLog12FillCrashLogEP7stringb+0x11e) [0x62264e]
 [02] /usr/local/games/openttd(_ZNK8CrashLog12MakeCrashLogEv+0xa4) [0x622e84]
 [03] /usr/local/games/openttd() [0x73b705]
 [04] /usr/lib/libc.so.6(+0x339f0) [0x7f4ca61b59f0]
 [05] /usr/lib/libc.so.6(gsignal+0x37) [0x7f4ca61b5967]
 [06] /usr/lib/libc.so.6(abort+0x16a) [0x7f4ca61b6d3a]
 [07] /usr/local/games/openttd() [0x729534]
 [08] /usr/local/games/openttd() [0x69c15f]
 [09] /usr/local/games/openttd() [0x69f8c7]
 [10] /usr/local/games/openttd(_Z17GenerateLandscapeh+0x4c6) [0x6a0136]
 [11] /usr/local/games/openttd() [0x6691e7]
 [12] /usr/local/games/openttd(_ZN20ThreadObject_pthread10ThreadProcEv+0xb) [0x82202b]
 [13] /usr/local/games/openttd(_ZN20ThreadObject_pthread12stThreadProcEPv+0x9) [0x8220a9]
 [14] /usr/lib/libpthread.so.0(+0x7314) [0x7f4caa320314]
 [15] /usr/lib/libc.so.6(clone+0x6d) [0x7f4ca626a3ed]

Operating system:
 Name:     Linux
 Release:  3.15.0-rc8-ARCH
 Version:  #1 SMP PREEMPT Thu Aug 14 16:15:10 CEST 2014
 Machine:  x86_64
 Compiler: GCC 4.9.2 "4.9.2"

Configuration:
 Blitter:      32bpp-sse4-anim
 Graphics set: zBase (251)
 Language:     /usr/local/share/games/openttd/lang/norwegian_bokmal.lng
 Music driver: extmidi
 Music set:    NoMusic (0)
 Network:      no
 Sound driver: sdl
 Sound set:    NoSound (2)
 Video driver: sdl

Fonts:
 Small:  DejaVu Sans
 Medium: DejaVu Sans
 Large:  DejaVu Sans
 Mono:   sprite

AI Configuration (local: 255):

Libraries:
 FontConfig: 2.11.1
 FreeType:   2.5.3
 ICU:        54.1
 LZMA:       5.0.7
 LZO:        2.08
 PNG:        1.6.13
 SDL:        1.2.15
 Zlib:       1.2.8

---- gamelog start ----
Tick 0: New game
    Revision text changed to g5bcea3d0, savegame version 22, not modified, newgrf version 0x150064d0
    New game mode 1, landscape 0
    Added NewGRF: GRF ID 33325A43, checksum 8767596EEC0C25A41B060D834C356402, filename: 32bpp_ez-0.1.grf (md5sum matches)
    Added NewGRF: GRF ID 44440A01, checksum FCEEC76CF44EC23E7FE9C88048CF11CC, filename: av8_aviators_aircraft_set-2.21/pb_av8w.grf (md5sum matches)
    Added NewGRF: GRF ID F1250005, checksum 6B9F2DD07EFA14B7A5FE5F2150A10F80, filename: firs.grf (md5sum matches)
    Added NewGRF: GRF ID 52571201, checksum 9548AAA21E5B7E8168B3B19EF8290A83, filename: grvts32.grf (md5sum matches)
    Added NewGRF: GRF ID 4A430002, checksum 658BE666D7F1EAA7D23B93BC38890D71, filename: industrial_stations_renewal-1.0.1/indstatr.grf (md5sum matches)
    Added NewGRF: GRF ID 4C4D0103, checksum 96DC4AD076690CD135F91332F2E477A6, filename: roads.grf (md5sum matches)
    Added NewGRF: GRF ID 4F472B31, checksum 21377D78803A5BB9C57DE4C918A534B3, filename: ogfx-trains.grf (md5sum matches)
    Added NewGRF: GRF ID EC0D9110, checksum D1510A1006B03BCDAAFE562D5D05BACF, filename: raise_landscaping_costs.2/raise_landscaping_costs.grf (md5sum matches)
    Added NewGRF: GRF ID 48530101, checksum EC17E22A38C037D156BD22A96F4A8523, filename: reduced_passenger_payment.1.0/reducedpassengerpayment.grf (md5sum matches)
    Added NewGRF: GRF ID 414E0201, checksum 809D7424C8CEFC9DDC8E0AE4F64D79AB, filename: fish_2-squidrc8/fish.grf (md5sum matches)
    Added NewGRF: GRF ID 54670901, checksum F3699B81A7B2BB59EABD49164AE53796, filename: TGrandom.grf (md5sum matches)
    Game started
---- gamelog end ----
*** End of OpenTTD Crash Report ***
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 8 guests