New map features

[romazoon]

hmm seems i m experiencing the same problem with planes and freezes.

I bought my first plane, and when i tried to add the first order it freezed. no crash

Also i could not reload the savegame i ve made just before buying the plane ?! it crashes

But i could reload the savegame BEFORE building the airport with no problem


this is crash log when i reload the savegame that have airport, but no plane.

*** OpenTTD Crash Report ***

Crash at: Mon Jan 19 17:28:47 2015
In game date: 1951-07-01 (0)

Crash reason:
Exception: E1212012
Location: 7661C42D
Message: Assertion failed at line 28 of C:/MinGW/msys/1.0/home/Adminguy/fttd/src/map/class.h: tile < MapSize()

Binary:
Version: g4568557a (0)
NewGRF ver: 150064d0
Build date: Jan 13 2015 17:38:35
Flags: 32-bit little-endian

Registers:
EAX: 00269254 EBX: 0926CB90 ECX: 76F705F0 EDX: 00000000
ESI: 00000016 EDI: 002693C8 EBP: 002692A4 ESP: 00269254
EIP: 7661C42D EFLAGS: 00000246

Bytes at instruction pointer:
C9 C2 10 00 CC CC CC CC CC 8B FF 55 8B EC 56 8B 75 08 83 FE F4 72 18 83

[HackaLittleBit]

rev 23488 it is still working.
So it is something you did after that.

[romazoon]

here is another maybe usefull savegame for you to inspect the problem

[cirdan]

I am still missing detailed instructions to reproduce the freeze. Do I have to build an airport? Do I have to build an airplane? What do I have to tell it to do? Send it to the same airport, or to another one? Everything I try works as intended...

Also, it would greatly help me if I could have a savegame that shows the bug with as few newgrfs as possible.

[romazoon]

so the savegame that have already an airport built ingame is loading fine for you ? cause for me it s crashing just when loading the savegame (the crashlog i sent)


now for the freeze : buy an airplane in Monza/Milano Airport, try to give the plane an order (personally it freezes at the moment i select the first order of the plane".

[HackaLittleBit]

To reproduce:
Before starting new game add av8 aviators aircraftset in NewGRF settings.
Create new game.
Build airport.
Buy plane.
Add Goto order to same airfield.
Freeze!
Without any NewGRF's this does not happen.

P.S. Maybe GetOrderDistance proc Not sure though.
It can however have something to do with that because that GRF set uses Range.
e.g. cached_max_range_sqr and cached_max_range

[cirdan]

so the savegame that have already an airport built ingame is loading fine for you ? cause for me it s crashing just when loading the savegame (the crashlog i sent)

No, I could not load it because of missing newgrfs; that is why I asked for a simpler savegame.

To reproduce:
Before starting new game add av8 aviators aircraftset in NewGRF settings.
[...]

Thank you; now I can reproduce the freeze. I was using the world airliners set (as per the original report) and everything worked as it should.

[romazoon]

sorry about the many newgrfs then

[HackaLittleBit]

sorry:oops:

Sorry? Don't worry.

Cirdan I found the origin of the problem.
See patch.
When patch applied problem disappears.
Also when I rename the procedure "static uint GetOrderDistance (const BaseOrder *prev, const BaseOrder *cur, const Vehicle *v)"
into GetOrderDistancex for example I get serious complaints!

[cirdan]

I have updated the repository with fixes for the freeze reported by te_lanus and an engine visibility bug when loading old savegames (all engines would suddenly become hidden in the buy menu).

There are also some changes in the marshalling code for functions exported to squirrel, which should produce simpler and faster code, but this can always introduce new bugs. If you usually play with a game script or AI competitors, testing would be welcome.

[wallyweb]

I have updated the repository ...

and here is the unguaranteed Windows binary ...

OpenTTD-g8bebb0db-Win32.7z

(5.43 MiB) Downloaded 48 times

[TrueSatan]

And here is the usual Ubuntu 64bit version

[Eddy Arfik]

Since I couldn't get this to compile with MSVC, I installed MinGW. After I bit of messing around with configurations and some small modifications to strings.cpp and win32.h I managed to get a working binary*

* Working, but I've had to include 3 .dll files with the binary, I'm having a bit of trouble getting all the libraries static-linked

[wallyweb]

Over two weeks since the last release and no bug reports? WOW!

[romazoon]

and no bug reports? WOW!

yes this is quite awesome ! Congratulation and Thank you Cirdan

Also you might be happy to hear that i tested (with two other player) multiplayer and "we" encountered no problem so far !!

[romazoon]

maybe we have been talking to fast...my game just crashed now while i was building a signal.

i m not sure it s valid bug report though, i did changed a few newgrfs at some point and it s still the newgrf list that you disliked last time...

anyway i post here just in case it turn out to still be usefull.

Crashlog : *** OpenTTD Crash Report ***

Crash at: Sat Feb 07 20:34:54 2015
In game date: 2966-06-20 (28)

Crash reason:
Exception: E1212012
Location: 76DAC42D
Message: Assertion failed at line 489 of C:/MinGW/msys/1.0/home/Adminguy/fttd/src/pbs.cpp: ft.m_new.has_signals()

Binary:
Version: g8bebb0db (0)
NewGRF ver: 150064d0
Build date: Jan 21 2015 18:28:01
Flags: 32-bit little-endian

Registers:
EAX: 002899F4 EBX: 00000016 ECX: 00000000 EDX: 0008E3C8
ESI: 77063180 EDI: 00000000 EBP: 00289A44 ESP: 002899F4
EIP: 76DAC42D EFLAGS: 00000246

[cirdan]

Over two weeks since the last release and no bug reports? WOW!

I was a bit surprised myself, too. In a sense, I expected my last update to be fairly stable, since the last bunch of commits were mainly bugfixes, but not as much. On the other hand, this means that I have had more time to work on destabilising changes.

Also you might be happy to hear that i tested (with two other player) multiplayer and "we" encountered no problem so far !!

This is excellent news, because otherwise it is hard for me to tell if there are no bug reports just because nobody is testing the build; and doubly so because the next set of changes touches multiplayer code and it is good to know that they will be tested.

maybe we have been talking to fast...my game just crashed now while i was building a signal.

i m not sure it s valid bug report though, i did changed a few newgrfs at some point and it s still the newgrf list that you disliked last time...

anyway i post here just in case it turn out to still be usefull.

...and then this happened. Do you have the stack trace of your crash log? It should be somewhere below the information you already posted. I will need it if the crash is not reproducible.

[romazoon]

here is the Stactrace, and in case you want the full crash.text, it s inside the .rar

Stack trace:
E1212012 00000000 00000000 76DAC42D 00000000 00289A28 76CBFCF1 001A0670
770664A8 770103E0 00012010 00000000 FFFFFFFF 00289A44 76CBFD36 001A0670
77C5FAEA 77C81092 FFFFFFFF 00000024 00289A64 0054879A E1212012 00000000
00000000 00000000 77060290 00289AB0 00289AB0 77025E8F 00000016 500BEC7F
00000007 07DED9F8 00289E00 77C5FAEA 77C79DEC 00000000 00000024 00548770
00000001 00289A70 0028941C 0028FFC4 76FE8CD5 27212877 FFFFFFFE 00289DE8
77028EA2 00000016 07DED9F8 00240434 010BA178 010A5F40 0005001B 0000002C
00000000 010001C3 00000000 00000160 01010000 00289A20 76C8CF5C 0028FFC4
77CB71F5 0964F78B FFFFFFFE 77C738AA 77C734A2 00000000 010BA178 00010003
00000000 00289D2C 010BA170 00289BC8 76CBF774 01040000 00000000 010BA178
00000001 00289D2C 00000001 0000001F 0000000D 00000000 00DCFEA0 00000010
001A0670 00000000 00000006 00000000 00000000 00000556 00000300 00000000
0000010A 00289D2C 000001F5 00000000 00007F01 00000000 00000001 00000027
50022080 00000032 00000020 00000000 00000000 0000016C 00000000 010BA178
014011D8 00000000 010BA1DC 01401244 00000134 00289D20 76CBFA18 00000010
00000007 07DED9F8 76CBFA50 00000001 00000000 00000000 00000000 00000000
00000000 01400E04 00000000 00000000 00000000 00000000 00000000 76CBFA6C
00000000 00000001 00000000 00000000 00000000 00000000 00000000 7FFFFFFF
00978085 00289C68 76FDAA42 01271B5D 00978085 00000016 00000016 7FFFFFFF
00000000 08D683E0 012714B8 76FCA53A 00000000 00289C98 76FDA8C1 01271B5D
00978085 00000016 00289C88 7FFFFFFF 00000000 08D683E0 012714B8 012707D0
00000000 00289CC8 76FDA9C8 01271B5D 00978085 00000016 00000000 0000000A
00000004 00000004 00000004 012707D0 00000001 00289CE0 00289CF3 00000000
00000004 00289CF0 006ED45D 00000004 0000007F 00289E00 00DCFEA0 00000200

[cirdan]

Hrm. I expected something along the lines of

Code: Select all

Stacktrace:
 [00] ./bin/openttd(_ZNK12CrashLogUnix13LogStacktraceEP7stringb+0x5c) [0x83668fc]
 [01] ./bin/openttd(_ZNK8CrashLog12FillCrashLogEP7stringb+0x10d) [0x8250ffd]
 [02] ./bin/openttd(_ZNK8CrashLog12MakeCrashLogEv+0xa7) [0x8251797]
 [03] ./bin/openttd() [0x836677b]

...and so on, or whatever is appropriate on windows, but never mind.

Anyway, I take it that the game crashed when you tried to build a signal on the tile that is selected in your screenshot, right? Is the tile in front of it (the one with the dirt path across) a station tile?

[Eddi]

or whatever is appropriate on windows, but never mind.

VS creates a debug file next to the .exe, you need that to interprete the crash files.