New map features

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

Hafting
Engineer
Engineer
Posts: 106
Joined: 13 Feb 2014 11:22

Re: New map features

Post by Hafting »

Another crash report. I just built a new ship, and was setting up its route & re-fits:

Pause the game
Make a depot in the middle of the sea (not realistic, but ideal for this route)
Buy a ship, bring up the order list
Create a farm pier
Click the farm pier, order the ship to re-fit to milk and wait for a full load.
I'm rich at this stage, so build a canal so the ship can deliver to the dairy (no need to set up milk trucks then)
Go via a depot and some buyos, due to the distance
Deliver the milk at the dairy pier
Go to "Seltinden havn" (older combined railroad & harbour station) where I want my ship to fetch farming supplies for the return trip
Click the refit button, and the game immediately dies in a segmantation fault!

I guess this is a "rare" sort of crash, for I have several combined rail/harbour stations, all with lots of refits for ships & trains
Or is it a problem building some of the destinations in between adding orders to an open order window?

I could restart the game, complete the orders and start the ship on its route. Whatever it was, it doesn't happen every time I try this.

The crash report:

Code: Select all

*** OpenTTD Crash Report ***

Crash at: Fri May 15 12:38:03 2015
In game date: 1965-12-01 (3)

Crash reason:
 Signal:  Segmentation fault (11)
 Message: <none>

Binary:
 Version:    g118d39e2 (0)
 NewGRF ver: 16006a56
 Build date: May 11 2015 15:05:45
 Flags:      64-bit little-endian

Stacktrace:
 [00] /usr/local/games/openttd() [0x5e3ca8]
 [01] /usr/local/games/openttd() [0x6c9b28]
 [02] /usr/local/games/openttd() [0x5e3c33]
 [03] /usr/lib/libc.so.6(+0x33540) [0x7f790776b540]
 [04] /usr/local/games/openttd() [0x5f7495]
 [05] /usr/local/games/openttd() [0x7083ed]
 [06] /usr/local/games/openttd() [0x75025d]
 [07] /usr/local/games/openttd() [0x5ffc35]
 [08] /usr/lib/libc.so.6(__libc_start_main+0xf0) [0x7f7907758800]
 [09] /usr/local/games/openttd(_start+0x29) [0x4a9b29]

Operating system:
 Name:     Linux
 Release:  4.0.1-1-ARCH
 Version:  #1 SMP PREEMPT Wed Apr 29 12:00:26 CEST 2015
 Machine:  x86_64
 Compiler: GCC 4.9.2 "4.9.2 20150304 (prerelease)"

Configuration:
 Blitter:      32bpp-sse4-anim
 Graphics set: zBase (251)
 Language:     /usr/local/share/games/openttd/lang/norwegian_bokmal.lng
 Music driver: extmidi
 Music set:    NoMusic (0)
 Network:      no
 Sound driver: null
 Sound set:    NoSound (2)
 Video driver: sdl

Fonts:
 Small:  DejaVu Sans
 Medium: DejaVu Sans
 Large:  DejaVu Sans
 Mono:   sprite

AI Configuration (local: 0):
  0: Human
  1: FastPTPAI (v4)
  2: AdmiralAI (v25)
  3: DictatorAI (v169)
  4: CluelessPlus (v37)
  5: RoadRunner (v9)
 GS: Renewed City Growth (v5)

Libraries:
 FontConfig: 2.11.1
 FreeType:   2.5.5
 ICU:        55.1
 LZMA:       5.2.1
 LZO:        2.09
 PNG:        1.6.16
 SDL:        1.2.15
 Zlib:       1.2.8

---- gamelog start ----
Tick 0: New game
    Revision text changed to g118d39e2, savegame version 23, not modified, newgrf version 0x16006a56
    New game mode 1, landscape 1
    Added NewGRF: GRF ID F1250005, checksum EF9CA5244B98B86C62BAC5B39D6F351B, filename: firs_industry_replacement_set-1.4.3/firs.grf (md5sum matches)
    Added NewGRF: GRF ID 52571201, checksum 9548AAA21E5B7E8168B3B19EF8290A83, filename: grvts32.grf (md5sum matches)
    Added NewGRF: GRF ID 4F472B31, checksum 21377D78803A5BB9C57DE4C918A534B3, filename: ogfx-trains.grf (md5sum matches)
    Added NewGRF: GRF ID 33325A43, checksum 8767596EEC0C25A41B060D834C356402, filename: 32bpp_ez-0.1.grf (md5sum matches)
    Added NewGRF: GRF ID 44440A01, checksum FCEEC76CF44EC23E7FE9C88048CF11CC, filename: av8_aviators_aircraft_set-2.21/pb_av8w.grf (md5sum matches)
    Added NewGRF: GRF ID 4A430002, checksum 332F5EE83BB1A8F7C1766E610B48A222, filename: indstatr_32.grf (md5sum matches)
    Added NewGRF: GRF ID 43415000, checksum 4DA9FE9A87DD330EBAD43916771BAF21, filename: opengfx_airports-0.4.2/ogfx-airports.grf (md5sum matches)
    Added NewGRF: GRF ID EC0D9110, checksum D1510A1006B03BCDAAFE562D5D05BACF, filename: raise_landscaping_costs.2/raise_landscaping_costs.grf (md5sum matches)
    Added NewGRF: GRF ID 48530101, checksum EC17E22A38C037D156BD22A96F4A8523, filename: reduced_passenger_payment.1.0/reducedpassengerpayment.grf (md5sum matches)
    Added NewGRF: GRF ID 414E0201, checksum 0551E1BD6EB3100574B0474EAF3DE462, filename: fish_2-2.0.0/fish.grf (md5sum matches)
    Added NewGRF: GRF ID 54670901, checksum F3699B81A7B2BB59EABD49164AE53796, filename: TGrandom.grf (md5sum matches)
    Game started
---- gamelog end ----

*** End of OpenTTD Crash Report ***

Attachments
crash.png
Crash image, showing the click that killed the game.
(330.83 KiB) Downloaded 8 times
crash.sav
The game saved during the crash
(131.18 KiB) Downloaded 37 times
Hafting
Engineer
Engineer
Posts: 106
Joined: 13 Feb 2014 11:22

Re: New map features

Post by Hafting »

The crash I just reported is repeatable, which probably makes it easier to fix.

Crash recipe:
1. Load the attached savegame. It should come up paused.
2. Click the ship depot a little south to the airport/harbour labeled "Fosnavåg Raffineri". It should contain the newly bought "ship 73"
3. Click "ship 73", bring up its order list
4. Click "go to" the pier "Lørenskog kornbruk".
5. Notice that now, the game is ready for me to pick more destinations for the ship. If I want a re-fit, I should select the correct order line, because the active line is the " - - end of order - -" marker. But if I try to re-fit without selecting the correct line, the game crashes. Looks like a missing check - the attempt to build a re-fit menu for a line after the last order line seems to be the killer.

I have done some more checking, and it looks like asking for a re-fit without selecting a line - or explicitly selecting the "- - end of order - -" line, will kill the game on every attempt. At least when I use the last ship built.
This is hopefully easy to avoid. The most user-friendly action is probably to create a re-fit order for the last refit-able line. That is usually what the player intends, when making a series of destinations and suddenly a re-fit. But simply graying out the re-fit button when "- - end of order - -" is active is good enough to avoid this crash.
Attachments
Lørenskog Transport, 4. Des 1965.sav
Crashable game
(131.11 KiB) Downloaded 35 times
User avatar
cirdan
Director
Director
Posts: 539
Joined: 07 Apr 2007 18:08

Re: New map features

Post by cirdan »

Thanks for your bug report. The refit button in the orders window for an aircraft or a ship was not being disabled when no order was selected or when refitting did not make sense for the selected order. I have just pushed a fix for this.
User avatar
wallyweb
Tycoon
Tycoon
Posts: 6102
Joined: 27 Nov 2004 15:05
Location: Canada

Re: New map features

Post by wallyweb »

cirdan wrote:I have just pushed a fix for this.
:bow:
Here is the unguaranteed Windows 32 bit binary ...

Enjoy :D
Attachments
OpenTTD-g2715b330-Win32.7z
(5.45 MiB) Downloaded 43 times
TrueSatan
Transport Coordinator
Transport Coordinator
Posts: 291
Joined: 16 Jul 2003 18:33

Re: New map features

Post by TrueSatan »

And here is the ubuntu version.
Attachments
openttd-custom-g2715b330-UNIX.tar.xz
Version:g2715b330
Ubtuntu 14.04 64bit
(4.63 MiB) Downloaded 40 times
arsenlupin
Engineer
Engineer
Posts: 4
Joined: 23 May 2015 05:51

Re: New map features

Post by arsenlupin »

Hello! I want to report crash on game.
Situation: two trains have different speed passing through tunnel with signal simultaneously occur Floating point exception.
I'm using Ubuntu 14.10 64bit and cloned your fork and compile using gcc.
Below attachments are log and save file. I'll give more information if you need
Thanks
Attachments
crash.sav
(1.43 MiB) Downloaded 41 times
crash.txt
(5.07 KiB) Downloaded 44 times
TrueSatan
Transport Coordinator
Transport Coordinator
Posts: 291
Joined: 16 Jul 2003 18:33

Re: New map features

Post by TrueSatan »

my mistake, was an old crash log :)
Last edited by TrueSatan on 24 May 2015 00:54, edited 1 time in total.
User avatar
cirdan
Director
Director
Posts: 539
Joined: 07 Apr 2007 18:08

Re: New map features

Post by cirdan »

arsenlupin wrote:Situation: two trains have different speed passing through tunnel with signal simultaneously occur Floating point exception.
Thanks for your report. The crash was a division by zero when the rear engine of a dual-headed train partially into a tunnel and stuck behind another, slower train tried to produce a spark. I have just pushed an update to the repo that should fix this.
TrueSatan wrote:Tried to load the crash savegame and got a crash as well. Missing only a few graphics, guess they don't matter.
[snip]
Maybe it helps for finding the bug Cirdan.
Your crash happens at a different place, so it seems unrelated to the other one. Were you doing something when it crashed, like placing rail (that is what the stacktrace suggests)? Could you recheck and report back if the crash persists with today's snapshot?
User avatar
wallyweb
Tycoon
Tycoon
Posts: 6102
Joined: 27 Nov 2004 15:05
Location: Canada

Re: New map features

Post by wallyweb »

cirdan wrote:I have just pushed an update to the repo that should fix this.
:bow:
Here is the unguaranteed Windows 32 bit binary ...

Enjoy :D
Attachments
OpenTTD-gad661986-Win32.7z
(5.45 MiB) Downloaded 45 times
TrueSatan
Transport Coordinator
Transport Coordinator
Posts: 291
Joined: 16 Jul 2003 18:33

Re: New map features

Post by TrueSatan »

cirdan wrote:
arsenlupin wrote:Situation: two trains have different speed passing through tunnel with signal simultaneously occur Floating point exception.
Thanks for your report. The crash was a division by zero when the rear engine of a dual-headed train partially into a tunnel and stuck behind another, slower train tried to produce a spark. I have just pushed an update to the repo that should fix this.
TrueSatan wrote:Tried to load the crash savegame and got a crash as well. Missing only a few graphics, guess they don't matter.
[snip]
Maybe it helps for finding the bug Cirdan.
Your crash happens at a different place, so it seems unrelated to the other one. Were you doing something when it crashed, like placing rail (that is what the stacktrace suggests)? Could you recheck and report back if the crash persists with today's snapshot?
Funny thing, I only loaded the crash.sav provided by arsenlupin. Nothing more nothing less, I couldn't even do anything it crashed immediately.
I will check if it happens again. Maybe there is something else fishy in his save game.
Edit: oopsy it was the wrong crashlog. Nevermind. Game still crashes though but maybeIt was because of the missing graphic files. With trains in NML
the game runs.

Thanks for the fast bugfix :)
Compiled for Ubuntu 14.04 64bit as usual.

Cheers
Attachments
openttd-custom-gad661986-UNIX.tar.xz
Version: gad661986
Ubuntu 14.04 64bit
(4.63 MiB) Downloaded 36 times
arsenlupin
Engineer
Engineer
Posts: 4
Joined: 23 May 2015 05:51

Re: New map features

Post by arsenlupin »

Thank you for lightening-fast commit :)
I've pulled and compiled on Ubuntu 15.04, there was no crash or bug on 6+ hours play. :o

By the way, is there someone having trouble with compiling using make with file not found error of <tr1/memory> on OS X Yosemite?
Tried troubleshooting guide for Mavericks on https://wiki.openttd.org/Compiling_on_Mac_OS_X but it just resolves some warnings.

Code: Select all

[LANG] Compiling strgen/strgen_base.cpp
In file included from /Users/***/workspace/fttd/src/strgen/strgen_base.cpp:14:
/Users/***/workspace/fttd/src/strgen/../core/pointer.h:35:12: fatal error: 
      'tr1/memory' file not found
#  include <tr1/memory>
           ^
1 error generated.
make[1]: *** [strgen_base.o] Error 1
make: *** [all] Error 1
User avatar
cirdan
Director
Director
Posts: 539
Joined: 07 Apr 2007 18:08

Re: New map features

Post by cirdan »

That error is related to the detection of smart pointer classes. The code requires at least an implementation of a shared pointer in the library. Now, while most (all?) supported compilers have a working shared_ptr somewhere, the problem is finding it: the canonical place is namespace std in header <memory>, but sometimes the namespace is std::tr1 and sometimes the header is <tr1/memory>, and these two do not always come together. So I use a simple static heuristic at compile time that checks for compiler type and version, which seems to fail in your case. What compiler are you using?

You can also try to tweak the checks for your particular case yourself. In file src/core/pointer.h, delete lines 27 to 56 and substitute this:

Code: Select all

#include <memory>
#define ttd_shared_ptr std::shared_ptr
#define ttd_unique_ptr ttd_shared_ptr
#define TTD_UNIQUE_PTR_USABLE 0
Try replacing <memory> in the first line by <tr1/memory> and/or std::shared_ptr in the second line by std::tr1::shared_ptr until it compiles. If none of the four combinations works, then I would very much like to hear about your setup. If one of those combinations does work, you will get a working binary (barring other errors, of course), and you can further fine-tune your compilation by replacing ttd_shared_ptr in the third line by std::unique_ptr and, if that succeeds, by setting TTD_UNIQUE_PTR_USABLE to 1 in the last line. These two changes should reduce pointer overhead if you have a fully working C++11 environment.
Hafting
Engineer
Engineer
Posts: 106
Joined: 13 Feb 2014 11:22

Re: New map features

Post by Hafting »

Crash report

Seeing congestion, I tried to optimize my railway a bit. Some trains don't use the depot shown in the crash image, so I was building a line with less corners. Fast trains will not slow down so much, or so is the theory.To connect the line, I had to remove a signal. You can see the cursor in the screen dump - ctrl-clicking the tile crashed my game.
crash.png
Crash image, showing where I clicked to remove a signal.
(1.84 MiB) Downloaded 4 times
I can only guess that this is something about "removing a signal with a moving train on top, with the other end of the train inside a depot" ?

Code: Select all

Crash encountered, generating crash log...
*** OpenTTD Crash Report ***

Crash at: Fri Jun 12 13:08:40 2015
In game date: 1988-05-28 (21)

Crash reason:
 Signal:  Aborted (6)
 Message: Assertion failed at line 2772 of /usr/src/openttd/src/train_cmd.cpp: v->trackdir != TRACKDIR_DEPOT

Binary:
 Version:    gad661986 (0)
 NewGRF ver: 16006a83
 Build date: Jun  2 2015 13:30:23
 Flags:      64-bit little-endian

Stacktrace:
 [00] /usr/local/games/openttd() [0x6c2ad8]
 [01] /usr/local/games/openttd() [0x6b4ce8]
 [02] /usr/local/games/openttd() [0x6c2a5f]
 [03] /usr/lib/libc.so.6(+0x335b0) [0x7f0cf474a5b0]
 [04] /usr/lib/libc.so.6(gsignal+0x38) [0x7f0cf474a528]
 [05] /usr/lib/libc.so.6(abort+0x16a) [0x7f0cf474b93a]
 [06] /usr/local/games/openttd() [0x5c76b0]
 [07] /usr/local/games/openttd() [0x6e6fc0]
 [08] /usr/local/games/openttd() [0x5f65f0]
 [09] /usr/local/games/openttd() [0x511ea5]
 [10] /usr/local/games/openttd() [0x512488]
 [11] /usr/local/games/openttd() [0x5e9250]
 [12] /usr/local/games/openttd() [0x6aff74]
 [13] /usr/local/games/openttd() [0x67d3a5]
 [14] /usr/local/games/openttd() [0x5db40b]
 [15] /usr/lib/libc.so.6(__libc_start_main+0xf0) [0x7f0cf4737790]
 [16] /usr/local/games/openttd(_start+0x29) [0x4a0a79]

Operating system:
 Name:     Linux
 Release:  4.0.1-1-ARCH
 Version:  #1 SMP PREEMPT Wed Apr 29 12:00:26 CEST 2015
 Machine:  x86_64
 Compiler: GCC 5.1.0 "5.1.0"

Configuration:
 Blitter:      32bpp-sse4-anim
 Graphics set: zBase (5588)
 Language:     /usr/local/share/games/openttd/lang/norwegian_bokmal.lng
 Music driver: extmidi
 Music set:    NoMusic (0)
 Network:      no
 Sound driver: null
 Sound set:    NoSound (2)
 Video driver: sdl

Fonts:
 Small:  DejaVu Sans
 Medium: DejaVu Sans
 Large:  DejaVu Sans
 Mono:   sprite

AI Configuration (local: 0):
  0: Human
  1: CluelessPlus (v37)
  2: DictatorAI (v169)
  3: FastPTPAI (v4)
  4: OtviAI (v418)
  5: DictatorAI (v169)
 GS: Renewed City Growth (v5)

Libraries:
 FontConfig: 2.11.1
 FreeType:   2.5.5
 ICU:        55.1
 LZMA:       5.2.1
 LZO:        2.09
 PNG:        1.6.16
 SDL:        1.2.15
 Zlib:       1.2.8

---- gamelog start ----
Tick 0: New game
    Revision text changed to gad661986, savegame version 23, not modified, newgrf version 0x16006a83
    New game mode 1, landscape 1
    Added NewGRF: GRF ID F1250005, checksum 955C122CEFCC91F1EDAB646F7DF7D141, filename: firs_industry_replacement_set-1.4.4/firs.grf (md5sum matches)
    Added NewGRF: GRF ID 52571201, checksum 9548AAA21E5B7E8168B3B19EF8290A83, filename: grvts32.grf (md5sum matches)
    Added NewGRF: GRF ID 33325A43, checksum 8767596EEC0C25A41B060D834C356402, filename: 32bpp_ez-0.1.grf (md5sum matches)
    Added NewGRF: GRF ID 44440A01, checksum FCEEC76CF44EC23E7FE9C88048CF11CC, filename: av8_aviators_aircraft_set-2.21/pb_av8w.grf (md5sum matches)
*** OpenTTD Crash Report ***

Crash at: Fri Jun 12 13:08:40 2015
In game date: 1988-05-28 (21)

Crash reason:
 Signal:  Aborted (6)
 Message: Assertion failed at line 2772 of /usr/src/openttd/src/train_cmd.cpp: v->trackdir != TRACKDIR_DEPOT

Binary:
 Version:    gad661986 (0)
 NewGRF ver: 16006a83
 Build date: Jun  2 2015 13:30:23
 Flags:      64-bit little-endian

Stacktrace:
 [00] /usr/local/games/openttd() [0x6c2ad8]
 [01] /usr/local/games/openttd() [0x6b4ce8]
 [02] /usr/local/games/openttd() [0x6c2a5f]
 [03] /usr/lib/libc.so.6(+0x335b0) [0x7f0cf474a5b0]
 [04] /usr/lib/libc.so.6(gsignal+0x38) [0x7f0cf474a528]
 [05] /usr/lib/libc.so.6(abort+0x16a) [0x7f0cf474b93a]
 [06] /usr/local/games/openttd() [0x5c76b0]
 [07] /usr/local/games/openttd() [0x6e6fc0]
 [08] /usr/local/games/openttd() [0x5f65f0]
 [09] /usr/local/games/openttd() [0x511ea5]
 [10] /usr/local/games/openttd() [0x512488]
 [11] /usr/local/games/openttd() [0x5e9250]
 [12] /usr/local/games/openttd() [0x6aff74]
 [13] /usr/local/games/openttd() [0x67d3a5]
 [14] /usr/local/games/openttd() [0x5db40b]
 [15] /usr/lib/libc.so.6(__libc_start_main+0xf0) [0x7f0cf4737790]
 [16] /usr/local/games/openttd(_start+0x29) [0x4a0a79]

Operating system:
 Name:     Linux
 Release:  4.0.1-1-ARCH
 Version:  #1 SMP PREEMPT Wed Apr 29 12:00:26 CEST 2015
 Machine:  x86_64
 Compiler: GCC 5.1.0 "5.1.0"

Configuration:
 Blitter:      32bpp-sse4-anim
 Graphics set: zBase (5588)
 Language:     /usr/local/share/games/openttd/lang/norwegian_bokmal.lng
 Music driver: extmidi
 Music set:    NoMusic (0)
 Network:      no
 Sound driver: null
 Sound set:    NoSound (2)
 Video driver: sdl
    Added NewGRF: GRF ID 4A430002, checksum 332F5EE83BB1A8F7C1766E610B48A222, filename: indstatr_32.grf (md5sum matches)
    Added NewGRF: GRF ID 43415000, checksum 4DA9FE9A87DD330EBAD43916771BAF21, filename: opengfx_airports-0.4.2/ogfx-airports.grf (md5sum matches)
    Added NewGRF: GRF ID EC0D9110, checksum D1510A1006B03BCDAAFE562D5D05BACF, filename: raise_landscaping_costs.2/raise_landscaping_costs.grf (md5sum matches)
    Added NewGRF: GRF ID 48530101, checksum EC17E22A38C037D156BD22A96F4A8523, filename: reduced_passenger_payment.1.0/reducedpassengerpayment.grf (md5sum matches)
    Added NewGRF: GRF ID 54670901, checksum F3699B81A7B2BB59EABD49164AE53796, filename: TGrandom.grf (md5sum matches)
    Added NewGRF: GRF ID 44440000, checksum A15C21BAFCC06FBB85CDB2E7CB945667, filename: pineapple_trains-1.2/pb_trains_10cc.grf (md5sum matches)
    Added NewGRF: GRF ID 414E0201, checksum 536506BDDDBD8644815FC2E7E6A80D7A, filename: fish_2-2.0.2/fish.grf (md5sum matches)
    Game started
Tick 32791: Load game
    Game loaded
Tick 7382: Load game
    Game loaded
---- gamelog end ----

*** End of OpenTTD Crash Report ***
Savegame also attached. Hope it helps improving an already excellent game :-)
Attachments
crash.sav
(300.05 KiB) Downloaded 34 times
arsenlupin
Engineer
Engineer
Posts: 4
Joined: 23 May 2015 05:51

Re: New map features

Post by arsenlupin »

Hello! Set gcc version as 4.9+ just make succeed compile on OS X Yoseimite.
Thank you again!

But I'm back with new crash report.
It also produced on train_cmd.cpp, same as Hafting.

Code: Select all

Crash reason:
 Signal:  Aborted (6)
 Message: Assertion failed at line 3132 of /home/lupin/workspace/fttd/src/train_cmd.cpp: abs((int)(GetSlopePixelZ(x, y) - v->z_pos)) < 3

Binary:
 Version:    gad661986M (2)
 NewGRF ver: 16006a83
 Build date: Jun  7 2015 16:33:26
 Flags:      64-bit little-endian

Stacktrace:
 [00] /home/***/workspace/fttd/bundle/openttd(_ZNK12CrashLogUnix13LogStacktraceEP7stringb+0x7b) [0x74464b]
 [01] /home/***/workspace/fttd/bundle/openttd(_ZNK8CrashLog12FillCrashLogEP7stringb+0x134) [0x623914]
 [02] /home/***/workspace/fttd/bundle/openttd(_ZNK8CrashLog12MakeCrashLogEv+0xcc) [0x62416c]
 [03] /home/***/workspace/fttd/bundle/openttd() [0x744495]
 [04] /lib/x86_64-linux-gnu/libc.so.6(+0x352f0) [0x7f87069992f0]
 [05] /lib/x86_64-linux-gnu/libc.so.6(gsignal+0x37) [0x7f8706999267]
 [06] /lib/x86_64-linux-gnu/libc.so.6(abort+0x16a) [0x7f870699aeca]
 [07] /home/***/workspace/fttd/bundle/openttd() [0x731fcf]
 [08] /home/***/workspace/fttd/bundle/openttd() [0x854a4e]
 [09] /home/***/workspace/fttd/bundle/openttd(_Z15TrainControllerP5TrainP7Vehicleb+0x3b0) [0x855050]
 [10] /home/***/workspace/fttd/bundle/openttd() [0x857d9f]
 [11] /home/***/workspace/fttd/bundle/openttd(_ZN5Train4TickEv+0x59) [0x858799]
 [12] /home/***/workspace/fttd/bundle/openttd(_Z16CallVehicleTicksv+0x106) [0x86a016]
 [13] /home/***/workspace/fttd/bundle/openttd(_Z13StateGameLoopv+0xb0) [0x7347a0]
 [14] /home/***/workspace/fttd/bundle/openttd(_Z8GameLoopv+0x140) [0x735700]
 [15] /home/***/workspace/fttd/bundle/openttd(_ZN15VideoDriver_SDL8MainLoopEv+0x202) [0x877982]
 [16] /home/***/workspace/fttd/bundle/openttd(_Z12openttd_mainiPPc+0x1589) [0x733b19]
 [17] /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf0) [0x7f8706984a40]
 [18] /home/***/workspace/fttd/bundle/openttd(_start+0x29) [0x577b49]
Unlike first report, infrastructure on map is too much, so I cannot specify the situation make crash.
I'll upload extra information if you need.
arsenlupin
Engineer
Engineer
Posts: 4
Joined: 23 May 2015 05:51

Re: New map features

Post by arsenlupin »

I found the situation via debugging.
On train_cmd.cpp, function TrainEnter_Track restricts the slope least than 3. But ground slope of newly lay rail track on edge of bridge was 8, so it make assertion failure.
EA#0.png
(417.15 KiB) Downloaded 3 times
I've modify assertion condition to 9 it makes not crash anymore but makes side effect like below screenshot.
EA#1.png
(418.18 KiB) Downloaded 3 times
Eddi
Tycoon
Tycoon
Posts: 8271
Joined: 17 Jan 2007 00:14

Re: New map features

Post by Eddi »

this call fails to convert the tile slope (steep slope) into the foundation slope (flat)
User avatar
cirdan
Director
Director
Posts: 539
Joined: 07 Apr 2007 18:08

Re: New map features

Post by cirdan »

Hafting wrote:Crash report

Seeing congestion, I tried to optimize my railway a bit. Some trains don't use the depot shown in the crash image, so I was building a line with less corners. Fast trains will not slow down so much, or so is the theory.To connect the line, I had to remove a signal. You can see the cursor in the screen dump - ctrl-clicking the tile crashed my game.
Thanks for your bug report.
Hafting wrote:I can only guess that this is something about "removing a signal with a moving train on top, with the other end of the train inside a depot" ?
Yes, this is giving me no small amount of headaches. But this time I may have found the way to get rid of all these "partially into a depot" bugs. I still have some testing to do, but I should have a fix ready in a few days.
arsenlupin wrote:Hello! Set gcc version as 4.9+ just make succeed compile on OS X Yoseimite.
Thank you again!
Glad to help.
arsenlupin wrote:But I'm back with new crash report.
It also produced on train_cmd.cpp, same as Hafting.
...although it is a different bug. Yours is something that I missed when I allowed custom bridgeheads on steep slopes. Easy enough to fix, but I will wait until I have the other one fully sorted out. Thank you too!
User avatar
cirdan
Director
Director
Posts: 539
Joined: 07 Apr 2007 18:08

Re: New map features

Post by cirdan »

I have updated the repository with fixes for the bugs reported last week (crash when removing signals under a train that is partially into a depot, reported by Hafting; crash when using a custom bridge head on a steep tile, reported by arsenlupin).

There is also one new feature. The town window now has a button to show the station influence area for the town, i.e., the area where a station (as represented by its sign tile) contributes to town growth and company rating improvement. In the attached picture, the southern station would help the town grow, but the northern one would not.
Attachments
townarea.png
townarea.png (175.62 KiB) Viewed 1772 times
User avatar
wallyweb
Tycoon
Tycoon
Posts: 6102
Joined: 27 Nov 2004 15:05
Location: Canada

Re: New map features

Post by wallyweb »

cirdan wrote:I have updated the repository
:bow:
and here is the Win32 binary ...
Enjoy
:D
Attachments
OpenTTD-g29408edb-Win32.7z
(5.45 MiB) Downloaded 56 times
TrueSatan
Transport Coordinator
Transport Coordinator
Posts: 291
Joined: 16 Jul 2003 18:33

Re: New map features

Post by TrueSatan »

And here as usual the Ubtuntu 64 bit version for 14.04
Attachments
openttd-custom-g29408edb-UNIX.tar.xz
Version:g29408edb
Ubuntu 14.04 64bit
(4.64 MiB) Downloaded 37 times
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 21 guests