New map features

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

User avatar
romazoon
Tycoon
Tycoon
Posts: 1291
Joined: 20 Jun 2010 23:16

Re: New map features

Post by romazoon »

nice to see you found the bug ;) looking forward the updated version :)
User avatar
cirdan
Director
Director
Posts: 539
Joined: 07 Apr 2007 18:08

Re: New map features

Post by cirdan »

I have just updated my branch at the usual place. The update fixes a crash when a company that owns a rail tunnel goes bankrupt, as reported by romazoon (thanks!). It also includes cherry-picks from openttd trunk up to r26438, and further cleanups in the pathfinding code, although these are not user-visible. (Most notably, debugging YAPF cache issues is way easier and more reliable now, because any cache incoherency will be detected, not just those that change the pathfinding result, and will be detected at the earliest opportunity. Moreover, some spurious cache error reports have been removed. Thanks to this, the YAPF cache is now used more aggressively.)
wallyweb wrote:TTDPatch controls platform access with programmable signals, however, platform numbering would be easier to manage. I like it.
I have heard of these programmable signals before, but I think they are an overkill for the task at hand (not that I am saying that they are bad, just too complex for what we want here). Plus platform numbers and new signals are not mutually exclusive. I guess most people would feel more confortable routing trains to specific platforms than programming signals.
wallyweb wrote:Could it also be applied to the dock discussion above?
Certainly; in fact, they may be a better starting point, since docks are individual entities and therefore easier to handle, unlike platforms, which (usually) consist of several tiles.

(But please do not get too excited about new features; recently, I am finding less time to hack the code than I used to.)
Pyoro wrote:Has anyone managed to combine more height levels with this? Seems like something rather difficult to do; or at least it's clearly beyond me ^^;
Now that you mention it... One of the reasons I designed a new map array was precisely to allow for more height levels. If you look at the map array, you will see that one byte per tile contains the map zone (only in sub-tropic climate) and the tile height, up to 16, but there is room left for expansion. I had the idea of either allowing heights up to 64 or only up to 32 but increase the number of zones in the map (for an all-climate map, for example). In any case, we could bump the maximum height to 32 now and leave the decision for later.

What difficulties are you facing? Is the more-height-levels patch actively maintained and working?
TrueSatan
Transport Coordinator
Transport Coordinator
Posts: 291
Joined: 16 Jul 2003 18:33

Re: New map features

Post by TrueSatan »

[quote="cirdan"]I have just updated my branch at the usual place. The update fixes a crash when a company that owns a rail tunnel goes bankrupt, as reported by romazoon (thanks!). It also includes cherry-picks from openttd trunk up to r26438, and further cleanups in the pathfinding code, although these are not user-visible. (Most notably, debugging YAPF cache issues is way easier and more reliable now, because any cache incoherency will be detected, not just those that change the pathfinding result, and will be detected at the earliest opportunity. Moreover, some spurious cache error reports have been removed. Thanks to this, the YAPF cache is now used more aggressively.)

And compiled the new branch as linux version. Unbuntu 13.10 64bit again.
Seen that there is a lot about yapf again :)

My save game is running, so no obvious bugs for now.

Thanks again for the efforts cirdan.

Happy dispatching.
Attachments
openttd-custom-g751d5abf-UNIX.tar.xz
Ubuntu 13.10 64bit
Git ver. 751d5abf
(4.52 MiB) Downloaded 69 times
User avatar
wallyweb
Tycoon
Tycoon
Posts: 6102
Joined: 27 Nov 2004 15:05
Location: Canada

Re: New map features

Post by wallyweb »

cirdan wrote:
wallyweb wrote:TTDPatch controls platform access with programmable signals, however, platform numbering would be easier to manage. I like it.
I have heard of these programmable signals before, but I think they are an overkill for the task at hand (not that I am saying that they are bad, just too complex for what we want here). Plus platform numbers and new signals are not mutually exclusive. I guess most people would feel more confortable routing trains to specific platforms than programming signals.
Agreed ... as I noted, platform numbering would be easier to manage. 8)
There will be some interesting considerations. Let me know when you are ready for them and I will post them.
(But please do not get too excited about new features; recently, I am finding less time to hack the code than I used to.)
My future feature requests are hereby consigned to the depths of my freezer (alongside best unused credit cards). Keep in mind that the growth in quantity is directly proportional to elapsed time on ice. :wink:

And now, what we have all been waiting for ...
OpenTTD-g751d5abf-Win32.7z
(5.13 MiB) Downloaded 81 times
The usual lack of warrantee applies.

Enjoy. :D
User avatar
cirdan
Director
Director
Posts: 539
Joined: 07 Apr 2007 18:08

Re: New map features

Post by cirdan »

wallyweb wrote:My future feature requests are hereby consigned to the depths of my freezer (alongside best unused credit cards). Keep in mind that the growth in quantity is directly proportional to elapsed time on ice. :wink:
Oh, I did not mean it that way. Suggestions are always welcome; I just meant that I have limited time for them, so some of them may never be at the top of my list.
User avatar
wallyweb
Tycoon
Tycoon
Posts: 6102
Joined: 27 Nov 2004 15:05
Location: Canada

Re: New map features

Post by wallyweb »

cirdan wrote:
wallyweb wrote:My future feature requests are hereby consigned to the depths of my freezer (alongside best unused credit cards). Keep in mind that the growth in quantity is directly proportional to elapsed time on ice. :wink:
Oh, I did not mean it that way. Suggestions are always welcome; I just meant that I have limited time for them, so some of them may never be at the top of my list.
Not to worry ... I'm sure that some of them will be too hot to freeze. 8)
User avatar
Pyoro
Tycoon
Tycoon
Posts: 2558
Joined: 17 Oct 2008 12:17
Location: Virgo Supercluster

Re: New map features

Post by Pyoro »

cirdan wrote:What difficulties are you facing? Is the more-height-levels patch actively maintained and working?
The latest one is from January, so it's not exactly brand-new but presumably within reasonable ... err ... reach ;)

Patch is simply too big and difficult to understand for me to adapt (not really blaming the patch or anything. It's actually nicely divided into smaller patches). Just thought maybe someone with some actual programming knowledge had the patience to merge them (since as you said it's actually a rather logical combination ;) ). Unfortunately the current patch packs don't seem to include your patches yet, so I'll just wait and see if someone updates any of them or creates a new one or whatever ...
... maybe trunk inclusion? Ha ...

...weather is getting too good and I'm lacking time right now anyways ^^;
User avatar
romazoon
Tycoon
Tycoon
Posts: 1291
Joined: 20 Jun 2010 23:16

Re: New map features

Post by romazoon »

Hey Cirdan.

Am I suposed to be able to load a savegame or scenario made with OTTD 1.4.0 into your forked version ? I would understand if not, but at the moment when i just click the savegame i'd like to load, the game instantly crash and return to windows with a crash report...so i suspect a bug.

here is how it happens : I load a scenario in 1.4.0 (actually South American Corsica, available on bananas), i edit it (not adding newgrf) and save it. Now, i open your ottd forked version to play it. a the moment i click on the scenario, game crash and return to windows.

i understand i could use the scenario editor from your version and crash would not happen, but using a stable version to make a scenario (many hours of works) sounds more productive on the long term.

Also i m planning in the near future (mid-may) to test your version on multiplayer ( i m thinking cooperativ, no competition), so if some players are interested pm me. But before that, Cirdan, is your version suposed to work in multiplayer (if yes, any feedback about it yet) ?



here is crash log :

*** OpenTTD Crash Report ***

Crash at: Sun Apr 27 17:33:29 2014
In game date: 2051-05-09 (27)

Crash reason:
Exception: C0000005
Location: 006C0CF1
Message: <none>

OpenTTD version:
Version: g9d44e037 (0)
NewGRF ver: 150064d0
Bits: 32
Endian: little
Dedicated: no
Build date: Apr 4 2014 22:04:16

Registers:
EAX: 00000043 EBX: 02F58128 ECX: 0028B8B8 EDX: 0026B76C
ESI: 0026B62C EDI: 0026B6EC EBP: 0026B62C ESP: 0026B59C
EIP: 006C0CF1 EFLAGS: 00010246

Bytes at instruction pointer:
80 78 FE FF 0F 84 3D 01 00 00 8A 50 FB 80 FA E8 0F 84 58 01 00 00 80 FA

Stack trace:
00000042 0026B7C0 0057EB7D 00000000 00000000 00000000 0057E4D4 40000000
0026B76C 00000000 00000000 00000000 00000000 00000000 00000000 0026B82C
0000018C 254BE618 0028FFC4 02F58128 0026B62C 0026B6EC 0026B804 006C1636
0000002D 0000001C 00000000 02000002 02D881A8 A70002A5 00000000 0028FFC4
00000000 000007FF 0026B6EC 0026B76C 00000000 00000000 00000000 00000000
00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
00000000 00000000 00000000 00000000 0026B7F0 00000000 0026B7F4 0026B7F8
00000000 0026B804 0026B7FC 0026B800 0026B808 00000000 00000000 00000000
00000000 00000000 00000000 00000000 00000000 00000000 0026B80C 007BE509
00000000 00000000 00000000 006C15BC 40000000 00000000 00000000 00000000
00000000 00000000 00000000 00000000 0026B7F0 00000000 0026B7F4 0028B8A4
00000000 0028B8B0 0028B8A8 0028B8AC 0028B8B4 00000000 00000000 00000000
00000000 00000000 00000000 00000000 00000000 00000000 0028B8B8 00000043
00000000 00000000 00000000 0057E4D4 40000000 00000000 00000000 00000000
00000000 00000000 00000000 00000000 00863140 0078B6A4 249B3FEC 02F58128
0028B898 00000004 006C97C4 007BE509 02F58128 00000001 00000004 76B92A00
0028B8D8 0028B898 0028B8D8 0057EB7D 02F58148 0092C5E4 006ED380 012901AC
01290000 0000013D 00000024 00F2009C 03030303 03030303 03030303 03030303
03030303 03030303 03030303 03030303 03030303 03030303 03030303 03030303
4550414D 00400000 00000000 00000000 00000000 00000000 00000000 00000000

Operating system:
Name: Windows
Release: 6.1.7601 (Service Pack 1)
Compiler: GCC 4.6.2 "4.6.2"

Configuration:
Blitter: 8bpp-optimized
Graphics set: original_windows (0)
Language: C:\Users\andylu\Desktop\Spiel\OTTD Newmapfeature\OpenTTD-g9d44e037-Win32\lang\french.lng
Music driver: win32
Music set: NoMusic (0)
Network: no
Sound driver: win32
Sound set: NoSound (2)
Video driver: win32

Fonts:
Small: Arial
Medium: Arial
Large: Arial
Mono: sprite

AI Configuration (local: 0):
0: Human

Libraries:
FreeType: 2.4.10
LZMA: 5.0.4
LZO: 2.06
PNG: 1.5.16
Zlib: 1.2.8

Module information:
C:\Users\andylu\Desktop\Spiel\OTTD Newmapfeature\OpenTTD-g9d44e037-Win32\openttd.exe handle: 00400000 size: 10750463 crc: 58559C13 date: 2014-04-05 01:09:03
C:\Windows\SysWOW64\ntdll.dll handle: 77e20000 size: 1292192 crc: 87C3B42F date: 2013-08-29 01:50:30
C:\Windows\syswow64\kernel32.dll handle: 75df0000 size: 1114112 crc: 8F4ED6D1 date: 2014-03-04 09:16:17
C:\Windows\syswow64\KERNELBASE.dll handle: 75940000 size: 274944 crc: C96F6E3E date: 2013-08-02 01:50:42
C:\Windows\syswow64\ADVAPI32.DLL handle: 76760000 size: 640512 crc: 939A0B41 date: 2013-08-29 01:48:17
C:\Windows\syswow64\msvcrt.dll handle: 76af0000 size: 690688 crc: DAB48B3A date: 2011-12-16 07:52:58
C:\Windows\SysWOW64\sechost.dll handle: 75b00000 size: 92160 crc: B624B29A date: 2009-07-14 01:16:13
C:\Windows\syswow64\RPCRT4.dll handle: 75f00000 size: 663552 crc: A34B30BE date: 2013-07-09 04:52:33
C:\Windows\syswow64\SspiCli.dll handle: 75850000 size: 96768 crc: 60665434 date: 2013-09-25 01:58:17
C:\Windows\syswow64\CRYPTBASE.dll handle: 75840000 size: 36864 crc: 00308E17 date: 2009-07-14 01:15:07
C:\Windows\syswow64\GDI32.dll handle: 758b0000 size: 311808 crc: 156F979F date: 2013-10-03 02:00:44
C:\Windows\syswow64\USER32.dll handle: 76340000 size: 833024 crc: 9EFE504D date: 2010-11-20 12:08:58
C:\Windows\syswow64\LPK.dll handle: 75990000 size: 25600 crc: 3A7246AE date: 2013-06-06 04:57:01
C:\Windows\syswow64\USP10.dll handle: 76060000 size: 626688 crc: 6C809B74 date: 2012-11-22 04:45:03
C:\Windows\syswow64\IMM32.DLL handle: 76a90000 size: 119808 crc: 38DB5163 date: 2010-11-20 12:08:52
C:\Windows\syswow64\MSCTF.dll handle: 76800000 size: 828928 crc: DFE09EEB date: 2009-07-14 01:15:43
C:\Windows\syswow64\SHELL32.DLL handle: 76c30000 size: 12872704 crc: C9774862 date: 2013-07-26 01:55:59
C:\Windows\syswow64\SHLWAPI.dll handle: 76000000 size: 350208 crc: 23E05F73 date: 2010-11-20 12:21:20
C:\Windows\system32\WINMM.DLL handle: 73e60000 size: 194048 crc: 849223C7 date: 2010-11-20 12:21:38
C:\Windows\syswow64\WS2_32.dll handle: 76440000 size: 206848 crc: FD00A753 date: 2010-11-20 12:21:40
C:\Windows\syswow64\NSI.dll handle: 76c00000 size: 8704 crc: 2ACE9671 date: 2009-07-14 01:16:11
C:\Windows\SysWOW64\nvinit.dll handle: 73e20000 size: 203072 crc: C5777A8E date: 2011-10-17 02:44:00
C:\Windows\syswow64\ole32.dll handle: 759a0000 size: 1414144 crc: 74A1E844 date: 2010-11-20 12:20:50
C:\Windows\system32\mswsock.dll handle: 75080000 size: 231424 crc: 2A2905A9 date: 2013-09-08 02:03:58
C:\Windows\System32\wshtcpip.dll handle: 75070000 size: 9216 crc: BA963A19 date: 2009-07-14 01:16:20
C:\Windows\system32\MMDevAPI.DLL handle: 73de0000 size: 213504 crc: 93C0AA4F date: 2010-11-20 12:19:40
C:\Windows\system32\PROPSYS.dll handle: 73ce0000 size: 988160 crc: 888D0BCB date: 2010-11-20 12:20:58
C:\Windows\syswow64\OLEAUT32.dll handle: 76590000 size: 571904 crc: 2B85E126 date: 2011-08-27 04:26:27
C:\Windows\system32\wdmaud.drv handle: 6e0a0000 size: 172032 crc: D5B9F5FA date: 2010-11-20 12:16:52
C:\Windows\system32\ksuser.dll handle: 6e090000 size: 4608 crc: EBE07232 date: 2009-07-14 01:15:35
C:\Windows\system32\AVRT.dll handle: 6e080000 size: 14336 crc: 9818237B date: 2009-07-14 01:14:58
C:\Windows\syswow64\SETUPAPI.dll handle: 77880000 size: 1667584 crc: 1D0104E8 date: 2010-11-20 12:21:16
C:\Windows\syswow64\CFGMGR32.dll handle: 75dc0000 size: 145920 crc: 377B5190 date: 2011-10-19 03:07:08
C:\Windows\syswow64\DEVOBJ.dll handle: 76100000 size: 64512 crc: 66B02A5A date: 2011-10-19 03:07:08
C:\Windows\system32\AUDIOSES.DLL handle: 73ca0000 size: 195584 crc: 0A7E52B1 date: 2010-11-20 12:18:06
C:\Windows\system32\msacm32.drv handle: 6e070000 size: 20992 crc: 73923147 date: 2009-07-14 01:14:08
C:\Windows\system32\MSACM32.dll handle: 6e050000 size: 72192 crc: ABA25814 date: 2009-07-14 01:15:42
C:\Windows\system32\midimap.dll handle: 6e040000 size: 16896 crc: C000494C date: 2009-07-14 01:15:40
C:\Windows\syswow64\CLBCatQ.DLL handle: 75d20000 size: 522240 crc: 6C130B8A date: 2009-07-14 01:15:03
C:\Windows\syswow64\psapi.dll handle: 76480000 size: 6144 crc: 25B988F9 date: 2009-07-14 01:16:12

---- gamelog start ----
Tick 62675: Load game
Conversion from OTTD savegame without gamelog, version 0, 1
Revision text changed to g9d44e037, savegame version 17, not modified, newgrf version 0x150064d0
New game mode 0, landscape 1
Game loaded
---- gamelog end ----

*** End of OpenTTD Crash Report ***
Eddi
Tycoon
Tycoon
Posts: 8258
Joined: 17 Jan 2007 00:14

Re: New map features

Post by Eddi »

the game should not crash under any data you feed it, be it a valid or invalid savegame, or a word document with a recipe for black forest cake.
User avatar
cirdan
Director
Director
Posts: 539
Joined: 07 Apr 2007 18:08

Re: New map features

Post by cirdan »

romazoon wrote:Am I suposed to be able to load a savegame or scenario made with OTTD 1.4.0 into your forked version ? I would understand if not, but at the moment when i just click the savegame i'd like to load, the game instantly crash and return to windows with a crash report...so i suspect a bug.
Yes. My branch has full backwards compatibility with itself and also with openttd; if it does not load a savegame from openttd, then that is a bug. (Openttd savegame compatibility may lag behind, so a savegame made with a very recent version of openttd may not load in my branch, but then it should point that out and not crash.)
romazoon wrote:here is how it happens : I load a scenario in 1.4.0 (actually South American Corsica, available on bananas), i edit it (not adding newgrf) and save it. Now, i open your ottd forked version to play it. a the moment i click on the scenario, game crash and return to windows.
Can you send me your scenario after editing, so that I can do some testing myself?
romazoon wrote:Also i m planning in the near future (mid-may) to test your version on multiplayer ( i m thinking cooperativ, no competition), so if some players are interested pm me. But before that, Cirdan, is your version suposed to work in multiplayer (if yes, any feedback about it yet) ?
It should. I try to keep multiplayer working, and I occasionally test a multiplayer game myself (with two running instances) when I suspect a bug, but that is very limited testing, so I cannot say I have any serious reports on multiplayer stability. If you do test my branch in multiplayer, I would appreciate any feedback.
User avatar
romazoon
Tycoon
Tycoon
Posts: 1291
Joined: 20 Jun 2010 23:16

Re: New map features

Post by romazoon »

Thanks for your answers Eddi and Cirdan

interesting problem then !

and for the edited scenario, it s attached. note that since it was for a test, i only edited a simple stretch of road of about 5 tile, then saved it...

And about the multiplayer, I will definitly give you proper feedback....i m only scared that we might play a scenario in wich we will add newgrf.
Attachments
SACorsica test.scn
the edited scenario
(1.62 MiB) Downloaded 79 times
User avatar
cirdan
Director
Director
Posts: 539
Joined: 07 Apr 2007 18:08

Re: New map features

Post by cirdan »

Thanks for your scenario. Unfortunately, it works as intended for me: when I try to load it in the same revision as you, it properly complains that it was made with an unsupported version of openttd. This means that whatever bug you are hitting is exposed by your particular environment, most likely either the OS or the compiler (I guess that you are using this binary?), and I cannot find any debugging information in your crash log.

On the other hand, the fact is that your scenario would not load in that particular revision, or in any other published one, because I have only very recently added the ability to load openttd version 188 savegames, and this work is still unpublished. I will try to push this change soon, so we can see if your problem persists.
User avatar
romazoon
Tycoon
Tycoon
Posts: 1291
Joined: 20 Jun 2010 23:16

Re: New map features

Post by romazoon »

cirdan wrote: this binary
oh yes sorry, i forgot to mention it in my message (i knew you would find i in the crashreport)...
but I have just done now a small test with the more recent version from the22/04 from wallyweb and the crash is identical. it just crash if i click a savegame/scenario that was not made with the your revision or, it seems, that was not made with an old enough version of OTTD --> England and Wales scenario (from bananas) is a perfect exemple : all version i have work till the V2.8 included, but the more recent V2.8.5 make the crash happen (just by clicking it).

Anyway, i really appreciate that you gave a look at what might be wrong, and since you tell me that my savegame would anyway not load, there is no problem :mrgreen: I will be patitent and look forward that revision that will load it ;)
TrueSatan
Transport Coordinator
Transport Coordinator
Posts: 291
Joined: 16 Jul 2003 18:33

Re: New map features

Post by TrueSatan »

I can confirm the crash from romazoon if you try the england and wales scenario with wally's version.
So we just have to wait for the bump cirdan did and compile a new version afterwards :)

Interesting bug, guess such crash should never happen anyway.

edit: checked with the linux version and the crash did not happen. It shows that a newer version was used for the scenario.
either there is a bug in the windows version (should be easy to check with a none patched version that is bit older
and try to play the scenario) or something went wrong while compiling (guess that's unlikely ;) )

a few hours l8er another edit ;)
strange but it only happens with wally's builds.
powered up my windows development vm and compiled it (without sld and icu) and it doesn't crash.
can you verify this please . Thanks.

Regards
Attachments
openttd-g751d5abf-win32.7z
(4.7 MiB) Downloaded 73 times
User avatar
romazoon
Tycoon
Tycoon
Posts: 1291
Joined: 20 Jun 2010 23:16

Re: New map features

Post by romazoon »

Hey True Satan, Thanks for testing and compiling again ! The crash is indeed not happening with your compilation !!
User avatar
wallyweb
Tycoon
Tycoon
Posts: 6102
Joined: 27 Nov 2004 15:05
Location: Canada

Re: New map features

Post by wallyweb »

Interesting ... Must be something in my set up. Anybody have any hints on where I should look?

Definie difference in the exe file sizes ... mine is larger.
Attachments
Wally's on left
Wally's on left
FileSizeDifference.png (26.09 KiB) Viewed 515 times
Last edited by wallyweb on 03 May 2014 11:14, edited 1 time in total.
Eddi
Tycoon
Tycoon
Posts: 8258
Joined: 17 Jan 2007 00:14

Re: New map features

Post by Eddi »

start by compiling with debug symbols and reproducing the crash with a proper backtrace.
User avatar
wallyweb
Tycoon
Tycoon
Posts: 6102
Joined: 27 Nov 2004 15:05
Location: Canada

Re: New map features

Post by wallyweb »

Eddi wrote:start by compiling with debug symbols and reproducing the crash with a proper backtrace.
Considering the differences in the file size I added to my post as you were posting, is it possible to do a diff between the two binaries?
Eddi
Tycoon
Tycoon
Posts: 8258
Joined: 17 Jan 2007 00:14

Re: New map features

Post by Eddi »

there is no useful way to do a binary diff.
User avatar
wallyweb
Tycoon
Tycoon
Posts: 6102
Joined: 27 Nov 2004 15:05
Location: Canada

Re: New map features

Post by wallyweb »

Eddi wrote:there is no useful way to do a binary diff.
I was afraid of that.
My OS is Windows7.
My regular OTTD is 1.3.1.
I started 1.3.1 and saved a game.
I started my binary and loaded the saved game. No problem.
I let the gae run a bit and saved it.
I returned to 1.3.1 and loaded the first saved game. No problem.
I tried to load the second save game and got:
BinaryIssue.png
BinaryIssue.png (18.34 KiB) Viewed 2563 times
There was no crash.
There was no problem using TrueSatan's windows binary.
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 9 guests