New map features

[wallyweb]

Found a bug ...

I can confirm this on Windows.
Details:

Crash.png (22.71 KiB) Viewed 2701 times

Code: Select all

*** OpenTTD Crash Report ***

Crash at: Sun Jul 27 06:58:29 2014
In game date: 1920-01-01 (0)

Crash reason:
 Exception: E1212012
 Location:  76B9C42D
 Message:   Assertion failed at line 105 of C:/MinGW/msys/1.0/home/Adminguy/fttd/src/map/tilearea.h: dx < this->w

Binary:
 Version:    gc170ccb4M (2)
 NewGRF ver: 150064d0
 Build date: Jul 27 2014 03:00:37

 Flags:      32-bit little-endianRegisters:
 EAX: 0028AD90 EBX: 00000016 ECX: 00000000 EDX: 0008E3C8
 ESI: 74B03180 EDI: 00000000 EBP: 0028ADE0 ESP: 0028AD90
 EIP: 76B9C42D EFLAGS: 00000246

 Bytes at instruction pointer:
 C9 C2 10 00 CC CC CC CC CC E9 1E 77 2E FD 56 8B 75 08 83 FE F4 72 18 83

Stack trace:
 E1212012 00000000 00000000 76B9C42D 00000000 00000246 0028ADEC 00000000
 00000000 0028ADE0 752AFD36 752AFD1E 00000206 73E85A88 752AFD36 00D80562
 76FFFAEA 77021092 FFFFFFFF 00000024 0028AE4C 0053C2A7 E1212012 00000000
 00000000 00000000 74B00290 0028AE4C 74AC5E89 74AC5E8F 00000016 7EFD5F0A
 0000000B 0028000B 0028B19C 76FFFAEA 77019DEC 00000000 00000024 0053C280
 00000001 0028AE0C 0028A934 0028BA78 74A88CD5 0A79AFFE FFFFFFFE 0028B184
 74AC8EA2 00000016 0028000B 00000010 0000000B 0028000B 752AFA50 00000001
 010032D4 00000000 000003F8 0101015A 00000000 014C0E04 0028AF50 770571F5
 08DA0C7A 00000000 00000000 752AFA6C 00000000 00000001 72F332C0 732917AC
 73291620 73291618 0028AEE8 72E982D8 73280000 00000004 73291620 732917A2
 00000000 73291648 0000015A 72ED7DD0 0C39D576 FFFFFFFE 0028AF60 72E93D3E
 72F332C0 0028AF2C 4253413A 0000049A 72F14E8C 7EE3FB4E 00DBFD80 00DBFD80
 0028AFFC 00000000 00000080 00000000 00000090 00000001 000000DA 73291648
 732917A2 0000015A 0000015A 00000000 000000CA 00000000 0028AF04 72F33B78
 0028AFCC 72ED7DD0 0C39DD5E FFFFFFFE 0028AF8C 72E93DD9 0028AF7C 00000018
 00000000 0028AFFC 00000000 00DBFD80 00000000 000000CA 0000006C 0028AFDC
 72EB3BAF 00000018 0000006C 0028AFFC 72EB3BC1 0000000B 7EFD5EA6 0028B018
 752AFB1F 0028AFB8 00000028 00D80562 00000000 00DBFD80 008F5478 00000010
 00000000 00000000 00000000 00000000 00000000 00000000 00000000 0028AE6C
 0028AE84 00000001 00000000 00000001 FFFFFFFF 00000000 00000000 00000061
 000001D8 0000009D 0028B038 752AFD15 00D80562 00DBFD80 008F5478 00000010
 00000000 FFFFFFFF 0028B070 72ED7D21 00D80562 00DBFD80 008F5478 00000010
 00000246 00000001 73E85B20 0028B108 7EFA0000 00000000 0028B07C 72E88B80
 00000001 00000085 0028B0F8 72E8A017 00000000 00000000 7EE3E4D6 0000000B

Operating system:
 Name:     Windows
 Release:  6.1.7601 (Service Pack 1)
 Compiler: GCC 4.6.2 "4.6.2"

Configuration:
 Blitter:      32bpp-anim
 Graphics set: original_windows (0)
 Language:     C:\BuildOTTD\Source_Builds\07_27_14_gc170ccb4M\OpenTTD-gc170ccb4M-Win32\lang\english.lng
 Music driver: win32
 Music set:    NoMusic (0)
 Network:      no
 Sound driver: win32
 Sound set:    NoSound (2)
 Video driver: win32

Fonts:
 Small:  sprite
 Medium: sprite
 Large:  sprite
 Mono:   sprite

AI Configuration (local: 0):
  0: Human

Libraries:
 FreeType:   2.4.10
 LZMA:       5.0.4
 LZO:        2.06
 PNG:        1.5.16
 Zlib:       1.2.8

Module information:
 C:\BuildOTTD\Source_Builds\07_27_14_gc170ccb4M\OpenTTD-gc170ccb4M-Win32\openttd.exe handle: 00400000 size: 10992590 crc: E6D9C592 date: 2014-07-27 06:05:51
 C:\Windows\SysWOW64\ntdll.dll handle: 76fe0000 size: 1292192 crc: 87C3B42F date: 2013-08-29 01:50:30
 C:\Windows\syswow64\kernel32.dll handle: 76a80000 size: 1114112 crc: 8F4ED6D1 date: 2014-03-04 09:16:17
 C:\Windows\syswow64\KERNELBASE.dll handle: 76b90000 size: 274944 crc: D5B7EFFE date: 2014-03-04 09:16:18
 C:\Program Files\Bitdefender\Bitdefender\Active Virus Control\Avc3_00248_014\avcuf32.dll handle: 72e80000 size: 780080 crc: 3B9ADFEC date: 2014-07-18 10:33:12
 C:\Windows\syswow64\ADVAPI32.DLL handle: 75660000 size: 640512 crc: 939A0B41 date: 2013-08-29 01:48:17
 C:\Windows\syswow64\msvcrt.dll handle: 74a60000 size: 690688 crc: DAB48B3A date: 2011-12-16 07:52:58
 C:\Windows\SysWOW64\sechost.dll handle: 74bd0000 size: 92160 crc: B624B29A date: 2009-07-14 01:16:13
 C:\Windows\syswow64\RPCRT4.dll handle: 76850000 size: 663552 crc: A34B30BE date: 2013-07-09 04:52:33
 C:\Windows\syswow64\SspiCli.dll handle: 749f0000 size: 96768 crc: 1E8F2A1D date: 2014-06-05 14:25:49
 C:\Windows\syswow64\CRYPTBASE.dll handle: 749e0000 size: 36864 crc: 00308E17 date: 2009-07-14 01:15:07
 C:\Windows\syswow64\GDI32.dll handle: 75a90000 size: 311808 crc: 156F979F date: 2013-10-03 02:00:44
 C:\Windows\syswow64\USER32.dll handle: 75240000 size: 833024 crc: 9EFE504D date: 2010-11-20 12:08:57
 C:\Windows\syswow64\LPK.dll handle: 74a50000 size: 25600 crc: 3A7246AE date: 2013-06-06 04:57:01
 C:\Windows\syswow64\USP10.dll handle: 74b30000 size: 626688 crc: 7CF1A954 date: 2014-04-25 02:06:17
 C:\Windows\syswow64\IMM32.DLL handle: 751e0000 size: 119808 crc: 38DB5163 date: 2010-11-20 12:08:51
 C:\Windows\syswow64\MSCTF.dll handle: 76780000 size: 828928 crc: DFE09EEB date: 2009-07-14 01:15:43
 C:\Windows\syswow64\SHELL32.DLL handle: 75b30000 size: 12874240 crc: 81F9465B date: 2014-03-25 02:09:54
 C:\Windows\syswow64\SHLWAPI.dll handle: 75400000 size: 350208 crc: 23E05F73 date: 2010-11-20 12:21:19
 C:\Windows\system32\WINMM.DLL handle: 714b0000 size: 194048 crc: 849223C7 date: 2010-11-20 12:21:36
 C:\Windows\syswow64\WS2_32.dll handle: 75110000 size: 206848 crc: FD00A753 date: 2010-11-20 12:21:38
 C:\Windows\syswow64\NSI.dll handle: 75560000 size: 8704 crc: 2ACE9671 date: 2009-07-14 01:16:11
 C:\Windows\syswow64\ole32.dll handle: 75700000 size: 1414144 crc: 74A1E844 date: 2010-11-20 12:20:49
 C:\Windows\system32\uxtheme.dll handle: 71d40000 size: 245760 crc: 60C5C746 date: 2009-07-14 01:11:24
 C:\Windows\system32\dwmapi.dll handle: 71490000 size: 67072 crc: FC7CA4B8 date: 2009-07-14 01:15:13
 C:\Program Files\Bitdefender\Bitdefender\antispam32\bdsecurepass.dll handle: 713c0000 size: 96136 crc: 3CFB7DDA date: 2014-03-27 12:15:27
 C:\Windows\syswow64\PSAPI.DLL handle: 74e40000 size: 6144 crc: 25B988F9 date: 2009-07-14 01:16:12
 C:\Windows\syswow64\OLEAUT32.dll handle: 75580000 size: 571904 crc: 2B85E126 date: 2011-08-27 04:26:27
 C:\Program Files\Bitdefender\Bitdefender\antispam32\MSVCP100.dll handle: 713e0000 size: 421200 crc: 2492E74F date: 2014-03-27 12:15:37
 C:\Program Files\Bitdefender\Bitdefender\antispam32\MSVCR100.dll handle: 70c40000 size: 773968 crc: 14EE1F12 date: 2014-03-27 12:15:07
 C:\Windows\system32\OLEACC.dll handle: 71450000 size: 233472 crc: 6B296DD6 date: 2011-08-27 04:26:27
 C:\Windows\system32\mswsock.dll handle: 70180000 size: 231424 crc: 2A2905A9 date: 2013-09-08 02:03:58
 C:\Windows\System32\wshtcpip.dll handle: 74290000 size: 9216 crc: BA963A19 date: 2009-07-14 01:16:20
 C:\Windows\system32\MMDevAPI.DLL handle: 6c4c0000 size: 213504 crc: 93C0AA4F date: 2010-11-20 12:19:39
 C:\Windows\system32\PROPSYS.dll handle: 71f60000 size: 988160 crc: 888D0BCB date: 2010-11-20 12:20:57
 C:\Windows\system32\wdmaud.drv handle: 68c40000 size: 172032 crc: D5B9F5FA date: 2010-11-20 12:16:50
 C:\Windows\system32\ksuser.dll handle: 6a340000 size: 4608 crc: EBE07232 date: 2009-07-14 01:15:35
 C:\Windows\system32\AVRT.dll handle: 6a350000 size: 14336 crc: 9818237B date: 2009-07-14 01:14:58
 C:\Windows\syswow64\SETUPAPI.dll handle: 74f70000 size: 1667584 crc: 1D0104E8 date: 2010-11-20 12:21:14
 C:\Windows\syswow64\CFGMGR32.dll handle: 75180000 size: 145920 crc: 377B5190 date: 2011-05-24 10:39:38
 C:\Windows\syswow64\DEVOBJ.dll handle: 75150000 size: 64512 crc: 66B02A5A date: 2011-05-24 10:40:05
 C:\Windows\system32\AUDIOSES.DLL handle: 6c480000 size: 195584 crc: 0A7E52B1 date: 2010-11-20 12:18:05
 C:\Windows\system32\msacm32.drv handle: 68c90000 size: 20992 crc: 73923147 date: 2009-07-14 01:14:08
 C:\Windows\system32\MSACM32.dll handle: 68c70000 size: 72192 crc: ABA25814 date: 2009-07-14 01:15:42
 C:\Windows\system32\midimap.dll handle: 6a290000 size: 16896 crc: C000494C date: 2009-07-14 01:15:40
 C:\Windows\syswow64\CLBCatQ.DLL handle: 74bf0000 size: 522240 crc: 6C130B8A date: 2009-07-14 01:15:03

---- gamelog start ----
Tick 0: New game
    Revision text changed to gc170ccb4M, savegame version 19, modified, newgrf version 0x150064d0
    New game mode 1, landscape 0
    Added NewGRF: GRF ID F1250005, checksum 71231BAE6D5F4A5878933ADB74CABEE5, filename: firs_industry_replacement_set-1.3.0\firs.grf (md5sum matches)
    Added NewGRF: GRF ID 4A430002, checksum 237EC8B4432F26C2721B69D0814045E6, filename: industrial_stations_renewal-1.0.0\indstatr.grf (md5sum matches)
    Added NewGRF: GRF ID 41501202, checksum B13DD8FB0D7C34CACAC2FE68BD137BB9, filename: heqs_heavy_equipment_set-1.5.2\heqs.grf (md5sum matches)
    Added NewGRF: GRF ID 52571208, checksum DC83DAB2933FACCB91678D4F75ABCCC6, filename: generic_cars-0.4\cars.grf (md5sum matches)
    Game started
---- gamelog end ----

*** End of OpenTTD Crash Report ***

[cirdan]

Found a bug

Tsch, tsch, I told you not to find any...

If you build a station, then an joined station and try to remove the first station the game crashes.
Does only happen if the the stations are at least 3 tiles away.

...and, for extra fun, if it is not a train station.

Strange but it happens in the version before as well.
My linux doesn't produce any logfiles or crashdumps.
I will see if I can get it crashing on my windows machine as well.

Providing a way to reliably reproduce the bug, as you did, is good enough.

The attached diff should fix the issue (apply with patch -p1). The real fix will have to wait, because I am going to take this opportunity to look into the station building code in more detail, and I will not be able to update my published branch in a few weeks, anyway. But you should be fine with this.

[wallyweb]

Found a bug

The attached diff should fix the issue

1. Hotfix patched in
2. Tested - Bug is gone
3. Windows patched binary post updated here.

Thank you cirdan for the quick fix.


EDIT: By the way, the Advanced settings window looks good and the World generation is very intuitive and easy to use. Another big Thank you.

[TrueSatan]

Thanks for fixing it Cirdan and I told you I will find and report lol
And thanks wally for testing it right away. I will be a bit l8er on my Linux machine
to apply the patch and test it

edit: applied the patch, complied it and as wally said its working now

and Regards

[Pyoro]

Does the 2014-08-13 one compile for anyone? I get a lot of complaining about linkgraphs (unfortunately in Japanese so I don't really know what it's actually complaining about ^^) ...

[wallyweb]

Does the 2014-08-13 one compile for anyone? I get a lot of complaining about linkgraphs (unfortunately in Japanese so I don't really know what it's actually complaining about ^^) ...

Usually TrueSatan and I wait until Cirdan posts here that his repo is ready for another compile. I do see from the git repo that he has been working on linkgraphs, so it is possible that he still has some work to do.

[TrueSatan]

Agreed someone has upgraded the git repro, but even the pull gives me errors for now, because i have applied the patch.
So I will, like Wally, wait for Cridans reply in here about a new version as well.
Maybe he just "parked" some code fragments there.

So i can't tell if there are compile errors or not.

Regards

[cirdan]

Okay, so you have already found out that I have been updating my branch. I am currently going through my backlog of summer work, pushing commits in small batches, and I intended to finish pushing before making an announcement. But, since you already know, this is what I have pushed so far:

• Fixed a crash when removing a station part that leaves the station sign out of the station area, as reported by TrueSatan.
• You can now have a non-ASCII character as custom currency thousands separator (for instance, a non-break space).
• Reworked some internals of ini file handling.
• Reworked some data structures used in cargodist. I did this mostly for code readability, but it also resulted in improved data locality and a smaller memory footprint.

Does the 2014-08-13 one compile for anyone? I get a lot of complaining about linkgraphs (unfortunately in Japanese so I don't really know what it's actually complaining about ^^) ...

What compiler and platform are you using? Compiling with MSVC is known-broken for a long time. I have a fix for MSVC 2008, but I would like some testing to make sure it does not make things worse for MSVC 2010. And a few days ago I learnt that my linkgraph changes broke compilation on Windows with any compiler, because of some unforeseen interaction with preprocessor macros. If this is your case, could you try the following patch?

[Pyoro]

I'm using MinGW on Win7, so probably something very similar to wallyweb, if I remember that correctly. Old versions always compiled (well, those I tried), so I suspected it was something recently changed.

And, of course, anything that helps - yes, compiles just fine with the diff applied. And OTTD runs as well ... or, at least, starts up fine.

Edit: just remembered something small: in the scenario editor, when you place a city, the name doesn't "clear" automatically. So for example you build Munich, then the name changed to "MunichBerlin". Then you build that one, get "MunichBerlinFrankfurt" and so on (until you get a CTD). Haven't dug around too deeply what's causing this, but it definitely doesn't happen in the latest trunk nightly.

Edit: I might've found something else - towns don't grow over custom bridgeheads, ie. if you connect two islands with a bridge and only make a "sharp" corner right after the connection (the way you can't without the patch) the town won't grow to the other side. Guess the town growth doesn't check corners at bridgeheads since it'd normally be impossible for them to be there ^^;

[cirdan]

I'm using MinGW on Win7, so probably something very similar to wallyweb, if I remember that correctly. Old versions always compiled (well, those I tried), so I suspected it was something recently changed.

And, of course, anything that helps - yes, compiles just fine with the diff applied. And OTTD runs as well ... or, at least, starts up fine.

Thanks for testing. The patch is already in a development branch, although it may take some time until it makes it to the published repo.

Edit: just remembered something small: in the scenario editor, when you place a city, the name doesn't "clear" automatically. So for example you build Munich, then the name changed to "MunichBerlin". Then you build that one, get "MunichBerlinFrankfurt" and so on (until you get a CTD). Haven't dug around too deeply what's causing this, but it definitely doesn't happen in the latest trunk nightly.

Edit: I might've found something else - towns don't grow over custom bridgeheads, ie. if you connect two islands with a bridge and only make a "sharp" corner right after the connection (the way you can't without the patch) the town won't grow to the other side. Guess the town growth doesn't check corners at bridgeheads since it'd normally be impossible for them to be there ^^;

Thanks for letting me know. I will take a look into this when time permits.

[TrueSatan]

Linux compilation without any problems.
Will provide the package later.
Thanks for the new version Cirdan

Cheers

[romazoon]

Would someone be kind enough to share the latest win compiled version ?

thanks in advance

[TrueSatan]

Two revisions l8er....
Cirdan was busy doing patches i guess.
So now here is the l8test version gd8c25d3a of his work as a Linux 64bit compiled executable for
Ubuntu 14.04.
I got some warnings for fileio

Code: Select all

[SRC] Compiling fileio.cpp
In file included from /home/computeradvisor/nmf/src/debug.h:16:0,
                 from /home/computeradvisor/nmf/src/fileio.cpp:14:
/home/computeradvisor/nmf/src/fileio.cpp: In member function ‘virtual bool TarScanner::AddFile(const char*, size_t, const char*)’:
/home/computeradvisor/nmf/src/string.h:364:55: warning: field precision specifier ‘.*’ expects argument of type ‘int’, but argument 4 has type ‘long unsigned int’ [-Wformat=]
  snprintf (bstrfmt__buffer, bstrfmt__size, __VA_ARGS__); \
                                                       ^
/home/computeradvisor/nmf/src/fileio.cpp:766:4: note: in expansion of macro ‘bstrfmt’
    bstrfmt (name, "%.*s" PATHSEP "%.*s",
    ^
/home/computeradvisor/nmf/src/string.h:364:55: warning: field precision specifier ‘.*’ expects argument of type ‘int’, but argument 6 has type ‘long unsigned int’ [-Wformat=]
  snprintf (bstrfmt__buffer, bstrfmt__size, __VA_ARGS__); \
                                                       ^
/home/computeradvisor/nmf/src/fileio.cpp:766:4: note: in expansion of macro ‘bstrfmt’
    bstrfmt (name, "%.*s" PATHSEP "%.*s",
    ^
/home/computeradvisor/nmf/src/string.h:364:55: warning: field precision specifier ‘.*’ expects argument of type ‘int’, but argument 4 has type ‘long unsigned int’ [-Wformat=]
  snprintf (bstrfmt__buffer, bstrfmt__size, __VA_ARGS__); \
                                                       ^
/home/computeradvisor/nmf/src/fileio.cpp:766:4: note: in expansion of macro ‘bstrfmt’
    bstrfmt (name, "%.*s" PATHSEP "%.*s",
    ^
/home/computeradvisor/nmf/src/string.h:364:55: warning: field precision specifier ‘.*’ expects argument of type ‘int’, but argument 6 has type ‘long unsigned int’ [-Wformat=]
  snprintf (bstrfmt__buffer, bstrfmt__size, __VA_ARGS__); \
                                                       ^
/home/computeradvisor/nmf/src/fileio.cpp:766:4: note: in expansion of macro ‘bstrfmt’
    bstrfmt (name, "%.*s" PATHSEP "%.*s",
    ^
/home/computeradvisor/nmf/src/string.h:364:55: warning: field precision specifier ‘.*’ expects argument of type ‘int’, but argument 4 has type ‘long unsigned int’ [-Wformat=]
  snprintf (bstrfmt__buffer, bstrfmt__size, __VA_ARGS__); \
                                                       ^
/home/computeradvisor/nmf/src/fileio.cpp:770:4: note: in expansion of macro ‘bstrfmt’
    bstrfmt (name, "%.*s", sizeof(th.name), th.name);
    ^
/home/computeradvisor/nmf/src/string.h:364:55: warning: field precision specifier ‘.*’ expects argument of type ‘int’, but argument 4 has type ‘long unsigned int’ [-Wformat=]
  snprintf (bstrfmt__buffer, bstrfmt__size, __VA_ARGS__); \
                                                       ^
/home/computeradvisor/nmf/src/fileio.cpp:770:4: note: in expansion of macro ‘bstrfmt’
    bstrfmt (name, "%.*s", sizeof(th.name), th.name);
    ^

and networ, but since i am not playing network games i ignore those for now.
Thanks Cirdan

Any bugs i will find i let you know lol
Cheers

[wallyweb]

Would someone be kind enough to share the latest win compiled version ?

thanks in advance

I prefer to compile a published repo but if you really want to try a developmental version I will compile sometime in the next 48 hours. Some real life stuff to contend with first.

[romazoon]

thank you Wally, i d be happy to try further cirdan's version take your time though, no rush

[wallyweb]

thank you Wally, i d be happy to try further cirdan's version take your time though, no rush

Sorry for the delay.
WARNING: This is NOT an official release. Use at your own risk.
WARNING: If using a saved game, BEFORE loading it into this release, copy it into a safe secure location.
WARNING: Other than making sure OpenTTD loads, this version has NOT been played or tested.

OpenTTD-gd8c25d3aM-Win32.7z

(5.2 MiB) Downloaded 49 times

[TrueSatan]

Thanks wally, was about to power up my virtual compiling machine.
Will test the version right away.
edit: loaded my savegame for windows fine. thanks for the version wally

Regards

[romazoon]

Thanks Wally, it's also running well here

And Cirdan, i loaded successfully a big savegame from 1.4.2 into this last version compiled by wally, it s awesome, working just fine, i notice only a small lag when zooming in and out wich did not occured with 1.4.2, no big deal as the game is running really smooth otherwise, but i just thought i would inform you about it

edit : lag is happening on the two latest zoom out level (more lag on the last zoom out level), and happens especially when moving the view around.

[wallyweb]

Thanks Wally, it's also running well here

Note: The cooling fan on my developer machine went toasters. It'll be at least three weeks before the new fan arrives and it gets fixed. I'm just another player until then.

[michael blunck]

The cooling fan on my developer machine went toasters. It'll be at least three weeks before the new fan arrives and it gets fixed. It´s a specially crafted fan from China, to be delivered by a genuine junk. Good thing is: it´s still in the guarantee period!

Yeah. We simple folk are depending on ordinary no-name fans, from the corner shop.

regards
Michael