[Patch] improved production change news

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

Post Reply
sulai
Traffic Manager
Traffic Manager
Posts: 159
Joined: 24 Sep 2004 18:23

[Patch] improved production change news

Post by sulai »

On large maps with much industry and smooth production change, you will get loads of news about changing production.

Most of those news have little information, and as such are simply ignored by the player. Goal of this patch is to reduce the amount of useless news.

With this patch turned on, production change is only reported if
a) production is increased, but there is no- or little transportation
b) production is decreased, but there is a lot of transportation established

This patch works both with smooth economy enabled and disabled.

Additionally, if you don't like the message history to be flooded by messages you actually turned off, there is a button to really turn off those messages. Originally those messages generate a red reminder button, and are queued into message history.
Attachments
2 new buttons added in the bottom of the Message Options.
2 new buttons added in the bottom of the Message Options.
improved_production_change_news.png (11.39 KiB) Viewed 2118 times
improved_production_change_news_r17680.diff
This patch adds both buttons into the Message Options window, as shown in the screenshot.
(10.35 KiB) Downloaded 142 times
dont_report_off_messages_r17680.diff
This is only the "report off news" button. Some messages tend to flood the message history - even if they are turned off. Result: bowsing back is a pain, message history is full of rubbish. Using this button you can really turn them off.
(6.91 KiB) Downloaded 107 times
Last edited by sulai on 07 Oct 2009 08:20, edited 3 times in total.
User avatar
SirkoZ
Tycoon
Tycoon
Posts: 1518
Joined: 06 Mar 2004 23:51
Location: The sunny side of Alps

Re: [Patch] improved production change news

Post by SirkoZ »

Interesting patch, sulai.

I have usually only enabled news messages for the industries that my company links, therefore greatly decreasing the amount of economy news.

Perhaps if it was another option apart from the current ones in the news settings window...
sulai
Traffic Manager
Traffic Manager
Posts: 159
Joined: 24 Sep 2004 18:23

Re: [Patch] improved production change news

Post by sulai »

Good idea. On smaller maps you might want to get messages for any production change. I added two buttons into the message options window. I split off the first button "Report news marked 'off'" as separate patch. See first post.
2007Alain2007
Chief Executive
Chief Executive
Posts: 658
Joined: 11 Nov 2007 12:06
Contact:

Re: [Patch] improved production change news

Post by 2007Alain2007 »

should not they match the settings as the abover ones

or be in the settings page
For Community Integrated Version http://code.google.com/p/civopenttd/
User avatar
Gremnon
Tycoon
Tycoon
Posts: 1517
Joined: 16 Sep 2005 12:23
Skype: the_gremnon
Location: /home
Contact:

Re: [Patch] improved production change news

Post by Gremnon »

sulai,
On your Don't Report Off patch, can I suggest removing the blank line at the end? With it, the patch command thinks the file ended unexpectedly, and doesn't apply the final hunk.

Also, are you meant to apply it as the Improved Production Patch first, and then the Don't Report? or does the order not matter?

Edit: Don't worry, I just realised. I didn't realist the Don't Report patch was already included in the Improved Production. My bad.
sulai
Traffic Manager
Traffic Manager
Posts: 159
Joined: 24 Sep 2004 18:23

Re: [Patch] improved production change news

Post by sulai »

Gremnon wrote:On your Don't Report Off patch, can I suggest removing the blank line at the end? With it, the patch command thinks the file ended unexpectedly, and doesn't apply the final hunk.
Thanks for that hint. I accidentally removed one line too much. I updated that patch. =)
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 11 guests