[Patch] Group by Property

[sulai]

This patch adds a drop down to the "create new group" button in the vehicle window. See the screenshot below. Using one of the entries allows you to create Vehicle Groups based on common properties of vehicles.

If you have some group selected, only vehicles out of this group are considered. For example, you may select "all trains", choose "Group old Vehicles". Select the new group and choose "Group vehicles with negative income" - you will get a group with vehicles that are both old and have negative income.

Works for all vehicle types, of course.

Old behavior is untouched: if you just click the "new group" graphical button, you will notice no changes.

It's a simple yet powerful patch. Have fun

[2007Alain2007]

sounds fun and help full theres work on the last years porfit

[Roujin]

Does it create a virtual, temporary group, or does it take the vehicles fitting the criteria out of their current group (if any) and put them into a new full-fledged group?
I can see much potential in the former idea, with an option to transform it to a full-fledged group.

Sorry for requesting stuff without even having tested your patch first, but I'm not in a position to test it right now and the thought just popped to my head.

[Gremnon]

I like the idea of this patch.

I have one small issue, namely one warning generated on compiling with it:

Code: Select all

~/svn/ottd-testing/src/group_gui.cpp: In function ‘void CcCreateGroup(bool, TileIndex, uint32, uint32)’:
~/svn/ottd-testing/src/group_gui.cpp:775: warning: comparison between signed and unsigned integer expressions

[sulai]

Does it create a virtual, temporary group, or does it take the vehicles fitting the criteria out of their current group (if any) and put them into a new full-fledged group?

It does take the vehicles fitting the criteria out of their current group (if any) and put them into a new full-fledged group. Note: only the current selected group is considered. So if you select "ungrouped vehicles", it won't touch any custom group.

warning generated on compiling with it

Thanks Gremnon! I don't get this warning and I see two possible reasons for that warning in that code line. I removed one of them (and making the code a little prettier in the same step). Could you test it again? Update see first post.

[Gremnon]

That's fixed it, no warning this time. Thanks sulai