Patch: Snow line height in create scenario window

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

Post Reply
Terkhen
OpenTTD Developer
OpenTTD Developer
Posts: 1034
Joined: 11 Sep 2008 07:32
Location: Spain

Patch: Snow line height in create scenario window

Post by Terkhen »

This simple patch adds an option in the create scenario window to change the snow line height. Without this patch, if you want a flat scenario with a certain snow line height, you have to enter into random land generation to change it, then come back to the original window.

I await your comments. Don't be too harsh, this is my first patch :D

Flyspray task: http://bugs.openttd.org/task/2545

Changes in v0.2: Removed a few comments that have been added to trunk. Everything else keeps the same.
Attachments
snowline.png
snowline.png (12.93 KiB) Viewed 3335 times
snowline_v0.2_r15116.diff
(5.12 KiB) Downloaded 173 times
Last edited by Terkhen on 16 Jan 2009 23:16, edited 1 time in total.
User avatar
atalantino
Traffic Manager
Traffic Manager
Posts: 155
Joined: 01 Jan 2009 11:30

Re: Patch: Snow line height in create scenario window

Post by atalantino »

Dont be too harsh? A patch is always appreciated. And if something is wrong its human behaviour to correct and help eachover.
FORZA BERGAMASCA CALCIO ATALANTA
Terkhen
OpenTTD Developer
OpenTTD Developer
Posts: 1034
Joined: 11 Sep 2008 07:32
Location: Spain

Re: Patch: Snow line height in create scenario window

Post by Terkhen »

Patch updated because some comments and clarifications are now in trunk. Thank you for your time, Belugas! :D
viking42
Engineer
Engineer
Posts: 26
Joined: 22 Jan 2010 14:53

Re: Patch: Snow line height in create scenario window

Post by viking42 »

Hi,

How and where to install?
Alberth
OpenTTD Developer
OpenTTD Developer
Posts: 4765
Joined: 09 Sep 2007 05:03
Location: home

Re: Patch: Snow line height in create scenario window

Post by Alberth »

viking42 wrote:How and where to install?
Patches here are always source patches.
Installation by downloading the source, installing a C++ compiler, compiling to an executable, running the unmodified executable (to check whether compiling went ok), apply patch to the source, compile again, run & play.

There is a sticky thread about how to apply a patch.
At the wiki there are explanations for the other steps afaik.
Terkhen
OpenTTD Developer
OpenTTD Developer
Posts: 1034
Joined: 11 Sep 2008 07:32
Location: Spain

Re: Patch: Snow line height in create scenario window

Post by Terkhen »

Also note that the patch is really old and it will not apply to current versions of OpenTTD source.

I think this still would be useful, but not in the way I coded it. As Belugas mentions in the FS task, it would be nice to unify the code of all generation windows. Then, adding parameters from the new game generation window to this one would be really easy. I won't know for sure if this is feasible until I check the code, which I'll do once I find some free time.
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: Amazon [Bot] and 10 guests