[Patch] better profit rating

[sulai]

You know these small round buttons in the vehicle lists, which show the colors red, yellow and green?

This is what they mean in the original game:
red: negative income
yellow: profit <10.000 Pounds
green: more than 10.000 Pounds profit.

This is what the patch makes them show:
red: negative income
yellow: vehicle makes profit, but can't make up its buying price
green: vehicle makes profit and can make up its buying price

This gives you an idea if the vehicle in question actually was worth its price.

Furthermore, the patch results in a more balanced profit rating, because the rating depends on the vehicles buying cost. Road vehicles benefit from it a lot, while it's still challenging to get a high "min. refund" rating.

Hope you like it!

[PhilSophus]

red: negative income
yellow: vehicle makes profit, but can't make up its buying price in its life time
green: vehicle makes profit and can make up its buying price in life time

This actually makes more sense, than using an arbitrary number that might fit some types of vehicles and doesn't for others. So, sounds like a nice patch.

[CommanderZ]

Nice idea, I like it. A lot

[Mchl]

Finally I know what' they're supposed to mean (I always thought they were showing vehicles' age)!!
Also good idea for a patch. I like it.

[Zephyris]

Nice; simple and effective. "Will not make money in its lifetime." is much more informative than "Not making much money.", good work!

[athanasios]

If you patch the rating system too, according to this patch, it will be great!

[sulai]

Thanks to all of you for this positive feedback

If you patch the rating system too, according to this patch, it will be great!

Yes, this is also included in the patch. Have a look at the tooltip in the screenshot (which is the tooltip for the "min. recoup" entry).

[athanasios]

Sorry I missed that.
Your patch is great.
What about difficulty settings? (X2, x5 value in life-time for hard settings.)
Is inflation taken into consideration? I mean a vehicle will not suffice to make its money, but the money needed to replace it the time it reaches the end of it's life.

[sulai]

Update to r17593. See first post.
Inflation is not taken into account.

[sulai]

Update to r17656. See first post.
Recoup rating is not anymore based on last year's profit, but on total profit done by the vehicle. Additionally "negative profit" messages won't pop up for vehicles that actually do profit, but travel longer than a year.

Edit1: Update to 17666, "negative profit" message optimized, "negative total profit message" added.
Edit2: Update to 17680, "Depreciation" and "Refund" added to vehicles property window. Refund is now rated.