#wwOTTDgd/2 finished. Some patches here

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

User avatar
planetmaker
OpenTTD Developer
OpenTTD Developer
Posts: 9432
Joined: 07 Nov 2007 22:44
Location: Sol d

#wwOTTDgd/2 finished. Some patches here

Post by planetmaker »

Just starting this thread to gather the necessary patches for a renewed wwottdgd in one place.

PATCH WANTED:
A nice addition to a #wwottdgd game would be to have diverse regions on the map. We're looking for a patch(er) which allows to apply different grf to different towns. Volunteers please step forward now :) See also Ammlers post further down this thread.

The patches are written by different people; what I post here is just an updated version to current trunk for the cases where they don't apply flawlessly anymore.

See also the wwottdgd wiki page.

Current planning for patches (20 June 2008):
- new patch setting: disable tree growth updated to r13397; originally by Frostregen, simplified & rewritten by Belugas
- close airports updated to r13397; originally by cirdan
- infrasructure sharing v04_alpha updated to r13590; by Gedemon with modifications
- 55 clients (Ammler)
- no terraform (accessible via rcon, per-company basis) Thanks to SmatZ
* restrict terraform to one tile (this thread)
- move player (dihedral)
- automove to previous company on re-join (dihedral)
- modified build o slope costs
- ingame rivers parts now (though not functionality) in trunk, updated to r13536
- clientList_show_id
* copy & paste
* distant join
- no company stat changes (probably not)]
* no

Additional player-side patches (available in the full client patch of beta4):
* fastest bridge built by Ctrl-drag, updated to r13058; originally by Frostregen
* quick goto
* filter by cargo
* copy & paste
* view place of latest build activity (thx to SmatZ)

Patches preceded by "-" are in the current version running on the dev server, patches preceded by "*" are scheduled for the next release and only tested locally.

Some of the patches can also be retrieved from http://wwottdgd.ammler.ch/wwottdgd/patches/2/
See a post further down for a current beta patch of wwottdgd.
Attachments
wwottdgd.swf
wwottdgd banner by LordAzamoth
(19.73 KiB) Downloaded 4856 times
is_closeAirport_r13305.diff
infrastructure sharing + close airports (r13305)
(133.07 KiB) Downloaded 117 times
wwottdgd_alpha3c_r13305.diff
wwottdgd integrated patch for r13305
(171.56 KiB) Downloaded 128 times
Last edited by planetmaker on 14 Mar 2009 21:23, edited 35 times in total.
User avatar
planetmaker
OpenTTD Developer
OpenTTD Developer
Posts: 9432
Joined: 07 Nov 2007 22:44
Location: Sol d

Re: Patch assortment for wwottdgd / 2

Post by planetmaker »

Further patches
Attachments
r13040_basecost_foundation.diff
costs of autoslope during building made dependent on rail cost not on tf cost; originally by Phazorx
(7.57 KiB) Downloaded 531 times
r13040_no_company_changes.diff
players cannot change company properties (color, name, password, manager name); originally by dihedral
(1.46 KiB) Downloaded 447 times
clientlist_show_id_v1_r13201.diff
clientlist with id; for r13202
(1.82 KiB) Downloaded 238 times
Last edited by planetmaker on 22 May 2008 11:49, edited 5 times in total.
User avatar
planetmaker
OpenTTD Developer
OpenTTD Developer
Posts: 9432
Joined: 07 Nov 2007 22:44
Location: Sol d

Re: Patch assortment for wwottdgd / 2

Post by planetmaker »

.
Attachments
wwottdgd_55clients_r13134.diff
increase to 55 clients maximum
(514 Bytes) Downloaded 130 times
ingame_rivers_r13305.diff
ingame rivers updated to r13305; originally by Roujin
(10.13 KiB) Downloaded 122 times
move_client_v5_r13305.diff
move clients, updated to r13305
(8.56 KiB) Downloaded 135 times
Last edited by planetmaker on 29 May 2008 20:20, edited 9 times in total.
dihedral
Tycoon
Tycoon
Posts: 1053
Joined: 14 Feb 2007 17:48

Re: Patch assortment for wwottdgd / 2

Post by dihedral »

little note on the side - these patches together will not be able to run as a server... as soon as more than 11 clients are in the game you have an increased probability of it crashing.
we had to do a minor (and dirty) fix for the server to work with no crashes :-)
User avatar
Ammler
President
President
Posts: 953
Joined: 18 Jun 2006 18:18
Location: Switzerland
Contact:

Re: Patch assortment for wwottdgd / 2

Post by Ammler »

dihedral wrote: we had to do a minor (and dirty) fix for the server to work with no crashes :-)
I greped the server and might found that ugly patch. ;-)
http://wwottdgd.ammler.ch/wwottdgd/patc ... pfix.patch
Last edited by Ammler on 22 May 2008 13:46, edited 1 time in total.
dihedral
Tycoon
Tycoon
Posts: 1053
Joined: 14 Feb 2007 17:48

Re: Patch assortment for wwottdgd / 2

Post by dihedral »

nasty - i must say :-P
we should have at least kept the <none> in!
User avatar
planetmaker
OpenTTD Developer
OpenTTD Developer
Posts: 9432
Joined: 07 Nov 2007 22:44
Location: Sol d

wwOTTDgd / 2 - looking for patcher

Post by planetmaker »

I recently stumbled over the close airport patch - which seemed to me a good adition to the wwottdgd. What do you think. See link to thread and updated version in first post of this thread.
Attachments
rock_tree_r13202.diff
patchsetting tree growth + no TF on rocks for r13202
(11.24 KiB) Downloaded 126 times
wwottdgd_alpha2_r13211.diff
wwottdgd alpha 2 for r13211
missing: yapp, fast-bridges, no-tf-on-rocks, snow-in-temp
(145.32 KiB) Downloaded 151 times
wwottdgd_alpha2_osx_r13211.tgz
binary r13211M-wwottdgd for OS-X
(2.95 MiB) Downloaded 124 times
Last edited by planetmaker on 22 May 2008 17:13, edited 7 times in total.
User avatar
Ammler
President
President
Posts: 953
Joined: 18 Jun 2006 18:18
Location: Switzerland
Contact:

Re: #wwottdgd - looking for patcher

Post by Ammler »

Idea for a patch:

1. Region / Town dependend NewGRFs
Is it possible to hack the code to have possibility of different town and road grfs for different towns/regions?

I would like something like nacity at west, TTRS in the middle and japan houses at east or something like that, same with different road sets.

2. Balancing different NewGRFs
That problem is already mentioned here but wwottdgd should have different Vehicle Sets, we need something to balance different GRFs. (That problem is known before the new feature was introduced, i.e. with Trams and 4LV) The 2. something to filter for different Sets and labled somehow, so you see fast, from which GRF a vehicle is.

There is only one rule for it: Multiplayer safe.

Greets
Ammler

Edit: attached a Linux i686 build for the current WWOTTDGD patch
Edit2: attached a winbin (unzip and run the exe...)
Edit3: removed binaries.
Attachments
wwottdgd.swf
WWOTTDGD/2 Banner from LordAzamath
(19.73 KiB) Downloaded 5733 times
Last edited by Ammler on 23 Jun 2008 13:44, edited 1 time in total.
User avatar
planetmaker
OpenTTD Developer
OpenTTD Developer
Posts: 9432
Joined: 07 Nov 2007 22:44
Location: Sol d

Re: #wwottdgd - looking for patcher

Post by planetmaker »

Bump. Some patches needed an update. Also now close airports works jointly with infrastructure sharing. ingame rivers currently need a serious update and are left out. No terraform on rocks for some reason screws the binary, though it works on its own nicely, therefor left out, too.

Find joint patch here.
Attachments
no_terraform3.diff
patch to disallow terraform on a per-company basis. rcon <pw> "patch allow_terraform <value>". <value> is a bit mask for the companies ingame. Thanks to SmatZ
(2.17 KiB) Downloaded 225 times
mist
mist
Nenpool Falls Transport, 14. Jan 1950.png (71.54 KiB) Viewed 751 times
Last edited by planetmaker on 12 Jul 2008 00:02, edited 2 times in total.
dihedral
Tycoon
Tycoon
Posts: 1053
Joined: 14 Feb 2007 17:48

Re: #wwottdgd - looking for patcher; alpha2 out

Post by dihedral »

What i would love to see is a rcon gui!

all admin function should be available, and the rcon password stored in the variable rcon_pass should be used for any admin actions done.

a mere check if the client has the rcon_pass set, and is not the server should suffice in this case

i would love to do this myself yet am lacking a lot of time for all the things going on.

also if someone feels like adding a gui to the move clients feature (running the rcon commands in the same style as mentioned above) that would ease up a lot of admin work on the special day :-)
User avatar
Ammler
President
President
Posts: 953
Joined: 18 Jun 2006 18:18
Location: Switzerland
Contact:

Re: #wwottdgd - looking for patcher; alpha2 out

Post by Ammler »

The admin GUI would be a really nice addon, I think, it should be technically possible like you make your own (not dedicated) server... (If you use rcon <pw> GUI, all patch settings are changeable like you are the server self.)
User avatar
planetmaker
OpenTTD Developer
OpenTTD Developer
Posts: 9432
Joined: 07 Nov 2007 22:44
Location: Sol d

Re: #wwottdgd - looking for patcher; alpha3 out

Post by planetmaker »

Bump and update of all patches to trunk r13305. OS-X binary attached here, integrated patch in first posting.
Attachments
openttd-r13305M-wwottdgd-OSX.tgz
binary of the r13305M-wwottdgd for OS-X
(2.96 MiB) Downloaded 132 times
Last edited by planetmaker on 01 Jun 2008 13:21, edited 1 time in total.
LordAzamath
Tycoon
Tycoon
Posts: 1656
Joined: 08 Jun 2007 08:00

Re: #wwottdgd - looking for patcher; alpha3 out

Post by LordAzamath »

I was wondering if you had the map yet done by mark.. I asked planetmaker and he said thatyou dont have it yet.. So here is one draft based on mark's proposal.. Please tell me what to improve further.. I think I should make the global area smaller and give the other companies more room..

I created this from heightmap created with gimp and I've got the xcf with shadows and highlights too, soI can change the things pretty easily..
You need to open this map via scenario editor, because it doesn't have any towns or industries yet.


And the heightmap from what it was produced.


EDIT: I took these things out, because they are outta date..
The real map will look like this.. It's basically ready now.
gj.png
(619.44 KiB) Downloaded 288 times
PS: And I stopped the propaganda to support Dave Worley since he got a nice new red hat now.[/color]
I know I have a BBCode error in my signature but I really cba to fix it.
LordAzamath
Tycoon
Tycoon
Posts: 1656
Joined: 08 Jun 2007 08:00

Re: #wwottdgd - looking for patcher; alpha3 out

Post by LordAzamath »

WinBin, compiled with BOTTD
openttd-r13305M-wwottdgd-win.zip.zip
(2.83 MiB) Downloaded 139 times
The height map from which the scenario was made. Done by me :)
g.png
(443.92 KiB) Downloaded 495 times
PS: And I stopped the propaganda to support Dave Worley since he got a nice new red hat now.[/color]
I know I have a BBCode error in my signature but I really cba to fix it.
User avatar
planetmaker
OpenTTD Developer
OpenTTD Developer
Posts: 9432
Joined: 07 Nov 2007 22:44
Location: Sol d

Re: #wwottdgd - looking for patcher; alpha3 out

Post by planetmaker »

In order to forbid exessive terraforming, I created a small patch which restricts terraforming to one-tile operations only. Maybe it is of use to someone else, too :).

It's accessible via patch setting and is disabled by default.

Criticism & praise welcome :)
Attachments
patchsetting_one_tile_tf_r13397.diff
patchsetting: one tile terraform only for r13397
(4.74 KiB) Downloaded 333 times
55clients_r13397.diff
55 clients patch for r13397
(502 Bytes) Downloaded 116 times
wwottdgd_client_beta1_r13400.diff
diff for wwottdgd-client-beta1 for r13400
(287.72 KiB) Downloaded 157 times
Last edited by planetmaker on 07 Jun 2008 20:18, edited 2 times in total.
Roujin
Tycoon
Tycoon
Posts: 1884
Joined: 08 Apr 2007 04:07

Re: #wwottdgd - looking for patcher; alpha3 out

Post by Roujin »

This means the level tool is disabled completely?
* @Belugas wonders what is worst... a mom or a wife...
<Lakie> Well, they do the same thing but the code is different.

______________
My patches
check my wiki page (sticky button) for a complete list

ImageImage
ImageImageImageImageImageImageImage
LordAzamath
Tycoon
Tycoon
Posts: 1656
Joined: 08 Jun 2007 08:00

Re: #wwottdgd - looking for patcher; alpha3 out

Post by LordAzamath »

The other possibility would be to change terraforming costs very high, but we dont want to bankrupt the companies.. It's mainly for wwottdgd to limit terraforming.. (Although I have no answer to your question..)
PS: And I stopped the propaganda to support Dave Worley since he got a nice new red hat now.[/color]
I know I have a BBCode error in my signature but I really cba to fix it.
User avatar
planetmaker
OpenTTD Developer
OpenTTD Developer
Posts: 9432
Joined: 07 Nov 2007 22:44
Location: Sol d

Re: #wwottdgd - looking for patcher; alpha3 out

Post by planetmaker »

Roujin wrote:This means the level tool is disabled completely?
Not quite. You may still level a 2x2 area, changing the side of one tile :) But you may not level more than two tile edges simultaneously.

An improvement of this patch actually would be to make the size of the restriction a patch option.

Please don't mis-understand me here: I like your patches on the terraform tools a lot and think they're absolutely nice and trunk-worthy. But in a game with many players I'd like some control and not have one person spoil the fun for dozens of players.

As it's a patch option, it can be switched off and on via rcon during a game.
Roujin
Tycoon
Tycoon
Posts: 1884
Joined: 08 Apr 2007 04:07

Re: #wwottdgd - looking for patcher; alpha3 out

Post by Roujin »

I was just wondering if it wasn't a bit over the top.. but if you feel it is needed for your event...

Did you limit the drag-tool to a certain size? or does it display an error when dragging too big an area?

Did you make sure the check is enforced on the server, not only on the client itself?


edit: I just checked. It just errors out when you drag more than 2x2.
This probably means (without looking at code) that the server enforces it. That's good, so nobody can go around it with a hacked client.

It could be more user friendly though if it would also change the client in a way that it's not able to drag more than 2x2 anymore.

edit2: for hints on how to archieve that, look at how station placement drag is limited to max station spread size.
* @Belugas wonders what is worst... a mom or a wife...
<Lakie> Well, they do the same thing but the code is different.

______________
My patches
check my wiki page (sticky button) for a complete list

ImageImage
ImageImageImageImageImageImageImage
dihedral
Tycoon
Tycoon
Posts: 1053
Joined: 14 Feb 2007 17:48

Re: #wwottdgd - looking for patcher; alpha3 out

Post by dihedral »

as far as i am aware of it, there is another patch that will allow us to only allow tf'ing for a certain company. or disable for everyone!
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 23 guests