[Patch] Order-based full-load any/all cargo selection

[PhilSophus]

In this topic it was suggested to make it possible to select the full-load behavior per order instead of a global patch setting.

So here is the patch to implement that:

1. Select an order.
2. Enable full-load by pushing the full-load button. Whether this initially is full-load any or full-load all cargo depends on the global patch setting (the GUI shows you which).
3. CTRL-click on the full-load button to toggle between full-load any and full-load all.

As this modification was even demanded by a todo tag in trunk, I guess this is a candidate for inclusion. Before I post this on flyspray, I would be grateful for any comments on coding style (I tried to obey it), on implementation and if it's working for you without bugs.

In the thread mentioned above it was discussed, whether it should be possible to select which cargo should be filled. I did not implement this for several reasons:

1. I wanted to take a step-by-step approach and I think this would be an advanced step
2. I was quite sure how to do this first step, but would have to think a bit about the selection by cargo
3. I am not so sure anymore that such a feature would really be such a good thing as orders may be shared among vehicles with different cargos.

Update: Feature now in trunk (although not from this patch).

[richk67]

Coding style looks OK to me. Watch the alignment in the final column of the SDT_BOOL( line in settings.cpp. If it works as advertised, (Ive not compiled to check), then post to FS. Should be dead cert for inclusion in my view.

[PhilSophus]

Watch the alignment in the final column of the SDT_BOOL( line in settings.cpp.

Yes, you're right. I removed this setting and added it again, as using it as a default value seemed to be a good idea. Must have happened then.

If it works as advertised, (Ive not compiled to check), then post to FS. Should be dead cert for inclusion in my view.

Well, it compiles under Linux and I tested loading old games with both settings and changing in-game very shortly. So let's wait for some reports from other platforms.

[Indiana]

Nice work.
I use it with the GonozalIN und windows XP and it works great.