YAPP - Yet Another PBS Patch (now in trunk!)

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

Klaatu
Engineer
Engineer
Posts: 43
Joined: 04 Aug 2003 14:58

Re: YAPP - Yet Another PBS Patch (New version 6 out!)

Post by Klaatu »

Roest wrote:I merged it with copy&paste for anyone interested.
Very! Thanks a bunch Roest; I couldn't play without C&P, and have been wanting to try YAPP for a while now. This is perfect. Thanks again.
User avatar
rpa
Engineer
Engineer
Posts: 33
Joined: 15 Apr 2005 12:21

Re: YAPP - Yet Another PBS Patch (New version 6 out!)

Post by rpa »

I read the 'how to install patches/diff' thread, and didn't understand it.
I want to use this, as I have a map that I'm running that have loads of trains, but they keep slowing down due to trains on other lines..

Can someone send me a compiled one (or have I missed it in the thread)?
User avatar
Roest
Traffic Manager
Traffic Manager
Posts: 215
Joined: 03 Apr 2008 08:18

Re: YAPP - Yet Another PBS Patch (New version 6 out!)

Post by Roest »

Here you are.

You need the copypaste.grf for it tho.
Attachments
trunk_r12703_yapp_copypaste_r12701.zip
(2.89 MiB) Downloaded 154 times
User avatar
vwspeedracer
Engineer
Engineer
Posts: 28
Joined: 31 Mar 2008 01:37
Location: Colchester, VT, USA
Contact:

Re: YAPP - Yet Another PBS Patch (New version 6 out!)

Post by vwspeedracer »

Here's a really sloppy fix to overcome a change in 12711. I didn't bother to fix offsets. Compiles in 12715 with a little fuzz, but seems to run ok.
Attachments
yapp_r12711_v6m_svn.patch
(195.83 KiB) Downloaded 122 times
Fan of: Image
Draakon
Director
Director
Posts: 542
Joined: 11 Mar 2007 16:50

Re: YAPP - Yet Another PBS Patch (New version 6 out!)

Post by Draakon »

@Michi_cc: Is there anyway that a combining of presignals with PBS signals will happen like in TTDP is?
User avatar
pavel1269
Route Supervisor
Route Supervisor
Posts: 473
Joined: 03 Dec 2006 13:22
Location: Czech Republic
Contact:

Re: YAPP - Yet Another PBS Patch (New version 6 out!)

Post by pavel1269 »

Draakon wrote:@Michi_cc: Is there anyway that a combining of presignals with PBS signals will happen like in TTDP is?
i play using only PBS signals, and i never encouraged situation i need them ... maybye i do it all wrong, but ... show me where would u need PBS with this great patch?
Draakon
Director
Director
Posts: 542
Joined: 11 Mar 2007 16:50

Re: YAPP - Yet Another PBS Patch (New version 6 out!)

Post by Draakon »

No no no, you meant that TTDP has merged PBS signals with presignals aka, they act like presignals but like PBS too.

Now there are many situations where it comes a problem. For example 2 platform station (terminus) is full and a third one comes? It goes forward and waits a signal where the train that was in the station wants to come out? It can't.
Draakon
Director
Director
Posts: 542
Joined: 11 Mar 2007 16:50

Re: YAPP - Yet Another PBS Patch (New version 6 out!)

Post by Draakon »

Hmm, i am wrong indeed with the stations (sorry) but i don't know but in #openttdcoop, there are things called Priorities. That makes so that if a train from a sideline comes and will jam the Mainline for a while when the train from sideline merges to mainline, the priority instead prevents that. Now it is not possible to do it without presignals and we also know that combining in the normal way is not a good way to do. TTDP PBS signals let's you to make prober priorities while YAPP does not.
User avatar
Roest
Traffic Manager
Traffic Manager
Posts: 215
Joined: 03 Apr 2008 08:18

Re: YAPP - Yet Another PBS Patch (New version 6 out!)

Post by Roest »

Michi said that somewhere in this thread that whacky stuff like priorities wont work.
User avatar
AndersI
Tycoon
Tycoon
Posts: 1732
Joined: 19 Apr 2004 20:09
Location: Sweden
Contact:

Re: YAPP - Yet Another PBS Patch (New version 6 out!)

Post by AndersI »

Draakon wrote:Now there are many situations where it comes a problem. For example 2 platform station (terminus) is full and a third one comes? It goes forward and waits a signal where the train that was in the station wants to come out? It can't.
With the YAPP flavour of PBS, you should only put signals where it's 'safe' for a train to wait. So, no signals directly after a crossing, no signals just in front of the station.
User avatar
vwspeedracer
Engineer
Engineer
Posts: 28
Joined: 31 Mar 2008 01:37
Location: Colchester, VT, USA
Contact:

Re: YAPP - Yet Another PBS Patch (New version 6 out!)

Post by vwspeedracer »

I'm not sure what you're trying to do. Here's the stations with old signals vs. presignals. I hope I got them right - I've been using PBS for so long I'm a bit flakey with the old stuff. Makes multi-player more of a challenge. :D
Attachments
Simple Pre-Signal Station
Simple Pre-Signal Station
Pre-Signals.png (56.87 KiB) Viewed 4075 times
Simple YAPP Station
Simple YAPP Station
PBS.png (53.13 KiB) Viewed 4079 times
Fan of: Image
User avatar
vwspeedracer
Engineer
Engineer
Posts: 28
Joined: 31 Mar 2008 01:37
Location: Colchester, VT, USA
Contact:

Re: YAPP - Yet Another PBS Patch (New version 6 out!)

Post by vwspeedracer »

<Snip>
Last edited by vwspeedracer on 16 Apr 2008 01:04, edited 1 time in total.
Fan of: Image
DaleStan
TTDPatch Developer
TTDPatch Developer
Posts: 10285
Joined: 18 Feb 2004 03:06
Contact:

Re: YAPP - Yet Another PBS Patch (New version 6 out!)

Post by DaleStan »

Stop with the painful anti-aliased scaling. Just give us cropped screenshots, so we can see what's going on.
To get a good answer, ask a Smart Question. Similarly, if you want a bug fixed, write a Useful Bug Report. No TTDPatch crashlog? Then follow directions.
Projects: NFORenum (download) | PlaneSet (Website) | grfcodec (download) | grfdebug.log parser
User avatar
vwspeedracer
Engineer
Engineer
Posts: 28
Joined: 31 Mar 2008 01:37
Location: Colchester, VT, USA
Contact:

Re: YAPP - Yet Another PBS Patch (New version 6 out!)

Post by vwspeedracer »

As requested.
Attachments
Fancy Pre-Signal Station (crop only)
Fancy Pre-Signal Station (crop only)
Fancy Pre-Signal Station - Big.png (111.39 KiB) Viewed 4067 times
Fancy PBS Station (crop only)
Fancy PBS Station (crop only)
Fancy PBS Station - Big.png (84.94 KiB) Viewed 4071 times
Fan of: Image
Progman
Engineer
Engineer
Posts: 76
Joined: 15 Jul 2006 12:55
Contact:

Re: YAPP - Yet Another PBS Patch (New version 4 out!)

Post by Progman »

Progman wrote:If a train waits for the green signal it shows "Waiting for free path". Thats cool, but the target should be shown, too. If several trains deadlock a junction and all shows "Waiting for free path" you have no idea which one could maybe solve the deadlock. So this message should be sth. like "Waiting for free path to {TARGET}"
I mentioned it already but it isn't implemented yet. Is is possible to add this to the patch?
Mchl
Director
Director
Posts: 611
Joined: 05 Jan 2007 15:50
Location: Poland
Contact:

Re: YAPP - Yet Another PBS Patch (New version 6 out!)

Post by Mchl »

You could always check trains' orders, which in my opinion would take less time, than resizing train window to see the whole message...
Mchl
Director
Director
Posts: 611
Joined: 05 Jan 2007 15:50
Location: Poland
Contact:

Re: YAPP - Yet Another PBS Patch (New version 6 out!)

Post by Mchl »

Got an assertion with latest (v6) version. Compiled from svn diff with BuildOTTD. It seems to be related with a train that has no orders (assertion appears just before 'Train is lost mesasge', it can be ignored and game continues as normal).

I've got a savegome just before this, but it is 2048x2048, so I can't attach it here. Will try to reproduce it on smaller map.
User avatar
rpa
Engineer
Engineer
Posts: 33
Joined: 15 Apr 2005 12:21

Re: YAPP - Yet Another PBS Patch (New version 6 out!)

Post by rpa »

I downloaded the one that Roest uploaded.

I've found 1 small problem with this (otherwise its brilliant). I can save a game, but not re-load it at another time. Once I finished the game and saved it (to go to bed for instance), I can't reload the next day.

Is there a way I can get a version that does allow me to reload a game.

cheers. :) :?
User avatar
Roest
Traffic Manager
Traffic Manager
Posts: 215
Joined: 03 Apr 2008 08:18

Re: YAPP - Yet Another PBS Patch (New version 6 out!)

Post by Roest »

rpa wrote: Is there a way I can get a version that does allow me to reload a game.
I just checked it, save/load works fine here.
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 27 guests