Patch: Upgrade airports

Sarvesh50 · **Joined:** Mon Mar 31, 2008 4:29 pm **Posts:** 63

Can i reqeust the last openttd with this patch and some other nice one?
I cant compile :oops:

Eddi · **Joined:** Wed Jan 17, 2007 12:14 am **Posts:** 4614

no, you can't request that. this forum is only for people who actually develop something.

Sarvesh50 · **Joined:** Mon Mar 31, 2008 4:29 pm **Posts:** 63

No problem
Good there is karma you will burn.
Have a nice day.

sickie · **Posted:** Mon May 17, 2010 7:11 am

Wishing for other people to burn does no good to your karma too, Sarvesh50.

planetmaker · **Posted:** Mon May 17, 2010 10:27 am

Sarvesh50 wrote:

Can i reqeust the last openttd with this patch and some other nice one?
I cant compile :oops:

Of course you may ask.

Providing binaries with one patch: 100€
Additional work required depending on available patch and how well it applies: 100€ / hour
Additional patches: 150€ each plus required extra work.

A four hour minimum charge applies.

So, contact me, if you're interested and we can work out the details. Delivery of a binary upon reception of money.

nighthawk_c_m · **Joined:** Wed Apr 14, 2010 6:26 am **Posts:** 26

Damn capitalism starts hitting openttd :lol:

PikkaBird · **Posted:** Mon May 17, 2010 9:57 pm

Eddi wrote:

no, you can't request that. this forum is only for people who actually develop something.

Actually, this forum is only for people who are willing to be constructive and helpful. Consider this a moderator warning!

Sarvesh50, compiling isn't too hard, perhaps if you want regular updates you should consider learning how to do it? http://wiki.openttd.org/Category:Compiling_OpenTTD is a good place to start.

Eddi · **Joined:** Wed Jan 17, 2007 12:14 am **Posts:** 4614

PikkaBird wrote:

Consider this a moderator warning!

... I challenge the validity of this warning, as you are not actually a moderator of this forum

PikkaBird · **Posted:** Tue May 18, 2010 1:28 am

Eddi wrote:

PikkaBird wrote:

Consider this a moderator warning!

... I challenge the validity of this warning, as you are not actually a moderator of this forum

I know I'm not, I sought the opinion of a global moderator first!

Sarvesh50 · **Joined:** Mon Mar 31, 2008 4:29 pm **Posts:** 63

Thank you Pikkabird. :mrgreen:

Why are so many people not nice anymore?
The reccesion ?

cirdan · **Joined:** Sat Apr 07, 2007 6:08 pm **Posts:** 274

Update against trunk.

andythenorth · **Posted:** Tue Sep 14, 2010 6:05 pm

Sarvesh50 wrote:

Why are so many people not nice anymore?

They're about as nice as they ever were. The past was not a better place

xmirakulix · **Joined:** Wed Jan 06, 2010 6:06 pm **Posts:** 35

I found a bug in this patch that crashes the game because of a failed assertion.
It can be reproduced with the latest version of the patch against trunk r20794.

Quote:

Crash reason:
Signal: Abort trap (6)
Message: Assertion failed at line 497 of /Users/flo/Desktop/openttd/git-openttd/src/station.cpp: this->PtInExtendedRect(TileX(ta.tile), TileY(ta.tile))

It happens when you upgrade an airport two times and don't place it at the exact same location every time.
I think the screenshot shows what I try to describe...

Attachment:

File comment: Crash screenshot

crash.jpg [ 86.24 KiB | Viewed 1677 times ]

cirdan · **Joined:** Sat Apr 07, 2007 6:08 pm **Posts:** 274

Wow, a bug two years and a half after the last one. I almost thought there weren't any left. :-)

The attached patch fixes it. Thanks for the report!

xmirakulix · **Joined:** Wed Jan 06, 2010 6:06 pm **Posts:** 35

Confimed as fixed. Thank you for the quick response!

Sarvesh50 · **Joined:** Mon Mar 31, 2008 4:29 pm **Posts:** 63

Will this one update for openttd 1.1 beta3?

cirdan · **Joined:** Sat Apr 07, 2007 6:08 pm **Posts:** 274

The last patch I posted (against r21541) should apply cleanly against 1.1.0-beta3.

Sarvesh50 · **Joined:** Mon Mar 31, 2008 4:29 pm **Posts:** 63

I tried it it doesnt work

I apply tortoisesvn opens but doesnt change or patch anything...

ChillCore · **Posted:** Mon Jan 17, 2011 7:22 pm

Tortoisesvn only like svn patches. It can not apply git or hg patches.

Just change the header from:

Code:

diff --git a/src/station_cmd.cpp b/src/station_cmd.cpp
index fc6faff..357a83f 100644
--- a/src/station_cmd.cpp
+++ b/src/station_cmd.cpp

to:

Code:

Index: src/station_cmd.cpp
===================================================================
--- src/station_cmd.cpp   (revision 21541)
+++ src/station_cmd.cpp   (working copy)

and it should apply just fine.

I think you should also be able to apply the git patch with "-p1" from the console but I have never tested that when I was still on Windows. I could be wrong ...

ps: I could post an svn patch but as the change to make is minor ...

dihedral · **Joined:** Wed Feb 14, 2007 5:48 pm **Posts:** 1048

andythenorth wrote:

Sarvesh50 wrote:

Why are so many people not nice anymore?

They're about as nice as they ever were. The past was not a better place

but the future was better in the past

Transport Tycoon Forums

Patch: Upgrade airports

Who is online