Patch: Upgrade airports

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

Sarvesh50
Engineer
Engineer
Posts: 63
Joined: 31 Mar 2008 16:29

Re: Patch: Upgrade airports

Post by Sarvesh50 »

Can i reqeust the last openttd with this patch and some other nice one?
I cant compile :oops:
Image
Eddi
Tycoon
Tycoon
Posts: 8258
Joined: 17 Jan 2007 00:14

Re: Patch: Upgrade airports

Post by Eddi »

no, you can't request that. this forum is only for people who actually develop something.
Sarvesh50
Engineer
Engineer
Posts: 63
Joined: 31 Mar 2008 16:29

Re: Patch: Upgrade airports

Post by Sarvesh50 »

:roll:
No problem
Good there is karma you will burn.
Have a nice day.
Image
User avatar
sickie
Engineer
Engineer
Posts: 85
Joined: 15 Sep 2007 00:51
Location: Slovenia
Contact:

Re: Patch: Upgrade airports

Post by sickie »

Wishing for other people to burn does no good to your karma too, Sarvesh50.
User avatar
planetmaker
OpenTTD Developer
OpenTTD Developer
Posts: 9432
Joined: 07 Nov 2007 22:44
Location: Sol d

Re: Patch: Upgrade airports

Post by planetmaker »

Sarvesh50 wrote:Can i reqeust the last openttd with this patch and some other nice one?
I cant compile :oops:
Of course you may ask.

Providing binaries with one patch: 100€
Additional work required depending on available patch and how well it applies: 100€ / hour
Additional patches: 150€ each plus required extra work.

A four hour minimum charge applies.

So, contact me, if you're interested and we can work out the details. Delivery of a binary upon reception of money.
nighthawk_c_m
Engineer
Engineer
Posts: 26
Joined: 14 Apr 2010 06:26

Re: Patch: Upgrade airports

Post by nighthawk_c_m »

Damn capitalism starts hitting openttd :lol:
User avatar
PikkaBird
Graphics Moderator
Graphics Moderator
Posts: 5601
Joined: 13 Sep 2004 13:21
Location: The Moon

Re: Patch: Upgrade airports

Post by PikkaBird »

Eddi wrote:no, you can't request that. this forum is only for people who actually develop something.
Actually, this forum is only for people who are willing to be constructive and helpful. Consider this a moderator warning! :)

Sarvesh50, compiling isn't too hard, perhaps if you want regular updates you should consider learning how to do it? http://wiki.openttd.org/Category:Compiling_OpenTTD is a good place to start.
Eddi
Tycoon
Tycoon
Posts: 8258
Joined: 17 Jan 2007 00:14

Re: Patch: Upgrade airports

Post by Eddi »

PikkaBird wrote:Consider this a moderator warning! :)
... I challenge the validity of this warning, as you are not actually a moderator of this forum ;)
User avatar
PikkaBird
Graphics Moderator
Graphics Moderator
Posts: 5601
Joined: 13 Sep 2004 13:21
Location: The Moon

Re: Patch: Upgrade airports

Post by PikkaBird »

Eddi wrote:
PikkaBird wrote:Consider this a moderator warning! :)
... I challenge the validity of this warning, as you are not actually a moderator of this forum ;)
I know I'm not, I sought the opinion of a global moderator first! :)
Sarvesh50
Engineer
Engineer
Posts: 63
Joined: 31 Mar 2008 16:29

Re: Patch: Upgrade airports

Post by Sarvesh50 »

Thank you Pikkabird. :mrgreen:
Why are so many people not nice anymore?
The reccesion ?
Image
User avatar
cirdan
Director
Director
Posts: 539
Joined: 07 Apr 2007 18:08

Re: Patch: Upgrade airports

Post by cirdan »

Update against trunk.
Attachments
airport-upgrade-v6-r20794.patch
(12.13 KiB) Downloaded 232 times
xmirakulix
Engineer
Engineer
Posts: 36
Joined: 06 Jan 2010 18:06

Re: Patch: Upgrade airports

Post by xmirakulix »

I found a bug in this patch that crashes the game because of a failed assertion.
It can be reproduced with the latest version of the patch against trunk r20794.
Crash reason:
Signal: Abort trap (6)
Message: Assertion failed at line 497 of /Users/flo/Desktop/openttd/git-openttd/src/station.cpp: this->PtInExtendedRect(TileX(ta.tile), TileY(ta.tile))
It happens when you upgrade an airport two times and don't place it at the exact same location every time.
I think the screenshot shows what I try to describe...
Crash screenshot
Crash screenshot
crash.jpg (86.24 KiB) Viewed 5491 times
User avatar
cirdan
Director
Director
Posts: 539
Joined: 07 Apr 2007 18:08

Re: Patch: Upgrade airports

Post by cirdan »

Wow, a bug two years and a half after the last one. I almost thought there weren't any left. :-)

The attached patch fixes it. Thanks for the report!
Attachments
airport-upgrade-v7-r21541.patch
(12.17 KiB) Downloaded 184 times
xmirakulix
Engineer
Engineer
Posts: 36
Joined: 06 Jan 2010 18:06

Re: Patch: Upgrade airports

Post by xmirakulix »

Confimed as fixed. Thank you for the quick response!
Sarvesh50
Engineer
Engineer
Posts: 63
Joined: 31 Mar 2008 16:29

Re: Patch: Upgrade airports

Post by Sarvesh50 »

Will this one update for openttd 1.1 beta3?
Image
User avatar
cirdan
Director
Director
Posts: 539
Joined: 07 Apr 2007 18:08

Re: Patch: Upgrade airports

Post by cirdan »

The last patch I posted (against r21541) should apply cleanly against 1.1.0-beta3.
Sarvesh50
Engineer
Engineer
Posts: 63
Joined: 31 Mar 2008 16:29

Re: Patch: Upgrade airports

Post by Sarvesh50 »

I tried it it doesnt work :(
I apply tortoisesvn opens but doesnt change or patch anything...
Image
User avatar
ChillCore
Tycoon
Tycoon
Posts: 2822
Joined: 04 Oct 2008 23:05
Location: Lost in spaces

Re: Patch: Upgrade airports

Post by ChillCore »

Tortoisesvn only like svn patches. It can not apply git or hg patches.

Just change the header from:

Code: Select all

diff --git a/src/station_cmd.cpp b/src/station_cmd.cpp
index fc6faff..357a83f 100644
--- a/src/station_cmd.cpp
+++ b/src/station_cmd.cpp
to:

Code: Select all

Index: src/station_cmd.cpp
===================================================================
--- src/station_cmd.cpp	(revision 21541)
+++ src/station_cmd.cpp	(working copy)
and it should apply just fine.

I think you should also be able to apply the git patch with "-p1" from the console but I have never tested that when I was still on Windows. I could be wrong ...

ps: I could post an svn patch but as the change to make is minor ...
-- .- -.-- / - .... . / ..-. --- .-. -.-. . / -... . / .-- .. - .... / -.-- --- ..- .-.-.-
--- .... / -.-- . .- .... --..-- / .- -. -.. / .--. .-. .- .. ... . / - .... . / .-.. --- .-. -.. / ..-. --- .-. / .... . / --. .- ...- . / ..- ... / -.-. .... --- --- -.-. .... --- --- ... .-.-.- / ---... .--.

Playing with my patchpack? Ask questions on usage and report bugs in the correct thread first, please.
All included patches have been modified and are no longer 100% original.
dihedral
Tycoon
Tycoon
Posts: 1053
Joined: 14 Feb 2007 17:48

Re: Patch: Upgrade airports

Post by dihedral »

andythenorth wrote:
Sarvesh50 wrote:Why are so many people not nice anymore?
They're about as nice as they ever were. The past was not a better place :)
but the future was better in the past
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 8 guests