NewGRF GUI Window

[yorick]

An update I extracted from the TibPP.

[planetmaker]

update to trunk (r14103)
EDIT: somewhat made the code more OpenTTD compliant . Thx Belugas for his time and patience

[peter1138]

There's an off-by-one error somewhere, causing trails to be left behind when resizing the window.

[planetmaker]

Update to trunk r14423.

There's an off-by-one error somewhere, causing trails to be left behind when resizing the window.

I hope that's fixed now, too.

There's still a problem with the button texts becoming too wide, if the window is sufficiently decreased in size.

[planetmaker]

An update and small bugfix to this patch can be found at flyspray.

[Tiberius]

Just received the flyspray notification mail, glad to see there's still someone taking care of it
Hope I can squeeze some time to fiddle with OpenTTD ...

[Batti5]

it should be in the patch setting, so if you have trouble with it thay can turn-it off.

[Gremnon]

If people test this, then the trouble can be fixed. I've tested it alone and with other patches I use, and there are no such problems, therefore I don't believe your suggestion is of any use. It needs no patch setting.

[Hamilton2007]

I really would like to add this, but for the moment i'm not succeded in patching anything jet...

[planetmaker]

it should be in the patch setting, so if you have trouble with it thay can turn-it off.

what do you want to turn off, Batti5? You want a switch to change the window design? respectively the way the user interface works?

IMO, as it doesn't change the game at all, it doesn not need any switch.

[Hamilton2007]

Indeed, the window is much better, hopefully it's in the next nightly.

[planetmaker]

there's an update to trunk r15256 available at flyspray: http://bugs.openttd.org/task/2195/getfi ... 15256.diff

EDIT: a few changes to the layout
http://bugs.openttd.org/task/2195/getfi ... 2_320l.png

[planetmaker]

Update to trunk r15776:

[nex259]

Update to trunk r15913.

bug:when resizing to small size (height),layout of "selected" grf list will get out of shape.

edited:
(add png )
resize to larger than default(height induced)
-> last line is bad.(lower-side harf is for "next" position grf,but grfname and marker are not shown)

[planetmaker]

Thanks for your update, nex259!

I don't understand what graphical bug you refer to... to me it looks like it behaves like it did before, also wrt resizing. Do I miss something?

[Terkhen]

When nex259's latest version is patched against current trunk, the game aborts whenever you open the content download window.

[planetmaker]

I cannot follow that either. Worked for me. Any more details? Crash log? assertion?

[Terkhen]

Sorry, i was too hasty assuming it was this patch's fault. I got the bug in clean trunk too: just after opening the content downloading window, the game crashes. I'm going to get more info and report it to flyspray.

[nex259]

When nex259's latest version is patched against current trunk, the game aborts whenever you open the content download window.

I confirmed that it was before svn r15919 that this patch works without the critical issues.

Now,the networking codes of OTTD are under changing (and they are greatly) , networking is in buggy and unstable state.
Because,which the codes of this patch ,or the networking codes ,the cause is not understood.

==My compile environment:
pc1)Win32 gcc 3.4.5/MinGW at WindowsXP SP3
pc2)Linux_amd64 gcc 4.3.2-1.1 at Debian/5.0

[planetmaker]

it works flawlessly for me with r15929.