Patch: %5 Shares

[TheJosh]

This patch makes the shares buy and sell in quantities 5% instead of 25%.
You can still buy and sell by quantities of 25% by ctrl clicking

It is patched against nightly revision 10622

This patch will bump your savegame to v73

There are no known save or load issues. Tested with old and new savegames, and network games.

Revision History:
v3 - fixed a small multiplayer bug
v2 - Added ctrl+click support
v1 - Initial

[Bilbo]

I thought of two things that could be improved:

1. Strings like STR_7077_BUY_25_SHARE_IN_COMPANY should be renamed to STR_7077_BUY_5_SHARE_IN_COMPANY to avoid confusion.

2. You needed 3 clicks to buy max. share of somebody in old system. Now you need 19. Perhaps add a feature that CTRL-clicking on buy/sell will do it in higher increments (like 25% or even "maximum possible")

[TheJosh]

I have added the ctrl+click functunality, and cleaned up the strings. See the first post for the new patch

[Bilbo]

Well, I have tried it and I've discovered two bugs:

First, since shares can be sold in 5% units, company can be owned by 7 other companies. However, in such case, only first three are shown (first three by ID)

Second - as one company I bought 45% of player 1 shares. As second company, I bought 30%.
When I start clicking to buy by 5% steps, I end up at 50% and not being able to buy more (that is correct, 45%+50%=95%)

But if I used CTRL+click, while having that 30%, I suddenly have 55%! Together with 45% from second company we have 100% of player 1, which should not be possible.

[TheJosh]

Neither of these are bugs, I guess you never payed much attention to the old shares.

First, since shares can be sold in 5% units, company can be owned by 7 other companies. However, in such case, only first three are shown (first three by ID)

It only used to show the first 2 companies. I would like to expand this patch so I can put in a full company list, but Ill do that with another patch when I do a but of a bigger overhaul of shares.

But if I used CTRL+click, while having that 30%, I suddenly have 55%! Together with 45% from second company we have 100% of player 1, which should not be possible.

This was possible in the old one too. Two (or more) players could together own 100% of the company.

[Bilbo]

Neither of these are bugs, I guess you never payed much attention to the old shares.

First, since shares can be sold in 5% units, company can be owned by 7 other companies. However, in such case, only first three are shown (first three by ID)

It only used to show the first 2 companies. I would like to expand this patch so I can put in a full company list, but Ill do that with another patch when I do a but of a bigger overhaul of shares.

You're right, now I see it shows only 2 without your patch ... hmm, a bug :)
Perhaps the code for showing three companies could be separated from the patch and filed at bugs.openttd.org as an enhancement :)

But if I used CTRL+click, while having that 30%, I suddenly have 55%! Together with 45% from second company we have 100% of player 1, which should not be possible.

This was possible in the old one too. Two (or more) players could together own 100% of the company.

No, it was not possible, at least not without any patches. What is inconsistent, that with normal clicking in your patch I can't buy 100%, but with ctrl+clicking I can.

[DaleStan]

This was possible in the old one too. Two (or more) players could together own 100% of the company.

No, it was not possible, at least not without any patches.

Yes it was. Go play a bit of multiplayer TTD sometime. (not Patch, not Open, just TTD.)

[TheJosh]

Fixed another bug, see the first post.

Chow, Josh