Integrated Version ChrisIN-Final-1 [2008/03/12] *r11485*

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

User avatar
ukdmbfan
Engineer
Engineer
Posts: 31
Joined: 11 Sep 2007 22:01
Location: Surrey, UK
Contact:

Re: Integrated Version ChrisIN-r11060 [08/09/2007]

Post by ukdmbfan »

A very quick scan of the Subversion documentation says that I was asking a very obvious question and that I can specify the revision number with the -r command line option. :oops:

I'll give both a try tonight, see if I can compile the latest ChrisIN source and then try and apply the r11069 patch as to the SVN trunk for that revision as well.

Thanks for all your help!
Matt
- "If you do things right, people won't be sure you've done anything at all"
chrissicom
Route Supervisor
Route Supervisor
Posts: 415
Joined: 07 Oct 2004 10:05

Re: Integrated Version ChrisIN-r11060 [08/09/2007]

Post by chrissicom »

If you mean the r11069 build from my server that's a test build only! Just a warning :!:

Right now I have a weird problem with making the routemarkers dropdown working after vehicle speed tab was added. See what happens...
Attachments
routemarker_speedtabbug.png
routemarker_speedtabbug.png (72.87 KiB) Viewed 2913 times
User avatar
ukdmbfan
Engineer
Engineer
Posts: 31
Joined: 11 Sep 2007 22:01
Location: Surrey, UK
Contact:

Re: Integrated Version ChrisIN-r11060 [08/09/2007]

Post by ukdmbfan »

That's interesting :p I'll stick to 11060 for now then.
Matt
- "If you do things right, people won't be sure you've done anything at all"
parfittr
Engineer
Engineer
Posts: 6
Joined: 12 Sep 2007 07:34

Re: Integrated Version ChrisIN-r11060 [08/09/2007]

Post by parfittr »

Thanks for all your help with my inexperience of svn and patching, Chris. Have successfully applied your r11060 patch to svn r11060 source, compiled and run - hooray!
User avatar
glx
OpenTTD Developer
OpenTTD Developer
Posts: 622
Joined: 02 Dec 2005 15:43
Location: Drancy(93) - France
Contact:

Re: Integrated Version ChrisIN-r11060 [08/09/2007]

Post by glx »

chrissicom wrote:If you mean the r11069 build from my server that's a test build only! Just a warning :!:

Right now I have a weird problem with making the routemarkers dropdown working after vehicle speed tab was added. See what happens...
Check the widget index.
doghousedean
Traffic Manager
Traffic Manager
Posts: 141
Joined: 30 Apr 2007 10:26

Re: Integrated Version ChrisIN-r11060 [08/09/2007]

Post by doghousedean »

beat me to it! i was going to say a duplicate widget or typo!
chrissicom
Route Supervisor
Route Supervisor
Posts: 415
Joined: 07 Oct 2004 10:05

Re: Integrated Version ChrisIN-r11060 [08/09/2007]

Post by chrissicom »

Thanks for the tip :) Rubidium said the same on Mirc and after some head breaking :lol: I found a magic number somewhere in the routemarkers gui code which was wrong :wink:

I attached the .diff for the current test only :!: build of ChrisIN-r11091. I have the problem that after adding the grass growth on unused tracks patch that the patch grows routemarkers instead of grass :D. As I can't find any conflicts between these patches I'd like to know if anyone has an idea or might want to look at the code if I just didn't find the conflict.
Attachments
r11091-ChrisIN.diff
TEST ONLY build!
(502.19 KiB) Downloaded 70 times
User avatar
MeTo
Traffic Manager
Traffic Manager
Posts: 129
Joined: 06 Apr 2003 14:02
Location: UnL; Czech Republic
Contact:

Re: Integrated Version ChrisIN-r11060 [08/09/2007]

Post by MeTo »

The ChrisIN version is a great work !
Do you have in plan to add the subsidiaries patch sometimes ?
doghousedean
Traffic Manager
Traffic Manager
Posts: 141
Joined: 30 Apr 2007 10:26

Re: Integrated Version ChrisIN-r11060 [08/09/2007]

Post by doghousedean »

chrissicom wrote: I have the problem that after adding the grass growth on unused tracks patch that the patch grows routemarkers instead of grass :D.
Thought that was funniest thing in the world!

Could it be a sprite problem, eg both use sprite number 2341 etc
chrissicom
Route Supervisor
Route Supervisor
Posts: 415
Joined: 07 Oct 2004 10:05

Re: Integrated Version ChrisIN-r11060 [08/09/2007]

Post by chrissicom »

MeTo wrote:The ChrisIN version is a great work !
Do you have in plan to add the subsidiaries patch sometimes ?
As soon as there is a satisfyingly working version :)

The sprites shouldn't be the problem, when I look at sprites.h the two patches integrate perfectly fine and don't influence each other from what I can see.
blitzkrieg
Engineer
Engineer
Posts: 105
Joined: 30 Jun 2006 04:22

Re: Integrated Version ChrisIN-r11060 [08/09/2007]

Post by blitzkrieg »

MeTo wrote:The ChrisIN version is a great work !
Do you have in plan to add the subsidiaries patch sometimes ?
As long as someone is asking for new patches to be integrated into ChrisIN , could i suggest adding the passengers with destination patch too :idea:!!!! Its an amazing patch which will go nicely with vehicle separation patch.
User avatar
Sir A. Boey
Transport Coordinator
Transport Coordinator
Posts: 299
Joined: 17 Nov 2006 17:40
Location: Everywhere and nowhere

Re: Integrated Version ChrisIN-r11060 [08/09/2007]

Post by Sir A. Boey »

@ Chrissicom

Could you take a look at this because I have a problem and I think it's related to the ChrisIN but I posted in a thread that I posted before...

thanks...

see last post & second last post
Image
_____________# If you believe in it, you can achieve it" # ____________
__________________# Check out My Closed Platform #___________________
chrissicom
Route Supervisor
Route Supervisor
Posts: 415
Joined: 07 Oct 2004 10:05

Re: Integrated Version ChrisIN-r11060 [08/09/2007]

Post by chrissicom »

Oh my gosh how did you actually create this town 8o I wasn't aware that you can even make such huge towns lol. I highly doubt that it is a bug that these towns shrink. The game is not meant to start with such large towns and towns would never grow to such huge cities without a big amount of transports in and around them. In your screenshot there is nearly no transport to be seen in that huge city and therefore I assume the shrinking is right. I don't know how the town growth algorithm works though so maybe a dev can shed some light into this.
User avatar
Sir A. Boey
Transport Coordinator
Transport Coordinator
Posts: 299
Joined: 17 Nov 2006 17:40
Location: Everywhere and nowhere

Re: Integrated Version ChrisIN-r11060 [08/09/2007]

Post by Sir A. Boey »

hmmm I post the responce in the other thread ok?
Image
_____________# If you believe in it, you can achieve it" # ____________
__________________# Check out My Closed Platform #___________________
Bjarni
Tycoon
Tycoon
Posts: 2088
Joined: 08 Mar 2004 13:10

Re: Integrated Version ChrisIN-r11060 [08/09/2007]

Post by Bjarni »

I was asked to look at a linking error when compiling this on OSX and I found a solution for it.

The problem is that GetCurrentLocale() is already defined in src/os/macosx/macos.mm, so defining it in src/strings.cpp is not a good idea. Solution:

GetCurrentLocale() is inside

Code: Select all

#ifndef WIN32
Change this to

Code: Select all

#if !defined(WIN32) && !defined(__APPLE__)
(updating the comments might be a good idea as well, but is naturally not needed for making it link correctly).


This will produce a binary. However I think it has way too many warnings for my liking.
User avatar
ukdmbfan
Engineer
Engineer
Posts: 31
Joined: 11 Sep 2007 22:01
Location: Surrey, UK
Contact:

Re: Integrated Version ChrisIN-r11060 [08/09/2007]

Post by ukdmbfan »

Thanks for your help Bjarni. Got it to compile as an Intel binary OK.

I've created a zip file of the r11060-ChrisIN for Mac OS X Intel if anyone is interested and would like a copy.
Matt
- "If you do things right, people won't be sure you've done anything at all"
chrissicom
Route Supervisor
Route Supervisor
Posts: 415
Joined: 07 Oct 2004 10:05

Re: Integrated Version ChrisIN-r11060 [08/09/2007]

Post by chrissicom »

ukdmbfan wrote:Thanks for your help Bjarni. Got it to compile as an Intel binary OK.

I've created a zip file of the r11060-ChrisIN for Mac OS X Intel if anyone is interested and would like a copy.
If you attach the .zip to this thread I can also upload the file to my version archive on the server :) also the same goes for a linux binary if someone wants to provide one!

Thanks Bjarni for pointing this out :) I will update the code. Maybe when you have time you can send me the warnings you get as I don't have any warnings on Vista with MSVC :)
User avatar
ukdmbfan
Engineer
Engineer
Posts: 31
Joined: 11 Sep 2007 22:01
Location: Surrey, UK
Contact:

Re: Integrated Version ChrisIN-r11060 [08/09/2007]

Post by ukdmbfan »

No problem. If Bjarni doesn't get back to you I'll PM you the warnings I get during Mac compile when I get home this evening. A lot of it seems to be instantiation errors when compiling the yapf code, not sure what patch has altered that as it compiles with no warnings for the standard r11060.
Matt
- "If you do things right, people won't be sure you've done anything at all"
chrissicom
Route Supervisor
Route Supervisor
Posts: 415
Joined: 07 Oct 2004 10:05

Re: Integrated Version ChrisIN-r11060 [08/09/2007]

Post by chrissicom »

ukdmbfan wrote:No problem. If Bjarni doesn't get back to you I'll PM you the warnings I get during Mac compile when I get home this evening. A lot of it seems to be instantiation errors when compiling the yapf code, not sure what patch has altered that as it compiles with no warnings for the standard r11060.
Except for routemarkers no patch influences the YAPF code. But I have modified the routemarkers patch quite a bit for the next ChrisIN build, so maybe that is a solution already :) I can't test the changes to routemarkers right now because the grass growth patch is still growing routemarkes all over the track making the use of them as intended not easy ;)
doghousedean
Traffic Manager
Traffic Manager
Posts: 141
Joined: 30 Apr 2007 10:26

Re: Integrated Version ChrisIN-r11060 [08/09/2007]

Post by doghousedean »

chrissicom wrote: I can't test the changes to routemarkers right now because the grass growth patch is still growing routemarkes all over the track making the use of them as intended not easy ;)
....this still cracks me up! :lol:
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 38 guests